Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
chore(clickhouse): trim comments to one line
bernie-g7b5b1ebb4566
diff --git a/backend/src/ee/services/gateway-v2/gateway-v2-fns.ts b/backend/src/ee/services/gateway-v2/gateway-v2-fns.tsindex e12bcadbbf..458fae22c0 100644--- a/backend/src/ee/services/gateway-v2/gateway-v2-fns.ts+++ b/backend/src/ee/services/gateway-v2/gateway-v2-fns.ts@@ -43,8 +43,7 @@ export const testConnectionWithGateway = async (}};-// Takes the built test whole, so the ports its certificate must authorise travel with it. Passing them-// separately meant a caller could omit them and have the gateway refuse a port it was meant to probe.+// Takes the built test whole so its authorised ports can't be dropped.export const testBuiltConnectionWithGateway = async (test: { host: string; port: number; request: Record<string, unknown>; additionalPorts?: number[] },gatewayId: string,diff --git a/backend/src/ee/services/pam-account/pam-account-connection-test.test.ts b/backend/src/ee/services/pam-account/pam-account-connection-test.test.tsindex 75b2f02b68..9fae2c78ba 100644--- a/backend/src/ee/services/pam-account/pam-account-connection-test.test.ts+++ b/backend/src/ee/services/pam-account/pam-account-connection-test.test.ts@@ -272,8 +272,6 @@ describe("buildGatewayConnectionTest: ClickHouse", () => {sslEnabled: false});expect(result?.port).toBe(8123);- // These are the ports the gateway's certificate authorises, so a probe it is asked to run is refused- // without them.expect(result?.additionalPorts).toEqual([8123, 9000]);});diff --git a/backend/src/ee/services/pam-account/pam-account-schemas.ts b/backend/src/ee/services/pam-account/pam-account-schemas.tsindex 8e7d8692a5..f44017c750 100644--- a/backend/src/ee/services/pam-account/pam-account-schemas.ts+++ b/backend/src/ee/services/pam-account/pam-account-schemas.ts@@ -1167,8 +1167,6 @@ export const gatewaySupportsAccountType = (supportedTypes: string[] | undefined): boolean => !supportedTypes || supportedTypes.includes(resolveGatewayAccountType(accountType));-// Web Access speaks HTTP, so an account whose server has no HTTP interface cannot serve it. Returns the-// reason to show the user, or null when Web Access is fine.export const webAccessUnavailableReason = (accountType: PamAccountType,connectionDetails: Record<string, unknown>diff --git a/frontend/src/pages/pam/PamAccountsPage/components/accountFormSchema.ts b/frontend/src/pages/pam/PamAccountsPage/components/accountFormSchema.tsindex b07d22d040..c31ec06b5f 100644--- a/frontend/src/pages/pam/PamAccountsPage/components/accountFormSchema.ts+++ b/frontend/src/pages/pam/PamAccountsPage/components/accountFormSchema.ts@@ -36,8 +36,7 @@ const defaultForField = (field: TPamFieldDescriptor): unknown =>export const buildDefaultFieldValues = (fields: TPamFieldDescriptor[]): Record<string, unknown> =>Object.fromEntries(fields.map((field) => [field.key, defaultForField(field)]));-// A metadata default is a new-account convenience. The edit form submits every field, so seeding-// one over a key the account does not store would silently give it a value it never had.+// Defaults are for new accounts; seeding them on edit invents stored values.export const buildEditFieldValues = (fields: TPamFieldDescriptor[],existing: Record<string, unknown> = {}@@ -46,8 +45,7 @@ export const buildEditFieldValues = (fields.map((field) => [field.key, existing[field.key] ?? emptyForField(field)]));-// A field the account never stored must reach the backend as absent, not as "". Zod's `.default()` fires on-// undefined and rejects an empty string, so submitting "" blocks the save on a field the user never touched.+// Absent keys must stay absent: zod's .default() fires on undefined, not "".export const omitUnsetAbsentFields = (values: Record<string, unknown>,existing: Record<string, unknown> = {}diff --git a/frontend/src/pages/pam/components/accountSheetDetails.tsx b/frontend/src/pages/pam/components/accountSheetDetails.tsxindex 7edb49c96a..275b9870fc 100644--- a/frontend/src/pages/pam/components/accountSheetDetails.tsx+++ b/frontend/src/pages/pam/components/accountSheetDetails.tsx@@ -79,8 +79,7 @@ export const useAccountSheetDetails = (account: TAccessiblePamAccount | null, is...fieldRows(typeMeta?.credentialFields, credentials)];- // Web Access speaks HTTP, so a ClickHouse account with no HTTP port cannot serve it. Left null while the- // full account is still loading, so the option is not greyed out on missing data.+ // Null until the account loads, so missing data doesn't grey out Web Access.const webAccessUnavailableReason =fullAccount && account.accountType === PamAccountType.ClickHouse && conn.port === undefined? "Requires ClickHouse's HTTP interface. Set an HTTP port on this account, or use the CLI."