Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
refactor(agent-vault): work out a session's lifetime once, in the service
Scott Wilson7c6dfb54619b
diff --git a/backend/src/ee/routes/v1/agent-vault-routers/agent-vault-session-router.ts b/backend/src/ee/routes/v1/agent-vault-routers/agent-vault-session-router.tsindex b1d0421dbf..e42d5c6f7a 100644--- a/backend/src/ee/routes/v1/agent-vault-routers/agent-vault-session-router.ts+++ b/backend/src/ee/routes/v1/agent-vault-routers/agent-vault-session-router.ts@@ -219,7 +219,7 @@ export const registerAgentVaultSessionRouter = async (server: FastifyZodProvideractorName = req.auth.identityName;}- const { session, token, ttl, onBehalfOf } = await server.services.agentVaultSession.mintSession({+ const { session, token, ttlSeconds, onBehalfOf } = await server.services.agentVaultSession.mintSession({actorName,actorEmail,projectId: req.internalAgentVaultProjectId,@@ -252,7 +252,7 @@ export const registerAgentVaultSessionRouter = async (server: FastifyZodProviderproperties: {sessionId: session.id,accessBundleId: session.accessBundles[0].id,- ttlSeconds: ttl === AGENT_VAULT_SESSION_TTL_NEVER ? null : Math.floor(ms(ttl) / 1000),+ ttlSeconds,isOnBehalfOfUser: Boolean(onBehalfOf)}});diff --git a/backend/src/ee/services/agent-vault-session/agent-vault-session-service.ts b/backend/src/ee/services/agent-vault-session/agent-vault-session-service.tsindex 65a196a647..33c688b2d8 100644--- a/backend/src/ee/services/agent-vault-session/agent-vault-session-service.ts+++ b/backend/src/ee/services/agent-vault-session/agent-vault-session-service.ts@@ -250,7 +250,8 @@ export const agentVaultSessionServiceFactory = ({}}- const expiresAt = ttl === AGENT_VAULT_SESSION_TTL_NEVER ? null : new Date(Date.now() + ms(ttl));+ const ttlMs = ttl === AGENT_VAULT_SESSION_TTL_NEVER ? null : ms(ttl);+ const expiresAt = ttlMs === null ? null : new Date(Date.now() + ttlMs);const { token, tokenHash } = generateSessionToken();const sessionId = crypto.nativeCrypto.randomUUID();@@ -320,7 +321,7 @@ export const agentVaultSessionServiceFactory = ({}))},token,- ttl,+ ttlSeconds: ttlMs === null ? null : Math.floor(ttlMs / 1000),onBehalfOf: onBehalfOfUser? { userId: onBehalfOfUser.user.id, username: onBehalfOfUser.user.username, email: onBehalfOfUser.user.email }: null