Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix: make the permissions to be on the same line instead of jumping it

adilson7f373e75aed4
diff --git a/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.test.ts b/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.test.ts
index b41337c33a..4a6166a8b9 100644
--- a/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.test.ts
+++ b/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.test.ts
@@ -44,7 +44,7 @@ const makeRequest = (requestData: unknown): TApprovalRequests => ({
});
describe("buildSecretAccessDispatchDetails", () => {
- test("derives the environment, path and flattened permissions from the stored request", () => {
+ test("derives the environment, path and aligned permissions from the stored request", () => {
const permissions = packRules([
makeRule("read", "prod", "/db"),
makeRule("edit", "prod", "/db"),
@@ -59,7 +59,7 @@ describe("buildSecretAccessDispatchDetails", () => {
policyType: ApprovalPolicyType.SecretAccess,
environment: "prod",
secretPath: "/db",
- permissions: ["secrets:read", "secrets:edit", "secret-folders:read"],
+ permissions: ["secrets: read, edit", "secret-folders: read"],
isTemporary: true,
temporaryRange: "1h"
});
diff --git a/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.ts b/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.ts
index af51570619..3ecbd569fa 100644
--- a/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.ts
+++ b/backend/src/services/delegated-approval/dispatch/delegated-approval-dispatch-builders.ts
@@ -13,13 +13,17 @@ export const buildSecretAccessDispatchDetails: TDelegatedApprovalDispatchDetails
const { permissions, isTemporary, temporaryRange } = getSecretAccessRequestData(request);
const { envSlug, secretPath, requestedPermissions } = verifyRequestedPermissions({ permissions });
+ const rows = requestedPermissions.map(({ subject, actions }) => ({
+ label: `${subject}:`,
+ actions: actions.join(", ")
+ }));
+ const labelWidth = Math.max(...rows.map((row) => row.label.length));
+
return {
policyType: ApprovalPolicyType.SecretAccess,
environment: envSlug,
secretPath,
- permissions: requestedPermissions.flatMap(({ subject, actions }) =>
- actions.map((action) => `${subject}:${action}`)
- ),
+ permissions: rows.map((row) => `${row.label.padEnd(labelWidth)} ${row.actions}`),
isTemporary,
temporaryRange: isTemporary ? temporaryRange : null
};