Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
clarify why the sql dynamic secret passes a fixed knex version
Dimitris Staratzis81f4a7dc74a4
diff --git a/backend/src/ee/services/dynamic-secret/providers/sql-database.ts b/backend/src/ee/services/dynamic-secret/providers/sql-database.tsindex 6f4ab72f44..1e046dfe2f 100644--- a/backend/src/ee/services/dynamic-secret/providers/sql-database.ts+++ b/backend/src/ee/services/dynamic-secret/providers/sql-database.ts@@ -207,7 +207,8 @@ export const SqlDatabaseProvider = ({},acquireConnectionTimeout: EXTERNAL_REQUEST_TIMEOUT,pool: { min: 0, max: 7 },- // knex's Postgres client can't parse CockroachDB's version() and hangs on connect. It only needs the version for DDL we never run.+ // The value doesn't matter. Passing any version stops knex from running `select version()` on connect,+ // and knex's Postgres client can't parse CockroachDB's reply to it, which leaves the connection hanging....(providerInputs.client === SqlProviders.Postgres ? { version: "9.6.0" } : {})});return db;