Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

feature(pki): audit log certificate issuance failures

bernie-g85b5dffa8142
diff --git a/backend/CLAUDE.md b/backend/CLAUDE.md
index 9df3d7a88c..e1bbf40d9c 100644
--- a/backend/CLAUDE.md
+++ b/backend/CLAUDE.md
@@ -1055,6 +1055,14 @@ windows and a late flush never share a counter), and the job writes one summary
for. To collapse another event, call it instead of `createAuditLog` and add
`TAuditLogCollapseSummary` to that event's metadata type so the summary fields are typed.
+`CERTIFICATE_ISSUANCE_FAILED` is recorded by `recordCertificateIssuanceFailure`
+(`services/certificate-common/certificate-issuance-audit-fns.ts`), collapsed the same way. The
+synchronous paths record it only when the caller passes `auditLogInfo` to
+`issueCertificateFromProfile`, `signCertificateFromProfile`, `orderCertificate` or `renewCertificate`,
+so a new route or protocol handler that issues certificates must pass it. Asynchronous failures are
+recorded where the request leaves pending, in `certificateRequestService.updateCertificateRequestStatus`,
+with a `PLATFORM` actor, so write a failed request through it rather than through the DAL.
+
### Server Plugins
Key plugins in `src/server/plugins/`:
diff --git a/backend/src/ee/routes/est/certificate-est-router.ts b/backend/src/ee/routes/est/certificate-est-router.ts
index 4ed85dce78..432a2f88f6 100644
--- a/backend/src/ee/routes/est/certificate-est-router.ts
+++ b/backend/src/ee/routes/est/certificate-est-router.ts
@@ -193,7 +193,8 @@ export const registerCertificateEstRouter = async (server: FastifyZodProvider) =
return server.services.certificateEstV3.simpleEnrollByProfile({
csr: req.body,
profileId: identifier,
- sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string
+ sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string,
+ auditLogInfo: req.auditLogInfo
});
}
return server.services.certificateEst.simpleEnroll({
@@ -230,7 +231,8 @@ export const registerCertificateEstRouter = async (server: FastifyZodProvider) =
return server.services.certificateEstV3.simpleReenrollByProfile({
csr: req.body,
profileId: identifier,
- sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string
+ sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string,
+ auditLogInfo: req.auditLogInfo
});
}
return server.services.certificateEst.simpleReenroll({
@@ -299,7 +301,8 @@ export const registerCertificateEstRouter = async (server: FastifyZodProvider) =
csr: req.body,
profileId,
applicationId,
- sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string
+ sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string,
+ auditLogInfo: req.auditLogInfo
});
}
});
@@ -324,7 +327,8 @@ export const registerCertificateEstRouter = async (server: FastifyZodProvider) =
csr: req.body,
profileId,
applicationId,
- sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string
+ sslClientCert: req.headers[appCfg.SSL_CLIENT_CERTIFICATE_HEADER_KEY] as string,
+ auditLogInfo: req.auditLogInfo
});
}
});
diff --git a/backend/src/ee/services/audit-log/audit-log-types.ts b/backend/src/ee/services/audit-log/audit-log-types.ts
index c4844ab2db..df7006159e 100644
--- a/backend/src/ee/services/audit-log/audit-log-types.ts
+++ b/backend/src/ee/services/audit-log/audit-log-types.ts
@@ -47,6 +47,8 @@ import {
CrlReason
} from "@app/services/certificate/certificate-types";
import { CaStatus } from "@app/services/certificate-authority/certificate-authority-enums";
+import { CertificateIssuanceOperation } from "@app/services/certificate-common/certificate-constants";
+import { EnrollmentType } from "@app/services/certificate-profile/certificate-profile-types";
import { CertificateRequestStatus } from "@app/services/certificate-request/certificate-request-types";
import { CertificateRenewalKeySource, TRenewalAuditChange } from "@app/services/certificate-v3/certificate-v3-types";
import type { ExternalMigrationImportStatus } from "@app/services/external-migration/external-migration-types";
@@ -469,6 +471,7 @@ export enum EventType {
AUTOMATED_RENEW_SUBSCRIBER_CERT = "automated-renew-subscriber-cert",
AUTOMATED_RENEW_CERTIFICATE = "automated-renew-certificate",
AUTOMATED_RENEW_CERTIFICATE_FAILED = "automated-renew-certificate-failed",
+ CERTIFICATE_ISSUANCE_FAILED = "certificate-issuance-failed",
LIST_PKI_SUBSCRIBER_CERTS = "list-pki-subscriber-certs",
GET_SUBSCRIBER_ACTIVE_CERT_BUNDLE = "get-subscriber-active-cert-bundle",
CREATE_KMS = "create-kms",
@@ -3562,6 +3565,24 @@ interface AutomatedRenewCertificateFailed {
};
}
+interface CertificateIssuanceFailedEvent {
+ type: EventType.CERTIFICATE_ISSUANCE_FAILED;
+ metadata: TAuditLogCollapseSummary & {
+ operation: CertificateIssuanceOperation;
+ enrollmentType?: EnrollmentType;
+ certificateProfileId?: string;
+ profileName?: string;
+ caId?: string;
+ certificateRequestId?: string;
+ originalCertificateId?: string;
+ commonName?: string;
+ applicationId?: string;
+ applicationName?: string;
+ errorName: string;
+ error: string;
+ };
+}
+
interface SignPkiSubscriberCert {
type: EventType.SIGN_PKI_SUBSCRIBER_CERT;
metadata: {
@@ -8591,6 +8612,7 @@ export type Event =
| CancelCertificateRequestEvent
| AutomatedRenewCertificate
| AutomatedRenewCertificateFailed
+ | CertificateIssuanceFailedEvent
| UserLoginEvent
| SelectOrganizationEvent
| SelectSubOrganizationEvent
diff --git a/backend/src/ee/services/pki-acme/pki-acme-service.ts b/backend/src/ee/services/pki-acme/pki-acme-service.ts
index 1500554be6..33eb5c41db 100644
--- a/backend/src/ee/services/pki-acme/pki-acme-service.ts
+++ b/backend/src/ee/services/pki-acme/pki-acme-service.ts
@@ -41,10 +41,12 @@ import {
TCertificateIssuanceQueueFactory,
TIssueCertificateFromProfileJobData
} from "@app/services/certificate-authority/certificate-issuance-queue";
+import { CertificateIssuanceOperation } from "@app/services/certificate-common/certificate-constants";
import {
extractAlgorithmsFromCSR,
extractCertificateRequestFromCSR
} from "@app/services/certificate-common/certificate-csr-utils";
+import { recordCertificateIssuanceFailure } from "@app/services/certificate-common/certificate-issuance-audit-fns";
import { validateCertificateRequestLicense } from "@app/services/certificate-common/certificate-utils";
import { TCertificatePolicyDALFactory } from "@app/services/certificate-policy/certificate-policy-dal";
import { TCertificatePolicyServiceFactory } from "@app/services/certificate-policy/certificate-policy-service";
@@ -185,7 +187,7 @@ type TPkiAcmeServiceFactoryDep = {
certificateIssuanceQueue: Pick<TCertificateIssuanceQueueFactory, "queueCertificateIssuance">;
acmeChallengeService: Pick<TPkiAcmeChallengeServiceFactory, "markChallengeAsReady">;
pkiAcmeQueueService: Pick<TPkiAcmeQueueServiceFactory, "queueChallengeValidation">;
- auditLogService: Pick<TAuditLogServiceFactory, "createAuditLog">;
+ auditLogService: Pick<TAuditLogServiceFactory, "createAuditLog" | "createCollapsedAuditLog">;
approvalPolicyDAL: Pick<TApprovalPolicyDALFactory, "findByProjectId" | "findStepsByPolicyId">;
approvalPolicyService: Pick<TApprovalPolicyServiceFactory, "createRequestFromPolicy" | "matchPolicy">;
certificateRequestDAL: Pick<TCertificateRequestDALFactory, "create" | "updateById" | "transitionFromPending">;
@@ -1503,7 +1505,6 @@ export const pkiAcmeServiceFactory = ({
certIssuanceJobData = result.certIssuanceJobData;
} catch (exp) {
logger.error(exp, "Failed to sign certificate");
- // TODO: audit log the error
if (issuedCertificateId) {
// The certificate is already issued and committed, and its certificate request is marked
// ISSUED against this order, so marking the order invalid here would strand a real
@@ -1514,6 +1515,24 @@ export const pkiAcmeServiceFactory = ({
message: "Failed to finalize certificate issuance"
});
}
+ await recordCertificateIssuanceFailure(auditLogService, {
+ auditLogInfo: {
+ ...auditLogInfo,
+ actor: { type: ActorType.ACME_ACCOUNT, metadata: { profileId, accountId } }
+ },
+ projectId: profile.projectId,
+ error: exp,
+ metadata: {
+ operation:
+ caType === CaType.INTERNAL ? CertificateIssuanceOperation.SIGN : CertificateIssuanceOperation.ORDER,
+ enrollmentType: EnrollmentType.ACME,
+ certificateProfileId: profileId,
+ profileName: profile.slug,
+ ...(profile.caId && { caId: profile.caId }),
+ commonName: certificateRequest.commonName || undefined,
+ ...(accountApplicationId && { applicationId: accountApplicationId })
+ }
+ });
await acmeOrderDAL.updateById(orderId, {
csr,
status: AcmeOrderStatus.Invalid,
diff --git a/backend/src/ee/services/pki-scep/pki-scep-service.ts b/backend/src/ee/services/pki-scep/pki-scep-service.ts
index f4975e8c31..94319407cb 100644
--- a/backend/src/ee/services/pki-scep/pki-scep-service.ts
+++ b/backend/src/ee/services/pki-scep/pki-scep-service.ts
@@ -30,10 +30,12 @@ import {
} from "@app/services/certificate-authority/certificate-authority-fns";
import { assertCaSupportsCustomExtensions } from "@app/services/certificate-authority/certificate-authority-maps";
import { TCertificateIssuanceQueueFactory } from "@app/services/certificate-authority/certificate-issuance-queue";
+import { CertificateIssuanceOperation } from "@app/services/certificate-common/certificate-constants";
import {
extractAlgorithmsFromCSR,
extractCertificateRequestFromCSR
} from "@app/services/certificate-common/certificate-csr-utils";
+import { recordCertificateIssuanceFailure } from "@app/services/certificate-common/certificate-issuance-audit-fns";
import { validateCertificateRequestLicense } from "@app/services/certificate-common/certificate-utils";
import { TCertificatePolicyDALFactory } from "@app/services/certificate-policy/certificate-policy-dal";
import { TCertificatePolicyServiceFactory } from "@app/services/certificate-policy/certificate-policy-service";
@@ -104,7 +106,7 @@ type TPkiScepServiceFactoryDep = {
certificatePolicyService: Pick<TCertificatePolicyServiceFactory, "validateCertificateRequest">;
certificateRequestService: Pick<TCertificateRequestServiceFactory, "createCertificateRequest">;
certificateIssuanceQueue: Pick<TCertificateIssuanceQueueFactory, "queueCertificateIssuance">;
- auditLogService: Pick<TAuditLogServiceFactory, "createAuditLog">;
+ auditLogService: Pick<TAuditLogServiceFactory, "createAuditLog" | "createCollapsedAuditLog">;
permissionService: Pick<TPermissionServiceFactory, "getProjectPermission" | "getResourcePermission">;
pkiApplicationProfileDAL: Pick<TPkiApplicationProfileDALFactory, "findOneByApplicationAndProfile">;
pkiApplicationDAL: Pick<TPkiApplicationDALFactory, "findById">;
@@ -515,7 +517,9 @@ export const pkiScepServiceFactory = ({
parsed,
csrPem,
ttl,
- applicationId
+ applicationId,
+ isRenewal: false,
+ clientIp
});
} catch (err) {
// Notify the validator that post-validation issuance failed.
@@ -776,7 +780,9 @@ export const pkiScepServiceFactory = ({
parsed,
csrPem,
ttl,
- applicationId
+ applicationId,
+ isRenewal: true,
+ clientIp
});
if (result.status === ScepIssuanceStatus.Pending) {
@@ -863,7 +869,7 @@ export const pkiScepServiceFactory = ({
// For internal CAs signs directly via signCertificateFromProfile.
// For external CAs, creates a cert request and queues async issuance.
- const issueOrQueueCertificate = async ({
+ const $issueOrQueueCertificate = async ({
profile,
project,
caType,
@@ -1035,6 +1041,46 @@ export const pkiScepServiceFactory = ({
return { status: ScepIssuanceStatus.Pending };
};
+ const issueOrQueueCertificate = async ({
+ isRenewal,
+ clientIp,
+ ...params
+ }: Parameters<typeof $issueOrQueueCertificate>[0] & { isRenewal: boolean; clientIp: string }) => {
+ try {
+ return await $issueOrQueueCertificate(params);
+ } catch (error) {
+ let operation =
+ params.caType === CaType.INTERNAL ? CertificateIssuanceOperation.SIGN : CertificateIssuanceOperation.ORDER;
+ if (isRenewal) operation = CertificateIssuanceOperation.RENEW;
+
+ let commonName: string | undefined;
+ try {
+ commonName = extractCertificateRequestFromCSR(params.csrPem).commonName || undefined;
+ } catch {
+ commonName = undefined;
+ }
+
+ await recordCertificateIssuanceFailure(auditLogService, {
+ auditLogInfo: {
+ ipAddress: clientIp,
+ actor: { type: ActorType.SCEP_ACCOUNT, metadata: { profileId: params.profile.id } }
+ },
+ projectId: params.profile.projectId,
+ error,
+ metadata: {
+ operation,
+ enrollmentType: EnrollmentType.SCEP,
+ certificateProfileId: params.profile.id,
+ profileName: params.profile.slug,
+ ...(params.profile.caId && { caId: params.profile.caId }),
+ commonName,
+ ...(params.applicationId && { applicationId: params.applicationId })
+ }
+ });
+ throw error;
+ }
+ };
+
const handleGetCertInitial = async ({
profile,
scepConfig,
diff --git a/backend/src/server/routes/index.ts b/backend/src/server/routes/index.ts
index 39a2658b4b..8abc50e0d5 100644
--- a/backend/src/server/routes/index.ts
+++ b/backend/src/server/routes/index.ts
@@ -3646,7 +3646,9 @@ export const registerRoutes = async (
resourceMetadataDAL,
queueService,
userDAL,
- identityDAL
+ identityDAL,
+ certificateProfileDAL,
+ auditLogService
});
const certificateIssuanceQueue = certificateIssuanceQueueFactory({
@@ -3727,7 +3729,8 @@ export const registerRoutes = async (
[ApprovalPolicyType.CertRequest]: certRequestApprovalResourceFactory({
approvalPolicyDAL,
certificateApprovalService,
- certificateRequestDAL
+ certificateRequestDAL,
+ certificateRequestService
}) as TApprovalResourceRegistry[ApprovalPolicyType],
[ApprovalPolicyType.CertCodeSigning]: codeSigningApprovalResourceFactory({
approvalPolicyDAL,
@@ -3947,7 +3950,8 @@ export const registerRoutes = async (
pkiApplicationProfileDAL,
apiEnrollmentConfigDAL,
licenseService,
- telemetryService
+ telemetryService,
+ auditLogService
});
const certificateV3Queue = certificateV3QueueServiceFactory({
diff --git a/backend/src/server/routes/v1/certificate-router.ts b/backend/src/server/routes/v1/certificate-router.ts
index 7e8563c940..7841c667ec 100644
--- a/backend/src/server/routes/v1/certificate-router.ts
+++ b/backend/src/server/routes/v1/certificate-router.ts
@@ -240,6 +240,7 @@ export const registerCertificateRouter = async (server: FastifyZodProvider) => {
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: requestBody.profileId,
applicationId: requestBody.applicationId,
certificateOrder: certificateOrderObject,
@@ -293,6 +294,7 @@ export const registerCertificateRouter = async (server: FastifyZodProvider) => {
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: requestBody.profileId,
applicationId: requestBody.applicationId,
csr,
@@ -384,6 +386,7 @@ export const registerCertificateRouter = async (server: FastifyZodProvider) => {
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: requestBody.profileId,
applicationId: requestBody.applicationId,
certificateRequest: mappedCertificateRequest,
@@ -934,6 +937,7 @@ export const registerCertificateRouter = async (server: FastifyZodProvider) => {
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: req.body.profileId,
certificateRequest: mappedCertificateRequest,
removeRootsFromChain: req.body.removeRootsFromChain
@@ -1028,6 +1032,7 @@ export const registerCertificateRouter = async (server: FastifyZodProvider) => {
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: req.body.profileId,
csr: req.body.csr,
validity: {
@@ -1148,6 +1153,7 @@ export const registerCertificateRouter = async (server: FastifyZodProvider) => {
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: req.body.profileId,
certificateOrder: certificateOrderObject,
removeRootsFromChain: req.body.removeRootsFromChain
@@ -1272,6 +1278,7 @@ export const registerCertificateRouter = async (server: FastifyZodProvider) => {
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
certificateId: req.params.id,
removeRootsFromChain: req.body?.removeRootsFromChain,
renewalKeySource: req.body?.renewalKeySource,
diff --git a/backend/src/server/routes/v3/deprecated-certificates-router.ts b/backend/src/server/routes/v3/deprecated-certificates-router.ts
index c3ae48155f..a2ee383b99 100644
--- a/backend/src/server/routes/v3/deprecated-certificates-router.ts
+++ b/backend/src/server/routes/v3/deprecated-certificates-router.ts
@@ -137,6 +137,7 @@ export const registerCertificatesRouter = async (server: FastifyZodProvider) =>
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: req.body.profileId,
certificateRequest: mappedCertificateRequest,
removeRootsFromChain: req.body.removeRootsFromChain
@@ -253,6 +254,7 @@ export const registerCertificatesRouter = async (server: FastifyZodProvider) =>
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: req.body.profileId,
csr: req.body.csr,
validity: {
@@ -401,6 +403,7 @@ export const registerCertificatesRouter = async (server: FastifyZodProvider) =>
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
profileId: req.body.profileId,
certificateOrder: certificateOrderObject,
removeRootsFromChain: req.body.removeRootsFromChain
@@ -496,6 +499,7 @@ export const registerCertificatesRouter = async (server: FastifyZodProvider) =>
actorId: req.permission.id,
actorAuthMethod: req.permission.authMethod,
actorOrgId: req.permission.orgId,
+ auditLogInfo: req.auditLogInfo,
certificateId: req.params.certificateId,
removeRootsFromChain: req.body?.removeRootsFromChain
});
diff --git a/backend/src/services/approval-policy/cert-request/cert-request-policy-factory.ts b/backend/src/services/approval-policy/cert-request/cert-request-policy-factory.ts
index 60f73bc352..767e694ba6 100644
--- a/backend/src/services/approval-policy/cert-request/cert-request-policy-factory.ts
+++ b/backend/src/services/approval-policy/cert-request/cert-request-policy-factory.ts
@@ -1,6 +1,8 @@
import { getConfig } from "@app/lib/config/env";
import { logger } from "@app/lib/logger";
+import { CertificateIssuanceOperation } from "@app/services/certificate-common/certificate-constants";
import { TCertificateRequestDALFactory } from "@app/services/certificate-request/certificate-request-dal";
+import { TCertificateRequestServiceFactory } from "@app/services/certificate-request/certificate-request-service";
import { CertificateRequestStatus } from "@app/services/certificate-request/certificate-request-types";
import { TCertificateApprovalService } from "@app/services/certificate-v3/certificate-approval-fns";
import { NotificationType } from "@app/services/notification/notification-types";
@@ -21,12 +23,14 @@ type TCertRequestApprovalResourceDep = {
approvalPolicyDAL: Pick<TApprovalPolicyDALFactory, "findByProjectId">;
certificateApprovalService: TCertificateApprovalService;
certificateRequestDAL: Pick<TCertificateRequestDALFactory, "updateById" | "findById">;
+ certificateRequestService: Pick<TCertificateRequestServiceFactory, "recordIssuanceFailure">;
};
export const certRequestApprovalResourceFactory = ({
approvalPolicyDAL,
certificateApprovalService,
- certificateRequestDAL
+ certificateRequestDAL,
+ certificateRequestService
}: TCertRequestApprovalResourceDep): TApprovalResource<
TCertRequestPolicyInputs,
TCertRequestPolicy,
@@ -108,10 +112,15 @@ export const certRequestApprovalResourceFactory = ({
);
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error);
- await certificateRequestDAL.updateById(certReqId, {
+ const failedRequest = await certificateRequestDAL.updateById(certReqId, {
status: CertificateRequestStatus.FAILED,
errorMessage
});
+ await certificateRequestService.recordIssuanceFailure(
+ failedRequest,
+ failedRequest.csr ? CertificateIssuanceOperation.SIGN : CertificateIssuanceOperation.ISSUE,
+ error
+ );
logger.error(
{ error, certificateRequestId: certReqId, approvalRequestId: request.id },
`Failed to issue certificate after approval [certificateRequestId=${certReqId}]`
diff --git a/backend/src/services/certificate-authority/certificate-issuance-queue.ts b/backend/src/services/certificate-authority/certificate-issuance-queue.ts
index 3a7032f2d6..085e955a65 100644
--- a/backend/src/services/certificate-authority/certificate-issuance-queue.ts
+++ b/backend/src/services/certificate-authority/certificate-issuance-queue.ts
@@ -403,6 +403,7 @@ export const certificateIssuanceQueueFactory = ({
basicConstraints,
customExtensions
} = data;
+ const issuanceOperation = isRenewal ? CertificateIssuanceOperation.RENEW : CertificateIssuanceOperation.ORDER;
const setPending = async (message: string) => {
if (!certificateRequestId || !certificateRequestDAL) return;
@@ -550,6 +551,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: issuanceOperation,
errorMessage: `Failed to attach certificate: ${attachError instanceof Error ? attachError.message : String(attachError)}`
});
} catch (statusUpdateError) {
@@ -616,6 +618,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: issuanceOperation,
errorMessage: `Failed to attach certificate: ${attachError instanceof Error ? attachError.message : String(attachError)}`
});
} catch (statusUpdateError) {
@@ -687,6 +690,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: issuanceOperation,
errorMessage: `Failed to attach certificate: ${attachError instanceof Error ? attachError.message : String(attachError)}`
});
} catch (statusUpdateError) {
@@ -756,6 +760,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: issuanceOperation,
errorMessage: `Failed to attach certificate: ${attachError instanceof Error ? attachError.message : String(attachError)}`
});
} catch (statusUpdateError) {
@@ -827,6 +832,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: issuanceOperation,
errorMessage: `Failed to attach certificate: ${attachError instanceof Error ? attachError.message : String(attachError)}`
});
} catch (statusUpdateError) {
@@ -1105,6 +1111,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: issuanceOperation,
errorMessage: `Failed to attach certificate: ${attachError instanceof Error ? attachError.message : String(attachError)}`
});
} catch (statusUpdateError) {
@@ -1228,7 +1235,7 @@ export const certificateIssuanceQueueFactory = ({
profileId,
applicationId: scopedApplicationId,
enrollmentType: telemetryProfile?.enrollmentType ?? EnrollmentType.API,
- operation: isRenewal ? CertificateIssuanceOperation.RENEW : CertificateIssuanceOperation.ORDER
+ operation: issuanceOperation
});
}
} catch (error: unknown) {
@@ -1260,6 +1267,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: issuanceOperation,
errorMessage: isAcmeTerminal ? errorMessage : `Certificate issuance failed: ${errorMessage}`
});
logger.info(`Updated certificate request ${certificateRequestId} status to failed due to issuance error`);
@@ -1303,6 +1311,7 @@ export const certificateIssuanceQueueFactory = ({
await certificateRequestService.updateCertificateRequestStatus({
certificateRequestId,
status: CertificateRequestStatus.FAILED,
+ operation: job.data.isRenewal ? CertificateIssuanceOperation.RENEW : CertificateIssuanceOperation.ORDER,
errorMessage: `AWS ACM DNS validation did not complete after ${maxAttempts} attempts: ${error.message}`
});
logger.info(
diff --git a/backend/src/services/certificate-authority/digicert/digicert-certificate-authority-processor.ts b/backend/src/services/certificate-authority/digicert/digicert-certificate-authority-processor.ts
index ca6d30fe87..2ef1159b80 100644
--- a/backend/src/services/certificate-authority/digicert/digicert-certificate-authority-processor.ts
+++ b/backend/src/services/certificate-authority/digicert/digicert-certificate-authority-processor.ts
@@ -142,6 +142,7 @@ export const processDigiCertPendingValidationRequest = async (
await deps.certificateRequestService.updateCertificateRequestStatus({
certificateRequestId: request.id,
status: CertificateRequestStatus.FAILED,
+ operation: parsed.digicert.isRenewal ? CertificateIssuanceOperation.RENEW : CertificateIssuanceOperation.ORDER,
errorMessage: "Validation timed out after 24h"
});
logger.info(`DigiCert validation timed out [certificateRequestId=${request.id}]`);
@@ -239,6 +240,7 @@ export const processDigiCertPendingValidationRequest = async (
await deps.certificateRequestService.updateCertificateRequestStatus({
certificateRequestId: request.id,
status: CertificateRequestStatus.FAILED,
+ operation: parsed.digicert.isRenewal ? CertificateIssuanceOperation.RENEW : CertificateIssuanceOperation.ORDER,
errorMessage: `DigiCert order ${orderStatus}`
});
logger.info(`DigiCert order terminal state [certificateRequestId=${request.id}] [status=${orderStatus}]`);
diff --git a/backend/src/services/certificate-authority/godaddy/godaddy-certificate-authority-processor.ts b/backend/src/services/certificate-authority/godaddy/godaddy-certificate-authority-processor.ts
index 4775a0d6b2..af6595edba 100644
--- a/backend/src/services/certificate-authority/godaddy/godaddy-certificate-authority-processor.ts
+++ b/backend/src/services/certificate-authority/godaddy/godaddy-certificate-authority-processor.ts
@@ -145,6 +145,7 @@ export const processGoDaddyPendingValidationRequest = async (
await deps.certificateRequestService.updateCertificateRequestStatus({
certificateRequestId: request.id,
status: CertificateRequestStatus.FAILED,
+ operation: parsed.godaddy.isRenewal ? CertificateIssuanceOperation.RENEW : CertificateIssuanceOperation.ORDER,
errorMessage: "Validation timed out after 24h"
});
logger.info(`GoDaddy validation timed out [certificateRequestId=${request.id}]`);
@@ -238,6 +239,7 @@ export const processGoDaddyPendingValidationRequest = async (
await deps.certificateRequestService.updateCertificateRequestStatus({
certificateRequestId: request.id,
status: CertificateRequestStatus.FAILED,
+ operation: parsed.godaddy.isRenewal ? CertificateIssuanceOperation.RENEW : CertificateIssuanceOperation.ORDER,
errorMessage: `GoDaddy certificate ${orderStatus}`
});
logger.info(`GoDaddy certificate terminal state [certificateRequestId=${request.id}] [status=${orderStatus}]`);
diff --git a/backend/src/services/certificate-common/certificate-issuance-audit-fns.ts b/backend/src/services/certificate-common/certificate-issuance-audit-fns.ts
new file mode 100644
index 0000000000..a603b13325
--- /dev/null
+++ b/backend/src/services/certificate-common/certificate-issuance-audit-fns.ts
@@ -0,0 +1,67 @@
+import { ForbiddenError } from "@casl/ability";
+
+import {
+ ACTOR_TYPE_TO_METADATA_ID_KEY,
+ AuditLogInfo,
+ Event,
+ EventType,
+ TAuditLogCollapseSummary,
+ TAuditLogServiceFactory
+} from "@app/ee/services/audit-log/audit-log-types";
+import { ForbiddenRequestError } from "@app/lib/errors";
+import { logger } from "@app/lib/logger";
+
+const MAX_ERROR_MESSAGE_LENGTH = 1000;
+
+type TCertificateIssuanceFailedMetadata = Omit<
+ Extract<Event, { type: EventType.CERTIFICATE_ISSUANCE_FAILED }>["metadata"],
+ "errorName" | "error" | keyof TAuditLogCollapseSummary
+>;
+
+export type TRecordCertificateIssuanceFailureDTO = {
+ auditLogInfo: AuditLogInfo;
+ projectId: string;
+ error: unknown;
+ metadata: TCertificateIssuanceFailedMetadata;
+};
+
+// Never throws, so callers can rethrow the original error untouched.
+export const recordCertificateIssuanceFailure = async (
+ auditLogService: Pick<TAuditLogServiceFactory, "createCollapsedAuditLog">,
+ { auditLogInfo, projectId, error, metadata }: TRecordCertificateIssuanceFailureDTO
+) => {
+ // An access refusal is not an issuance failure; CASL denials get their own permission-denied event.
+ if (error instanceof ForbiddenError || error instanceof ForbiddenRequestError) return;
+
+ const errorName = error instanceof Error ? error.name : "UnknownError";
+ const errorMessage = (error instanceof Error ? error.message : String(error)).slice(0, MAX_ERROR_MESSAGE_LENGTH);
+
+ const actorIdKey = ACTOR_TYPE_TO_METADATA_ID_KEY[auditLogInfo.actor.type];
+ const actorId = actorIdKey ? (auditLogInfo.actor.metadata as Record<string, unknown>)[actorIdKey] : undefined;
+
+ try {
+ await auditLogService.createCollapsedAuditLog({
+ ...auditLogInfo,
+ projectId,
+ event: {
+ type: EventType.CERTIFICATE_ISSUANCE_FAILED,
+ metadata: { ...metadata, errorName, error: errorMessage }
+ },
+ collapseKeyParts: [
+ projectId,
+ auditLogInfo.actor.type,
+ actorId ?? null,
+ metadata.operation,
+ metadata.certificateProfileId ?? null,
+ metadata.certificateRequestId ?? null,
+ errorName,
+ errorMessage
+ ]
+ });
+ } catch (auditError) {
+ logger.warn(
+ auditError,
+ `Failed to record certificate issuance failure [projectId=${projectId}] [operation=${metadata.operation}]`
+ );
+ }
+};
diff --git a/backend/src/services/certificate-est-v3/certificate-est-v3-service.ts b/backend/src/services/certificate-est-v3/certificate-est-v3-service.ts
index 810b4e6fd4..9de11b8fea 100644
--- a/backend/src/services/certificate-est-v3/certificate-est-v3-service.ts
+++ b/backend/src/services/certificate-est-v3/certificate-est-v3-service.ts
@@ -1,5 +1,6 @@
import * as x509 from "@peculiar/x509";
+import { AuditLogInfo } from "@app/ee/services/audit-log/audit-log-types";
import { extractX509CertFromChain } from "@app/lib/certificates/extract-certificate";
import { BadRequestError, NotFoundError, UnauthorizedError } from "@app/lib/errors";
import { ActorType } from "@app/services/auth/auth-type";
@@ -124,12 +125,14 @@ export const certificateEstV3ServiceFactory = ({
csr,
profileId,
sslClientCert,
- applicationId
+ applicationId,
+ auditLogInfo
}: {
csr: string;
profileId: string;
sslClientCert: string;
applicationId?: string;
+ auditLogInfo?: AuditLogInfo;
}) => {
const profile = await certificateProfileDAL.findByIdWithConfigs(profileId);
if (!profile) {
@@ -187,7 +190,11 @@ export const certificateEstV3ServiceFactory = ({
csr,
validity: { ttl },
enrollmentType: EnrollmentType.EST,
- applicationId
+ applicationId,
+ auditLogInfo: auditLogInfo && {
+ ...auditLogInfo,
+ actor: { type: ActorType.EST_ACCOUNT, metadata: { profileId } }
+ }
});
if (result.status === CertificateRequestStatus.PENDING_APPROVAL) {
@@ -208,12 +215,14 @@ export const certificateEstV3ServiceFactory = ({
csr,
profileId,
sslClientCert,
- applicationId
+ applicationId,
+ auditLogInfo
}: {
csr: string;
profileId: string;
sslClientCert: string;
applicationId?: string;
+ auditLogInfo?: AuditLogInfo;
}) => {
const profile = await certificateProfileDAL.findByIdWithConfigs(profileId);
if (!profile) {
@@ -337,7 +346,11 @@ export const certificateEstV3ServiceFactory = ({
csr,
validity: { ttl },
enrollmentType: EnrollmentType.EST,
- applicationId
+ applicationId,
+ auditLogInfo: auditLogInfo && {
+ ...auditLogInfo,
+ actor: { type: ActorType.EST_ACCOUNT, metadata: { profileId } }
+ }
});
if (result.status === CertificateRequestStatus.PENDING_APPROVAL) {
diff --git a/backend/src/services/certificate-request/certificate-request-service.test.ts b/backend/src/services/certificate-request/certificate-request-service.test.ts
index 40a7f6e4f8..a1846050f0 100644
--- a/backend/src/services/certificate-request/certificate-request-service.test.ts
+++ b/backend/src/services/certificate-request/certificate-request-service.test.ts
@@ -7,6 +7,7 @@ import { createMongoAbility, ForbiddenError } from "@casl/ability";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { ActionProjectType } from "@app/db/schemas";
+import { EventType } from "@app/ee/services/audit-log/audit-log-types";
import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
import {
ProjectPermissionCertificateActions,
@@ -18,6 +19,7 @@ import { NotFoundError } from "@app/lib/errors";
import { ActorType, AuthMethod } from "@app/services/auth/auth-type";
import { TCertificateDALFactory } from "@app/services/certificate/certificate-dal";
import { TCertificateServiceFactory } from "@app/services/certificate/certificate-service";
+import { CertificateIssuanceOperation } from "@app/services/certificate-common/certificate-constants";
import { TCertificateRequestDALFactory } from "./certificate-request-dal";
import { certificateRequestServiceFactory, TCertificateRequestServiceFactory } from "./certificate-request-service";
@@ -61,6 +63,8 @@ describe("CertificateRequestService", () => {
};
const mockUserDAL = { findById: vi.fn() };
const mockIdentityDAL = { findById: vi.fn() };
+ const mockCertificateProfileDAL = { findById: vi.fn() };
+ const mockAuditLogService = { createCollapsedAuditLog: vi.fn() };
beforeEach(() => {
vi.clearAllMocks();
@@ -74,7 +78,9 @@ describe("CertificateRequestService", () => {
resourceMetadataDAL: { find: vi.fn().mockResolvedValue([]), insertMany: vi.fn() },
queueService: mockQueueService as any,
userDAL: mockUserDAL as any,
- identityDAL: mockIdentityDAL as any
+ identityDAL: mockIdentityDAL as any,
+ certificateProfileDAL: mockCertificateProfileDAL as any,
+ auditLogService: mockAuditLogService
});
});
@@ -646,6 +652,65 @@ describe("CertificateRequestService", () => {
})
).rejects.toThrow(NotFoundError);
});
+ it("records a certificate-issuance-failed event when the request moves to failed", async () => {
+ const failedRequest = {
+ id: "550e8400-e29b-41d4-a716-446655440014",
+ projectId: "project-1",
+ status: CertificateRequestStatus.FAILED,
+ errorMessage: "Certificate issuance failed: DigiCert rejected the order",
+ enrollmentType: "api",
+ profileId: "profile-1",
+ caId: "ca-1",
+ commonName: "app.example.com"
+ };
+ (mockCertificateRequestDAL.findById as any).mockResolvedValue({ ...failedRequest, status: "pending" });
+ (mockCertificateRequestDAL.transitionFromPending as any).mockResolvedValue(failedRequest);
+ mockCertificateProfileDAL.findById.mockResolvedValue({ id: "profile-1", slug: "public-web" });
+
+ await service.updateCertificateRequestStatus({
+ certificateRequestId: failedRequest.id,
+ status: CertificateRequestStatus.FAILED,
+ errorMessage: failedRequest.errorMessage,
+ operation: CertificateIssuanceOperation.RENEW
+ });
+
+ expect(mockAuditLogService.createCollapsedAuditLog).toHaveBeenCalledWith(
+ expect.objectContaining({
+ projectId: "project-1",
+ actor: { type: ActorType.PLATFORM, metadata: {} },
+ event: {
+ type: EventType.CERTIFICATE_ISSUANCE_FAILED,
+ metadata: {
+ operation: CertificateIssuanceOperation.RENEW,
+ enrollmentType: "api",
+ certificateRequestId: failedRequest.id,
+ certificateProfileId: "profile-1",
+ profileName: "public-web",
+ caId: "ca-1",
+ commonName: "app.example.com",
+ errorName: "Error",
+ error: "Certificate issuance failed: DigiCert rejected the order"
+ }
+ }
+ })
+ );
+ });
+
+ it("records nothing when the request had already left pending", async () => {
+ (mockCertificateRequestDAL.findById as any).mockResolvedValue({
+ id: "r",
+ status: CertificateRequestStatus.FAILED
+ });
+ (mockCertificateRequestDAL.transitionFromPending as any).mockResolvedValue(null);
+
+ await service.updateCertificateRequestStatus({
+ certificateRequestId: "550e8400-e29b-41d4-a716-446655440015",
+ status: CertificateRequestStatus.FAILED,
+ errorMessage: "late failure"
+ });
+
+ expect(mockAuditLogService.createCollapsedAuditLog).not.toHaveBeenCalled();
+ });
});
describe("attachCertificateToRequest", () => {
diff --git a/backend/src/services/certificate-request/certificate-request-service.ts b/backend/src/services/certificate-request/certificate-request-service.ts
index 2754b95cca..5bdad0d7ff 100644
--- a/backend/src/services/certificate-request/certificate-request-service.ts
+++ b/backend/src/services/certificate-request/certificate-request-service.ts
@@ -2,7 +2,8 @@ import { ForbiddenError, subject } from "@casl/ability";
import { Knex } from "knex";
import { z } from "zod";
-import { ActionProjectType, ResourceType } from "@app/db/schemas";
+import { ActionProjectType, ResourceType, TCertificateRequests } from "@app/db/schemas";
+import { TAuditLogServiceFactory } from "@app/ee/services/audit-log/audit-log-types";
import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
import {
ProjectPermissionCertificateActions,
@@ -20,6 +21,7 @@ import { QueueName, TQueueServiceFactory } from "@app/queue";
import { TCertificateDALFactory } from "@app/services/certificate/certificate-dal";
import { TCertificateServiceFactory } from "@app/services/certificate/certificate-service";
import {
+ CertificateIssuanceOperation,
domainComponentsSchema,
resolvedCustomExtensionSchema
} from "@app/services/certificate-common/certificate-constants";
@@ -27,6 +29,9 @@ import {
describeCustomExtensionValue,
TResolvedCustomExtension
} from "@app/services/certificate-common/certificate-extension-fns";
+import { recordCertificateIssuanceFailure } from "@app/services/certificate-common/certificate-issuance-audit-fns";
+import { TCertificateProfileDALFactory } from "@app/services/certificate-profile/certificate-profile-dal";
+import { EnrollmentType } from "@app/services/certificate-profile/certificate-profile-types";
import { TPkiApplicationDALFactory } from "@app/services/pki-application/pki-application-dal";
import { ActorAuthMethod, ActorType } from "../auth/auth-type";
@@ -54,6 +59,8 @@ type TCertificateRequestServiceFactoryDep = {
queueService: Pick<TQueueServiceFactory, "stopJobById" | "cancelActiveJob">;
userDAL: Pick<TUserDALFactory, "findById">;
identityDAL: Pick<TIdentityDALFactory, "findById">;
+ certificateProfileDAL: Pick<TCertificateProfileDALFactory, "findById">;
+ auditLogService: Pick<TAuditLogServiceFactory, "createCollapsedAuditLog">;
};
export type TCertificateRequestServiceFactory = ReturnType<typeof certificateRequestServiceFactory>;
@@ -151,7 +158,9 @@ export const certificateRequestServiceFactory = ({
resourceMetadataDAL,
queueService,
userDAL,
- identityDAL
+ identityDAL,
+ certificateProfileDAL,
+ auditLogService
}: TCertificateRequestServiceFactoryDep) => {
const $resolveApplicationName = async (applicationId?: string | null) => {
if (!applicationId) return null;
@@ -463,17 +472,60 @@ export const certificateRequestServiceFactory = ({
};
};
+ const recordIssuanceFailure = async (
+ certificateRequest: TCertificateRequests,
+ operation: CertificateIssuanceOperation,
+ error?: unknown
+ ) => {
+ try {
+ const profile = certificateRequest.profileId
+ ? await certificateProfileDAL.findById(certificateRequest.profileId)
+ : undefined;
+ const applicationName = await $resolveApplicationName(certificateRequest.applicationId);
+
+ await recordCertificateIssuanceFailure(auditLogService, {
+ auditLogInfo: { actor: { type: ActorType.PLATFORM, metadata: {} } },
+ projectId: certificateRequest.projectId,
+ error: error ?? new Error(certificateRequest.errorMessage || "Certificate issuance failed"),
+ metadata: {
+ operation,
+ ...(certificateRequest.enrollmentType && {
+ enrollmentType: certificateRequest.enrollmentType as EnrollmentType
+ }),
+ certificateRequestId: certificateRequest.id,
+ ...(certificateRequest.profileId && { certificateProfileId: certificateRequest.profileId }),
+ ...(profile && { profileName: profile.slug }),
+ ...(certificateRequest.caId && { caId: certificateRequest.caId }),
+ ...(certificateRequest.commonName && { commonName: certificateRequest.commonName }),
+ ...(certificateRequest.applicationId && { applicationId: certificateRequest.applicationId }),
+ ...(applicationName && { applicationName })
+ }
+ });
+ } catch (auditError) {
+ logger.warn(
+ auditError,
+ `Failed to record certificate issuance failure [certificateRequestId=${certificateRequest.id}]`
+ );
+ }
+ };
+
const updateCertificateRequestStatus = async ({
certificateRequestId,
status,
- errorMessage
+ errorMessage,
+ operation = CertificateIssuanceOperation.ORDER
}: TUpdateCertificateRequestStatusDTO) => {
const certificateRequest = await certificateRequestDAL.findById(certificateRequestId);
if (!certificateRequest) {
throw new NotFoundError({ message: "Certificate request not found" });
}
- return certificateRequestDAL.transitionFromPending(certificateRequestId, status, errorMessage);
+ const updated = await certificateRequestDAL.transitionFromPending(certificateRequestId, status, errorMessage);
+ // A null result means the request already left pending, so its failure was recorded then.
+ if (updated && status === CertificateRequestStatus.FAILED) {
+ await recordIssuanceFailure(updated, operation);
+ }
+ return updated;
};
const attachCertificateToRequest = async ({
@@ -733,6 +785,7 @@ export const certificateRequestServiceFactory = ({
getCertificateRequest,
getCertificateFromRequest,
updateCertificateRequestStatus,
+ recordIssuanceFailure,
attachCertificateToRequest,
cancelCertificateRequest,
listCertificateRequests
diff --git a/backend/src/services/certificate-request/certificate-request-types.ts b/backend/src/services/certificate-request/certificate-request-types.ts
index 85c65f8611..0646580f97 100644
--- a/backend/src/services/certificate-request/certificate-request-types.ts
+++ b/backend/src/services/certificate-request/certificate-request-types.ts
@@ -1,7 +1,7 @@
import { TProjectPermission } from "@app/lib/types";
import { TResolvedCustomExtension } from "@app/services/certificate-common/certificate-extension-fns";
-import { CertificateRequestStatus } from "../certificate-common/certificate-constants";
+import { CertificateIssuanceOperation, CertificateRequestStatus } from "../certificate-common/certificate-constants";
import { EnrollmentType } from "../certificate-profile/certificate-profile-types";
export { CertificateRequestStatus };
@@ -56,6 +56,7 @@ export type TUpdateCertificateRequestStatusDTO = {
certificateRequestId: string;
status: CertificateRequestStatus;
errorMessage?: string;
+ operation?: CertificateIssuanceOperation;
};
export type TAttachCertificateToRequestDTO = {
diff --git a/backend/src/services/certificate-v3/certificate-v3-service.test.ts b/backend/src/services/certificate-v3/certificate-v3-service.test.ts
index 1e06f0eba2..05f83adb89 100644
--- a/backend/src/services/certificate-v3/certificate-v3-service.test.ts
+++ b/backend/src/services/certificate-v3/certificate-v3-service.test.ts
@@ -9,6 +9,7 @@ import { join } from "node:path";
import { createMongoAbility, ForbiddenError } from "@casl/ability";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { EventType, UserAgentType } from "@app/ee/services/audit-log/audit-log-types";
import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
import {
ProjectPermissionCertificateActions,
@@ -81,6 +82,10 @@ describe("CertificateV3Service", () => {
sendPostHogEvents: vi.fn().mockResolvedValue(undefined)
};
+ const mockAuditLogService = {
+ createCollapsedAuditLog: vi.fn().mockResolvedValue(undefined)
+ };
+
const mockCertificateDAL: Pick<
TCertificateDALFactory,
| "findOne"
@@ -355,7 +360,7 @@ describe("CertificateV3Service", () => {
},
projectDAL: {
findOne: vi.fn().mockResolvedValue({ id: "project-123" }),
- findById: vi.fn().mockResolvedValue({ id: "project-123" }),
+ findById: vi.fn().mockResolvedValue({ id: "project-123", orgId: "org-123" }),
updateById: vi.fn().mockResolvedValue({ id: "project-123" }),
transaction: vi.fn().mockImplementation(async (callback: (tx: any) => Promise<unknown>) => {
const mockTx = {};
@@ -391,7 +396,8 @@ describe("CertificateV3Service", () => {
usageCounterDAL: mockUsageCounterDAL,
keyStore: mockKeyStore,
licenseService: mockLicenseService,
- telemetryService: mockTelemetryService
+ telemetryService: mockTelemetryService,
+ auditLogService: mockAuditLogService
});
});
@@ -3555,4 +3561,133 @@ describe("CertificateV3Service", () => {
).rejects.toThrow("Certificate is not eligible for auto-renewal: certificate was not issued from a profile");
});
});
+ describe("certificate issuance failure audit", () => {
+ const auditLogInfo = {
+ ipAddress: "127.0.0.1",
+ userAgent: "test-agent",
+ userAgentType: UserAgentType.OTHER,
+ actor: { type: ActorType.USER as const, metadata: { userId: "user-123", email: "[email protected]", username: "[email protected]" } }
+ };
+
+ const issueDto = {
+ profileId: "profile-123",
+ certificateRequest: { commonName: "fail.example.com", validity: { ttl: "30d" } },
+ actor: ActorType.USER,
+ actorId: "user-123",
+ actorAuthMethod: AuthMethod.EMAIL,
+ actorOrgId: "org-123"
+ };
+
+ beforeEach(() => {
+ vi.mocked(mockCertificateProfileDAL.findById).mockResolvedValue({
+ id: "profile-123",
+ projectId: "project-123",
+ slug: "web-servers",
+ caId: "ca-123"
+ } as never);
+ });
+
+ it("records the failure with the reason and rethrows the original error", async () => {
+ const failure = new BadRequestError({ message: "TTL exceeds the policy maximum of 90 days" });
+ vi.mocked(mockCertificateProfileDAL.findByIdWithConfigs).mockRejectedValue(failure);
+
+ await expect(service.issueCertificateFromProfile({ ...issueDto, auditLogInfo })).rejects.toBe(failure);
+
+ expect(mockAuditLogService.createCollapsedAuditLog).toHaveBeenCalledTimes(1);
+ expect(mockAuditLogService.createCollapsedAuditLog).toHaveBeenCalledWith(
+ expect.objectContaining({
+ projectId: "project-123",
+ actor: auditLogInfo.actor,
+ event: {
+ type: EventType.CERTIFICATE_ISSUANCE_FAILED,
+ metadata: {
+ operation: CertificateIssuanceOperation.ISSUE,
+ enrollmentType: EnrollmentType.API,
+ commonName: "fail.example.com",
+ applicationId: undefined,
+ certificateProfileId: "profile-123",
+ profileName: "web-servers",
+ caId: "ca-123",
+ errorName: "BadRequest",
+ error: "TTL exceeds the policy maximum of 90 days"
+ }
+ }
+ })
+ );
+ });
+
+ it("records nothing without audit log info", async () => {
+ vi.mocked(mockCertificateProfileDAL.findByIdWithConfigs).mockRejectedValue(new BadRequestError({ message: "x" }));
+
+ await expect(service.issueCertificateFromProfile(issueDto)).rejects.toThrow("x");
+
+ expect(mockAuditLogService.createCollapsedAuditLog).not.toHaveBeenCalled();
+ });
+
+ it("leaves permission denials to the permission-denied event", async () => {
+ vi.mocked(mockCertificateProfileDAL.findByIdWithConfigs).mockRejectedValue(
+ new ForbiddenRequestError({ message: "denied" })
+ );
+
+ await expect(service.issueCertificateFromProfile({ ...issueDto, auditLogInfo })).rejects.toThrow("denied");
+
+ expect(mockAuditLogService.createCollapsedAuditLog).not.toHaveBeenCalled();
+ });
+
+ it("never writes into another org's audit log", async () => {
+ vi.mocked(mockCertificateProfileDAL.findByIdWithConfigs).mockRejectedValue(new NotFoundError({ message: "x" }));
+
+ await expect(
+ service.issueCertificateFromProfile({ ...issueDto, actorOrgId: "other-org", auditLogInfo })
+ ).rejects.toThrow("x");
+
+ expect(mockAuditLogService.createCollapsedAuditLog).not.toHaveBeenCalled();
+ });
+
+ it("still surfaces the original error when recording fails", async () => {
+ const failure = new BadRequestError({ message: "bad csr" });
+ vi.mocked(mockCertificateProfileDAL.findByIdWithConfigs).mockRejectedValue(failure);
+ mockAuditLogService.createCollapsedAuditLog.mockRejectedValueOnce(new Error("redis down"));
+
+ await expect(service.issueCertificateFromProfile({ ...issueDto, auditLogInfo })).rejects.toBe(failure);
+ });
+
+ it("records a failed renewal against the original certificate", async () => {
+ vi.mocked(mockCertificateDAL.findById).mockResolvedValue({
+ id: "cert-123",
+ projectId: "project-123",
+ commonName: "renew.example.com",
+ profileId: "profile-123",
+ caId: "ca-123"
+ } as never);
+ vi.mocked(mockCertificateDAL.transaction).mockRejectedValueOnce(
+ new BadRequestError({ message: "CA is disabled" })
+ );
+
+ await expect(
+ service.renewCertificate({
+ certificateId: "cert-123",
+ actor: ActorType.USER,
+ actorId: "user-123",
+ actorAuthMethod: AuthMethod.EMAIL,
+ actorOrgId: "org-123",
+ auditLogInfo
+ })
+ ).rejects.toThrow("CA is disabled");
+
+ expect(mockAuditLogService.createCollapsedAuditLog).toHaveBeenCalledWith(
+ expect.objectContaining({
+ event: expect.objectContaining({
+ type: EventType.CERTIFICATE_ISSUANCE_FAILED,
+ metadata: expect.objectContaining({
+ operation: CertificateIssuanceOperation.RENEW,
+ originalCertificateId: "cert-123",
+ commonName: "renew.example.com",
+ certificateProfileId: "profile-123"
+ })
+ })
+ })
+ );
+ });
+ });
});
diff --git a/backend/src/services/certificate-v3/certificate-v3-service.ts b/backend/src/services/certificate-v3/certificate-v3-service.ts
index b0c3244230..1432966459 100644
--- a/backend/src/services/certificate-v3/certificate-v3-service.ts
+++ b/backend/src/services/certificate-v3/certificate-v3-service.ts
@@ -3,6 +3,7 @@ import { randomUUID } from "crypto";
import { Knex } from "knex";
import { ActionProjectType, ResourceType } from "@app/db/schemas";
+import { AuditLogInfo, TAuditLogServiceFactory } from "@app/ee/services/audit-log/audit-log-types";
import { TLicenseServiceFactory } from "@app/ee/services/license/license-service";
import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
import {
@@ -49,6 +50,7 @@ import {
} from "@app/services/certificate-authority/certificate-authority-maps";
import { validateGoDaddyIssuanceInputs } from "@app/services/certificate-authority/godaddy/godaddy-certificate-authority-validators";
import { TInternalCertificateAuthorityServiceFactory } from "@app/services/certificate-authority/internal/internal-certificate-authority-service";
+import { recordCertificateIssuanceFailure } from "@app/services/certificate-common/certificate-issuance-audit-fns";
import { recordNewCertificateQuotaKey } from "@app/services/certificate-common/certificate-quota-fns";
import { TCertificatePolicyServiceFactory } from "@app/services/certificate-policy/certificate-policy-service";
import { TCertificateProfileDALFactory } from "@app/services/certificate-profile/certificate-profile-dal";
@@ -199,6 +201,7 @@ type TCertificateV3ServiceFactoryDep = {
>;
keyStore: Pick<TKeyStoreFactory, "getItem" | "setItemWithExpiry" | "deleteItem">;
telemetryService: Pick<TTelemetryServiceFactory, "sendPostHogEvents">;
+ auditLogService: Pick<TAuditLogServiceFactory, "createCollapsedAuditLog">;
};
export type TCertificateV3ServiceFactory = ReturnType<typeof certificateV3ServiceFactory>;
@@ -362,7 +365,8 @@ export const certificateV3ServiceFactory = ({
licenseService,
usageCounterDAL,
keyStore,
- telemetryService
+ telemetryService,
+ auditLogService
}: TCertificateV3ServiceFactoryDep) => {
const $quotaDeps = { projectDAL, licenseService, usageCounterDAL, keyStore };
@@ -551,7 +555,61 @@ export const certificateV3ServiceFactory = ({
return application?.name ?? null;
};
- const issueCertificateFromProfile = async ({
+ const $recordIssuanceFailure = async ({
+ auditLogInfo,
+ actorOrgId,
+ projectId,
+ profileId,
+ error,
+ metadata
+ }: {
+ auditLogInfo?: AuditLogInfo;
+ actorOrgId: string;
+ projectId?: string;
+ profileId?: string | null;
+ error: unknown;
+ metadata: Omit<
+ Parameters<typeof recordCertificateIssuanceFailure>[1]["metadata"],
+ "certificateProfileId" | "profileName" | "applicationName"
+ >;
+ }) => {
+ if (!auditLogInfo) return;
+ try {
+ const profile = profileId ? await certificateProfileDAL.findById(profileId) : undefined;
+ const resolvedProjectId = projectId ?? profile?.projectId;
+ if (!resolvedProjectId) return;
+
+ // The ids come from the caller, so never write into another org's audit log.
+ const project = await projectDAL.findById(resolvedProjectId);
+ if (project?.orgId !== actorOrgId) return;
+
+ const applicationName = await $resolveApplicationName(metadata.applicationId);
+ await recordCertificateIssuanceFailure(auditLogService, {
+ auditLogInfo,
+ projectId: resolvedProjectId,
+ error,
+ metadata: {
+ ...metadata,
+ ...(profile && { certificateProfileId: profile.id, profileName: profile.slug }),
+ ...(!metadata.caId && profile?.caId && { caId: profile.caId }),
+ ...(applicationName && { applicationName })
+ }
+ });
+ } catch (lookupError) {
+ logger.warn(lookupError, `Failed to record certificate issuance failure [operation=${metadata.operation}]`);
+ }
+ };
+
+ const $commonNameFromCsr = (csr?: string) => {
+ if (!csr) return undefined;
+ try {
+ return extractCertificateRequestFromCSR(csr).commonName || undefined;
+ } catch {
+ return undefined;
+ }
+ };
+
+ const $issueCertificateFromProfile = async ({
profileId,
certificateRequest,
metadata,
@@ -1286,7 +1344,7 @@ export const certificateV3ServiceFactory = ({
};
};
- const signCertificateFromProfile = async ({
+ const $signCertificateFromProfile = async ({
profileId,
csr,
validity,
@@ -1779,7 +1837,7 @@ export const certificateV3ServiceFactory = ({
};
};
- const orderCertificate = async ({
+ const $orderCertificate = async ({
profileId,
certificateOrder,
metadata,
@@ -2316,8 +2374,97 @@ export const certificateV3ServiceFactory = ({
reportCertificateIssued: $reportCertificateIssued
});
+ const issueCertificateFromProfile = async (dto: TIssueCertificateFromProfileDTO) => {
+ try {
+ return await $issueCertificateFromProfile(dto);
+ } catch (error) {
+ await $recordIssuanceFailure({
+ auditLogInfo: dto.auditLogInfo,
+ actorOrgId: dto.actorOrgId,
+ profileId: dto.profileId,
+ error,
+ metadata: {
+ operation: CertificateIssuanceOperation.ISSUE,
+ enrollmentType: EnrollmentType.API,
+ commonName: dto.certificateRequest.commonName,
+ applicationId: dto.applicationId
+ }
+ });
+ throw error;
+ }
+ };
+
+ const signCertificateFromProfile = async (dto: TSignCertificateFromProfileDTO) => {
+ try {
+ return await $signCertificateFromProfile(dto);
+ } catch (error) {
+ await $recordIssuanceFailure({
+ auditLogInfo: dto.auditLogInfo,
+ actorOrgId: dto.actorOrgId,
+ profileId: dto.profileId,
+ error,
+ metadata: {
+ operation: CertificateIssuanceOperation.SIGN,
+ enrollmentType: dto.enrollmentType,
+ commonName: $commonNameFromCsr(dto.csr),
+ applicationId: dto.applicationId
+ }
+ });
+ throw error;
+ }
+ };
+
+ const orderCertificate = async (dto: TOrderCertificateFromProfileDTO) => {
+ try {
+ return await $orderCertificate(dto);
+ } catch (error) {
+ await $recordIssuanceFailure({
+ auditLogInfo: dto.auditLogInfo,
+ actorOrgId: dto.actorOrgId,
+ profileId: dto.profileId,
+ error,
+ metadata: {
+ operation: CertificateIssuanceOperation.ORDER,
+ enrollmentType: EnrollmentType.API,
+ commonName: dto.certificateOrder.commonName || $commonNameFromCsr(dto.certificateOrder.csr),
+ applicationId: dto.applicationId
+ }
+ });
+ throw error;
+ }
+ };
+
+ const renewCertificate = async (dto: Parameters<typeof renewalService.renewCertificate>[0]) => {
+ try {
+ return await renewalService.renewCertificate(dto);
+ } catch (error) {
+ const certificate = dto.auditLogInfo
+ ? await certificateDAL.findById(dto.certificateId).catch(() => undefined)
+ : undefined;
+ if (certificate) {
+ await $recordIssuanceFailure({
+ auditLogInfo: dto.auditLogInfo,
+ actorOrgId: dto.actorOrgId,
+ projectId: certificate.projectId,
+ profileId: certificate.profileId,
+ error,
+ metadata: {
+ operation: CertificateIssuanceOperation.RENEW,
+ enrollmentType: EnrollmentType.API,
+ originalCertificateId: certificate.id,
+ commonName: certificate.commonName,
+ ...(certificate.caId && { caId: certificate.caId }),
+ ...(certificate.applicationId && { applicationId: certificate.applicationId })
+ }
+ });
+ }
+ throw error;
+ }
+ };
+
return {
...renewalService,
+ renewCertificate,
issueCertificateFromProfile,
signCertificateFromProfile,
orderCertificate,
diff --git a/backend/src/services/certificate-v3/certificate-v3-types.ts b/backend/src/services/certificate-v3/certificate-v3-types.ts
index dae4be88c2..b647cb243d 100644
--- a/backend/src/services/certificate-v3/certificate-v3-types.ts
+++ b/backend/src/services/certificate-v3/certificate-v3-types.ts
@@ -1,3 +1,4 @@
+import { AuditLogInfo } from "@app/ee/services/audit-log/audit-log-types";
import { TProjectPermission } from "@app/lib/types";
import {
@@ -43,6 +44,7 @@ export type TIssueCertificateFromProfileDTO = {
metadata?: Array<{ key: string; value: string }>;
removeRootsFromChain?: boolean;
applicationId?: string;
+ auditLogInfo?: AuditLogInfo;
} & Omit<TProjectPermission, "projectId">;
export type TSignCertificateFromProfileDTO = {
@@ -62,6 +64,7 @@ export type TSignCertificateFromProfileDTO = {
};
applicationId?: string;
acmeOrderId?: string;
+ auditLogInfo?: AuditLogInfo;
} & Omit<TProjectPermission, "projectId">;
export type TOrderCertificateFromProfileDTO = {
@@ -97,6 +100,7 @@ export type TOrderCertificateFromProfileDTO = {
metadata?: Array<{ key: string; value: string }>;
removeRootsFromChain?: boolean;
applicationId?: string;
+ auditLogInfo?: AuditLogInfo;
} & Omit<TProjectPermission, "projectId">;
export type TCertificateIssuanceResponse = {
@@ -177,6 +181,7 @@ export type TRenewCertificateDTO = {
renewalKeySource?: CertificateRenewalKeySource;
csr?: string;
attributes?: TRenewalAttributes;
+ auditLogInfo?: AuditLogInfo;
} & Omit<TProjectPermission, "projectId">;
export type TUpdateRenewalConfigDTO = {
diff --git a/docs/documentation/platform/audit-logs.mdx b/docs/documentation/platform/audit-logs.mdx
index fe003fb1ea..53d66adcb5 100644
--- a/docs/documentation/platform/audit-logs.mdx
+++ b/docs/documentation/platform/audit-logs.mdx
@@ -303,6 +303,26 @@ Denials are only recorded for organizations on the new privilege system. If your
To keep a misconfigured client from filling the log, Infisical records the first `permission-denied` event per actor, project, action, subject, and endpoint in each minute. Denials that repeat inside that minute are counted rather than recorded. When the minute ends, Infisical writes one more `permission-denied` event for the same combination with the count in `suppressedRepeats` and the minute in `suppressedFrom` and `suppressedUntil`. If nothing repeated, no summary event is written.
+### Certificate issuance failures
+
+If Infisical can't issue a certificate, it records a `certificate-issuance-failed` event with the reason. Infisical records the event for certificates requested through the API or the Infisical UI, ACME, EST, and SCEP, including renewals and certificates issued after an approval. The event is in the `management` class, so it's always recorded.
+
+The event records which certificate failed and why:
+
+- `operation`: what was requested (`issue`, `sign`, `order`, or `renew`)
+- `enrollmentType`: how the certificate was requested (`api`, `acme`, `est`, or `scep`)
+- `error` and `errorName`: why issuance failed, such as a TTL longer than the certificate policy allows or an error from the CA
+- `certificateProfileId`, `profileName`, `caId`, `commonName`, `applicationId`, and `applicationName`: the certificate the request was for, where Infisical knows them
+- `certificateRequestId`: the certificate request that failed, if Infisical had already created one
+- `originalCertificateId`: on a failed renewal, the certificate being renewed
+- `suppressedRepeats`, `suppressedFrom`, and `suppressedUntil`: on a summary event, how many identical failures Infisical counted instead of recording, and the minute they fell in
+
+If issuance fails after the request has already returned, the event's actor is `platform`. This happens when an external CA such as DigiCert rejects an order, or when issuance fails after an approver approves the request. To find who requested the certificate, look for the request's original event, such as `order-certificate-from-profile`, with the same `certificateRequestId`.
+
+If a request is denied because the actor's role doesn't allow it, Infisical records a [`permission-denied` event](#permission-denials) instead.
+
+Infisical counts identical failures the same way it counts [repeated denials](#permission-denials): it records the first failure per actor, profile, and reason in each minute, then writes one summary event when the minute ends.
+
## Filtering audit logs
You can filter audit logs to find events more easily. When you set more than one filter, an event needs to match all of them to appear in the results.
diff --git a/frontend/src/hooks/api/auditLogs/constants.tsx b/frontend/src/hooks/api/auditLogs/constants.tsx
index 869c5d93c8..e495e53014 100644
--- a/frontend/src/hooks/api/auditLogs/constants.tsx
+++ b/frontend/src/hooks/api/auditLogs/constants.tsx
@@ -393,6 +393,7 @@ export const eventToNameMap: { [K in EventType]: string } = {
[EventType.ISSUE_CERTIFICATE_FROM_PROFILE]: "Issue Certificate From Profile",
[EventType.SIGN_CERTIFICATE_FROM_PROFILE]: "Sign Certificate From Profile",
[EventType.ORDER_CERTIFICATE_FROM_PROFILE]: "Order Certificate From Profile",
+ [EventType.CERTIFICATE_ISSUANCE_FAILED]: "Certificate Issuance Failed",
[EventType.GET_CERTIFICATE_PROFILE_LATEST_ACTIVE_BUNDLE]:
"Get Certificate Profile Latest Active Bundle",
diff --git a/frontend/src/hooks/api/auditLogs/enums.tsx b/frontend/src/hooks/api/auditLogs/enums.tsx
index 46ff946a47..51e922556a 100644
--- a/frontend/src/hooks/api/auditLogs/enums.tsx
+++ b/frontend/src/hooks/api/auditLogs/enums.tsx
@@ -382,6 +382,7 @@ export enum EventType {
ISSUE_CERTIFICATE_FROM_PROFILE = "issue-certificate-from-profile",
SIGN_CERTIFICATE_FROM_PROFILE = "sign-certificate-from-profile",
ORDER_CERTIFICATE_FROM_PROFILE = "order-certificate-from-profile",
+ CERTIFICATE_ISSUANCE_FAILED = "certificate-issuance-failed",
GET_CERTIFICATE_PROFILE_LATEST_ACTIVE_BUNDLE = "get-certificate-profile-latest-active-bundle",
CREATE_CERTIFICATE_REQUEST = "create-certificate-request",