Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix PR comments

Matheus Nogueira8c53ee8041ec
diff --git a/frontend/src/pages/secret-scanning/components/findings/FindingDetailSheet.tsx b/frontend/src/pages/secret-scanning/components/findings/FindingDetailSheet.tsx
index 9299e65893..1f0970b2d2 100644
--- a/frontend/src/pages/secret-scanning/components/findings/FindingDetailSheet.tsx
+++ b/frontend/src/pages/secret-scanning/components/findings/FindingDetailSheet.tsx
@@ -101,7 +101,7 @@ export const FindingDetailSheet = ({
</IconButton>
</div>
<div className="flex flex-wrap items-center gap-2">
- <SheetTitle className="font-mono">{finding.rule}</SheetTitle>
+ <SheetTitle>{finding.rule}</SheetTitle>
<FindingStatusBadge status={finding.status} />
</div>
<SheetDescription>{finding.details.description}</SheetDescription>
@@ -110,25 +110,29 @@ export const FindingDetailSheet = ({
<div className="grid flex-1 grid-cols-2 content-start gap-4 overflow-y-auto p-4">
<Detail className="col-span-2">
<DetailLabel>File</DetailLabel>
- <DetailValue className="font-mono">
+ <DetailValue>
{finding.details.link ? (
<a
href={finding.details.link}
target="_blank"
rel="noopener noreferrer"
- className="inline-flex items-center gap-1.5 hover:underline hover:underline-offset-2"
+ className="inline-flex items-center gap-1.5 font-mono hover:underline hover:underline-offset-2"
>
{finding.details.file}:{finding.details.startLine}
<ExternalLinkIcon className="size-3.5 shrink-0" />
</a>
) : (
- `${finding.details.file}:${finding.details.startLine}`
+ <span className="font-mono">
+ {finding.details.file}:{finding.details.startLine}
+ </span>
)}
</DetailValue>
</Detail>
<Detail>
<DetailLabel>Resource</DetailLabel>
- <DetailValue className="font-mono">{finding.resourceName}</DetailValue>
+ <DetailValue>
+ <span className="font-mono">{finding.resourceName}</span>
+ </DetailValue>
</Detail>
<Detail>
<DetailLabel>Detected</DetailLabel>
@@ -136,21 +140,21 @@ export const FindingDetailSheet = ({
</Detail>
<Detail>
<DetailLabel>Commit</DetailLabel>
- <DetailValue className="font-mono">
- {finding.details.commit.slice(0, 7)}
+ <DetailValue>
+ <span className="font-mono">{finding.details.commit.slice(0, 7)}</span>
+ {finding.details.message && (
+ <p className="line-clamp-3 text-xs text-muted">{finding.details.message}</p>
+ )}
</DetailValue>
- {finding.details.message && (
- <DetailValue className="line-clamp-3 text-xs text-muted">
- {finding.details.message}
- </DetailValue>
- )}
</Detail>
<Detail>
<DetailLabel>Author</DetailLabel>
- <DetailValue>{finding.details.author}</DetailValue>
- {finding.details.email && (
- <DetailValue className="text-xs text-muted">{finding.details.email}</DetailValue>
- )}
+ <DetailValue>
+ {finding.details.author}
+ {finding.details.email && (
+ <p className="text-xs text-muted">{finding.details.email}</p>
+ )}
+ </DetailValue>
</Detail>
<Detail>
<DetailLabel>Committed</DetailLabel>
@@ -158,19 +162,27 @@ export const FindingDetailSheet = ({
</Detail>
<Detail>
<DetailLabel>Severity</DetailLabel>
- <DetailValue className="capitalize">{finding.severity}</DetailValue>
+ <DetailValue>
+ <span className="capitalize">{finding.severity}</span>
+ </DetailValue>
</Detail>
<Detail className="col-span-2">
<DetailLabel>Fingerprint</DetailLabel>
- <DetailValue className="flex items-center gap-1 font-mono text-xs">
- <span className="min-w-0 break-all">{finding.fingerprint}</span>
- <CopyButton value={finding.fingerprint} ariaLabel="Copy fingerprint" />
+ <DetailValue>
+ <span className="flex items-center gap-1">
+ <span className="min-w-0 font-mono text-xs break-all">
+ {finding.fingerprint}
+ </span>
+ <CopyButton value={finding.fingerprint} ariaLabel="Copy fingerprint" />
+ </span>
</DetailValue>
</Detail>
{finding.triageComment && (
<Detail className="col-span-2">
<DetailLabel>Comment</DetailLabel>
- <DetailValue className="whitespace-pre-wrap">{finding.triageComment}</DetailValue>
+ <DetailValue>
+ <p className="whitespace-pre-wrap">{finding.triageComment}</p>
+ </DetailValue>
</Detail>
)}
</div>
diff --git a/frontend/src/pages/secret-scanning/components/findings/FindingStatusDialog.tsx b/frontend/src/pages/secret-scanning/components/findings/FindingStatusDialog.tsx
index c7e3852156..380f8c973a 100644
--- a/frontend/src/pages/secret-scanning/components/findings/FindingStatusDialog.tsx
+++ b/frontend/src/pages/secret-scanning/components/findings/FindingStatusDialog.tsx
@@ -14,6 +14,7 @@ import {
DialogHeader,
DialogTitle,
Field,
+ FieldDescription,
FieldError,
FieldLabel,
TextArea
@@ -35,7 +36,10 @@ type Props = {
findings: TSecretScanningFinding[];
status: SecretScanningFindingStatus | null;
onOpenChange: (isOpen: boolean) => void;
- onComplete?: (result: { status: SecretScanningFindingStatus; comment: string }) => void;
+ onComplete?: (result: {
+ status: SecretScanningFindingStatus;
+ triageComment: string | null;
+ }) => void;
};
export const FindingStatusDialog = ({ findings, status, onOpenChange, onComplete }: Props) => {
@@ -56,14 +60,17 @@ export const FindingStatusDialog = ({ findings, status, onOpenChange, onComplete
const { name, description } = SECRET_SCANNING_FINDING_STATUS_MAP[status];
const isBulk = findings.length > 1;
+ const hasExistingComment = findings.some((finding) => Boolean(finding.triageComment));
const onSubmit = ({ comment }: TFormData) => {
+ const triageComment = comment || null;
+
updateFindings.mutate(
findings.map((finding) => ({
findingId: finding.id,
projectId: finding.projectId,
status,
- triageComment: comment || undefined
+ triageComment
})),
{
onSuccess: () => {
@@ -74,7 +81,7 @@ export const FindingStatusDialog = ({ findings, status, onOpenChange, onComplete
: `Finding marked as ${name}`
});
onOpenChange(false);
- onComplete?.({ status, comment });
+ onComplete?.({ status, triageComment });
}
}
);
@@ -103,6 +110,9 @@ export const FindingStatusDialog = ({ findings, status, onOpenChange, onComplete
placeholder="Explain why, e.g. rotated in the provider and redeployed."
isError={Boolean(error)}
/>
+ <FieldDescription isOpen={hasExistingComment}>
+ Leave blank to remove the current {isBulk ? "comments" : "comment"}.
+ </FieldDescription>
<FieldError>{error?.message}</FieldError>
</Field>
)}
diff --git a/frontend/src/pages/secret-scanning/components/findings/SecretScanningFindingsTable.tsx b/frontend/src/pages/secret-scanning/components/findings/SecretScanningFindingsTable.tsx
index 574efc06d6..3107e53d74 100644
--- a/frontend/src/pages/secret-scanning/components/findings/SecretScanningFindingsTable.tsx
+++ b/frontend/src/pages/secret-scanning/components/findings/SecretScanningFindingsTable.tsx
@@ -236,14 +236,8 @@ export const SecretScanningFindingsTable = ({
);
};
- const handleChangeStatus = (
- targetFindings: TSecretScanningFinding[],
- status: SecretScanningFindingStatus
- ) => {
- if (status !== SecretScanningFindingStatus.Unresolved) {
- setStatusChange({ findings: targetFindings, status });
- return;
- }
+ const reopenFindings = (targetFindings: TSecretScanningFinding[]) => {
+ const status = SecretScanningFindingStatus.Unresolved;
reopenFinding.mutate(
targetFindings.map((f) => ({ findingId: f.id, projectId: f.projectId, status })),
@@ -265,6 +259,18 @@ export const SecretScanningFindingsTable = ({
);
};
+ const handleChangeStatus = (
+ targetFindings: TSecretScanningFinding[],
+ status: SecretScanningFindingStatus
+ ) => {
+ if (status !== SecretScanningFindingStatus.Unresolved) {
+ setStatusChange({ findings: targetFindings, status });
+ return;
+ }
+
+ reopenFindings(targetFindings);
+ };
+
const renderEmpty = () => {
if (!isFiltered) {
return (
@@ -459,13 +465,13 @@ export const SecretScanningFindingsTable = ({
}
/>
</TableCell>
- <TableCell isTruncatable className="h-auto py-2">
+ <TableCell isTruncatable>
<p className="truncate font-mono">{finding.rule}</p>
<p className="truncate font-mono text-xs text-muted">
{finding.details.file}:{finding.details.startLine}
</p>
</TableCell>
- <TableCell isTruncatable className="h-auto py-2">
+ <TableCell isTruncatable>
<p className="truncate font-mono">{finding.resourceName}</p>
{!isScoped && (
<p className="flex items-center gap-1.5 truncate text-xs text-muted">
@@ -567,10 +573,14 @@ export const SecretScanningFindingsTable = ({
findings={statusChange?.findings ?? []}
status={statusChange?.status ?? null}
onOpenChange={(isOpen) => !isOpen && setStatusChange(null)}
- onComplete={({ status, comment }) => {
+ onComplete={({ status, triageComment }) => {
setOpenFinding((prev) =>
prev && statusChange?.findings.some((f) => f.id === prev.id)
- ? { ...prev, status, triageComment: comment || prev.triageComment }
+ ? {
+ ...prev,
+ status,
+ triageComment
+ }
: prev
);
resetSelection();