Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

feat: remove vault migration code

varonix8eb2b4e90d82
diff --git a/backend/src/@types/knex.d.ts b/backend/src/@types/knex.d.ts
index ae09541361..3ae9977d4b 100644
--- a/backend/src/@types/knex.d.ts
+++ b/backend/src/@types/knex.d.ts
@@ -695,9 +695,6 @@ import {
TUserSecretActivationUpdate,
TUsersInsert,
TUsersUpdate,
- TVaultExternalMigrationConfigs,
- TVaultExternalMigrationConfigsInsert,
- TVaultExternalMigrationConfigsUpdate,
TWebauthnCredentials,
TWebauthnCredentialsInsert,
TWebauthnCredentialsUpdate,
@@ -1955,10 +1952,5 @@ declare module "knex/types/tables" {
TSecretValidationRulesInsert,
TSecretValidationRulesUpdate
>;
- [TableName.VaultExternalMigrationConfig]: KnexOriginal.CompositeTableType<
- TVaultExternalMigrationConfigs,
- TVaultExternalMigrationConfigsInsert,
- TVaultExternalMigrationConfigsUpdate
- >;
}
}
diff --git a/backend/src/db/migrations/20251013104547_add-in-platform-external-migration.ts b/backend/src/db/migrations/20251013104547_add-in-platform-external-migration.ts
index e5f74a0e04..b8b26dde62 100644
--- a/backend/src/db/migrations/20251013104547_add-in-platform-external-migration.ts
+++ b/backend/src/db/migrations/20251013104547_add-in-platform-external-migration.ts
@@ -3,9 +3,12 @@ import { Knex } from "knex";
import { TableName } from "../schemas";
import { createOnUpdateTrigger, dropOnUpdateTrigger } from "../utils";
+// Dropped by the 20260910093000 migration, so it no longer has a TableName entry.
+const VAULT_EXTERNAL_MIGRATION_CONFIGS = "vault_external_migration_configs";
+
export async function up(knex: Knex): Promise<void> {
- if (!(await knex.schema.hasTable(TableName.VaultExternalMigrationConfig))) {
- await knex.schema.createTable(TableName.VaultExternalMigrationConfig, (t) => {
+ if (!(await knex.schema.hasTable(VAULT_EXTERNAL_MIGRATION_CONFIGS))) {
+ await knex.schema.createTable(VAULT_EXTERNAL_MIGRATION_CONFIGS, (t) => {
t.uuid("id", { primaryKey: true }).defaultTo(knex.fn.uuid());
t.uuid("orgId").notNullable();
t.foreign("orgId").references("id").inTable(TableName.Organization).onDelete("CASCADE");
@@ -19,11 +22,11 @@ export async function up(knex: Knex): Promise<void> {
t.unique(["orgId", "namespace"]);
});
- await createOnUpdateTrigger(knex, TableName.VaultExternalMigrationConfig);
+ await createOnUpdateTrigger(knex, VAULT_EXTERNAL_MIGRATION_CONFIGS);
}
}
export async function down(knex: Knex): Promise<void> {
- await knex.schema.dropTableIfExists(TableName.VaultExternalMigrationConfig);
- await dropOnUpdateTrigger(knex, TableName.VaultExternalMigrationConfig);
+ await knex.schema.dropTableIfExists(VAULT_EXTERNAL_MIGRATION_CONFIGS);
+ await dropOnUpdateTrigger(knex, VAULT_EXTERNAL_MIGRATION_CONFIGS);
}
diff --git a/backend/src/db/migrations/20260330172252_rename-vault-to-external-migration-config.ts b/backend/src/db/migrations/20260330172252_rename-vault-to-external-migration-config.ts
index b91e97c9fa..641897da4a 100644
--- a/backend/src/db/migrations/20260330172252_rename-vault-to-external-migration-config.ts
+++ b/backend/src/db/migrations/20260330172252_rename-vault-to-external-migration-config.ts
@@ -1,7 +1,6 @@
import { Knex } from "knex";
import { inMemoryKeyStore } from "@app/keystore/memory";
-import { selectAllTableCols } from "@app/lib/knex";
import { initLogger } from "@app/lib/logger";
import { ExternalMigrationProviders } from "@app/services/external-migration/external-migration-schemas";
import { kmsRootConfigDALFactory } from "@app/services/kms/kms-root-config-dal";
@@ -13,6 +12,9 @@ import { createOnUpdateTrigger, dropOnUpdateTrigger } from "../utils";
import { getMigrationEnvConfig, getMigrationHsmConfig } from "./utils/env-config";
import { getMigrationEncryptionServices, getMigrationHsmService } from "./utils/services";
+// Dropped by the 20260910093000 migration, so it no longer has a TableName entry.
+const VAULT_EXTERNAL_MIGRATION_CONFIGS = "vault_external_migration_configs";
+
export async function up(knex: Knex): Promise<void> {
initLogger();
const { hsmService } = await getMigrationHsmService({ envConfig: getMigrationHsmConfig() });
@@ -36,10 +38,10 @@ export async function up(knex: Knex): Promise<void> {
await createOnUpdateTrigger(knex, TableName.ExternalMigrationConfig);
- if (await knex.schema.hasTable(TableName.VaultExternalMigrationConfig)) {
- const existingVaultConfigs = await knex(TableName.VaultExternalMigrationConfig).select(
- selectAllTableCols(TableName.VaultExternalMigrationConfig)
- );
+ if (await knex.schema.hasTable(VAULT_EXTERNAL_MIGRATION_CONFIGS)) {
+ const existingVaultConfigs = await knex
+ .select<{ orgId: string; namespace: string; connectionId?: string | null }[]>("*")
+ .from(VAULT_EXTERNAL_MIGRATION_CONFIGS);
await Promise.all(
existingVaultConfigs.map(async (vaultConfig) => {
diff --git a/backend/src/db/migrations/20260603120100_defer-app-connection-fks.ts b/backend/src/db/migrations/20260603120100_defer-app-connection-fks.ts
index abeaa4be30..9e98e834da 100644
--- a/backend/src/db/migrations/20260603120100_defer-app-connection-fks.ts
+++ b/backend/src/db/migrations/20260603120100_defer-app-connection-fks.ts
@@ -14,7 +14,6 @@ const BLOCKING_APP_CONNECTION_FKS: TFk[] = [
{ table: TableName.SecretScanningDataSource, column: "connectionId" },
{ table: TableName.PkiSync, column: "connectionId" },
{ table: TableName.ExternalMigrationConfig, column: "connectionId" },
- { table: TableName.VaultExternalMigrationConfig, column: "connectionId" },
{ table: TableName.HoneyTokenConfig, column: "connectionId" },
{ table: TableName.PamProjectRecordingConfig, column: "connectionId", originalOnDelete: "RESTRICT" }
];
diff --git a/backend/src/db/migrations/20260910093000_drop-vault-external-migration-configs.ts b/backend/src/db/migrations/20260910093000_drop-vault-external-migration-configs.ts
new file mode 100644
index 0000000000..69ee29e62a
--- /dev/null
+++ b/backend/src/db/migrations/20260910093000_drop-vault-external-migration-configs.ts
@@ -0,0 +1,34 @@
+import { Knex } from "knex";
+
+import { TableName } from "../schemas";
+import { createOnUpdateTrigger, dropOnUpdateTrigger } from "../utils";
+
+// Superseded by TableName.ExternalMigrationConfig, which the 20260330172252 migration backfilled from this table.
+const VAULT_EXTERNAL_MIGRATION_CONFIGS = "vault_external_migration_configs";
+
+export async function up(knex: Knex): Promise<void> {
+ if (await knex.schema.hasTable(VAULT_EXTERNAL_MIGRATION_CONFIGS)) {
+ await dropOnUpdateTrigger(knex, VAULT_EXTERNAL_MIGRATION_CONFIGS);
+ await knex.schema.dropTable(VAULT_EXTERNAL_MIGRATION_CONFIGS);
+ }
+}
+
+export async function down(knex: Knex): Promise<void> {
+ if (!(await knex.schema.hasTable(VAULT_EXTERNAL_MIGRATION_CONFIGS))) {
+ await knex.schema.createTable(VAULT_EXTERNAL_MIGRATION_CONFIGS, (t) => {
+ t.uuid("id", { primaryKey: true }).defaultTo(knex.fn.uuid());
+ t.uuid("orgId").notNullable();
+ t.foreign("orgId").references("id").inTable(TableName.Organization).onDelete("CASCADE");
+
+ t.string("namespace").notNullable();
+
+ t.uuid("connectionId");
+ t.foreign("connectionId").references("id").inTable(TableName.AppConnection).deferrable("deferred");
+
+ t.timestamps(true, true, true);
+ t.unique(["orgId", "namespace"]);
+ });
+
+ await createOnUpdateTrigger(knex, VAULT_EXTERNAL_MIGRATION_CONFIGS);
+ }
+}
diff --git a/backend/src/db/schemas/index.ts b/backend/src/db/schemas/index.ts
index fedb48bf30..0bb58809ee 100644
--- a/backend/src/db/schemas/index.ts
+++ b/backend/src/db/schemas/index.ts
@@ -266,7 +266,6 @@ export * from "./user-group-membership";
export * from "./user-mfa-recovery-codes";
export * from "./user-secret-activation";
export * from "./users";
-export * from "./vault-external-migration-configs";
export * from "./webauthn-credentials";
export * from "./webhooks";
export * from "./workflow-integrations";
diff --git a/backend/src/db/schemas/models.ts b/backend/src/db/schemas/models.ts
index 14a451ec95..d44d481495 100644
--- a/backend/src/db/schemas/models.ts
+++ b/backend/src/db/schemas/models.ts
@@ -276,7 +276,6 @@ export enum TableName {
AgentVaultSessionAccessBundle = "agent_vault_session_access_bundles",
AgentVaultProxy = "agent_vault_proxies",
- VaultExternalMigrationConfig = "vault_external_migration_configs",
ExternalMigrationConfig = "external_migration_configs",
// PKI ACME
diff --git a/backend/src/db/schemas/vault-external-migration-configs.ts b/backend/src/db/schemas/vault-external-migration-configs.ts
deleted file mode 100644
index 3101666698..0000000000
--- a/backend/src/db/schemas/vault-external-migration-configs.ts
+++ /dev/null
@@ -1,26 +0,0 @@
-// Code generated by automation script, DO NOT EDIT.
-// Automated by pulling database and generating zod schema
-// To update. Just run npm run generate:schema
-// Written by akhilmhdh.
-
-import { z } from "zod";
-
-import { TImmutableDBKeys } from "./models";
-
-export const VaultExternalMigrationConfigsSchema = z.object({
- id: z.string().uuid(),
- orgId: z.string().uuid(),
- namespace: z.string(),
- connectionId: z.string().uuid().nullable().optional(),
- createdAt: z.date(),
- updatedAt: z.date()
-});
-
-export type TVaultExternalMigrationConfigs = z.infer<typeof VaultExternalMigrationConfigsSchema>;
-export type TVaultExternalMigrationConfigsInsert = Omit<
- z.input<typeof VaultExternalMigrationConfigsSchema>,
- TImmutableDBKeys
->;
-export type TVaultExternalMigrationConfigsUpdate = Partial<
- Omit<z.input<typeof VaultExternalMigrationConfigsSchema>, TImmutableDBKeys>
->;