Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

test(e2e): cover secret tag CRUD and tag lifecycle on secrets

varonix96bbb34769a3
diff --git a/tests/suites/secretmanager/tags/helpers_test.go b/tests/suites/secretmanager/tags/helpers_test.go
new file mode 100644
index 0000000000..fa1786bf0e
--- /dev/null
+++ b/tests/suites/secretmanager/tags/helpers_test.go
@@ -0,0 +1,59 @@
+package tags_test
+
+import (
+ "encoding/json"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/clients/api"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/internal/apierr"
+ "github.com/stretchr/testify/require"
+)
+
+// slugsIn lists the project's tags as slugs, oldest first.
+func slugsIn(t *testing.T, proj *fixture.Project) []string {
+ t.Helper()
+ res, err := proj.Tenant().Admin.API.ListSecretTagsWithResponse(t.Context(), proj.ID)
+ require.NoError(t, err)
+ require.NotNilf(t, res.JSON200, "listing tags returned %d: %s", res.StatusCode(), apierr.Body(res.Body))
+ slugs := []string{}
+ for _, tag := range res.JSON200.Tags {
+ slugs = append(slugs, tag.Slug)
+ }
+ return slugs
+}
+
+// tagsOn reads the slugs attached to a secret at the project root in dev.
+func tagsOn(t *testing.T, proj *fixture.Project, key string) []string {
+ t.Helper()
+ res, err := proj.Tenant().Admin.API.GetSecretByNameV4WithResponse(t.Context(), key, &api.GetSecretByNameV4Params{
+ ProjectId: proj.ID, Environment: new("dev"),
+ })
+ require.NoError(t, err)
+ require.NotNilf(t, res.JSON200, "reading %s returned %d: %s", key, res.StatusCode(), apierr.Body(res.Body))
+ slugs := []string{}
+ if res.JSON200.Secret.Tags != nil {
+ for _, tag := range *res.JSON200.Secret.Tags {
+ slugs = append(slugs, tag.Slug)
+ }
+ }
+ return slugs
+}
+
+func createTaggedSecret(t *testing.T, proj *fixture.Project, key string, tagIDs ...string) {
+ t.Helper()
+ res, err := proj.Tenant().Admin.API.CreateSecretV4WithResponse(t.Context(), key, api.CreateSecretV4JSONRequestBody{
+ ProjectId: proj.ID, Environment: "dev", SecretValue: "v", TagIds: &tagIDs,
+ })
+ require.NoError(t, err)
+ require.NotNilf(t, res.JSON200, "creating %s returned %d: %s", key, res.StatusCode(), apierr.Body(res.Body))
+}
+
+func errorMessage(t *testing.T, body []byte) string {
+ t.Helper()
+ var e struct {
+ Message string `json:"message"`
+ }
+ require.NoErrorf(t, json.Unmarshal(body, &e), "decoding error body %s", apierr.Body(body))
+ return e.Message
+}
diff --git a/tests/suites/secretmanager/tags/lifecycle_test.go b/tests/suites/secretmanager/tags/lifecycle_test.go
new file mode 100644
index 0000000000..06a37e9377
--- /dev/null
+++ b/tests/suites/secretmanager/tags/lifecycle_test.go
@@ -0,0 +1,63 @@
+package tags_test
+
+import (
+ "net/http"
+ "slices"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/clients/api"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/fixture/secretmanager"
+ "github.com/Infisical/infisical/tests/harness"
+ "github.com/google/uuid"
+ "github.com/stretchr/testify/require"
+)
+
+func TestSecretTag_Lifecycle(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should strip the tag from secrets and keep the secrets when a tag is deleted", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ doomed, kept := secretmanager.CreateTag(t, proj, "doomed"), secretmanager.CreateTag(t, proj, "kept")
+ createTaggedSecret(t, proj, "BOTH_TAGS", doomed, kept)
+ createTaggedSecret(t, proj, "ONLY_DOOMED", doomed)
+
+ // Action
+ res, err := tn.Admin.API.DeleteSecretTagWithResponse(t.Context(), proj.ID, doomed)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusOK, res.StatusCode(), "deleting the tag returned %s", res.Body)
+ require.Equal(t, []string{"kept"}, slugsIn(t, proj))
+ require.Equal(t, []string{"kept"}, tagsOn(t, proj, "BOTH_TAGS"))
+ require.Empty(t, tagsOn(t, proj, "ONLY_DOOMED"))
+ require.Len(t, secretmanager.ListSecrets(t, proj, "dev"), 2)
+ })
+
+ t.Run("should refuse a batch create naming an unknown tag id and create none of it", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ known := secretmanager.CreateTag(t, proj, "known")
+ body := api.CreateManySecretsV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev"}
+ body.Secrets = slices.Grow(body.Secrets, 2)[:2]
+ body.Secrets[0].SecretKey, body.Secrets[0].SecretValue, body.Secrets[0].TagIds = "TAGGED", "v", &[]string{known}
+ body.Secrets[1].SecretKey, body.Secrets[1].SecretValue, body.Secrets[1].TagIds = "UNKNOWN_TAG", "v", &[]string{uuid.NewString()}
+
+ // Action
+ res, err := tn.Admin.API.CreateManySecretsV4WithResponse(t.Context(), body)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusNotFound, res.StatusCode(), "batch create returned %s", res.Body)
+ require.Equal(t, "Tag not found. Found known", errorMessage(t, res.Body))
+ require.Empty(t, secretmanager.ListSecrets(t, proj, "dev"))
+ })
+}
diff --git a/tests/suites/secretmanager/tags/main_test.go b/tests/suites/secretmanager/tags/main_test.go
new file mode 100644
index 0000000000..8d5fb47b57
--- /dev/null
+++ b/tests/suites/secretmanager/tags/main_test.go
@@ -0,0 +1,9 @@
+package tags_test
+
+import (
+ "testing"
+
+ "github.com/Infisical/infisical/tests/harness"
+)
+
+func TestMain(m *testing.M) { harness.Main(m, harness.Shared) }
diff --git a/tests/suites/secretmanager/tags/tag_test.go b/tests/suites/secretmanager/tags/tag_test.go
new file mode 100644
index 0000000000..e114dfaeb2
--- /dev/null
+++ b/tests/suites/secretmanager/tags/tag_test.go
@@ -0,0 +1,140 @@
+package tags_test
+
+import (
+ "fmt"
+ "net/http"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/clients/api"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/fixture/secretmanager"
+ "github.com/Infisical/infisical/tests/harness"
+ "github.com/google/uuid"
+ "github.com/stretchr/testify/require"
+)
+
+func TestSecretTag_Create(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should refuse a duplicate slug and keep one tag", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateTag(t, proj, "backend")
+
+ // Action
+ res, err := tn.Admin.API.CreateSecretTagWithResponse(t.Context(), proj.ID,
+ api.CreateSecretTagJSONRequestBody{Slug: "backend", Color: "#000000"})
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusBadRequest, res.StatusCode(), "creating a duplicate returned %s", res.Body)
+ require.Equal(t, "Tag already exists", errorMessage(t, res.Body))
+ require.Equal(t, []string{"backend"}, slugsIn(t, proj))
+ })
+
+ t.Run("should refuse a slug that is not lowercase letters, numbers and hyphens", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+
+ // Action
+ res, err := tn.Admin.API.CreateSecretTagWithResponse(t.Context(), proj.ID,
+ api.CreateSecretTagJSONRequestBody{Slug: "Back End", Color: "#000000"})
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusUnprocessableEntity, res.StatusCode(), "creating an invalid slug returned %s", res.Body)
+ require.Contains(t, string(res.Body), "Slug field can only contain lowercase letters, numbers, and hyphens")
+ require.Empty(t, slugsIn(t, proj))
+ })
+
+ t.Run("should refuse a viewer creating a tag", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ proj := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ viewer := proj.NewUser(t, fixture.WithPrincipalName("viewer"), fixture.WithRoles("viewer"))
+
+ // Action
+ res, err := viewer.API.CreateSecretTagWithResponse(t.Context(), proj.ID,
+ api.CreateSecretTagJSONRequestBody{Slug: "backend", Color: "#000000"})
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusForbidden, res.StatusCode(), "a viewer creating a tag returned %s", res.Body)
+ require.Empty(t, slugsIn(t, proj))
+ })
+}
+
+func TestSecretTag_Update(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should refuse an update onto another tag's slug and keep both", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateTag(t, proj, "backend")
+ frontend := secretmanager.CreateTag(t, proj, "frontend")
+
+ // Action
+ res, err := tn.Admin.API.UpdateSecretTagWithResponse(t.Context(), proj.ID, frontend,
+ api.UpdateSecretTagJSONRequestBody{Slug: "backend", Color: "#000000"})
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusBadRequest, res.StatusCode(), "renaming onto a taken slug returned %s", res.Body)
+ require.Equal(t, "Tag already exists", errorMessage(t, res.Body))
+ require.Equal(t, []string{"backend", "frontend"}, slugsIn(t, proj))
+ })
+}
+
+func TestSecretTag_Get(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should return a tag by slug", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ id := secretmanager.CreateTag(t, proj, "backend")
+ secretmanager.CreateTag(t, proj, "frontend")
+
+ // Action
+ res, err := tn.Admin.API.GetSecretTagBySlugWithResponse(t.Context(), proj.ID, "backend")
+
+ // Assert
+ require.NoError(t, err)
+ require.NotNilf(t, res.JSON200, "reading by slug returned %d: %s", res.StatusCode(), res.Body)
+ require.Equal(t, id, res.JSON200.Tag.Id.String())
+ require.Equal(t, "backend", res.JSON200.Tag.Slug)
+ require.Equal(t, proj.ID, res.JSON200.Tag.ProjectId)
+ })
+
+ t.Run("should return not found for an unknown id", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
+ unknown := uuid.NewString()
+
+ // Action
+ res, err := tn.Admin.API.GetSecretTagByIdWithResponse(t.Context(), proj.ID, unknown)
+
+ // Assert
+ require.NoError(t, err)
+ require.Equalf(t, http.StatusNotFound, res.StatusCode(), "reading an unknown tag returned %s", res.Body)
+ require.Equal(t, fmt.Sprintf("Tag with ID '%s' not found", unknown), errorMessage(t, res.Body))
+ })
+}