Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
fix(secret-sync): bound the portainer stack update request by the remaining wait budget
Yeongjin Leea034c5545fbe
diff --git a/backend/src/services/secret-sync/portainer/portainer-sync-fns.ts b/backend/src/services/secret-sync/portainer/portainer-sync-fns.tsindex 6a81260aa6..e2d39ebc09 100644--- a/backend/src/services/secret-sync/portainer/portainer-sync-fns.ts+++ b/backend/src/services/secret-sync/portainer/portainer-sync-fns.ts@@ -5,6 +5,7 @@ import { BadRequestError } from "@app/lib/errors";import {getPortainerErrorMessage,isPortainerGitStack,+ PORTAINER_REQUEST_TIMEOUT_MS,portainerRequest,PortainerStackStatus,PortainerStackType,@@ -22,8 +23,6 @@ import { TPortainerStackFileResponse, TPortainerSyncWithCredentials } from "./poconst PORTAINER_DEPLOYMENT_POLL_INTERVAL_MS = 5_000;// The sync job holds a five-minute lock per sync, so the wait has to give up inside that windowconst PORTAINER_DEPLOYMENT_TIMEOUT_MS = 4 * 60_000;-// Portainer releases before the background deployer run the redeploy inside the update request itself-const PORTAINER_STACK_UPDATE_TIMEOUT_MS = PORTAINER_DEPLOYMENT_TIMEOUT_MS;const DOTENV_ESCAPES: Record<string, string> = { '"': '"', "\\": "\\", n: "\n", r: "\r" };@@ -242,7 +241,9 @@ const writeFileStackEnv = async (path: `/stacks/${destinationConfig.stackId}`,params: { endpointId: String(destinationConfig.environmentId) },data: { env, stackFileContent, prune: stack.Option?.Prune ?? false },- timeoutMs: PORTAINER_STACK_UPDATE_TIMEOUT_MS+ // Releases before the background deployer run the redeploy inside this request, so it may take+ // whatever is left of the wait budget (but never less than a normal request)+ timeoutMs: Math.max(deadline - Date.now(), PORTAINER_REQUEST_TIMEOUT_MS)},deps);