Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
feat:add attempts on the delegated requests table
adilsona11820c2efa6
diff --git a/backend/src/db/migrations/20261019120000_delegated-approval-callback-attempts.ts b/backend/src/db/migrations/20261019120000_delegated-approval-callback-attempts.tsnew file mode 100644index 0000000000..50bcd4cdbc--- /dev/null+++ b/backend/src/db/migrations/20261019120000_delegated-approval-callback-attempts.ts@@ -0,0 +1,25 @@+import { Knex } from "knex";++import { TableName } from "../schemas";++export async function up(knex: Knex): Promise<void> {+ const hasCallbackAttempts = await knex.schema.hasColumn(TableName.DelegatedApprovalRequests, "callbackAttempts");++ await knex.schema.alterTable(TableName.DelegatedApprovalRequests, (t) => {+ if (!hasCallbackAttempts) {+ t.integer("callbackAttempts").notNullable().defaultTo(0);+ }+ t.index(["providerRequestId"], "delegated_approval_requests_provider_request_id_idx");+ });+}++export async function down(knex: Knex): Promise<void> {+ const hasCallbackAttempts = await knex.schema.hasColumn(TableName.DelegatedApprovalRequests, "callbackAttempts");++ await knex.schema.alterTable(TableName.DelegatedApprovalRequests, (t) => {+ t.dropIndex(["providerRequestId"], "delegated_approval_requests_provider_request_id_idx");+ if (hasCallbackAttempts) {+ t.dropColumn("callbackAttempts");+ }+ });+}diff --git a/backend/src/db/schemas/delegated-approval-requests.ts b/backend/src/db/schemas/delegated-approval-requests.tsindex 950f8c0f7e..5baf4ecb16 100644--- a/backend/src/db/schemas/delegated-approval-requests.ts+++ b/backend/src/db/schemas/delegated-approval-requests.ts@@ -17,7 +17,8 @@ export const DelegatedApprovalRequestsSchema = z.object({statusReason: z.string().nullable().optional(),providerRequestId: z.string().nullable().optional(),createdAt: z.date(),- updatedAt: z.date()+ updatedAt: z.date(),+ callbackAttempts: z.number().default(0)});export type TDelegatedApprovalRequests = z.infer<typeof DelegatedApprovalRequestsSchema>;diff --git a/backend/src/server/config/rateLimiter.ts b/backend/src/server/config/rateLimiter.tsindex c52daf13d8..bda9eb5c9b 100644--- a/backend/src/server/config/rateLimiter.ts+++ b/backend/src/server/config/rateLimiter.ts@@ -77,6 +77,15 @@ export const ocspLimit: RateLimitOptions = {keyGenerator: (req) => req.realIp};+// The delegated approval callback is unauthenticated, so the IP is all there is to key on. Each request+// accepts at most a handful of callbacks before it is invalidated, so one instance never needs more.+export const delegatedApprovalCallbackLimit: RateLimitOptions = {+ timeWindow: 60 * 1000,+ hook: "preValidation",+ max: 60,+ keyGenerator: (req) => req.realIp+};+// Gateways report load every 10s (6/min each), so 10 leaves room for tick drift and a restart// landing in the same window without leaving headroom for a flood. Keyed by the reporting gateway// rather than by IP, because the write limiter's IP key is shared: ~100 gateways behind one NATdiff --git a/backend/src/server/routes/index.ts b/backend/src/server/routes/index.tsindex 8e6af14115..049880c8f2 100644--- a/backend/src/server/routes/index.ts+++ b/backend/src/server/routes/index.ts@@ -358,6 +358,7 @@ import { delegatedApprovalPolicyDALFactory } from "@app/services/delegated-approimport { delegatedApprovalRequestDALFactory } from "@app/services/delegated-approval/delegated-approval-request-dal";import { delegatedApprovalServiceFactory } from "@app/services/delegated-approval/delegated-approval-service";import { delegatedApprovalDispatchQueueFactory } from "@app/services/delegated-approval/dispatch/delegated-approval-dispatch-queue";+import { delegatedApprovalCallbackEventConsumerFactory } from "@app/services/delegated-approval-callback/delegated-approval-callback-event-consumer";import { delegatedApprovalCallbackServiceFactory } from "@app/services/delegated-approval-callback/delegated-approval-callback-service";import { encryptionKeyRotationServiceFactory } from "@app/services/encryption-key-rotation/encryption-key-rotation-service";import { acmeEnrollmentConfigDALFactory } from "@app/services/enrollment-config/acme-enrollment-config-dal";@@ -1214,6 +1215,7 @@ export const registerRoutes = async (alertProviderRegistry}));+ eventOutboxRegistry.register(delegatedApprovalCallbackEventConsumerFactory());const eventOutboxService = eventOutboxServiceFactory({ eventOutboxDAL, eventOutboxRegistry });const eventOutboxQueue = eventOutboxQueueFactory({queueService,@@ -3241,7 +3243,9 @@ export const registerRoutes = async (const delegatedApprovalCallbackService = delegatedApprovalCallbackServiceFactory({delegatedApprovalRequestDAL,- kmsService+ approvalRequestDAL,+ kmsService,+ eventEmitter: eventOutboxService});const delegatedApprovalDispatchQueue = delegatedApprovalDispatchQueueFactory({