Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(reminders): qualify the secret id when copying reminders on a move

Calvina6b340551907
diff --git a/backend/src/services/reminder/reminder-service.test.ts b/backend/src/services/reminder/reminder-service.test.ts
index fe2b0434ab..f5e85a22c9 100644
--- a/backend/src/services/reminder/reminder-service.test.ts
+++ b/backend/src/services/reminder/reminder-service.test.ts
@@ -239,7 +239,9 @@ const buildWriteService = (opts: { projectUserIds?: string[]; alertRefusal?: Err
tags: []
}),
invalidateSecretCacheByProjectId: async () => {},
- find: async (filter: { $in: { id: string[] } }) => filter.$in.id.map((id) => ({ id, projectId: "proj-1" }))
+ // Only the qualified column works against the real query, which joins several tables with an id.
+ find: async (filter: { $in: Record<string, string[]> }) =>
+ filter.$in["secrets_v2.id"].map((id) => ({ id, projectId: "proj-1" }))
},
folderDAL: {
findSecretPathByFolderIds: async () => [{ id: "folder-1", path: "/", environmentSlug: "dev" }]
diff --git a/backend/src/services/reminder/reminder-service.ts b/backend/src/services/reminder/reminder-service.ts
index 9b9c659680..a496c48ed1 100644
--- a/backend/src/services/reminder/reminder-service.ts
+++ b/backend/src/services/reminder/reminder-service.ts
@@ -435,7 +435,11 @@ export const reminderServiceFactory = ({
const copyReminders: TReminderServiceFactory["copyReminders"] = async (moves, tx) => {
const carried = await $carrySchedules(moves, tx);
if (carried.length === 0) return;
- const secrets = await secretV2BridgeDAL.find({ $in: { id: carried.map((move) => move.fromSecretId) } }, { tx });
+ // Qualified: this find joins tags, metadata, folders and environments, which all have an id column.
+ const secrets = await secretV2BridgeDAL.find(
+ { $in: { [`${TableName.SecretV2}.id` as "id"]: carried.map((move) => move.fromSecretId) } },
+ { tx }
+ );
const projectIdBySecretId = new Map(secrets.map((secret) => [secret.id, secret.projectId]));
for (const move of carried) {
await alertService.copyAlertsToResource(