Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
improvement(ui): make access approval request rows real links (#8939)
Andrew Huangaef9aeb358d3
diff --git a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/AccessApprovalRequest.tsx b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/AccessApprovalRequest.tsxindex 486feddea9..dd54acd016 100644--- a/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/AccessApprovalRequest.tsx+++ b/frontend/src/pages/secret-manager/SecretApprovalsPage/components/AccessApprovalRequest/AccessApprovalRequest.tsx@@ -1,7 +1,7 @@/* eslint-disable no-nested-ternary *//* eslint-disable react/jsx-no-useless-fragment */import { useCallback, useEffect, useMemo, useState } from "react";-import { useNavigate, useSearch } from "@tanstack/react-router";+import { Link, useNavigate, useSearch } from "@tanstack/react-router";import { format, formatDistance } from "date-fns";import {BanIcon,@@ -50,6 +50,7 @@ import {InputGroupAddon,InputGroupInput,Pagination,+ RowLink,Skeleton,Table,TableBody,@@ -832,14 +833,7 @@ export const AccessApprovalRequest = ({environmentNamesBySlug[request.environmentName] ?? request.environmentName;return (- <TableRow- key={request.id}- tabIndex={0}- onClick={() => handleSelectRequest(request)}- onKeyDown={(evt) => {- if (evt.key === "Enter") handleSelectRequest(request);- }}- >+ <TableRow key={request.id} linked><TableCell>{request.isTemporary ? (<Badge variant="info">@@ -855,7 +849,15 @@ export const AccessApprovalRequest = ({<Badge variant="neutral">Permanent</Badge>)}</TableCell>- <TableCell title={environmentDisplayName}>{environmentDisplayName}</TableCell>+ <TableCell>+ <RowLink+ from={ROUTE_PATHS.SecretManager.ApprovalPage.path}+ to="."+ search={(prev) => ({ ...prev, requestId: request.id })}+ >+ {environmentDisplayName}+ </RowLink>+ </TableCell><TableCell title={request.policy.secretPath ?? undefined}>{request.policy.secretPath}</TableCell>@@ -925,11 +927,7 @@ export const AccessApprovalRequest = ({)}</div></TableCell>- <TableCell- variant="action"- onClick={(e) => e.stopPropagation()}- onKeyDown={(e) => e.stopPropagation()}- >+ <TableCell variant="action"><DropdownMenu><DropdownMenuTrigger asChild><IconButton variant="ghost" size="xs" aria-label="Request actions">@@ -937,9 +935,15 @@ export const AccessApprovalRequest = ({</IconButton></DropdownMenuTrigger><DropdownMenuContent align="end">- <DropdownMenuItem onClick={() => handleSelectRequest(request)}>- <EyeIcon />- View Request+ <DropdownMenuItem asChild>+ <Link+ from={ROUTE_PATHS.SecretManager.ApprovalPage.path}+ to="."+ search={(prev) => ({ ...prev, requestId: request.id })}+ >+ <EyeIcon />+ View Request+ </Link></DropdownMenuItem></DropdownMenuContent></DropdownMenu>