Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
fix(agent-vault): tell a member that variables are admin only
Scott Wilsonb13f338a5dc0
diff --git a/backend/e2e-test/routes/v1/agent-vault.spec.ts b/backend/e2e-test/routes/v1/agent-vault.spec.tsindex 19e3fb63aa..837e82cef9 100644--- a/backend/e2e-test/routes/v1/agent-vault.spec.ts+++ b/backend/e2e-test/routes/v1/agent-vault.spec.ts@@ -1469,6 +1469,7 @@ describe("Agent Vault V1 Router", async () => {const listed = await member.asIdentity("GET", variablesUrl(bundle.id));expect(listed.statusCode).toBe(403);+ expect(JSON.parse(listed.payload).message).toBe("Only Agent Vault admins can view or change variables");expect(listed.payload).not.toContain("admin_only_value");expect((await member.asIdentity("GET", `${variablesUrl(bundle.id)}/${variable.id}/value`)).statusCode).toBe(403diff --git a/backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-service.ts b/backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-service.tsindex 15655ee9a3..0f647b85f7 100644--- a/backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-service.ts+++ b/backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-service.ts@@ -20,7 +20,7 @@ import {ProjectPermissionSub} from "@app/ee/services/permission/project-permission";import { DatabaseErrorCode } from "@app/lib/error-codes";-import { BadRequestError, ConflictError, NotFoundError } from "@app/lib/errors";+import { BadRequestError, ConflictError, ForbiddenRequestError, NotFoundError } from "@app/lib/errors";import { hasPostgresConstraintViolation, hasPostgresErrorCode } from "@app/lib/errors/postgres";import { ActorType } from "@app/services/auth/auth-type";import { TKmsServiceFactory } from "@app/services/kms/kms-service";@@ -1317,10 +1317,14 @@ export const agentVaultAccessBundleServiceFactory = (deps: TAgentVaultAccessBund// from, and Edit is the action only an admin holds.const resolveVariableBundle = async (dto: TGetAccessBundleDTO) => {const { bundle, permission } = await resolveReachableBundle(dto);- ForbiddenError.from(permission).throwUnlessCan(- ProjectPermissionAgentVaultAccessBundleActions.Edit,- ProjectPermissionSub.AgentVaultAccessBundles- );+ if (+ permission.cannot(+ ProjectPermissionAgentVaultAccessBundleActions.Edit,+ ProjectPermissionSub.AgentVaultAccessBundles+ )+ ) {+ throw new ForbiddenRequestError({ message: "Only Agent Vault admins can view or change variables" });+ }return bundle;};