Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

test(secret-sync): drop the child-path auto-sync test

Calvinb151d855bfd9
diff --git a/backend/e2e-test/routes/v1/secret-sync.spec.ts b/backend/e2e-test/routes/v1/secret-sync.spec.ts
index 4653a10d52..4691d3eea8 100644
--- a/backend/e2e-test/routes/v1/secret-sync.spec.ts
+++ b/backend/e2e-test/routes/v1/secret-sync.spec.ts
@@ -1,7 +1,7 @@
import { randomUUID } from "crypto";
import { fakeParameterStore } from "e2e-test/fakes/aws-parameter-store-sync-fns";
-import { createFolder, deleteFolder } from "e2e-test/testUtils/folders";
import { createIsolatedOrgAndProject } from "e2e-test/testUtils/fixtures";
+import { createFolder, deleteFolder } from "e2e-test/testUtils/folders";
import { createSecretImport } from "e2e-test/testUtils/secret-imports";
import {
createAwsAppConnection,
@@ -448,7 +448,7 @@ describe("Secret syncs", async () => {
});
});
- describe("Automatic syncing is triggered by changes at the source secret path only", () => {
+ describe("Automatic syncing is triggered by changes at the source secret path", () => {
test("Creating a secret at the source secret path triggers a sync run", async () => {
const destinationPath = pathFor("auto-sync-source");
// Auto sync is enabled after creation, and only once the destination has gone quiet, so
@@ -470,37 +470,6 @@ describe("Secret syncs", async () => {
});
});
- // The second pin for recursive syncing: today a child folder write reaches nothing.
- test("Creating a secret in a child secret path does not trigger a sync run", async () => {
- const destinationPath = pathFor("auto-sync-child");
- // Written before auto sync is on, so it cannot queue a run that lands later and looks
- // like the child write's doing.
- const { secretSync } = await newSync("auto-sync-child", {
- secretPath: "/services",
- isAutoSyncEnabled: false
- });
- await addSecret("/services", "PARENT_KEY", "parent-value");
-
- // Enabling auto sync queues a run; wait for the parent's secret to arrive.
- await setAutoSync({ syncId: secretSync!.id, isAutoSyncEnabled: true, authToken });
- await waitForDestinationSecrets({
- region: REGION,
- destinationPath,
- expected: { PARENT_KEY: "parent-value" }
- });
-
- await addSecret("/services/api", "CHILD_KEY", "child-value");
-
- // The child's secret must not reach the destination. Whether the parent's sync happens to
- // run again is not asserted: the queue requeues on lock contention, so run counts are not
- // stable, while what arrives is.
- await expectDestinationUnchanged({
- region: REGION,
- destinationPath,
- expected: { PARENT_KEY: "parent-value" }
- });
- });
-
test("A change at the source secret path does not trigger a sync run when the auto sync parameter is false", async () => {
const destinationPath = pathFor("auto-sync-off");
await newSync("auto-sync-off", { secretPath: "/services", isAutoSyncEnabled: false });