Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
fix(insights): ignore a read from before the reader had access to the secret
Dimitris Staratzisb1c78d729fe8
diff --git a/backend/CLAUDE.md b/backend/CLAUDE.mdindex 1c67984c42..116029c373 100644--- a/backend/CLAUDE.md+++ b/backend/CLAUDE.md@@ -1158,7 +1158,9 @@ owns the two read endpoints and hands `recordRead` / `recordBulkRead` through toso a change only restarts the window for the secrets it opened. An edit to a custom role's rules dates that rolefor every secret it gives, since which secrets an edit opened is not recorded. Expired access is not a source,except an expired folder grant, which can give back access it held back in its folder. Only an actor with a- source newer than `judgedFrom` is checked per secret, and each source once per secret across actors. The per-secret sheet shows the plain fact+ source newer than `judgedFrom` is checked per secret, and each source once per secret across actors. A read from+ before the reader had access to a secret is dropped for that secret (`readsByActorKey`): reads are credited by+ folder, and a folder read then could not have returned it. The per-secret sheet shows the plain factinstead: a read, "No reads", or "No reads yet" with the reason.- **The access sheet.** The graph lives only in the secret's access sheet, served by`GET /insights/:projectId/secrets/read-activity/:secretName` (the fixed segment comes first so a secret nameddiff --git a/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.test.ts b/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.test.tsindex 7ba45e8edc..cbd5c89ebf 100644--- a/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.test.ts+++ b/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.test.ts@@ -215,6 +215,22 @@ describe("summarizeSecretAccess", () => {expect(ids(summary.unread)).toEqual(["direct", "via-group"]);});+ test("drops a read from before the reader had access to the secret, and keeps one after", () => {+ const readOnOct1 = readBy("direct");+ const before = summarizeSecretAccess(+ activity({ reads: readOnOct1 }),+ access(datedAccess({ direct: new Date("2026-10-05T00:00:00.000Z") }))+ );+ expect(before.readsByActorKey.has(toActorKey(ActorType.USER, "direct"))).toBe(false);+ const after = summarizeSecretAccess(+ activity({ reads: readOnOct1 }),+ access(datedAccess({ direct: new Date("2026-09-20T00:00:00.000Z") }))+ );+ expect(after.readsByActorKey.get(toActorKey(ActorType.USER, "direct"))?.lastReadAt).toEqual(+ new Date("2026-10-01T00:00:00.000Z")+ );+ });+test("does not count a secret newer than the judged period", () => {const summary = summarizeSecretAccess(activity({ trackedSince: new Date("2026-10-01T00:00:00.000Z") }), access());expect(summary.unread).toEqual([]);diff --git a/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.ts b/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.tsindex d5b19dcfaf..8eccc91347 100644--- a/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.ts+++ b/backend/src/ee/services/secret-read-activity/secret-read-activity-fns.ts@@ -223,12 +223,26 @@ export const summarizeSecretAccess = (const latest = latestAccessChangeOf(reader);return latest && latest > judgedFrom ? accessSinceOf(reader, activity) : latest;};+ // A read is credited by folder, so one from before the reader had access to this secret did not return it. A read+ // after their newest source change is after their access to every secret, so only an earlier one is checked.+ const readsByActorKey = new Map<string, TSecretReadResult>();+ entitled.forEach((reader) => {+ const key = toActorKey(reader.actorType, reader.actorId);+ const read = reads.get(key);+ if (!read) return;+ const latest = latestAccessChangeOf(reader);+ if (latest && read.lastReadAt < latest) {+ const since = accessSinceOf(reader, activity);+ if (since && read.lastReadAt < since) return;+ }+ readsByActorKey.set(key, read);+ });const unread = nonAdmins.filter((reader) =>- !reads.has(toActorKey(reader.actorType, reader.actorId)) &&+ !readsByActorKey.has(toActorKey(reader.actorType, reader.actorId)) &&coversWholeWindow(trackedSince, accessSince(reader), judgedFrom));- return { entitled, nonAdmins, unread };+ return { entitled, nonAdmins, unread, readsByActorKey };};// A reader without a read who is not unused access was left out for one of three reasons, checked in this order.diff --git a/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts b/backend/src/ee/services/secret-read-activity/secret-read-activity-service.tsindex 553da84db2..5b5b3242ce 100644--- a/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts+++ b/backend/src/ee/services/secret-read-activity/secret-read-activity-service.ts@@ -452,13 +452,13 @@ export const secretReadActivityServiceFactory = ({message: `Secret with name '${secretName}' not found at path '${secretPath}' in environment '${environment}'`});}- const { entitled, unread } = summarizeSecretAccess(activity, access);+ const { entitled, unread, readsByActorKey } = summarizeSecretAccess(activity, access);const unusedKeys = new Set(unread.map((reader) => toActorKey(reader.actorType, reader.actorId)));const names = await $findActorNames(entitled, access.directMembers);const actors = entitled.map((reader): TSecretReadActivityActor => {const key = toActorKey(reader.actorType, reader.actorId);- const lastReadAt = activity.reads.get(key)?.lastReadAt ?? null;+ const lastReadAt = readsByActorKey.get(key)?.lastReadAt ?? null;const isProjectAdmin = access.adminActorIds.has(reader.actorId);// Every reader has at least one dated source; without one, access is as old as the secret's tracked period.const accessSince = access.accessSinceOf(reader, activity) ?? activity.trackedSince;diff --git a/backend/src/ee/services/secret-read-activity/secret-read-activity-types.ts b/backend/src/ee/services/secret-read-activity/secret-read-activity-types.tsindex 31366a3a73..5e2ae84f9c 100644--- a/backend/src/ee/services/secret-read-activity/secret-read-activity-types.ts+++ b/backend/src/ee/services/secret-read-activity/secret-read-activity-types.ts@@ -145,6 +145,9 @@ export type TSecretAccessSummary = {entitled: TProjectReader[];nonAdmins: TProjectReader[];unread: TProjectReader[];+ // The latest read of each entitled reader, keyed by actor, leaving out a read from before they had access to the+ // secret: a folder read then could not have returned it.+ readsByActorKey: Map<string, TSecretReadResult>;};export enum SecretReadStatus {