Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(agent-vault): show a delegation row's excluded bundles beside its actions

Scott Wilsonb308f16780fe
diff --git a/frontend/src/components/agent-vault/IdentityDelegationSection.tsx b/frontend/src/components/agent-vault/IdentityDelegationSection.tsx
index d5c5e5bff8..970dd792d3 100644
--- a/frontend/src/components/agent-vault/IdentityDelegationSection.tsx
+++ b/frontend/src/components/agent-vault/IdentityDelegationSection.tsx
@@ -197,50 +197,48 @@ export const IdentityDelegationSection = ({ machineIdentityId, machineIdentityNa
<UsersRoundIcon className="size-4 shrink-0 text-muted" />
<div className="min-w-0">
<div className="truncate">All Agent Vault Members</div>
- <div className="flex min-w-0 items-center gap-2 text-xs leading-4 text-muted">
- <span className="min-w-0 truncate">
- Every user in Agent Vault, including users added later
- </span>
- <MissingAccessBundlesHint
- bundles={delegation.missingAccessBundles}
- machineIdentityName={machineIdentityName}
- onBehalfOf="Agent Vault members"
- />
+ <div className="truncate text-xs leading-4 text-muted">
+ Every user in Agent Vault, including users added later
</div>
</div>
</div>
</TableCell>
<TableCell>{format(new Date(delegation.updatedAt), "MMM d, yyyy")}</TableCell>
<TableCell variant="action">
- {rowActions("All Agent Vault Members", () =>
- setPendingRemoval({ kind: "all-members" })
- )}
+ <div className="flex items-center justify-end gap-2">
+ <MissingAccessBundlesHint
+ bundles={delegation.missingAccessBundles}
+ machineIdentityName={machineIdentityName}
+ onBehalfOf="Agent Vault members"
+ />
+ {rowActions("All Agent Vault Members", () =>
+ setPendingRemoval({ kind: "all-members" })
+ )}
+ </div>
</TableCell>
</TableRow>
) : (
subjects.map((subject) => (
<TableRow key={`${subject.type}:${subject.id}`}>
<TableCell>
- <MemberName
- member={subject}
- subtitleAddon={
- <MissingAccessBundlesHint
- bundles={subject.missingAccessBundles}
- machineIdentityName={machineIdentityName}
- onBehalfOf={
- subject.type === AgentVaultMemberType.Group
- ? `members of "${memberDisplayName(subject)}"`
- : `"${memberDisplayName(subject)}"`
- }
- />
- }
- />
+ <MemberName member={subject} />
</TableCell>
<TableCell>{format(new Date(subject.addedAt), "MMM d, yyyy")}</TableCell>
<TableCell variant="action">
- {rowActions(memberDisplayName(subject), () =>
- setPendingRemoval({ kind: "subject", subject })
- )}
+ <div className="flex items-center justify-end gap-2">
+ <MissingAccessBundlesHint
+ bundles={subject.missingAccessBundles}
+ machineIdentityName={machineIdentityName}
+ onBehalfOf={
+ subject.type === AgentVaultMemberType.Group
+ ? `members of "${memberDisplayName(subject)}"`
+ : `"${memberDisplayName(subject)}"`
+ }
+ />
+ {rowActions(memberDisplayName(subject), () =>
+ setPendingRemoval({ kind: "subject", subject })
+ )}
+ </div>
</TableCell>
</TableRow>
))
diff --git a/frontend/src/components/agent-vault/MemberName.tsx b/frontend/src/components/agent-vault/MemberName.tsx
index ed7fb889ed..d6618657ba 100644
--- a/frontend/src/components/agent-vault/MemberName.tsx
+++ b/frontend/src/components/agent-vault/MemberName.tsx
@@ -21,13 +21,7 @@ export const memberSubtitle = (actor: TAgentVaultActor | TAgentVaultSessionActor
return actor.email || actor.username;
};
-export const MemberName = ({
- member,
- subtitleAddon
-}: {
- member: TAgentVaultActor;
- subtitleAddon?: React.ReactNode;
-}) => {
+export const MemberName = ({ member }: { member: TAgentVaultActor }) => {
const { label, icon: Icon } = MEMBER_KIND[member.type];
return (
@@ -36,14 +30,7 @@ export const MemberName = ({
<span className="sr-only">{label}</span>
<div className="min-w-0">
<div className="truncate">{memberDisplayName(member)}</div>
- {subtitleAddon ? (
- <div className="flex min-w-0 items-center gap-2 text-xs leading-4 text-muted">
- <span className="min-w-0 truncate">{memberSubtitle(member)}</span>
- {subtitleAddon}
- </div>
- ) : (
- <div className="truncate text-xs leading-4 text-muted">{memberSubtitle(member)}</div>
- )}
+ <div className="truncate text-xs leading-4 text-muted">{memberSubtitle(member)}</div>
</div>
</div>
);
diff --git a/frontend/src/components/agent-vault/MissingAccessBundlesHint.tsx b/frontend/src/components/agent-vault/MissingAccessBundlesHint.tsx
index 543e8650bc..240c24336b 100644
--- a/frontend/src/components/agent-vault/MissingAccessBundlesHint.tsx
+++ b/frontend/src/components/agent-vault/MissingAccessBundlesHint.tsx
@@ -30,7 +30,7 @@ export const MissingAccessBundlesHint = ({ bundles, machineIdentityName, onBehal
<span className="underline decoration-dotted underline-offset-2">{label}</span>
</button>
</HoverCardTrigger>
- <HoverCardContent align="start" className="flex w-80 flex-col gap-2.5">
+ <HoverCardContent align="end" className="flex w-80 flex-col gap-2.5">
<p className="text-xs text-muted">
{`Sessions on behalf of ${onBehalfOf} can't use these access bundles, because "${machineIdentityName}" isn't granted them.`}
</p>