Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(pki-discovery): validate ip range format

bernie-gbe3e6f2c3e90
diff --git a/backend/src/ee/services/pki-discovery/pki-discovery-fns.ts b/backend/src/ee/services/pki-discovery/pki-discovery-fns.ts
index 567e5e26b9..92f62aca74 100644
--- a/backend/src/ee/services/pki-discovery/pki-discovery-fns.ts
+++ b/backend/src/ee/services/pki-discovery/pki-discovery-fns.ts
@@ -116,6 +116,14 @@ export const validateTargetConfig = (
}
if (hasIpRanges) {
+ const invalidRange = ipRanges.find((r) => net.isIP(r.split("/")[0]) === 0);
+ if (invalidRange) {
+ return {
+ valid: false,
+ error: `'${invalidRange}' is not a valid IP address or CIDR range. Add hostnames as domains instead.`
+ };
+ }
+
const cidrRanges = ipRanges.filter((r) => r.includes("/"));
const singleIps = ipRanges.filter((r) => !r.includes("/"));
@@ -632,6 +640,12 @@ export const resolveTargets = async (
if (targetConfig.ipRanges) {
for (const range of targetConfig.ipRanges) {
+ // expandCIDR passes a hostname through unchanged, and the TLS connect would resolve it from inside our network.
+ if (blockPrivate && net.isIP(range.split("/")[0]) === 0) {
+ // eslint-disable-next-line no-continue
+ continue;
+ }
+
const expandedIps = expandCIDR(range);
const ips = blockPrivate ? expandedIps.filter((ip) => !isPrivateIp(ip)) : expandedIps;