Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

refactor(audit-log-stream): drop redundant truncation, provider label map and failing-state tracking

Calvinc057fa490a08
diff --git a/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.test.ts b/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.test.ts
index 3e49d9b309..90a99239cc 100644
--- a/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.test.ts
+++ b/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.test.ts
@@ -710,8 +710,8 @@ describe("audit-log-stream-outbox-service delivery failure alerting", () => {
});
test("stays quiet when a stream that is already failing exhausts more rows", async () => {
- const { service, auditLogStreamOutboxDAL, auditLogStreamDAL, eventEmitter } = createService();
- auditLogStreamDAL.findById.mockResolvedValueOnce(failingStream);
+ const { service, auditLogStreamOutboxDAL, eventEmitter } = createService();
+ auditLogStreamOutboxDAL.markStreamFailing.mockResolvedValueOnce(null);
auditLogStreamOutboxDAL.claimBatchForStream
.mockResolvedValueOnce([buildRow({ attempts: 4 })])
.mockResolvedValueOnce([]);
@@ -719,7 +719,6 @@ describe("audit-log-stream-outbox-service delivery failure alerting", () => {
await service.drainStream({ streamId: STREAM_ID, orgId: ORG_ID, provider: PROVIDER });
- expect(auditLogStreamOutboxDAL.markStreamFailing).not.toHaveBeenCalled();
expect(eventEmitter.emit).not.toHaveBeenCalled();
});
diff --git a/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.ts b/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.ts
index 6b1921a513..d47d29ca9b 100644
--- a/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.ts
+++ b/backend/src/ee/services/audit-log-stream-outbox/audit-log-stream-outbox-service.ts
@@ -377,7 +377,7 @@ export const auditLogStreamOutboxServiceFactory = ({
// The state flip and the alert event commit with the drop itself, so an alert is never lost
// or sent for rows that are still retrying.
- const becameFailing = exhausted.length > 0 && !isFailing;
+ const becameFailing = exhausted.length > 0;
const recovered = isFailing && streamFail.length === 0 && streamSuccess.length > 0;
// eslint-disable-next-line no-await-in-loop
await auditLogStreamOutboxDAL.transaction(async (tx) => {
@@ -398,7 +398,6 @@ export const auditLogStreamOutboxServiceFactory = ({
await auditLogStreamOutboxDAL.clearStreamFailing(streamId, tx);
}
});
- if (becameFailing) isFailing = true;
if (recovered) isFailing = false;
if (streamFail.length > 0) {
diff --git a/backend/src/ee/services/audit-log-stream/audit-log-stream-events.ts b/backend/src/ee/services/audit-log-stream/audit-log-stream-events.ts
index 105502b9a2..475a924709 100644
--- a/backend/src/ee/services/audit-log-stream/audit-log-stream-events.ts
+++ b/backend/src/ee/services/audit-log-stream/audit-log-stream-events.ts
@@ -44,7 +44,7 @@ export const emitAuditLogStreamDeliveryFailed = (
resourceId: streamId,
targetIds: [streamId],
provider: provider ?? "unknown",
- errorMessage: truncateDeliveryError(errorMessage),
+ errorMessage,
droppedCount,
failingSince: failingSince.toISOString()
}
diff --git a/backend/src/services/alert/providers/audit-log-stream-alert-provider.ts b/backend/src/services/alert/providers/audit-log-stream-alert-provider.ts
index cb63d11f45..1305ef12e3 100644
--- a/backend/src/services/alert/providers/audit-log-stream-alert-provider.ts
+++ b/backend/src/services/alert/providers/audit-log-stream-alert-provider.ts
@@ -7,6 +7,7 @@ import {
AUDIT_LOG_STREAM_RESOURCE_TYPE,
AuditLogStreamDeliveryFailedPayloadSchema
} from "@app/ee/services/audit-log-stream/audit-log-stream-events";
+import { listProviderOptions } from "@app/ee/services/audit-log-stream/audit-log-stream-fns";
import { OrgPermissionActions, OrgPermissionSubjects } from "@app/ee/services/permission/org-permission";
import { TPermissionServiceFactory } from "@app/ee/services/permission/permission-service-types";
import { getConfig } from "@app/lib/config/env";
@@ -27,14 +28,7 @@ export { AUDIT_LOG_STREAM_DELIVERY_FAILED_EVENT, AUDIT_LOG_STREAM_RESOURCE_TYPE
const DeliveryFailedConditionSchema = z.object({}).nullish();
-const PROVIDER_LABELS: Record<string, string> = {
- azure: "Azure",
- cribl: "Cribl",
- custom: "Custom",
- datadog: "Datadog",
- splunk: "Splunk",
- "sumo-logic": "Sumo Logic"
-};
+const PROVIDER_LABELS = new Map<string, string>(listProviderOptions().map((option) => [option.provider, option.name]));
type TAuditLogStreamTarget = {
streamId: string;
@@ -90,7 +84,7 @@ export const auditLogStreamAlertProviderFactory = ({
const buildPayload = (alert: TAlertContext, targets: TAuditLogStreamTarget[], viewUrl: string): TAlertPayload => {
const [first] = targets;
- const providerLabel = (target: TAuditLogStreamTarget) => PROVIDER_LABELS[target.provider] ?? target.provider;
+ const providerLabel = (target: TAuditLogStreamTarget) => PROVIDER_LABELS.get(target.provider) ?? target.provider;
return {
alert: {