Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

only display accs whose credentials you can view

Andreyc6a66a9dd95d
diff --git a/frontend/src/hooks/api/pam/queries.tsx b/frontend/src/hooks/api/pam/queries.tsx
index 4d36a31fae..c0d5aa807d 100644
--- a/frontend/src/hooks/api/pam/queries.tsx
+++ b/frontend/src/hooks/api/pam/queries.tsx
@@ -173,15 +173,19 @@ export const usePamAccountActions = (accountId: string, enabled = true) => {
// Builds a `can` checker from packed permission rules already embedded in a list item, so list rows
// don't each fire a per-account /permissions request (see useListPamAccounts).
+export const buildPamAccountCan = (
+ permissions?: ResourcePermissionResponse<PamFolderPermissionSet>["permissions"]
+) => {
+ const rules = unpackRules<RawRuleOf<MongoAbility<PamFolderPermissionSet>>>(permissions ?? []);
+ const permission = createMongoAbility<PamFolderPermissionSet>(rules, { conditionsMatcher });
+ return (action: PamResourcePermissionActions) =>
+ permission.can(action, PamResourcePermissionSub.PamResource);
+};
+
export const usePamAccountActionsFromPermissions = (
permissions?: ResourcePermissionResponse<PamFolderPermissionSet>["permissions"]
) => {
- const can = useMemo(() => {
- const rules = unpackRules<RawRuleOf<MongoAbility<PamFolderPermissionSet>>>(permissions ?? []);
- const permission = createMongoAbility<PamFolderPermissionSet>(rules, { conditionsMatcher });
- return (action: PamResourcePermissionActions) =>
- permission.can(action, PamResourcePermissionSub.PamResource);
- }, [permissions]);
+ const can = useMemo(() => buildPamAccountCan(permissions), [permissions]);
return { can };
};
diff --git a/frontend/src/pages/pam/PamDiscoveryPage/components/ImportDiscoveredModal.tsx b/frontend/src/pages/pam/PamDiscoveryPage/components/ImportDiscoveredModal.tsx
index 12b0df9949..51c0deaaa6 100644
--- a/frontend/src/pages/pam/PamDiscoveryPage/components/ImportDiscoveredModal.tsx
+++ b/frontend/src/pages/pam/PamDiscoveryPage/components/ImportDiscoveredModal.tsx
@@ -11,6 +11,7 @@ import {
DialogTitle,
Field,
FieldContent,
+ FieldDescription,
FieldLabel,
Select,
SelectContent,
@@ -20,9 +21,11 @@ import {
Toggle
} from "@app/components/v3";
import {
+ buildPamAccountCan,
isRotatablePamAccountType,
PamAccountAccessibilityIssue,
PamAccountType,
+ PamResourcePermissionActions,
PamRotationStatus,
TImportPamDiscoveredAccountResult,
TPamDiscoveredAccount,
@@ -75,13 +78,18 @@ export const ImportDiscoveredModal = ({
const rotatableTypes = accountTypes.filter(isRotatablePamAccountType);
const isRotating = rotateOnImport && rotatableTypes.length > 0;
- // a rotation account authenticates with its own stored password, so one without it can't rotate
+ // setting a rotation account needs a stored password on it and permission to view that password
+ const credentialCandidates = useMemo(
+ () =>
+ pamAccounts.filter(
+ (a) =>
+ !a.accessibilityIssues.includes(PamAccountAccessibilityIssue.NoCredential) &&
+ buildPamAccountCan(a.permissions)(PamResourcePermissionActions.ViewCredentials)
+ ),
+ [pamAccounts]
+ );
const rotationCandidates = (type: string) =>
- pamAccounts.filter(
- (a) =>
- a.accountType === type &&
- !a.accessibilityIssues.includes(PamAccountAccessibilityIssue.NoCredential)
- );
+ credentialCandidates.filter((a) => a.accountType === type);
const rotationAccountIdFor = (type: string) => {
const selected = rotationAccountByType[type];
@@ -249,6 +257,9 @@ export const ImportDiscoveredModal = ({
}
placeholder={`Select a ${typeName} account`}
/>
+ <FieldDescription>
+ Only accounts whose credentials you can view are listed.
+ </FieldDescription>
</FieldContent>
</Field>
);