Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

feat: addressed llm comments

=c796751bf0a2
diff --git a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts
index 3efdbfc5d2..272788c2a2 100644
--- a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts
+++ b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts
@@ -1888,7 +1888,7 @@ export const secretV2BridgeServiceFactory = ({
[`${TableName.SecretV2}.userId` as "userId"]: secretType === SecretType.Personal ? actorId : null
})
: secretVersionDAL
- .findOneWithSecretTags({
+ .findOneWithTags({
folderId,
version,
type: secretType,
diff --git a/backend/src/services/secret-v2-bridge/secret-version-dal.ts b/backend/src/services/secret-v2-bridge/secret-version-dal.ts
index 12a772eca7..62100be232 100644
--- a/backend/src/services/secret-v2-bridge/secret-version-dal.ts
+++ b/backend/src/services/secret-v2-bridge/secret-version-dal.ts
@@ -42,20 +42,20 @@ export const secretVersionV2BridgeDALFactory = (db: TDbClient) => {
}
};
- const findOneWithSecretTags = async (filter: Partial<TSecretVersionsV2>, tx?: Knex) => {
+ const findOneWithTags = async (filter: Partial<TSecretVersionsV2>, tx?: Knex) => {
try {
const rawDocs = await (tx || db.replicaNode())(TableName.SecretVersionV2)
// eslint-disable-next-line
.where(buildFindFilter(filter, TableName.SecretVersionV2))
.leftJoin(TableName.SecretV2, `${TableName.SecretVersionV2}.secretId`, `${TableName.SecretV2}.id`)
.leftJoin(
- TableName.SecretV2JnTag,
- `${TableName.SecretV2}.id`,
- `${TableName.SecretV2JnTag}.${TableName.SecretV2}Id`
+ TableName.SecretVersionV2Tag,
+ `${TableName.SecretVersionV2}.id`,
+ `${TableName.SecretVersionV2Tag}.${TableName.SecretVersionV2}Id`
)
.leftJoin(
TableName.SecretTag,
- `${TableName.SecretV2JnTag}.${TableName.SecretTag}Id`,
+ `${TableName.SecretVersionV2Tag}.${TableName.SecretTag}Id`,
`${TableName.SecretTag}.id`
)
.leftJoin(TableName.SecretFolder, `${TableName.SecretV2}.folderId`, `${TableName.SecretFolder}.id`)
@@ -636,7 +636,7 @@ export const secretVersionV2BridgeDALFactory = (db: TDbClient) => {
findByIdsWithLatestVersion,
findByIdAndPreviousVersion,
findOne,
- findOneWithSecretTags,
+ findOneWithTags,
findByParentVersionIds
};
};