Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

test(e2e): move cross-project references into the sharing suite and cover more of them

varonixcddd7473b437
diff --git a/tests/suites/secretmanager/secrets/create_test.go b/tests/suites/secretmanager/secrets/create_test.go
index d2db07cfa6..a689d91b1f 100644
--- a/tests/suites/secretmanager/secrets/create_test.go
+++ b/tests/suites/secretmanager/secrets/create_test.go
@@ -438,23 +438,4 @@ func TestSecret_Create(t *testing.T) {
require.Equalf(t, http.StatusRequestEntityTooLarge, res.StatusCode(), "creating returned %s", apierr.Body(res.Body))
require.Empty(t, secretmanager.ListSecrets(t, proj, "dev"))
})
-
- t.Run("should answer a key over 100 characters with a route not found on the single-secret route", func(t *testing.T) {
- t.Parallel()
- spec.Why(t, "the router caps a path parameter at 100 characters, so a long key never reaches the route and reads as a missing route")
-
- // Setup
- tn := h.NewTenant(t)
- proj := fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
-
- // Action
- res, err := tn.Admin.API.CreateSecretV4WithResponse(t.Context(), strings.Repeat("K", 101),
- api.CreateSecretV4JSONRequestBody{ProjectId: proj.ID, Environment: "dev", SecretValue: "value"})
-
- // Assert
- require.NoError(t, err)
- require.Equalf(t, http.StatusNotFound, res.StatusCode(), "creating returned %s", apierr.Body(res.Body))
- require.Contains(t, string(res.Body), "Route POST:/api/v4/secrets/")
- require.Empty(t, secretmanager.ListSecrets(t, proj, "dev"))
- })
}
diff --git a/tests/suites/secretmanager/secrets/reference_test.go b/tests/suites/secretmanager/secrets/reference_test.go
index 28deeb7b51..5871716960 100644
--- a/tests/suites/secretmanager/secrets/reference_test.go
+++ b/tests/suites/secretmanager/secrets/reference_test.go
@@ -6,7 +6,6 @@ import (
"testing"
"github.com/Infisical/infisical/tests/clients/api"
- "github.com/Infisical/infisical/tests/fakes/license"
"github.com/Infisical/infisical/tests/fixture"
"github.com/Infisical/infisical/tests/fixture/secretmanager"
"github.com/Infisical/infisical/tests/harness"
@@ -381,97 +380,6 @@ func TestSecretReference_Expand(t *testing.T) {
})
}
-func TestSecretReference_CrossProject(t *testing.T) {
- t.Parallel()
- h := harness.From(t)
-
- t.Run("should expand a reference into another project's granted folder", func(t *testing.T) {
- t.Parallel()
-
- // Setup
- tn := h.NewTenant(t)
- source, target := sharingProjects(t, tn)
- secretmanager.AllowCrossProjectSharing(t, tn, true)
- secretmanager.GrantFolder(t, source, target, secretmanager.Location{Env: "dev", Path: "/"})
-
- // Action
- secretmanager.CreateSecret(t, target, "dev", "REF", fmt.Sprintf("${@%s.dev.SHARED}", source.Slug))
-
- // Assert
- require.Equal(t, "from-source", secretmanager.GetSecret(t, target, "dev", "REF").Value)
- })
-
- t.Run("should keep the reference literal when the folder is not granted", func(t *testing.T) {
- t.Parallel()
-
- // Setup
- tn := h.NewTenant(t)
- source, target := sharingProjects(t, tn)
- secretmanager.AllowCrossProjectSharing(t, tn, true)
- ref := fmt.Sprintf("${@%s.dev.SHARED}", source.Slug)
-
- // Action
- secretmanager.CreateSecret(t, target, "dev", "REF", ref)
-
- // Assert
- require.Equal(t, ref, secretmanager.GetSecret(t, target, "dev", "REF").Value)
- })
-
- t.Run("should keep the reference literal once the organization turns sharing off", func(t *testing.T) {
- t.Parallel()
-
- // Setup
- tn := h.NewTenant(t)
- source, target := sharingProjects(t, tn)
- secretmanager.AllowCrossProjectSharing(t, tn, true)
- secretmanager.GrantFolder(t, source, target, secretmanager.Location{Env: "dev", Path: "/"})
- ref := fmt.Sprintf("${@%s.dev.SHARED}", source.Slug)
- secretmanager.CreateSecret(t, target, "dev", "REF", ref)
-
- // Action
- secretmanager.AllowCrossProjectSharing(t, tn, false)
-
- // Assert
- require.Equal(t, ref, secretmanager.GetSecret(t, target, "dev", "REF").Value)
- })
-
- t.Run("should not expand references inside the other project's value", func(t *testing.T) {
- t.Parallel()
-
- // Setup
- tn := h.NewTenant(t)
- source, target := sharingProjects(t, tn)
- secretmanager.CreateSecret(t, source, "dev", "INNER", "inner")
- secretmanager.CreateSecret(t, source, "dev", "OUTER", "${INNER}")
- secretmanager.AllowCrossProjectSharing(t, tn, true)
- secretmanager.GrantFolder(t, source, target, secretmanager.Location{Env: "dev", Path: "/"})
-
- // Action
- secretmanager.CreateSecret(t, target, "dev", "REF", fmt.Sprintf("${@%s.dev.OUTER}", source.Slug))
-
- // Assert
- require.Equal(t, "${INNER}", secretmanager.GetSecret(t, target, "dev", "REF").Value)
- })
-
- t.Run("should keep resolving after the plan loses cross-project sharing", func(t *testing.T) {
- t.Parallel()
-
- // Setup
- tn := h.NewTenant(t)
- source, target := sharingProjects(t, tn)
- secretmanager.AllowCrossProjectSharing(t, tn, true)
- secretmanager.GrantFolder(t, source, target, secretmanager.Location{Env: "dev", Path: "/"})
- secretmanager.CreateSecret(t, target, "dev", "REF", fmt.Sprintf("${@%s.dev.SHARED}", source.Slug))
-
- // Action
- tn.SetPlan(t, license.Enterprise().Without(license.CrossProjectSecretSharing))
-
- // Assert
- require.Equal(t, "from-source", secretmanager.GetSecret(t, target, "dev", "REF").Value,
- "a license check must never change what an existing reference reads")
- })
-}
-
func TestSecretReference_Rewrite(t *testing.T) {
t.Parallel()
h := harness.From(t)
@@ -646,11 +554,3 @@ func readerOfOneFolder(t *testing.T, proj *fixture.Project, folderPath string) *
secretmanager.FolderRead)
return reader
}
-
-func sharingProjects(t *testing.T, tn *harness.Tenant) (source, target *fixture.Project) {
- t.Helper()
- source = fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
- target = fixture.NewProject(t, tn, fixture.WithProjectType("secret-manager"))
- secretmanager.CreateSecret(t, source, "dev", "SHARED", "from-source")
- return source, target
-}
diff --git a/tests/suites/secretmanager/sharing/reference_test.go b/tests/suites/secretmanager/sharing/reference_test.go
new file mode 100644
index 0000000000..6294b0815c
--- /dev/null
+++ b/tests/suites/secretmanager/sharing/reference_test.go
@@ -0,0 +1,163 @@
+package sharing_test
+
+import (
+ "fmt"
+ "testing"
+
+ "github.com/Infisical/infisical/tests/fakes/license"
+ "github.com/Infisical/infisical/tests/fixture"
+ "github.com/Infisical/infisical/tests/fixture/secretmanager"
+ "github.com/Infisical/infisical/tests/harness"
+ "github.com/stretchr/testify/require"
+)
+
+func TestCrossProjectReference(t *testing.T) {
+ t.Parallel()
+ h := harness.From(t)
+
+ t.Run("should expand a reference into another project's granted folder", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ source, target := sharingProjects(t, h.NewTenant(t))
+ secretmanager.GrantFolder(t, source, target, sourceRoot)
+
+ // Action
+ secretmanager.CreateSecret(t, target, "dev", "REF", fmt.Sprintf("${@%s.dev.SHARED}", source.Slug))
+
+ // Assert
+ require.Equal(t, "from-source", secretmanager.GetSecret(t, target, "dev", "REF").Value)
+ })
+
+ t.Run("should expand a reference into a nested folder that is granted", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ source, target := sharingProjects(t, h.NewTenant(t))
+ secretmanager.CreateFolder(t, source, "dev", "/app/api")
+ secretmanager.CreateSecret(t, source, "dev", "API_KEY", "nested-value", secretmanager.WithPath("/app/api"))
+ secretmanager.GrantFolder(t, source, target, secretmanager.Location{Env: "dev", Path: "/app/api"})
+
+ // Action
+ secretmanager.CreateSecret(t, target, "dev", "REF", fmt.Sprintf("${@%s.dev.app.api.API_KEY}", source.Slug))
+
+ // Assert
+ require.Equal(t, "nested-value", secretmanager.GetSecret(t, target, "dev", "REF").Value)
+ })
+
+ t.Run("should keep the reference literal when the folder is not granted", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ source, target := sharingProjects(t, h.NewTenant(t))
+ ref := fmt.Sprintf("${@%s.dev.SHARED}", source.Slug)
+
+ // Action
+ secretmanager.CreateSecret(t, target, "dev", "REF", ref)
+
+ // Assert
+ require.Equal(t, ref, secretmanager.GetSecret(t, target, "dev", "REF").Value)
+ })
+
+ t.Run("should keep a reference into a subfolder of a granted folder literal", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ source, target := sharingProjects(t, h.NewTenant(t))
+ secretmanager.CreateFolder(t, source, "dev", "/app/api")
+ secretmanager.CreateSecret(t, source, "dev", "API_KEY", "nested-value", secretmanager.WithPath("/app/api"))
+ secretmanager.GrantFolder(t, source, target, secretmanager.Location{Env: "dev", Path: "/app"})
+ ref := fmt.Sprintf("${@%s.dev.app.api.API_KEY}", source.Slug)
+
+ // Action
+ secretmanager.CreateSecret(t, target, "dev", "REF", ref)
+
+ // Assert
+ require.Equal(t, ref, secretmanager.GetSecret(t, target, "dev", "REF").Value)
+ })
+
+ t.Run("should keep a reference into an environment the grant does not cover literal", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ source, target := sharingProjects(t, h.NewTenant(t))
+ secretmanager.CreateSecret(t, source, "staging", "SHARED", "from-staging")
+ secretmanager.GrantFolder(t, source, target, sourceRoot)
+ ref := fmt.Sprintf("${@%s.staging.SHARED}", source.Slug)
+
+ // Action
+ secretmanager.CreateSecret(t, target, "dev", "REF", ref)
+
+ // Assert
+ require.Equal(t, ref, secretmanager.GetSecret(t, target, "dev", "REF").Value)
+ })
+
+ t.Run("should keep a reference into another organization's project literal", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ _, target := sharingProjects(t, tn)
+ other := fixture.NewProject(t, h.NewTenant(t), fixture.WithProjectType("secret-manager"))
+ secretmanager.CreateSecret(t, other, "dev", "FOREIGN", "foreign-value")
+ ref := fmt.Sprintf("${@%s.dev.FOREIGN}", other.Slug)
+
+ // Action
+ secretmanager.CreateSecret(t, target, "dev", "REF", ref)
+
+ // Assert
+ got := secretmanager.GetSecret(t, target, "dev", "REF").Value
+ require.Equal(t, ref, got)
+ require.NotContains(t, got, "foreign-value")
+ })
+
+ t.Run("should keep the reference literal once the organization turns sharing off", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ source, target := sharingProjects(t, tn)
+ secretmanager.GrantFolder(t, source, target, sourceRoot)
+ ref := fmt.Sprintf("${@%s.dev.SHARED}", source.Slug)
+ secretmanager.CreateSecret(t, target, "dev", "REF", ref)
+
+ // Action
+ secretmanager.AllowCrossProjectSharing(t, tn, false)
+
+ // Assert
+ require.Equal(t, ref, secretmanager.GetSecret(t, target, "dev", "REF").Value)
+ })
+
+ t.Run("should not expand references inside the other project's value", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ source, target := sharingProjects(t, h.NewTenant(t))
+ secretmanager.CreateSecret(t, source, "dev", "INNER", "inner")
+ secretmanager.CreateSecret(t, source, "dev", "OUTER", "${INNER}")
+ secretmanager.GrantFolder(t, source, target, sourceRoot)
+
+ // Action
+ secretmanager.CreateSecret(t, target, "dev", "REF", fmt.Sprintf("${@%s.dev.OUTER}", source.Slug))
+
+ // Assert
+ require.Equal(t, "${INNER}", secretmanager.GetSecret(t, target, "dev", "REF").Value)
+ })
+
+ t.Run("should keep resolving after the plan loses cross-project sharing", func(t *testing.T) {
+ t.Parallel()
+
+ // Setup
+ tn := h.NewTenant(t)
+ source, target := sharingProjects(t, tn)
+ secretmanager.GrantFolder(t, source, target, sourceRoot)
+ secretmanager.CreateSecret(t, target, "dev", "REF", fmt.Sprintf("${@%s.dev.SHARED}", source.Slug))
+
+ // Action
+ tn.SetPlan(t, license.Enterprise().Without(license.CrossProjectSecretSharing))
+
+ // Assert
+ require.Equal(t, "from-source", secretmanager.GetSecret(t, target, "dev", "REF").Value,
+ "a license check must never change what an existing reference reads")
+ })
+}