Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

fix(dynamic-secret): quote SAP ASE connection string values

Vlad Ligaid08ec91dd325
diff --git a/backend/src/ee/services/dynamic-secret/providers/sap-ase.test.ts b/backend/src/ee/services/dynamic-secret/providers/sap-ase.test.ts
new file mode 100644
index 0000000000..8fa2871823
--- /dev/null
+++ b/backend/src/ee/services/dynamic-secret/providers/sap-ase.test.ts
@@ -0,0 +1,43 @@
+import odbc from "odbc";
+import { beforeEach, describe, expect, test, vi } from "vitest";
+
+import { SapAseProvider } from "./sap-ase";
+
+vi.mock("odbc", () => ({ default: { connect: vi.fn() } }));
+vi.mock("../dynamic-secret-fns", () => ({ verifyHostInputValidity: vi.fn() }));
+
+const mockedConnect = vi.mocked(odbc.connect);
+
+const metadata = { projectId: "proj-1" };
+
+const inputs = (password: string) => ({
+ host: "db.example.com",
+ port: 5000,
+ database: "app",
+ username: "sa",
+ password,
+ creationStatement: "sp_addlogin '{{username}}', '{{password}}'",
+ revocationStatement: "sp_droplogin '{{username}}'"
+});
+
+describe("SapAseProvider connection string", () => {
+ beforeEach(() => {
+ mockedConnect.mockReset();
+ mockedConnect.mockResolvedValue({
+ query: vi.fn().mockResolvedValue([{ version: "16.0" }]),
+ close: vi.fn()
+ } as unknown as Awaited<ReturnType<typeof odbc.connect>>);
+ });
+
+ test("wraps a value containing ';' in braces and leaves plain values as they are", async () => {
+ await SapAseProvider().validateConnection(inputs("pa;ss"), metadata);
+
+ const connectionString = mockedConnect.mock.calls[0][0] as unknown as string;
+ expect(connectionString).toContain("UID=sa;PWD={pa;ss};");
+ });
+
+ test("refuses a value containing both ';' and '}'", async () => {
+ await expect(SapAseProvider().validateConnection(inputs("pa;ss}"), metadata)).rejects.toThrow('cannot contain "}"');
+ expect(mockedConnect).not.toHaveBeenCalled();
+ });
+});
diff --git a/backend/src/ee/services/dynamic-secret/providers/sap-ase.ts b/backend/src/ee/services/dynamic-secret/providers/sap-ase.ts
index c5da910b74..e45d12146d 100644
--- a/backend/src/ee/services/dynamic-secret/providers/sap-ase.ts
+++ b/backend/src/ee/services/dynamic-secret/providers/sap-ase.ts
@@ -23,6 +23,15 @@ enum SapCommands {
DropLogin = "sp_droplogin"
}
+// values with ";" or a leading "{" go in braces; unixODBC and FreeTDS disagree on escaping "}" inside them
+const formatConnectionValue = (field: string, value: string) => {
+ if (!value.includes(";") && !value.startsWith("{")) return value;
+ if (!value.includes("}")) return `{${value}}`;
+ throw new BadRequestError({
+ message: `SAP ASE ${field} cannot contain "}" together with ";" or a leading "{"`
+ });
+};
+
export const SapAseProvider = (): TDynamicProviderFns => {
const validateProviderInputs = async (inputs: unknown) => {
const providerInputs = await DynamicSecretSapAseSchema.parseAsync(inputs);
@@ -42,11 +51,11 @@ export const SapAseProvider = (): TDynamicProviderFns => {
const $getClient = async (providerInputs: z.infer<typeof DynamicSecretSapAseSchema>, useMaster?: boolean) => {
const connectionString =
`DRIVER={FreeTDS};` +
- `SERVER=${providerInputs.host};` +
+ `SERVER=${formatConnectionValue("host", providerInputs.host)};` +
`PORT=${providerInputs.port};` +
- `DATABASE=${useMaster ? "master" : providerInputs.database};` +
- `UID=${providerInputs.username};` +
- `PWD=${providerInputs.password};` +
+ `DATABASE=${useMaster ? "master" : formatConnectionValue("database", providerInputs.database)};` +
+ `UID=${formatConnectionValue("username", providerInputs.username)};` +
+ `PWD=${formatConnectionValue("password", providerInputs.password)};` +
`TDS_VERSION=5.0`;
const client = await odbc.connect(connectionString);