Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
add missing check on request bridge
adilsond38efd3ef35e
diff --git a/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.test.ts b/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.test.tsindex 7e8880c85f..d8034ddf24 100644--- a/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.test.ts+++ b/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.test.ts@@ -64,7 +64,8 @@ const POLICY = {enforcementLevel: "hard",allowedSelfApprovals: true,bypassers: [] as { type: string; id: string }[],- userApprovers: [{ userId: "approver-1" }]+ userApprovers: [{ userId: "approver-1" }],+ environments: [{ id: "env-1", slug: "dev", name: "Development" }]};const REVIEW_CREATED_AT = new Date("2026-02-01");const APPROVAL_REQUEST = {@@ -946,6 +947,21 @@ describe("secretChangeGlobalRequestBridge mergeSecretChangeRequest", () => {);});+ test("refuses a request whose folder's environment the policy no longer covers", async () => {+ const { service, deps } = buildService({+ policy: { ...POLICY, environments: [{ id: "env-2", slug: "staging", name: "Staging" }] },+ requestSteps: [stepWith({ approvals: approvedBy("approver-1") })]+ });++ await expect(merge(service)).rejects.toThrow(+ new BadRequestError({+ message: "The policy associated with this secret approval request is not linked to the environment."+ })+ );+ expect(applySecretApprovalCommitsV2Bridge).not.toHaveBeenCalled();+ expect(deps.secretChangeGlobalRequestBridgeDAL.updateById).not.toHaveBeenCalled();+ });+test("forbids a user who is neither admin, requester nor an eligible approver", async () => {const { service } = buildService({ requestSteps: [stepWith({ approvals: approvedBy("approver-1") })] });await expect(merge(service, { actorId: "stranger-1" })).rejects.toBeInstanceOf(ForbiddenRequestError);diff --git a/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.ts b/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.tsindex b0baa2e428..0e4eff22bf 100644--- a/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.ts+++ b/backend/src/ee/services/secret-change-global-request-bridge/secret-change-global-request-bridge-service.ts@@ -656,6 +656,11 @@ export const secretChangeGlobalRequestBridgeServiceFactory = ({const project = await projectDAL.findById(projectId);if (!project) throw new NotFoundError({ message: `Project with ID '${projectId}' not found` });const folder = await findMergedFolder(projectId, secretChangeRequest.folderId);+ if (!policy.environments.some((env) => env.id === folder.envId)) {+ throw new BadRequestError({+ message: "The policy associated with this secret approval request is not linked to the environment."+ });+ }const commits = await secretApprovalRequestSecretDAL.findBySecretChangeIdBridgeSecretV2(secretChangeRequest.id);const { conflicts, creates, updates, deletes } = await detectSecretApprovalCommitConflicts({folderId: folder.id,