Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
test(identity-kubernetes-auth): add tests for credential redaction in Axios error handling
Victor Hugo dos Santosd4d6628fb5bf
diff --git a/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.test.ts b/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.test.tsindex 3750222eb6..318a04ac06 100644--- a/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.test.ts+++ b/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.test.ts@@ -49,6 +49,35 @@ describe("handleAxiosError", () => {expect(error.message).toBe("bearer token [REDACTED] is not valid");});+ it("removes a credential from the HTTP reason phrase fallback", () => {+ const opaqueToken = "abcdef.0123456789abcdef";+ const err = new AxiosError("Request failed", "ERR_BAD_RESPONSE", undefined, undefined, {+ status: 502,+ statusText: `Bad Gateway for ${opaqueToken}`,+ data: {},+ headers: {},+ config: { headers: new AxiosHeaders() }+ });+ const error = handleAxiosError(+ err,+ { host: "https://k8s.example.com", credentials: [opaqueToken] },+ KubernetesAuthErrorContext.KubernetesApiServer+ );+ expect(error.message).toBe("Kubernetes returned HTTP 502: Bad Gateway for [REDACTED]");+ });++ it("removes a credential from the generic path when there is no response", () => {+ const opaqueToken = "abcdef.0123456789abcdef";+ const error = handleAxiosError(+ new AxiosError(`socket closed while sending ${opaqueToken}`, "ERR_UNKNOWN"),+ { host: "https://k8s.example.com", credentials: [opaqueToken] },+ KubernetesAuthErrorContext.KubernetesApiServer+ );+ expect(error.name).toBe("KubernetesConnectionError");+ expect(error.message).not.toContain(opaqueToken);+ expect(error.message).toContain("[REDACTED]");+ });+it.each([[401, "Token reviewer JWT is invalid or expired"],[403, "Token reviewer JWT does not have permission"],diff --git a/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.ts b/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.tsindex 1be5cf88a9..263b30fd2a 100644--- a/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.ts+++ b/backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-error-handlers.ts@@ -113,8 +113,7 @@ export const handleAxiosNetworkError = (*/export const handleAxiosHttpError = (err: AxiosError,- contextType: KubernetesAuthErrorContext,- credentials: (string | undefined)[] = []+ contextType: KubernetesAuthErrorContext): UnauthorizedError | BadRequestError | null => {if (!err.response) {return null;@@ -129,10 +128,6 @@ export const handleAxiosHttpError = (message = err.response.data;}- if (message) {- message = redactCredentialsFromText(message, credentials);- }-if (statusCode === 401) {return new UnauthorizedError({message: message || default401Message,@@ -195,15 +190,11 @@ export const handleAxiosError = (context: ErrorContext,contextType: KubernetesAuthErrorContext): BadRequestError | UnauthorizedError => {- const networkError = handleAxiosNetworkError(err, context, contextType);- if (networkError) {- return networkError;- }-- const httpError = handleAxiosHttpError(err, contextType, context.credentials);- if (httpError) {- return httpError;- }+ const error =+ handleAxiosNetworkError(err, context, contextType) ??+ handleAxiosHttpError(err, contextType) ??+ handleAxiosGenericError(err, context, contextType);- return handleAxiosGenericError(err, context, contextType);+ error.message = redactCredentialsFromText(error.message, context.credentials);+ return error;};