Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

check revocation before gettint the privilege id

adilsone492bb2c5f6a
diff --git a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.ts b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.ts
index 22ecc5da66..0438a37315 100644
--- a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.ts
+++ b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.test.ts
@@ -199,6 +199,17 @@ describe("toLegacyAccessApprovalRequest", () => {
expect(legacy.revokedByUserId).toBe("admin");
});
+ test("an expired grant stays approved and keeps the privilege", () => {
+ const legacy = toLegacyAccessApprovalRequest({
+ ...request({ status: ApprovalRequestStatus.Approved }),
+ grant: grant({ status: ApprovalRequestGrantStatus.Expired }),
+ privilegeId: "privilege-1"
+ });
+
+ expect(legacy.status).toBe(ApprovalStatus.APPROVED);
+ expect(legacy.privilegeId).toBe("privilege-1");
+ });
+
test("a cancelled request reads as rejected", () => {
const legacy = toLegacyAccessApprovalRequest({
...request({ status: ApprovalRequestStatus.Cancelled }),
@@ -456,6 +467,19 @@ describe("toSecretAccessRequestListItem", () => {
expect(item?.privilege).toBeNull();
});
+ test("an expired grant still reports when its access ended", () => {
+ const temporaryAccessEndTime = new Date("2026-01-03T00:00:00.000Z");
+ const item = toItem({
+ requests: [request({ status: ApprovalRequestStatus.Approved })],
+ grants: [grant({ status: ApprovalRequestGrantStatus.Expired })],
+ privileges: [privilege({ isTemporary: true, temporaryAccessEndTime })]
+ });
+
+ expect(item?.isApproved).toBe(true);
+ expect(item?.privilegeId).toBe("privilege-1");
+ expect(item?.privilege?.temporaryAccessEndTime).toEqual(temporaryAccessEndTime);
+ });
+
test("a request is hidden when its policy and environment are both gone", () => {
expect(toItem({ requests: [request({ policyId: null })] }, new Map())).toBeNull();
});
diff --git a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.ts b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.ts
index 47151f0611..bb4ec22f86 100644
--- a/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.ts
+++ b/backend/src/services/secret-access-approval-global-request-bridge/secret-access-approval-global-request-bridge-fns.ts
@@ -95,7 +95,7 @@ export const toLegacyAccessApprovalRequestFields = (
temporaryRange: data.temporaryRange,
permissions: data.permissions,
note: request.justification ?? null,
- privilegeId: grant?.status === ApprovalRequestGrantStatus.Active ? request.privilegeId : null,
+ privilegeId: isRevoked ? null : request.privilegeId,
status,
expiresAt: request.expiresAt ?? null,
approvedAt: grant?.createdAt ?? null,