Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.
TypeScript acmeagentsai-agentscertificate-managementdevsecopsenvironment-variableskubernetesopen-sourcepampkipostgresprivate-caprivileged-access-managementsecret-managementsecret-managersecretssecrets-managementsecuritysecurity-toolsvault
PR suggestions
Matheus Nogueirae8a7a025f37a
diff --git a/backend/src/db/migrations/20260929120000_reshape-secret-scanning-v2-tables.ts b/backend/src/db/migrations/20260929120000_reshape-secret-scanning-v2-tables.tsindex 4ecb51157e..570eaf2cc1 100644--- a/backend/src/db/migrations/20260929120000_reshape-secret-scanning-v2-tables.ts+++ b/backend/src/db/migrations/20260929120000_reshape-secret-scanning-v2-tables.ts@@ -4,20 +4,13 @@ import { TableName } from "../schemas";const SCAN_STARTED_AT_LEGACY_INDEX = "secret_scanning_scans_scanning_started_at_index";const SCAN_STARTED_AT_INDEX = "secret_scanning_scans_started_at_index";-const SCAN_TRIGGERED_BY_INDEX = "secret_scanning_scans_triggered_by_user_id_index";-const DATA_SOURCE_CONNECTION_ID_INDEX = "secret_scanning_data_sources_connectionid_index";-const FINDING_TRIAGED_BY_INDEX = "secret_scanning_findings_triaged_by_user_id_index";++// Indexes on these tables are built concurrently in the next migration, outside this transaction.export async function up(knex: Knex): Promise<void> {// Scan workers write to these tables continuously; fail the deploy fast rather than queue behind them.await knex.raw("SET LOCAL lock_timeout = '10s'");- await knex.raw(`CREATE INDEX IF NOT EXISTS ?? ON ?? (??)`, [- DATA_SOURCE_CONNECTION_ID_INDEX,- TableName.SecretScanningDataSource,- "connectionId"- ]);-if (await knex.schema.hasColumn(TableName.SecretScanningResource, "type")) {await knex.schema.alterTable(TableName.SecretScanningResource, (t) => {t.dropColumn("type");@@ -29,30 +22,18 @@ export async function up(knex: Knex): Promise<void> {t.renameColumn("scanningStartedAt", "startedAt");});await knex.schema.alterTable(TableName.SecretScanningScan, (t) => {- t.string("trigger").nullable();t.uuid("triggeredByUserId").nullable();t.foreign("triggeredByUserId").references("id").inTable(TableName.Users).onDelete("SET NULL");t.timestamp("completedAt").nullable();- t.index("resourceId");});await knex.raw(`ALTER INDEX IF EXISTS ?? RENAME TO ??`, [SCAN_STARTED_AT_LEGACY_INDEX, SCAN_STARTED_AT_INDEX]);- await knex.raw(`CREATE INDEX ?? ON ?? ("triggeredByUserId") WHERE "triggeredByUserId" IS NOT NULL`, [- SCAN_TRIGGERED_BY_INDEX,- TableName.SecretScanningScan- ]);- // Every existing full scan was started by someone creating a source or pressing scan, so they count as- // manual; diff scans only ever came from a push webhook. SET expressions all read the pre-update row.- await knex.raw(- `UPDATE ?? SET- type = CASE type WHEN 'full-scan' THEN 'historical' WHEN 'diff-scan' THEN 'realtime' ELSE type END,- "trigger" = CASE type WHEN 'diff-scan' THEN 'push' ELSE 'manual' END,- "createdAt" = COALESCE("createdAt", "startedAt", "progressUpdatedAt", NOW())`,- [TableName.SecretScanningScan]- );+ await knex(TableName.SecretScanningScan).whereNull("createdAt").delete();++ await knex(TableName.SecretScanningScan).where({ type: "full-scan" }).update({ type: "historical" });+ await knex(TableName.SecretScanningScan).where({ type: "diff-scan" }).update({ type: "realtime" });await knex.schema.alterTable(TableName.SecretScanningScan, (t) => {- t.string("trigger").notNullable().alter();t.timestamp("createdAt").notNullable().defaultTo(knex.fn.now()).alter();});}@@ -67,8 +48,8 @@ export async function up(knex: Knex): Promise<void> {TableName.SecretScanningScan]);- // Every finding is inserted with its scan, and a scan only disappears when its resource is deleted- // (SET NULL on scanId), so a finding with no resource here belongs to a resource that no longer exists.+ // Every finding is inserted with its scan, so a finding with no resource here lost its scan (SET NULL on scanId),+ // either because the scan's resource was deleted or because the scan was dropped above for having no createdAt.await knex(TableName.SecretScanningFinding).whereNull("resourceId").delete();await knex.schema.alterTable(TableName.SecretScanningFinding, (t) => {@@ -83,11 +64,8 @@ export async function up(knex: Knex): Promise<void> {await knex.schema.alterTable(TableName.SecretScanningFinding, (t) => {t.foreign("resourceId").references("id").inTable(TableName.SecretScanningResource).onDelete("CASCADE");- t.unique(["resourceId", "fingerprint"]);t.foreign("scanId").references("id").inTable(TableName.SecretScanningScan).onDelete("CASCADE");- t.index("scanId");- t.renameColumn("rule", "ruleKey");t.renameColumn("remarks", "triageComment");});@@ -105,11 +83,6 @@ export async function up(knex: Knex): Promise<void> {t.dropColumn("resourceType");t.dropColumn("projectId");});-- await knex.raw(`CREATE INDEX ?? ON ?? ("triagedByUserId") WHERE "triagedByUserId" IS NOT NULL`, [- FINDING_TRIAGED_BY_INDEX,- TableName.SecretScanningFinding- ]);}}@@ -151,12 +124,8 @@ export async function down(knex: Knex): Promise<void> {TableName.SecretScanningFinding]);- await knex.raw(`DROP INDEX IF EXISTS ??`, [FINDING_TRIAGED_BY_INDEX]);-await knex.schema.alterTable(TableName.SecretScanningFinding, (t) => {- t.dropUnique(["resourceId", "fingerprint"]);t.dropForeign(["scanId"]);- t.dropIndex(["scanId"]);t.dropForeign(["resourceId"]);t.dropForeign(["triagedByUserId"]);});@@ -168,7 +137,6 @@ export async function down(knex: Knex): Promise<void> {t.dropColumn("triagedAt");t.dropColumn("resolvedAt");- t.renameColumn("ruleKey", "rule");t.renameColumn("triageComment", "remarks");});@@ -190,20 +158,15 @@ export async function down(knex: Knex): Promise<void> {}if (await knex.schema.hasColumn(TableName.SecretScanningScan, "startedAt")) {- await knex.raw(- `UPDATE ?? SET type = CASE type WHEN 'historical' THEN 'full-scan' WHEN 'realtime' THEN 'diff-scan' ELSE type END`,- [TableName.SecretScanningScan]- );+ await knex(TableName.SecretScanningScan).where({ type: "historical" }).update({ type: "full-scan" });+ await knex(TableName.SecretScanningScan).where({ type: "realtime" }).update({ type: "diff-scan" });- await knex.raw(`DROP INDEX IF EXISTS ??`, [SCAN_TRIGGERED_BY_INDEX]);await knex.raw(`ALTER INDEX IF EXISTS ?? RENAME TO ??`, [SCAN_STARTED_AT_INDEX, SCAN_STARTED_AT_LEGACY_INDEX]);await knex.schema.alterTable(TableName.SecretScanningScan, (t) => {t.dropForeign(["triggeredByUserId"]);- t.dropIndex(["resourceId"]);});await knex.schema.alterTable(TableName.SecretScanningScan, (t) => {- t.dropColumn("trigger");t.dropColumn("triggeredByUserId");t.dropColumn("completedAt");t.renameColumn("startedAt", "scanningStartedAt");@@ -226,6 +189,4 @@ export async function down(knex: Knex): Promise<void> {t.string("type").notNullable().alter();});}-- await knex.raw(`DROP INDEX IF EXISTS ??`, [DATA_SOURCE_CONNECTION_ID_INDEX]);}diff --git a/backend/src/db/migrations/20260929120100_add-secret-scanning-v2-indexes.ts b/backend/src/db/migrations/20260929120100_add-secret-scanning-v2-indexes.tsnew file mode 100644index 0000000000..7d5c79c170--- /dev/null+++ b/backend/src/db/migrations/20260929120100_add-secret-scanning-v2-indexes.ts@@ -0,0 +1,67 @@+import { Knex } from "knex";++import { TableName } from "../schemas";++const INDEXES = [+ {+ name: "secret_scanning_data_sources_connectionid_index",+ sql: `CREATE INDEX CONCURRENTLY IF NOT EXISTS secret_scanning_data_sources_connectionid_index+ ON ${TableName.SecretScanningDataSource} ("connectionId")`+ },+ {+ name: "secret_scanning_scans_resourceid_index",+ sql: `CREATE INDEX CONCURRENTLY IF NOT EXISTS secret_scanning_scans_resourceid_index+ ON ${TableName.SecretScanningScan} ("resourceId")`+ },+ {+ name: "secret_scanning_scans_triggered_by_user_id_index",+ sql: `CREATE INDEX CONCURRENTLY IF NOT EXISTS secret_scanning_scans_triggered_by_user_id_index+ ON ${TableName.SecretScanningScan} ("triggeredByUserId") WHERE "triggeredByUserId" IS NOT NULL`+ },+ {+ name: "secret_scanning_findings_resourceid_fingerprint_unique",+ sql: `CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS secret_scanning_findings_resourceid_fingerprint_unique+ ON ${TableName.SecretScanningFinding} ("resourceId", fingerprint)`+ },+ {+ name: "secret_scanning_findings_scanid_index",+ sql: `CREATE INDEX CONCURRENTLY IF NOT EXISTS secret_scanning_findings_scanid_index+ ON ${TableName.SecretScanningFinding} ("scanId")`+ },+ {+ name: "secret_scanning_findings_triaged_by_user_id_index",+ sql: `CREATE INDEX CONCURRENTLY IF NOT EXISTS secret_scanning_findings_triaged_by_user_id_index+ ON ${TableName.SecretScanningFinding} ("triagedByUserId") WHERE "triagedByUserId" IS NOT NULL`+ }+];++// A failed CREATE INDEX CONCURRENTLY leaves an INVALID index behind, which IF NOT EXISTS would then skip.+const dropIfInvalid = async (knex: Knex, name: string) => {+ const invalid = await knex.raw(+ `SELECT 1 FROM pg_class c JOIN pg_index i ON i.indexrelid = c.oid WHERE c.relname = ? AND NOT i.indisvalid`,+ [name]+ );+ if (invalid.rows.length > 0) {+ await knex.raw(`DROP INDEX CONCURRENTLY IF EXISTS ??`, [name]);+ }+};++export async function up(knex: Knex): Promise<void> {+ for (const { name, sql } of INDEXES) {+ // eslint-disable-next-line no-await-in-loop+ await dropIfInvalid(knex, name);+ // eslint-disable-next-line no-await-in-loop+ await knex.raw(sql);+ }+}++export async function down(knex: Knex): Promise<void> {+ for (const { name } of INDEXES) {+ // eslint-disable-next-line no-await-in-loop+ await knex.raw(`DROP INDEX CONCURRENTLY IF EXISTS ??`, [name]);+ }+}++// CONCURRENTLY requires running outside a transaction+const config = { transaction: false };+export { config };diff --git a/backend/src/db/schemas/secret-scanning-findings.ts b/backend/src/db/schemas/secret-scanning-findings.tsindex 883784dc51..65b2438a59 100644--- a/backend/src/db/schemas/secret-scanning-findings.ts+++ b/backend/src/db/schemas/secret-scanning-findings.ts@@ -9,7 +9,7 @@ import { TImmutableDBKeys } from "./models";export const SecretScanningFindingsSchema = z.object({id: z.string().uuid(),- ruleKey: z.string(),+ rule: z.string(),severity: z.string(),status: z.string().default("unresolved"),triageComment: z.string().nullable().optional(),diff --git a/backend/src/db/schemas/secret-scanning-scans.ts b/backend/src/db/schemas/secret-scanning-scans.tsindex 71f3770730..ee280e8b2d 100644--- a/backend/src/db/schemas/secret-scanning-scans.ts+++ b/backend/src/db/schemas/secret-scanning-scans.ts@@ -18,7 +18,6 @@ export const SecretScanningScansSchema = z.object({lastScannedCommit: z.string().nullable().optional(),progressUpdatedAt: z.date().nullable().optional(),lastScannedCommitDigest: z.string().nullable().optional(),- trigger: z.string(),triggeredByUserId: z.string().uuid().nullable().optional(),completedAt: z.date().nullable().optional()});diff --git a/backend/src/ee/services/secret-scanning-v2/bitbucket/bitbucket-secret-scanning-factory.ts b/backend/src/ee/services/secret-scanning-v2/bitbucket/bitbucket-secret-scanning-factory.tsindex 65f592caa0..a6356612fd 100644--- a/backend/src/ee/services/secret-scanning-v2/bitbucket/bitbucket-secret-scanning-factory.ts+++ b/backend/src/ee/services/secret-scanning-v2/bitbucket/bitbucket-secret-scanning-factory.ts@@ -321,7 +321,7 @@ export const BitbucketSecretScanningFactory = () => {details: toFindingDetails(finding),fingerprint: finding.Fingerprint,severity: SecretScanningFindingSeverity.High,- ruleKey: finding.RuleID+ rule: finding.RuleID}));};diff --git a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-factory.ts b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-factory.tsindex eaf1d48179..d10a839fef 100644--- a/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-factory.ts+++ b/backend/src/ee/services/secret-scanning-v2/github/github-secret-scanning-factory.ts@@ -238,7 +238,7 @@ export const GitHubSecretScanningFactory = () => {details: toFindingDetails(finding),fingerprint: finding.Fingerprint,severity: SecretScanningFindingSeverity.High,- ruleKey: finding.RuleID+ rule: finding.RuleID}));};diff --git a/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts b/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.tsindex b0257a8935..887831c802 100644--- a/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts+++ b/backend/src/ee/services/secret-scanning-v2/gitlab/gitlab-secret-scanning-factory.ts@@ -372,7 +372,7 @@ export const GitLabSecretScanningFactory = ({ appConnectionDAL, kmsService }: TSdetails: toFindingDetails(finding),fingerprint: finding.Fingerprint,severity: SecretScanningFindingSeverity.High,- ruleKey: finding.RuleID+ rule: finding.RuleID}));};diff --git a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-enums.ts b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-enums.tsindex 051b390c71..670cd5bfd3 100644--- a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-enums.ts+++ b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-enums.ts@@ -16,11 +16,6 @@ export enum SecretScanningScanType {Realtime = "realtime"}-export enum SecretScanningScanTrigger {- Manual = "manual",- Push = "push"-}-export enum SecretScanningFindingStatus {Resolved = "resolved",Unresolved = "unresolved",diff --git a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-fns.ts b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-fns.tsindex fdf14646d9..62da25c6e4 100644--- a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-fns.ts+++ b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-fns.ts@@ -382,7 +382,7 @@ export const scanGitRepositoryAndGetFindings = async (details: toFindingDetails(finding),fingerprint: `${finding.Fingerprint}:${finding.StartColumn}`,severity: SecretScanningFindingSeverity.High,- ruleKey: finding.RuleID+ rule: finding.RuleID}));};diff --git a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.ts b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.tsindex 05c9877f63..c31f876b42 100644--- a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.ts+++ b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-queue.ts@@ -36,7 +36,6 @@ import { TSecretScanningV2DALFactory } from "./secret-scanning-v2-dal";import {SecretScanningDataSource,SecretScanningScanStatus,- SecretScanningScanTrigger,SecretScanningScanType} from "./secret-scanning-v2-enums";import { SECRET_SCANNING_FACTORY_MAP } from "./secret-scanning-v2-factory";@@ -226,7 +225,6 @@ export const secretScanningV2QueueServiceFactory = ({resourcesToScan.map((resource) => ({resourceId: resource.id,type: SecretScanningScanType.Historical,- trigger: SecretScanningScanTrigger.Manual,triggeredByUserId: triggeredByUserId ?? null})),tx@@ -372,7 +370,7 @@ export const secretScanningV2QueueServiceFactory = ({["resourceId", "fingerprint"],tx,// a no-op merge, so rows already found by an earlier scan are returned with their original scanId- ["ruleKey"]+ ["rule"]);}@@ -611,8 +609,7 @@ export const secretScanningV2QueueServiceFactory = ({const scan = await secretScanningV2DAL.scans.create({resourceId: resource.id,- type: SecretScanningScanType.Realtime,- trigger: SecretScanningScanTrigger.Push+ type: SecretScanningScanType.Realtime},tx);@@ -726,7 +723,7 @@ export const secretScanningV2QueueServiceFactory = ({})),["resourceId", "fingerprint"],tx,- ["ruleKey"]+ ["rule"]);}diff --git a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.ts b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.tsindex 56396eb0c3..58faa298af 100644--- a/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.ts+++ b/backend/src/ee/services/secret-scanning-v2/secret-scanning-v2-types.ts@@ -241,7 +241,7 @@ export type TSecretScanningFactory<export type TFindingsPayload = Pick<TSecretScanningFindingsInsert,- "details" | "fingerprint" | "severity" | "ruleKey"+ "details" | "fingerprint" | "severity" | "rule">[];export type TGetFindingsPayload = Promise<TFindingsPayload>;diff --git a/docs/documentation/platform/secret-scanning/bitbucket.mdx b/docs/documentation/platform/secret-scanning/bitbucket.mdxindex 4b062e8cf2..19bd16edb2 100644--- a/docs/documentation/platform/secret-scanning/bitbucket.mdx+++ b/docs/documentation/platform/secret-scanning/bitbucket.mdx@@ -43,7 +43,7 @@ description: "Learn how to configure secret scanning for Bitbucket."</Step><Step>- Your **Bitbucket Data Source** is now available and will begin a full scan if **Auto-Scan** is enabled.+ Your **Bitbucket Data Source** is now available and will begin a historical scan if **Auto-Scan** is enabled.</Step><Step>diff --git a/docs/documentation/platform/secret-scanning/concepts/secret-scanning.mdx b/docs/documentation/platform/secret-scanning/concepts/secret-scanning.mdxindex ab03cac7c5..7b80d9f010 100644--- a/docs/documentation/platform/secret-scanning/concepts/secret-scanning.mdx+++ b/docs/documentation/platform/secret-scanning/concepts/secret-scanning.mdx@@ -17,4 +17,4 @@ Infisical Secret Scanning continuously monitors your source code and connected sFindings are surfaced with detailed context — including file location, commit metadata, and rule match — and can be tracked through their lifecycle using status labels like `Resolved`, `False Positive`, or `Ignored`. Teams can configure rules, exclusions, and thresholds to reduce noise and tailor detection to their environment.-In addition to real-time monitoring, Infisical supports both full repository scans and lightweight diff scans, as well as local pre-commit scanning via the [Infisical CLI](/cli/reference#scan). This allows teams to prevent secret leaks before they ever reach production.+Infisical runs historical scans over a repository's full commit history and realtime scans over each new push, and supports local pre-commit scanning via the [Infisical CLI](/cli/reference#scan). This allows teams to prevent secret leaks before they ever reach production.diff --git a/docs/documentation/platform/secret-scanning/github.mdx b/docs/documentation/platform/secret-scanning/github.mdxindex 95e683317c..795f9703b5 100644--- a/docs/documentation/platform/secret-scanning/github.mdx+++ b/docs/documentation/platform/secret-scanning/github.mdx@@ -41,7 +41,7 @@ description: "Learn how to configure secret scanning for GitHub."</Step><Step>- Your **GitHub Data Source** is now available and will begin a full scan if **Auto-Scan** is enabled.+ Your **GitHub Data Source** is now available and will begin a historical scan if **Auto-Scan** is enabled.</Step><Step>diff --git a/docs/documentation/platform/secret-scanning/gitlab.mdx b/docs/documentation/platform/secret-scanning/gitlab.mdxindex 313abcce37..6c67c07aa3 100644--- a/docs/documentation/platform/secret-scanning/gitlab.mdx+++ b/docs/documentation/platform/secret-scanning/gitlab.mdx@@ -44,7 +44,7 @@ description: "Learn how to configure secret scanning for GitLab."</Step><Step>- Your **GitLab Data Source** is now available and will begin a full scan if **Auto-Scan** is enabled.+ Your **GitLab Data Source** is now available and will begin a historical scan if **Auto-Scan** is enabled.</Step><Step>diff --git a/docs/documentation/platform/secret-scanning/overview.mdx b/docs/documentation/platform/secret-scanning/overview.mdxindex ed1ea7ce14..6b82b86191 100644--- a/docs/documentation/platform/secret-scanning/overview.mdx+++ b/docs/documentation/platform/secret-scanning/overview.mdx@@ -13,6 +13,6 @@ Core capabilities include:- Integrated Scanning Across Environments: Monitor secrets in real time across connected repositories like GitHub, GitLab, and Bitbucket, or scan locally using the infisical scan CLI.- Detection Engine: Identify potential secrets using pattern matching, entropy analysis, and custom rules tailored to your codebase and workflows.-- Flexible Scan Modes: Run full scans manually or configure automatic diff scans triggered by new commits. CLI scans support Git history, file directories, or staged changes in CI pipelines.+- Flexible Scan Modes: Run historical scans manually or configure automatic realtime scans triggered by new commits. CLI scans support Git history, file directories, or staged changes in CI pipelines.- Findings and Lifecycle Management: Track detected secrets with context like file path, commit hash, and scanning rule. Findings can be resolved, ignored, or marked as false positives — with full visibility into scan results over time.- Custom Configuration and Noise Reduction: Fine-tune scanning behavior with custom patterns, ignore rules (betterleaks:allow, .infisicalignore), entropy thresholds, and excluded paths to reduce false positives.diff --git a/docs/documentation/platform/secret-scanning/usage.mdx b/docs/documentation/platform/secret-scanning/usage.mdxindex d6f9f86316..49bf9fe8da 100644--- a/docs/documentation/platform/secret-scanning/usage.mdx+++ b/docs/documentation/platform/secret-scanning/usage.mdx@@ -49,9 +49,9 @@ Each resource maintains its own scanning history and status, allowing for granulScans can be initiated in two ways:-1. **Full Scan** - Manually triggered scan that comprehensively checks either all resources associated with a data source or a single selected resource.+1. **Historical Scan** - Manually triggered scan that comprehensively checks either all resources associated with a data source or a single selected resource.-2. **Diff Scan** - Automatically executed when **Auto-Scan** is enabled on a data source. This scan type specifically focuses on updates to existing resources.+2. **Realtime Scan** - Automatically executed when **Auto-Scan** is enabled on a data source. This scan type specifically focuses on updates to existing resources.All scan activities can be monitored in real-time through the Infisical UI, which displays:diff --git a/frontend/src/hooks/api/secretScanningV2/enums.ts b/frontend/src/hooks/api/secretScanningV2/enums.tsindex 051b390c71..670cd5bfd3 100644--- a/frontend/src/hooks/api/secretScanningV2/enums.ts+++ b/frontend/src/hooks/api/secretScanningV2/enums.ts@@ -16,11 +16,6 @@ export enum SecretScanningScanType {Realtime = "realtime"}-export enum SecretScanningScanTrigger {- Manual = "manual",- Push = "push"-}-export enum SecretScanningFindingStatus {Resolved = "resolved",Unresolved = "unresolved",diff --git a/frontend/src/hooks/api/secretScanningV2/types/index.ts b/frontend/src/hooks/api/secretScanningV2/types/index.tsindex d07e46e0a5..be6ac04aee 100644--- a/frontend/src/hooks/api/secretScanningV2/types/index.ts+++ b/frontend/src/hooks/api/secretScanningV2/types/index.ts@@ -10,7 +10,6 @@ import {SecretScanningFindingSeverity,SecretScanningFindingStatus,SecretScanningScanStatus,- SecretScanningScanTrigger,SecretScanningScanType} from "../enums";import { TBitbucketDataSource, TBitbucketDataSourceOption } from "./bitbucket-data-source";@@ -111,7 +110,6 @@ export type TSecretScanningScanWithDetails = {createdAt: string;resourceId: string;type: SecretScanningScanType;- trigger: SecretScanningScanTrigger;triggeredByUserId?: string | null;startedAt?: string | null;completedAt?: string | null;@@ -146,7 +144,7 @@ export type TSecretScanningFinding = {dataSourceId: string;dataSourceName: string;dataSourceType: SecretScanningDataSource;- ruleKey: string;+ rule: string;severity: SecretScanningFindingSeverity;confidence?: SecretScanningFindingConfidence | null;status: SecretScanningFindingStatus;diff --git a/frontend/src/pages/secret-scanning/SecretScanningDataSourceByIdPage/components/SecretScanningScanRow.tsx b/frontend/src/pages/secret-scanning/SecretScanningDataSourceByIdPage/components/SecretScanningScanRow.tsxindex 0b472dc990..13957356f1 100644--- a/frontend/src/pages/secret-scanning/SecretScanningDataSourceByIdPage/components/SecretScanningScanRow.tsx+++ b/frontend/src/pages/secret-scanning/SecretScanningDataSourceByIdPage/components/SecretScanningScanRow.tsx@@ -84,7 +84,7 @@ export const SecretScanningScanRow = ({ scan }: Props) => {</div></Td><Td className="whitespace-nowrap">- {type === SecretScanningScanType.Historical ? "Full Scan" : "Diff Scan"}+ {type === SecretScanningScanType.Historical ? "Historical Scan" : "Realtime Scan"}</Td><Td>{diff --git a/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingRow.tsx b/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingRow.tsxindex 29e3c463c7..2f33fa2419 100644--- a/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingRow.tsx+++ b/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingRow.tsx@@ -50,7 +50,7 @@ export const SecretScanningFindingRow = ({dataSourceType,createdAt,dataSourceName,- ruleKey,+ rule,status,details,triageComment@@ -123,7 +123,7 @@ export const SecretScanningFindingRow = ({<p className="truncate text-xs text-muted">{dataSourceName}</p></div></Td>- <Td className="whitespace-nowrap">{ruleKey}</Td>+ <Td className="whitespace-nowrap">{rule}</Td><Td className="whitespace-nowrap"><Tooltip position="left" content={triageComment}><Badge variant={SECRET_SCANNING_FINDING_STATUS_MAP[status].variant}>diff --git a/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingsTable.tsx b/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingsTable.tsxindex 87c83ff9ad..bbc2440dcf 100644--- a/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingsTable.tsx+++ b/frontend/src/pages/secret-scanning/SecretScanningFindingsPage/components/SecretScanningFindingsTable.tsx@@ -114,7 +114,7 @@ export const SecretScanningFindingsTable = ({ findings }: Props) => {() =>findings.filter((finding) => {- const { ruleKey, resourceName, dataSourceType, dataSourceName, status, scanId } = finding;+ const { rule, resourceName, dataSourceType, dataSourceName, status, scanId } = finding;if (filters.dataSourceTypes.length && !filters.dataSourceTypes.includes(dataSourceType))return false;@@ -135,7 +135,7 @@ export const SecretScanningFindingsTable = ({ findings }: Props) => {.includes(searchValue) ||resourceName.toLowerCase().includes(searchValue) ||dataSourceName.toLowerCase().includes(searchValue) ||- ruleKey.toLowerCase().includes(searchValue)+ rule.toLowerCase().includes(searchValue));}).sort((a, b) => {@@ -148,9 +148,7 @@ export const SecretScanningFindingsTable = ({ findings }: Props) => {new Date(findingTwo.createdAt).getTime() - new Date(findingOne.createdAt).getTime());case FindingsOrderBy.Rule:- return findingOne.ruleKey- .toLowerCase()- .localeCompare(findingTwo.ruleKey.toLowerCase());+ return findingOne.rule.toLowerCase().localeCompare(findingTwo.rule.toLowerCase());case FindingsOrderBy.Status:return (getStatusOrderValue(findingOne.status) - getStatusOrderValue(findingTwo.status)