Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

mock logger so test does not fail

adilsoneed9f1447319
diff --git a/backend/src/services/delegated-approval/dispatch/providers/servicenow/servicenow-fns.test.ts b/backend/src/services/delegated-approval/dispatch/providers/servicenow/servicenow-fns.test.ts
index 94e5c22529..6205e1f251 100644
--- a/backend/src/services/delegated-approval/dispatch/providers/servicenow/servicenow-fns.test.ts
+++ b/backend/src/services/delegated-approval/dispatch/providers/servicenow/servicenow-fns.test.ts
@@ -1,9 +1,10 @@
import { AxiosError, AxiosHeaders } from "axios";
import { UnrecoverableError } from "bullmq";
-import { describe, expect, test } from "vitest";
+import { describe, expect, test, vi } from "vitest";
import { ProjectType } from "@app/db/schemas";
import { BadRequestError } from "@app/lib/errors";
+import { logger } from "@app/lib/logger";
import { ApprovalPolicyType } from "@app/services/approval-policy/approval-policy-enums";
import { TDelegatedApprovalDispatchInput } from "../../delegated-approval-dispatch-types";
@@ -14,6 +15,11 @@ import {
toServiceNowDispatchError
} from "./servicenow-fns";
+vi.mock("@app/lib/logger", async (importOriginal) => ({
+ ...(await importOriginal<typeof import("@app/lib/logger")>()),
+ logger: { info: vi.fn(), error: vi.fn(), warn: vi.fn(), debug: vi.fn() }
+}));
+
const INSTANCE_URL = "https://acme.service-now.com";
const CALLBACK_TOKEN = "callback-token-plaintext";
@@ -162,7 +168,7 @@ describe("toServiceNowDispatchError", () => {
[404, UnrecoverableError, /Infisical Approvals application/],
[400, UnrecoverableError, /rejected the request \(HTTP 400\)/],
[422, UnrecoverableError, /rejected the request \(HTTP 422\)/],
- [429, BadRequestError, /rate limiting/],
+ [429, BadRequestError, /could not accept the request/],
[500, BadRequestError, /server error \(HTTP 500\)/],
[503, BadRequestError, /server error \(HTTP 503\)/]
])("maps HTTP %s", (status, errorClass, message) => {
@@ -182,6 +188,16 @@ describe("toServiceNowDispatchError", () => {
expect(error.message).toContain("Missing required field: environment");
});
+ test("logs the rate limit instead of returning it to the user", () => {
+ const error = toServiceNowDispatchError(makeAxiosError(429), INSTANCE_URL);
+
+ expect(error.message).not.toMatch(/rate limit/);
+ expect(logger.warn).toHaveBeenCalledWith(
+ { status: 429, instance: "acme.service-now.com" },
+ expect.stringMatching(/rate limiting requests from Infisical \(HTTP 429\)/)
+ );
+ });
+
test("retries when there was no response at all", () => {
const error = toServiceNowDispatchError(makeAxiosError(undefined, undefined, "ECONNABORTED"), INSTANCE_URL);