Skip to content

Infisical is the open-source platform for securing secrets, certificates, access, and AI Agents.

improvement(ui): use real row links for Agent Vault and PAM tables (#8940)

Andrew Huangf863ffffc188
diff --git a/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx b/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx
index f780451007..744ae399dc 100644
--- a/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx
+++ b/frontend/src/pages/agent-vault/AgentVaultAccessBundlesPage/AgentVaultAccessBundlesPage.tsx
@@ -45,6 +45,7 @@ import {
InputGroupInput,
PageHeader,
Pagination,
+ RowLink,
Skeleton,
Table,
TableBody,
@@ -285,29 +286,26 @@ export const AgentVaultAccessBundlesPage = () => {
))}
{!isPending &&
displayedBundles.map((bundle) => (
- <TableRow
- key={bundle.id}
- onClick={() =>
- navigate({
- to: "/organizations/$orgId/agent-vault/access-bundles/$accessBundleId",
- params: { orgId: currentOrg.id, accessBundleId: bundle.id }
- })
- }
- >
+ <TableRow key={bundle.id} linked>
<TableCell isTruncatable className="min-w-64">
- <div className="flex items-center gap-2.5">
- <span className="truncate" title={bundle.name}>
+ <RowLink
+ to="/organizations/$orgId/agent-vault/access-bundles/$accessBundleId"
+ params={{ orgId: currentOrg.id, accessBundleId: bundle.id }}
+ className="flex items-center gap-2.5"
+ >
+ <span className="truncate" title={bundle.name} data-row-interactive>
{bundle.name}
</span>
{bundle.description && (
<span
className="min-w-0 flex-1 truncate text-sm text-muted"
title={bundle.description}
+ data-row-interactive
>
{bundle.description}
</span>
)}
- </div>
+ </RowLink>
</TableCell>
<TableCell>
<ServiceIconStack hostPatterns={bundle.hostPatterns} />
@@ -347,7 +345,7 @@ export const AgentVaultAccessBundlesPage = () => {
{bundle.servicesRequiringSetup.length > 0 && (
<Tooltip>
<TooltipTrigger asChild>
- <Badge variant="warning">
+ <Badge variant="warning" data-row-interactive>
<TriangleAlertIcon />
Requires Setup
</Badge>
diff --git a/frontend/src/pages/agent-vault/AgentVaultAccessControlPage/components/IdentitiesTab.tsx b/frontend/src/pages/agent-vault/AgentVaultAccessControlPage/components/IdentitiesTab.tsx
index 676e81ee67..1a4714eada 100644
--- a/frontend/src/pages/agent-vault/AgentVaultAccessControlPage/components/IdentitiesTab.tsx
+++ b/frontend/src/pages/agent-vault/AgentVaultAccessControlPage/components/IdentitiesTab.tsx
@@ -1,6 +1,5 @@
import { useState } from "react";
import { useQueryClient } from "@tanstack/react-query";
-import { useNavigate } from "@tanstack/react-router";
import {
MoreHorizontalIcon,
PencilIcon,
@@ -34,6 +33,7 @@ import {
InputGroupInput,
OrgIcon,
Pagination,
+ RowLink,
Skeleton,
SubOrgIcon,
Table,
@@ -72,7 +72,6 @@ type TMachineIdentityMember = TAgentVaultProductMemberOf<AgentVaultMemberType.Ma
export const IdentitiesTab = () => {
const { currentProject } = useProject();
const { currentOrg, isSubOrganization } = useOrganization();
- const navigate = useNavigate();
const queryClient = useQueryClient();
const [search, setSearch] = useState("");
const [debouncedSearch] = useDebounce(search);
@@ -228,24 +227,20 @@ export const IdentitiesTab = () => {
))}
{!isPending &&
filtered.map((identity) => (
- <TableRow
- key={identity.id}
- className="cursor-pointer"
- onClick={() => {
- navigate({
- to: "/organizations/$orgId/agent-vault/identities/$identityId",
- params: { orgId: currentOrg.id, identityId: identity.id }
- });
- }}
- >
+ <TableRow key={identity.id} linked>
<TableCell isTruncatable className="min-w-32" title={identity.name}>
- <HighlightText text={identity.name} highlight={debouncedSearch} />
+ <RowLink
+ to="/organizations/$orgId/agent-vault/identities/$identityId"
+ params={{ orgId: currentOrg.id, identityId: identity.id }}
+ >
+ <HighlightText text={identity.name} highlight={debouncedSearch} />
+ </RowLink>
</TableCell>
<TableCell>
<ProductRoleBadge role={identity.role} />
</TableCell>
<TableCell>{renderManagedByBadge(identity)}</TableCell>
- <TableCell variant="action" onClick={(event) => event.stopPropagation()}>
+ <TableCell variant="action">
<DropdownMenu>
<DropdownMenuTrigger asChild>
<IconButton variant="ghost" size="xs" aria-label="Open identity actions">
diff --git a/frontend/src/pages/pam/PamAccessControlPage/components/IdentitiesTab.tsx b/frontend/src/pages/pam/PamAccessControlPage/components/IdentitiesTab.tsx
index 122aa4758b..f148fcfdd7 100644
--- a/frontend/src/pages/pam/PamAccessControlPage/components/IdentitiesTab.tsx
+++ b/frontend/src/pages/pam/PamAccessControlPage/components/IdentitiesTab.tsx
@@ -1,6 +1,5 @@
import { useMemo, useState } from "react";
import { useQueryClient } from "@tanstack/react-query";
-import { useNavigate } from "@tanstack/react-router";
import { format } from "date-fns";
import { MoreHorizontalIcon, PencilIcon, Plus, SearchIcon, Trash2Icon } from "lucide-react";
@@ -36,6 +35,7 @@ import {
InputGroupInput,
OrgIcon,
ProjectIcon,
+ RowLink,
Skeleton,
SubOrgIcon,
Table,
@@ -67,7 +67,6 @@ import { IdentityRoleModal } from "./IdentityRoleModal";
export const IdentitiesTab = () => {
const { currentProject } = useProject();
const { currentOrg, isSubOrganization } = useOrganization();
- const navigate = useNavigate();
const queryClient = useQueryClient();
const [search, setSearch] = useState("");
const [isAddIdentityOpen, setIsAddIdentityOpen] = useState(false);
@@ -216,18 +215,14 @@ export const IdentitiesTab = () => {
</TableRow>
))}
{filteredIdentities.map((member) => (
- <TableRow
- key={member.membershipId}
- className="cursor-pointer"
- onClick={() =>
- navigate({
- to: "/organizations/$orgId/pam/identities/$identityId",
- params: { orgId: currentOrg.id, identityId: member.identityId! }
- })
- }
- >
+ <TableRow key={member.membershipId} linked>
<TableCell className="font-medium">
- <HighlightText text={member.name} highlight={search} />
+ <RowLink
+ to="/organizations/$orgId/pam/identities/$identityId"
+ params={{ orgId: currentOrg.id, identityId: member.identityId! }}
+ >
+ <HighlightText text={member.name} highlight={search} />
+ </RowLink>
</TableCell>
<TableCell>
<button
@@ -248,7 +243,7 @@ export const IdentitiesTab = () => {
<TableCell className="text-sm text-muted">
{member.createdAt ? format(new Date(member.createdAt), "MMM d, yyyy") : "—"}
</TableCell>
- <TableCell onClick={(e) => e.stopPropagation()}>
+ <TableCell data-row-interactive>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<IconButton