Skip to content

⭐️⭐️⭐️ Open-source, self-hosted alternative to Linear and Plane. Project management and issue tracking where teams and AI agents work side by side to plan and ship products.

fix(web): preserve touch scrolling in the project picker (#416)

Ahmad Othman Ammar Adi732ca673d08d
diff --git a/apps/web/src/components/layout/ProjectSwitcher.test.tsx b/apps/web/src/components/layout/ProjectSwitcher.test.tsx
new file mode 100644
index 00000000..7086a373
--- /dev/null
+++ b/apps/web/src/components/layout/ProjectSwitcher.test.tsx
@@ -0,0 +1,324 @@
+import assert from 'node:assert/strict';
+import { afterEach, beforeEach, describe, it } from 'node:test';
+import { act } from 'react';
+import type { Root } from 'react-dom/client';
+import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
+import { NextIntlClientProvider } from 'next-intl';
+import { JSDOM } from 'jsdom';
+import type { Project } from '@/lib/api/endpoints/projects';
+import { qk } from '@/services/queryKeys';
+import nav from '../../../messages/en/nav.json';
+import common from '../../../messages/en/common.json';
+
+const replacedGlobals = [
+ 'window',
+ 'document',
+ 'navigator',
+ 'Node',
+ 'NodeFilter',
+ 'DocumentFragment',
+ 'Element',
+ 'HTMLElement',
+ 'HTMLInputElement',
+ 'HTMLFormElement',
+ 'HTMLSelectElement',
+ 'SVGElement',
+ 'ShadowRoot',
+ 'Event',
+ 'CustomEvent',
+ 'MutationObserver',
+ 'getComputedStyle',
+ 'requestAnimationFrame',
+ 'cancelAnimationFrame',
+ 'ResizeObserver',
+ 'localStorage',
+ 'fetch',
+ 'IS_REACT_ACT_ENVIRONMENT',
+] as const;
+
+const projects: Project[] = Array.from({ length: 20 }, (_, index) => ({
+ id: index + 1,
+ teamId: 1,
+ teamName: 'Engineering',
+ key: `P${String(index + 1).padStart(2, '0')}`,
+ name: `Project ${index + 1}`,
+ description: '',
+ mcpEnabled: true,
+ teamMcpEnabled: true,
+ initiativesEnabled: true,
+ dashboardsEnabled: true,
+ documentsEnabled: true,
+ notesEnabled: true,
+ cyclesEnabled: true,
+ subtasksEnabled: true,
+ checklistsEnabled: true,
+ issueStatsEnabled: true,
+ availableFeatures: [],
+ pointsEstimateEnabled: false,
+ timeEstimateEnabled: false,
+ timeLoggingEnabled: false,
+ createdAt: '2026-01-01T00:00:00Z',
+}));
+
+let dom: JSDOM;
+let root: Root;
+let client: QueryClient;
+let selections: string[];
+let originalGlobalDescriptors: Map<string, PropertyDescriptor | undefined>;
+
+function element(selector: string): HTMLElement {
+ const found = document.querySelector<HTMLElement>(selector);
+ assert.ok(found, selector);
+ return found;
+}
+
+async function click(selector: string) {
+ await act(async () => element(selector).click());
+}
+
+async function key(target: HTMLElement, value: string) {
+ await act(async () => {
+ target.dispatchEvent(new window.KeyboardEvent('keydown', { key: value, bubbles: true }));
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ });
+}
+
+async function render(mobile = true) {
+ Object.defineProperty(window, 'innerWidth', { configurable: true, value: mobile ? 390 : 1280 });
+ const { Sidebar, SidebarProvider, SidebarTrigger } = await import('@/components/ui/sidebar');
+ const { default: ProjectSwitcher } = await import('./ProjectSwitcher');
+ await act(async () =>
+ root.render(
+ <QueryClientProvider client={client}>
+ <NextIntlClientProvider locale="en" messages={{ nav, common }} timeZone="UTC">
+ <SidebarProvider>
+ <SidebarTrigger />
+ <Sidebar>
+ <ProjectSwitcher
+ projects={projects}
+ currentProjectKey="P01"
+ onSelectProject={(key) => selections.push(key)}
+ />
+ </Sidebar>
+ </SidebarProvider>
+ </NextIntlClientProvider>
+ </QueryClientProvider>,
+ ),
+ );
+ if (mobile) await click('[data-slot="sidebar-trigger"]');
+ await click('[data-slot="popover-trigger"]');
+}
+
+function touch(target: HTMLElement, type: 'touchstart' | 'touchmove', y: number) {
+ const event = new window.Event(type, { bubbles: true, cancelable: true });
+ Object.defineProperty(event, 'changedTouches', { value: [{ clientX: 20, clientY: y }] });
+ Object.defineProperty(event, 'touches', { value: [{ clientX: 20, clientY: y }] });
+ act(() => target.dispatchEvent(event));
+ return event;
+}
+
+async function pointer(target: HTMLElement, type: string, pointerType: string) {
+ await act(async () => {
+ const event = new window.MouseEvent(type, { bubbles: true, cancelable: true, button: 0 });
+ Object.defineProperty(event, 'pointerType', { value: pointerType });
+ target.dispatchEvent(event);
+ });
+}
+
+function scrollableList() {
+ const list = element('[data-slot="command-list"]');
+ // jsdom has no layout engine, so supply the dimensions of an overflowing list.
+ Object.defineProperties(list, {
+ scrollHeight: { configurable: true, value: 1000 },
+ clientHeight: { configurable: true, value: 200 },
+ });
+ list.style.overflowY = 'auto';
+ list.scrollTop = 100;
+ // jsdom creates a selection on focus, which RemoveScroll treats as a text drag.
+ window.getSelection()?.removeAllRanges();
+ return list;
+}
+
+beforeEach(async () => {
+ originalGlobalDescriptors = new Map(
+ replacedGlobals.map((name) => [name, Object.getOwnPropertyDescriptor(globalThis, name)]),
+ );
+ dom = new JSDOM('<!doctype html><div id="root"></div>', {
+ url: 'https://example.test/project/P01',
+ pretendToBeVisual: true,
+ });
+ for (const name of replacedGlobals) {
+ if (name in dom.window) {
+ Object.defineProperty(globalThis, name, {
+ configurable: true,
+ value: dom.window[name as keyof typeof dom.window],
+ });
+ }
+ }
+ Object.defineProperties(globalThis, {
+ getComputedStyle: { configurable: true, value: dom.window.getComputedStyle.bind(dom.window) },
+ requestAnimationFrame: {
+ configurable: true,
+ value: dom.window.requestAnimationFrame.bind(dom.window),
+ },
+ cancelAnimationFrame: {
+ configurable: true,
+ value: dom.window.cancelAnimationFrame.bind(dom.window),
+ },
+ ResizeObserver: {
+ configurable: true,
+ value: class {
+ observe() {}
+ unobserve() {}
+ disconnect() {}
+ },
+ },
+ fetch: { configurable: true, value: async () => Response.json(null) },
+ IS_REACT_ACT_ENVIRONMENT: { configurable: true, value: true },
+ });
+ Object.defineProperty(window, '__ITSAPLAN_ENV__', {
+ value: { apiUrl: 'https://api.test', privacyUrl: '', termsUrl: '' },
+ });
+ window.matchMedia = (query) => ({
+ matches: window.innerWidth < 768,
+ media: query,
+ onchange: null,
+ addEventListener() {},
+ removeEventListener() {},
+ addListener() {},
+ removeListener() {},
+ dispatchEvent: () => true,
+ });
+ window.HTMLElement.prototype.scrollIntoView = () => {};
+ selections = [];
+ client = new QueryClient({ defaultOptions: { queries: { retry: false, staleTime: Infinity } } });
+ client.setQueryData(qk.teams, []);
+ const { createRoot } = await import('react-dom/client');
+ root = createRoot(element('#root'));
+});
+
+afterEach(async () => {
+ await act(async () => root.unmount());
+ client.clear();
+ // Better Auth's stores dispose their browser listeners one second after unmount.
+ await new Promise((resolve) => setTimeout(resolve, 1100));
+ dom.window.close();
+ for (const [name, descriptor] of originalGlobalDescriptors) {
+ if (descriptor) Object.defineProperty(globalThis, name, descriptor);
+ else Reflect.deleteProperty(globalThis, name);
+ }
+});
+
+describe('ProjectSwitcher', () => {
+ it('allows a swipe that starts on a project inside the mobile sidebar', async () => {
+ await render();
+ const list = scrollableList();
+ const row = element('[data-value="project-2"]');
+ assert.equal(element('[data-slot="sidebar"]').contains(list), false);
+ touch(row, 'touchstart', 200);
+ assert.equal(touch(row, 'touchmove', 140).defaultPrevented, false);
+ touch(row, 'touchstart', 140);
+ assert.equal(touch(row, 'touchmove', 200).defaultPrevented, false);
+ assert.deepEqual(selections, []);
+ });
+
+ it('contains mobile scrolling at both ends of the list', async () => {
+ await render();
+ const list = scrollableList();
+ const row = element('[data-value="project-2"]');
+ list.scrollTop = 0;
+ touch(row, 'touchstart', 140);
+ assert.equal(touch(row, 'touchmove', 200).defaultPrevented, true);
+ list.scrollTop = 800;
+ touch(row, 'touchstart', 200);
+ assert.equal(touch(row, 'touchmove', 140).defaultPrevented, true);
+ assert.deepEqual(selections, []);
+ });
+
+ it('opens on mobile without focusing the search field and still selects on a tap', async () => {
+ await render();
+ assert.equal(document.activeElement, element('[data-slot="popover-content"]'));
+ await click('[data-value="project-2"]');
+ assert.deepEqual(selections, ['P02']);
+ assert.equal(document.querySelector('[data-slot="popover-content"]'), null);
+ });
+
+ it('focuses search on desktop and allows keyboard selection', async () => {
+ await render(false);
+ const input = element('[data-slot="command-input"]');
+ assert.equal(document.activeElement, input);
+ assert.equal(document.body.style.pointerEvents, '');
+ scrollableList();
+ touch(input, 'touchstart', 200);
+ assert.equal(touch(input, 'touchmove', 140).defaultPrevented, false);
+ await key(input, 'ArrowDown');
+ await key(input, 'Enter');
+ assert.deepEqual(selections, ['P02']);
+ });
+
+ it('restores picker focus and scrolling after closing nested project actions', async () => {
+ await render();
+ const trigger = element('[aria-label="Actions for Project 2"]');
+ await key(trigger, 'Enter');
+ const menu = element('[role="menu"]');
+ await key(menu, 'Escape');
+ assert.equal(document.querySelector('[role="menu"]'), null);
+ assert.equal(document.activeElement, trigger);
+ scrollableList();
+ const row = element('[data-value="project-2"]');
+ touch(row, 'touchstart', 200);
+ assert.equal(touch(row, 'touchmove', 140).defaultPrevented, false);
+ assert.deepEqual(selections, []);
+ });
+
+ it('allows a swipe starting on project actions without opening the menu', async () => {
+ await render();
+ scrollableList();
+ const trigger = element('[aria-label="Actions for Project 2"]');
+ await pointer(trigger, 'pointerdown', 'touch');
+ assert.equal(document.querySelector('[role="menu"]'), null);
+ touch(trigger, 'touchstart', 200);
+ assert.equal(touch(trigger, 'touchmove', 140).defaultPrevented, false);
+ await pointer(trigger, 'pointercancel', 'touch');
+ assert.equal(document.querySelector('[role="menu"]'), null);
+ assert.deepEqual(selections, []);
+ });
+
+ it('keeps the picker scrollable after closing the sort selector', async () => {
+ await render();
+ const trigger = element('[data-slot="select-trigger"]');
+ await key(trigger, 'ArrowDown');
+ await key(element('[data-slot="select-content"]'), 'Escape');
+ assert.equal(document.querySelector('[data-slot="select-content"]'), null);
+ assert.equal(document.activeElement, trigger);
+ scrollableList();
+ const row = element('[data-value="project-2"]');
+ touch(row, 'touchstart', 200);
+ assert.equal(touch(row, 'touchmove', 140).defaultPrevented, false);
+ assert.deepEqual(selections, []);
+ });
+
+ it('opens project actions on a completed tap and preserves mouse activation', async () => {
+ await render();
+ const trigger = element('[aria-label="Actions for Project 2"]');
+ await pointer(trigger, 'pointerdown', 'touch');
+ await pointer(trigger, 'pointerup', 'touch');
+ await act(async () => trigger.click());
+ await key(element('[role="menu"]'), 'Escape');
+ await pointer(trigger, 'pointerdown', 'mouse');
+ assert.ok(element('[role="menu"]'));
+ assert.deepEqual(selections, []);
+ });
+
+ it('closes the picker before its sidebar and releases the scroll lock', async () => {
+ await render();
+ await key(element('[data-slot="popover-content"]'), 'Escape');
+ assert.equal(document.querySelector('[data-slot="popover-content"]'), null);
+ assert.equal(document.activeElement, element('[data-slot="popover-trigger"]'));
+ await key(element('[data-slot="sidebar"]'), 'Escape');
+ assert.equal(document.querySelector('[data-mobile="true"]'), null);
+ assert.equal(document.body.style.pointerEvents, '');
+ touch(document.body, 'touchstart', 200);
+ assert.equal(touch(document.body, 'touchmove', 140).defaultPrevented, false);
+ });
+});
diff --git a/apps/web/src/components/layout/ProjectSwitcher.tsx b/apps/web/src/components/layout/ProjectSwitcher.tsx
index b703a0c1..5efadcac 100644
--- a/apps/web/src/components/layout/ProjectSwitcher.tsx
+++ b/apps/web/src/components/layout/ProjectSwitcher.tsx
@@ -5,7 +5,7 @@ import { useSession } from '@/lib/auth-client';
import { useTeamsQuery } from '@/services/teams.service';
import { qk } from '@/services/queryKeys';
import { Popover, PopoverTrigger } from '@/components/ui/popover';
-import { SidebarMenu, SidebarMenuItem } from '@/components/ui/sidebar';
+import { SidebarMenu, SidebarMenuItem, useSidebar } from '@/components/ui/sidebar';
import ProjectSwitcherTrigger from './ProjectSwitcherTrigger';
import ProjectSwitcherMenu from './ProjectSwitcherMenu';
import { useProjectSwitcherPreferences } from './hooks/useProjectSwitcherPreferences';
@@ -19,6 +19,7 @@ export default function ProjectSwitcher({
currentProjectKey: string | null;
onSelectProject: (key: string) => void;
}) {
+ const { isMobile } = useSidebar();
const teams = useTeamsQuery().data ?? [];
const queryClient = useQueryClient();
const { data: session } = useSession();
@@ -31,6 +32,7 @@ export default function ProjectSwitcher({
<SidebarMenu>
<SidebarMenuItem>
<Popover
+ modal={isMobile}
open={open}
onOpenChange={(value) => {
setOpen(value);
diff --git a/apps/web/src/components/layout/ProjectSwitcherMenu.tsx b/apps/web/src/components/layout/ProjectSwitcherMenu.tsx
index 0640a987..8936bf2e 100644
--- a/apps/web/src/components/layout/ProjectSwitcherMenu.tsx
+++ b/apps/web/src/components/layout/ProjectSwitcherMenu.tsx
@@ -57,7 +57,8 @@ export default function ProjectSwitcherMenu({
}}
onOpenAutoFocus={(event) => {
event.preventDefault();
- inputRef.current?.focus();
+ if (isMobile) contentRef.current?.focus();
+ else inputRef.current?.focus();
}}
>
<ProjectSwitcherToolbar preferences={preferences} isMobile={isMobile} />
diff --git a/apps/web/src/components/layout/ProjectSwitcherProjectActions.tsx b/apps/web/src/components/layout/ProjectSwitcherProjectActions.tsx
index e29b7bde..b0d91ffd 100644
--- a/apps/web/src/components/layout/ProjectSwitcherProjectActions.tsx
+++ b/apps/web/src/components/layout/ProjectSwitcherProjectActions.tsx
@@ -1,3 +1,4 @@
+import { useRef, useState } from 'react';
import { Archive, ArchiveRestore, MoreHorizontal, Star } from 'lucide-react';
import { useTranslations } from 'next-intl';
import type { Project } from '@/lib/api/endpoints/projects';
@@ -13,19 +14,36 @@ import {
export default function ProjectSwitcherProjectActions({ project }: { project: Project }) {
const t = useTranslations('nav.projectPicker');
const update = useUpdateProjectPreferences();
+ const [open, setOpen] = useState(false);
+ const touchPress = useRef(false);
return (
- <DropdownMenu>
+ <DropdownMenu open={open} onOpenChange={setOpen}>
<DropdownMenuTrigger asChild>
<Button
variant="ghost"
size="icon-xs"
- className="shrink-0 text-muted-foreground"
+ className="size-10 shrink-0 text-muted-foreground md:size-7"
aria-label={t('projectActions', { name: project.name })}
title={t('projectActions', { name: project.name })}
disabled={update.isPending}
- onKeyDown={(event) => event.stopPropagation()}
- onClick={(event) => event.stopPropagation()}
+ onPointerDown={(event) => {
+ // Radix opens on pointerdown, before a touch can become a scroll.
+ touchPress.current = event.pointerType === 'touch';
+ if (touchPress.current) event.preventDefault();
+ }}
+ onPointerCancel={() => {
+ touchPress.current = false;
+ }}
+ onKeyDown={(event) => {
+ touchPress.current = false;
+ event.stopPropagation();
+ }}
+ onClick={(event) => {
+ event.stopPropagation();
+ if (touchPress.current) setOpen((value) => !value);
+ touchPress.current = false;
+ }}
>
<MoreHorizontal />
</Button>