Skip to content

⭐️⭐️⭐️ Open-source, self-hosted alternative to Linear and Plane. Project management and issue tracking where teams and AI agents work side by side to plan and ship products.

fix(web): "Add member" offers Owner for an AI agent (#511)

Pasqual Tronconeada3652fdfc7
diff --git a/apps/web/src/features/members/components/members/MemberAddDialog.tsx b/apps/web/src/features/members/components/members/MemberAddDialog.tsx
index 36ffeea7..cb527f9c 100644
--- a/apps/web/src/features/members/components/members/MemberAddDialog.tsx
+++ b/apps/web/src/features/members/components/members/MemberAddDialog.tsx
@@ -21,6 +21,7 @@ import {
} from '@/services/members.service';
import { useTeamRoleOptionsQuery } from '@/services/roles.service';
import MemberPicker, { type MemberOption } from './MemberPicker';
+import { OWNER_VALUE, chosenRole, ownerOffered } from '../../utils/addMemberRole';
// The message for each refusal the API can answer with; any other error falls back
// to 'refused'.
@@ -32,9 +33,6 @@ const REFUSAL_KEY: Record<string, RefusalKey> = {
INVITE_ALREADY_PENDING: 'alreadyInvited',
};
-// Owner is not a custom role, so it sits outside the roles list under this value.
-const OWNER_VALUE = 'owner';
-
const EMAIL_PATTERN = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
// Adds someone to the project. A member of the team joins straight away; anyone else
@@ -82,7 +80,8 @@ export default function MemberAddDialog({
// Default to the team's default role until another option is picked. Empty until
// the roles load, so a submit before that cannot fall back to Owner.
const defaultRoleId = roles.find((r) => r.isDefault)?.id ?? roles[0]?.id;
- const role = roleValue || (defaultRoleId != null ? String(defaultRoleId) : '');
+ const offerOwner = ownerOffered(canGrantOwner, target);
+ const role = chosenRole(roleValue, defaultRoleId, offerOwner);
const typed = query.trim().toLowerCase();
// An address nobody in the team carries is offered as an invite — unless the
@@ -165,7 +164,7 @@ export default function MemberAddDialog({
{r.name}
</SelectItem>
))}
- {canGrantOwner && <SelectItem value={OWNER_VALUE}>{tCommon('owner')}</SelectItem>}
+ {offerOwner && <SelectItem value={OWNER_VALUE}>{tCommon('owner')}</SelectItem>}
</SelectContent>
</Select>
</div>
diff --git a/apps/web/src/features/members/utils/addMemberRole.test.ts b/apps/web/src/features/members/utils/addMemberRole.test.ts
new file mode 100644
index 00000000..ecd57bec
--- /dev/null
+++ b/apps/web/src/features/members/utils/addMemberRole.test.ts
@@ -0,0 +1,33 @@
+import assert from 'node:assert/strict';
+import { describe, it } from 'node:test';
+import type { MemberCandidate } from '@/lib/api/endpoints/members';
+import type { MemberOption } from '../components/members/MemberPicker';
+import { OWNER_VALUE, chosenRole, ownerOffered } from './addMemberRole';
+
+function candidate(isAgent: boolean): MemberOption {
+ const c: MemberCandidate = {
+ userId: 'u',
+ name: 'n',
+ email: 'e',
+ username: null,
+ image: null,
+ isAgent,
+ };
+ return { kind: 'member', candidate: c };
+}
+
+describe('add member role', () => {
+ it('offers Owner for a person or an invite, never for an agent', () => {
+ assert.equal(ownerOffered(true, candidate(false)), true);
+ assert.equal(ownerOffered(true, { kind: 'invite', email: '[email protected]' }), true);
+ assert.equal(ownerOffered(true, candidate(true)), false);
+ assert.equal(ownerOffered(false, candidate(false)), false);
+ });
+
+ it('falls back to the default role when Owner was picked before choosing an agent', () => {
+ assert.equal(chosenRole(OWNER_VALUE, 7, false), '7');
+ assert.equal(chosenRole(OWNER_VALUE, 7, true), OWNER_VALUE);
+ assert.equal(chosenRole('9', 7, false), '9');
+ assert.equal(chosenRole('', 7, true), '7');
+ });
+});
diff --git a/apps/web/src/features/members/utils/addMemberRole.ts b/apps/web/src/features/members/utils/addMemberRole.ts
new file mode 100644
index 00000000..71f53375
--- /dev/null
+++ b/apps/web/src/features/members/utils/addMemberRole.ts
@@ -0,0 +1,20 @@
+import type { MemberOption } from '../components/members/MemberPicker';
+
+export const OWNER_VALUE = 'owner';
+
+// An agent works under a role, which caps what its key and its tools may do, so it is
+// never offered ownership: the API refuses it, and the row controls already hide it.
+export function ownerOffered(canGrantOwner: boolean, target: MemberOption | null): boolean {
+ return canGrantOwner && !(target?.kind === 'member' && target.candidate.isAgent);
+}
+
+// The role the dialog submits: the one picked, unless that is an owner no longer on
+// offer (an agent was chosen after it), and otherwise the team's default.
+export function chosenRole(
+ roleValue: string,
+ defaultRoleId: number | undefined,
+ owner: boolean,
+): string {
+ if (roleValue && (roleValue !== OWNER_VALUE || owner)) return roleValue;
+ return defaultRoleId != null ? String(defaultRoleId) : '';
+}