JiuwenSwarm is an intelligent AI Agent built on openJiuwen. It extends the powerful capabilities of large language models directly to your fingertips through various communication apps you use daily.
Python
fix(gateway): return 404 for cross-user cron delete on dev-stable
openJiuwen-bot8087de115fbc
diff --git a/jiuwenswarm/gateway/channel_manager/web/app_web_handlers.py b/jiuwenswarm/gateway/channel_manager/web/app_web_handlers.pyindex 383298d0e5..a0a0cb20f3 100644--- a/jiuwenswarm/gateway/channel_manager/web/app_web_handlers.py+++ b/jiuwenswarm/gateway/channel_manager/web/app_web_handlers.py@@ -7337,6 +7337,9 @@ def _register_web_handlers(bind: WebHandlersBindParams) -> None:)else:deleted = await cc.delete_job(job_id, group_id=g, bot_id=b, user_id=u)+ except KeyError:+ await channel.send_response(ws, req_id, ok=False, error="job not found", code="NOT_FOUND")+ returnexcept PermissionError as e:await channel.send_response(ws, req_id, ok=False, error=str(e), code="FORBIDDEN")returndiff --git "a/jiuwenswarm/gateway/docs/Gateway Web HTTP\346\216\245\345\217\243\346\226\207\346\241\243.md" "b/jiuwenswarm/gateway/docs/Gateway Web HTTP\346\216\245\345\217\243\346\226\207\346\241\243.md"index d9a085f48b..0471a928e4 100644--- "a/jiuwenswarm/gateway/docs/Gateway Web HTTP\346\216\245\345\217\243\346\226\207\346\241\243.md"+++ "b/jiuwenswarm/gateway/docs/Gateway Web HTTP\346\216\245\345\217\243\346\226\207\346\241\243.md"@@ -1633,7 +1633,7 @@ curl -sS -X POST "http://127.0.0.1:19002/api/v1/chat/web_a1b2c3d4e5f6/actions/us出参(`data.deleted`):`true`/`false`。-失败:任务不存在 → `404 NOT_FOUND`;无权限 → `403 FORBIDDEN`。+失败:任务不存在或无权访问 → `404 NOT_FOUND`(跨用户不区分"不存在"与"无权访问",按防枚举统一返回 404)。##### `cron.job.toggle` — `POST /cron/jobs/{id}/actions/toggle`diff --git a/tests/unit_tests/test_app_web_handlers.py b/tests/unit_tests/test_app_web_handlers.pyindex 4dc3b1021c..6be054e6cc 100644--- a/tests/unit_tests/test_app_web_handlers.py+++ b/tests/unit_tests/test_app_web_handlers.py@@ -2059,6 +2059,72 @@ def test_inject_identity_noop_without_connection_identity() -> None:assert transport._inject_user_id_into_frame(ws, raw) == raw+# =====================================================================+# cron.job.delete — 跨用户/不存在任务按防枚举统一返回 404+# =====================================================================+++class _KeyErrorCronController:+ """模拟跨用户删除:controller 所有权校验抛 KeyError('job not found')。"""++ def __init__(self) -> None:+ self.delete_calls: list[dict] = []++ async def get_job(self, job_id):+ # 非 proactive.tick 的普通任务,绕过主动推荐保护分支+ return SimpleNamespace(id=job_id, mode="chat")++ async def delete_job(self, job_id, *, group_id=None, bot_id=None, user_id=None):+ self.delete_calls.append(+ {"id": job_id, "group_id": group_id, "bot_id": bot_id, "user_id": user_id}+ )+ raise KeyError("job not found")+++async def test_cron_job_delete_cross_user_returns_not_found():+ """跨用户删除时 controller 抛 KeyError → 应映射为 404 NOT_FOUND,而非 500。"""+ channel = FakeWebChannel()+ cc = _KeyErrorCronController()+ _register_web_handlers(WebHandlersBindParams(channel=channel, cron_controller=cc))++ await channel.methods["cron.job.delete"](+ object(), "req-cron-del", {"id": "job-other"}, "sess-1"+ )++ last = channel.responses[-1]+ assert last["ok"] is False+ assert last["code"] == "NOT_FOUND"+ assert last["error"] == "job not found"+ # 确实走到了所有权校验路径(而非参数校验提前返回)+ assert cc.delete_calls[0]["id"] == "job-other"+++async def test_cron_job_delete_existing_job_returns_deleted():+ """本用户正常删除 → ok=true(回归保护,确保修复未破坏正常路径)。"""+ channel = FakeWebChannel()++ class _OkCronController:+ async def get_job(self, job_id):+ return SimpleNamespace(id=job_id, mode="chat")++ async def delete_job(self, job_id, *, group_id=None, bot_id=None, user_id=None):+ return True++ _register_web_handlers(+ WebHandlersBindParams(channel=channel, cron_controller=_OkCronController())+ )++ await channel.methods["cron.job.delete"](+ object(), "req-cron-del", {"id": "job-own"}, "sess-1"+ )++ last = channel.responses[-1]+ assert last["ok"] is True+ assert last["payload"] == {"deleted": True}++def test_capture_session_create_row_on_ok_response(monkeypatch) -> None:"""create 成功响应经下行拦截异步落行(remote 转发主路径);失败/未知 rid 不动。"""import threading