Skip to content

Job application tracker and AI-powered job search assistant. Helps job seekers manage their search journey with AI resume review, job matching, task logging, and application analytics, all while keeping your data private.

fix: update aria-label for user menu trigger and enhance task visibility checks

Khuram Niaz3f8250df18f4
diff --git a/e2e/signin.spec.ts b/e2e/signin.spec.ts
index 0632967..190a735 100644
--- a/e2e/signin.spec.ts
+++ b/e2e/signin.spec.ts
@@ -22,7 +22,7 @@ test("Signin and out from app", async ({ page, baseURL }) => {
await expect(page).toHaveURL(baseURL + "/dashboard");
- await page.getByRole("button", { name: "Avatar" }).click();
+ await page.getByRole("button", { name: "User menu" }).click();
await page.getByRole("button", { name: "Logout" }).click();
await expect(
diff --git a/e2e/tasks.spec.ts b/e2e/tasks.spec.ts
index fc8a193..8767f8e 100644
--- a/e2e/tasks.spec.ts
+++ b/e2e/tasks.spec.ts
@@ -370,10 +370,16 @@ test.describe("Tasks Management", () => {
.click({ force: true });
await page.keyboard.press("Escape");
+ // Widening the filter refetches page 1 (25 rows, ordered priority desc),
+ // so a default-priority task can land on a later page once completed
+ // tasks join the list. Search by the unique title to pin it on screen.
+ await page.getByPlaceholder("Search tasks...").fill(completedTaskTitle);
+
// Try to start activity via menu - should show error
const completedTaskRow = page
.getByRole("row", { name: new RegExp(completedTaskTitle, "i") })
.first();
+ await expect(completedTaskRow).toBeVisible({ timeout: 10000 });
await completedTaskRow
.getByTestId("task-actions-menu-btn")
.click({ force: true });
@@ -381,9 +387,11 @@ test.describe("Tasks Management", () => {
.getByRole("menuitem", { name: "Start Activity" })
.click({ force: true });
- await expect(page.getByRole("status").first()).toContainText(
- /Cannot start an activity from a completed or cancelled task/,
- );
+ await expect(
+ page.locator("[data-sonner-toast]").filter({
+ hasText: "Cannot start an activity from a completed or cancelled task",
+ }),
+ ).toBeVisible();
});
});
});
diff --git a/src/components/ProfileDropdown.tsx b/src/components/ProfileDropdown.tsx
index 1d73d27..877afd2 100644
--- a/src/components/ProfileDropdown.tsx
+++ b/src/components/ProfileDropdown.tsx
@@ -25,7 +25,7 @@ export function ProfileDropdown({ user, signOutAction }: ProfileDropdownProps) {
return (
<>
<DropdownMenu>
- <DropdownMenuTrigger>
+ <DropdownMenuTrigger aria-label="User menu">
<UserAvatar user={user} />
</DropdownMenuTrigger>
<DropdownMenuContent align="end">