Skip to content

Job application tracker and AI-powered job search assistant. Helps job seekers manage their search journey with AI resume review, job matching, task logging, and application analytics, all while keeping your data private.

Refactor: Remove functions from render method

Khuram Niaz6829abf76c36
diff --git a/src/components/admin/AddCompany.tsx b/src/components/admin/AddCompany.tsx
index c6e893c..7fbbdb8 100644
--- a/src/components/admin/AddCompany.tsx
+++ b/src/components/admin/AddCompany.tsx
@@ -72,6 +72,8 @@ function AddCompany({
setDialogOpen(true);
};
+ const closeDialog = () => setDialogOpen(false);
+
const onSubmit = (data: z.infer<typeof AddCompanyFormSchema>) => {
startTransition(async () => {
const res = editCompany
@@ -167,7 +169,7 @@ function AddCompany({
type="reset"
variant="outline"
className="mt-2 md:mt-0 w-full"
- onClick={() => setDialogOpen(false)}
+ onClick={closeDialog}
>
Cancel
</Button>
diff --git a/src/components/myjobs/AddJob.tsx b/src/components/myjobs/AddJob.tsx
index e039866..6291c31 100644
--- a/src/components/myjobs/AddJob.tsx
+++ b/src/components/myjobs/AddJob.tsx
@@ -147,6 +147,8 @@ export function AddJob({
}
};
+ const closeDialog = () => setDialogOpen(false);
+
return (
<>
<Button
@@ -438,7 +440,7 @@ export function AddJob({
type="reset"
variant="outline"
className="mt-2 md:mt-0 w-full"
- onClick={() => setDialogOpen(false)}
+ onClick={closeDialog}
>
Cancel
</Button>
diff --git a/src/components/profile/AddContactInfo.tsx b/src/components/profile/AddContactInfo.tsx
index 71baaf0..190aa5a 100644
--- a/src/components/profile/AddContactInfo.tsx
+++ b/src/components/profile/AddContactInfo.tsx
@@ -98,6 +98,8 @@ function AddContactInfo({
});
};
+ const closeDialog = () => setDialogOpen(false);
+
return (
<Dialog open={dialogOpen} onOpenChange={setDialogOpen}>
<DialogContent className="lg:max-h-screen overflow-y-scroll">
@@ -219,7 +221,7 @@ function AddContactInfo({
type="reset"
variant="outline"
className="mt-2 md:mt-0 w-full"
- onClick={() => setDialogOpen(false)}
+ onClick={closeDialog}
>
Cancel
</Button>
diff --git a/src/components/profile/AddEducation.tsx b/src/components/profile/AddEducation.tsx
index 24b4435..e3b1d1b 100644
--- a/src/components/profile/AddEducation.tsx
+++ b/src/components/profile/AddEducation.tsx
@@ -136,6 +136,8 @@ function AddEducation({
});
};
+ const closeDialog = () => setDialogOpen(false);
+
return (
<Dialog open={dialogOpen} onOpenChange={setDialogOpen}>
<DialogContent className="h-full md:h-[85%] lg:max-h-screen md:max-w-[40rem] overflow-y-scroll">
@@ -323,7 +325,7 @@ function AddEducation({
type="reset"
variant="outline"
className="mt-2 md:mt-0 w-full"
- onClick={() => setDialogOpen(false)}
+ onClick={closeDialog}
>
Cancel
</Button>
diff --git a/src/components/profile/AddExperience.tsx b/src/components/profile/AddExperience.tsx
index c87c722..6660e84 100644
--- a/src/components/profile/AddExperience.tsx
+++ b/src/components/profile/AddExperience.tsx
@@ -142,6 +142,8 @@ function AddExperience({
}
};
+ const closeDialog = () => setDialogOpen(false);
+
return (
<Dialog open={dialogOpen} onOpenChange={setDialogOpen}>
<DialogContent className="h-full md:h-[85%] lg:max-h-screen md:max-w-[40rem] overflow-y-scroll">
@@ -312,7 +314,7 @@ function AddExperience({
type="reset"
variant="outline"
className="mt-2 md:mt-0 w-full"
- onClick={() => setDialogOpen(false)}
+ onClick={closeDialog}
>
Cancel
</Button>
diff --git a/src/components/profile/AddResumeSection.tsx b/src/components/profile/AddResumeSection.tsx
index be99c33..ab41947 100644
--- a/src/components/profile/AddResumeSection.tsx
+++ b/src/components/profile/AddResumeSection.tsx
@@ -79,6 +79,20 @@ const AddResumeSection = forwardRef<AddResumeSectionRef, AddResumeSectionProps>(
const resetEducationToEdit = () => {
setEducationToEdit(null);
};
+ const openContactInfoDialog = () => setContactInfoDialogOpen(true);
+ const openSummaryDialog = () => setSummaryDialogOpen(true);
+ const openExperienceDialog = () => {
+ if (experienceToEdit) {
+ resetExperienceToEdit();
+ }
+ setExperienceDialogOpen(true);
+ };
+ const openEducationDialog = () => {
+ if (educationToEdit) {
+ resetEducationToEdit();
+ }
+ setEducationDialogOpen(true);
+ };
return (
<>
<DropdownMenu>
@@ -98,37 +112,27 @@ const AddResumeSection = forwardRef<AddResumeSectionRef, AddResumeSectionProps>(
<DropdownMenuGroup>
<DropdownMenuItem
className="cursor-pointer"
- onClick={() => setContactInfoDialogOpen(true)}
+ onClick={openContactInfoDialog}
disabled={!!resume?.ContactInfo}
>
Add Contact Info
</DropdownMenuItem>
<DropdownMenuItem
className="cursor-pointer"
- onClick={() => setSummaryDialogOpen(true)}
+ onClick={openSummaryDialog}
disabled={!!summarySection}
>
Add Summary
</DropdownMenuItem>
<DropdownMenuItem
className="cursor-pointer"
- onClick={() => {
- if (experienceToEdit) {
- resetExperienceToEdit();
- }
- setExperienceDialogOpen(true);
- }}
+ onClick={openExperienceDialog}
>
Add Experience
</DropdownMenuItem>
<DropdownMenuItem
className="cursor-pointer"
- onClick={() => {
- if (educationToEdit) {
- resetEducationToEdit();
- }
- setEducationDialogOpen(true);
- }}
+ onClick={openEducationDialog}
>
Add Education
</DropdownMenuItem>
diff --git a/src/components/profile/AddResumeSummary.tsx b/src/components/profile/AddResumeSummary.tsx
index b3d3d3d..b561da2 100644
--- a/src/components/profile/AddResumeSummary.tsx
+++ b/src/components/profile/AddResumeSummary.tsx
@@ -95,6 +95,8 @@ function AddResumeSummary({
});
};
+ const closeDialog = () => setDialogOpen(false);
+
return (
<Dialog open={dialogOpen} onOpenChange={setDialogOpen}>
<DialogContent className="lg:max-h-screen overflow-y-scroll">
@@ -147,7 +149,7 @@ function AddResumeSummary({
type="reset"
variant="outline"
className="mt-2 md:mt-0 w-full"
- onClick={() => setDialogOpen(false)}
+ onClick={closeDialog}
>
Cancel
</Button>