Skip to content

Job application tracker and AI-powered job search assistant. Helps job seekers manage their search journey with AI resume review, job matching, task logging, and application analytics, all while keeping your data private.

refactor: retire the dedicated resume review sheet and route

Khuram Niaz784b524d4637
diff --git a/.gitignore b/.gitignore
index ef98ab1..2c106b8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -65,3 +65,8 @@ evals/mcp-tools/tools.json
# Generated by evals/agent-chat/generate-tools.ts
evals/agent-chat/tools.json
+
+# One-off eval investigation harnesses. Kept on disk so a finding can be
+# re-run, but not part of the shipped suite. See the runs they produced in
+# docs/architecture/agent-chat.md.
+evals/*/_investigate-*
diff --git a/__tests__/AiResumeReviewSection.spec.tsx b/__tests__/AiResumeReviewSection.spec.tsx
deleted file mode 100644
index d0ad3d5..0000000
--- a/__tests__/AiResumeReviewSection.spec.tsx
+++ /dev/null
@@ -1,355 +0,0 @@
-import React from "react";
-import {
- render as rtlRender,
- screen,
- fireEvent,
- waitFor,
- within,
- act,
- type RenderOptions,
-} from "@testing-library/react";
-import { RightRailProvider } from "@/context/RightRailContext";
-
-// The sheet claims the right rail on open, so it needs the provider.
-const render = (ui: React.ReactElement, options?: RenderOptions) =>
- rtlRender(ui, { wrapper: RightRailProvider, ...options });
-import AiResumeReviewSection from "@/components/profile/AiResumeReviewSection";
-import { Resume, SectionType } from "@/models/profile.model";
-import type { ResumeReviewResult } from "@/utils/streamResumeReview.utils";
-import { buildInsufficientSectionsMessage } from "@/lib/resumeSections";
-
-const mockStreamResumeReview = vi.fn();
-vi.mock("@/utils/streamResumeReview.utils", () => ({
- streamResumeReview: (...args: any[]) => mockStreamResumeReview(...args),
-}));
-
-const mockSaveResumeReviewResult = vi.fn();
-vi.mock("@/actions/profile.actions", () => ({
- saveResumeReviewResult: (...args: any[]) =>
- mockSaveResumeReviewResult(...args),
-}));
-
-vi.mock("@/actions/userSettings.actions", () => ({
- getUserSettings: vi.fn().mockResolvedValue({
- success: true,
- data: { settings: { ai: { provider: "openai", model: "gpt-4o" } } },
- }),
-}));
-
-vi.mock("@/utils/ai.utils", () => ({
- checkOllamaConnection: vi.fn().mockResolvedValue({ isConnected: true }),
-}));
-
-const mockToastSuccess = vi.fn();
-const mockToastError = vi.fn();
-vi.mock("@/lib/toast", () => ({
- toastSuccess: (...args: any[]) => mockToastSuccess(...args),
- toastError: (...args: any[]) => mockToastError(...args),
-}));
-
-vi.mock("@/components/profile/AiResumeReviewResponseContent", () => ({
- AiResumeReviewResponseContent: () => <div data-testid="review-content" />,
-}));
-
-vi.mock("@/components/Loading", () => ({
- __esModule: true,
- default: () => <div data-testid="loading" />,
-}));
-
-vi.mock("@/components/common/SlowResponseWarning", () => ({
- SlowResponseWarning: () => <div data-testid="slow-warning" />,
-}));
-
-vi.mock("@/hooks/useSlowResponseWarning", () => ({
- useSlowResponseWarning: () => false,
-}));
-
-// Capture the Sheet's onOpenChange so a test can simulate closing the sheet.
-const mockSheetProps: { onOpenChange?: (open: boolean) => void } = {};
-
-vi.mock("@/components/ui/sheet", () => ({
- Sheet: ({ children, open, onOpenChange }: any) => {
- mockSheetProps.onOpenChange = onOpenChange;
- return (
- <div data-testid="sheet" data-open={open}>
- {children}
- </div>
- );
- },
- SheetPortal: ({ children }: any) => <div>{children}</div>,
- SheetContent: ({ children }: any) => (
- <div data-testid="sheet-content">{children}</div>
- ),
- SheetHeader: ({ children }: any) => <div>{children}</div>,
- SheetTitle: ({ children }: any) => <div>{children}</div>,
- SheetClose: ({ children }: any) => <div>{children}</div>,
- SheetTrigger: ({ children }: any) => (
- <div data-testid="sheet-trigger">{children}</div>
- ),
-}));
-
-vi.mock("@/components/ui/tooltip", () => ({
- Tooltip: ({ children }: any) => <div>{children}</div>,
- TooltipContent: ({ children }: any) => <div>{children}</div>,
- TooltipProvider: ({ children }: any) => <div>{children}</div>,
- TooltipTrigger: ({ children }: any) => <div>{children}</div>,
-}));
-
-// Fixtures
-const makeResume = (sectionCount: number): Resume => ({
- id: "resume-1",
- title: "My Resume",
- ResumeSections: Array.from({ length: sectionCount }, (_, i) => ({
- id: `section-${i}`,
- resumeId: "resume-1",
- sectionTitle: `Section ${i}`,
- sectionType: SectionType.EXPERIENCE,
- })),
-});
-
-const getGenerateButton = () =>
- screen.queryAllByRole("button", { name: /generate ai review/i })[0];
-
-// Opens the sheet (via the "Review" trigger) so the aISectionOpen-gated
-// settings fetch runs and selectedModel picks up the mocked AI settings.
-// Waits on the rendered provider/model label (not just the fetch call) so
-// the state update has actually flushed before the caller proceeds.
-const openSheet = async () => {
- const trigger = within(screen.getByTestId("sheet-trigger")).getByRole(
- "button",
- );
- fireEvent.click(trigger);
- await waitFor(() => expect(screen.getByText(/gpt-4o/i)).toBeInTheDocument());
-};
-
-describe("AiResumeReviewSection – Review trigger button state", () => {
- beforeEach(() => {
- vi.clearAllMocks();
- mockStreamResumeReview.mockResolvedValue({
- scores: { overall: 85, impact: 80, clarity: 82, atsCompatibility: 78 },
- body: "## Summary\nGreat resume",
- });
- });
-
- it("is enabled regardless of section count", () => {
- render(<AiResumeReviewSection resume={makeResume(1)} />);
- const trigger = within(screen.getByTestId("sheet-trigger")).getByRole(
- "button",
- );
- expect(trigger).not.toBeDisabled();
- });
-});
-
-describe("AiResumeReviewSection – Generate AI Review button", () => {
- beforeEach(() => {
- vi.clearAllMocks();
- mockStreamResumeReview.mockResolvedValue({
- scores: { overall: 85, impact: 80, clarity: 82, atsCompatibility: 78 },
- body: "## Summary\nGreat resume",
- });
- });
-
- it("shows toast error when resume has fewer than 2 sections", () => {
- render(<AiResumeReviewSection resume={makeResume(1)} />);
- fireEvent.click(getGenerateButton());
- expect(mockToastError).toHaveBeenCalledWith(
- buildInsufficientSectionsMessage(
- "running a review",
- "e.g. Summary and Experience",
- ),
- "Not enough content",
- );
- expect(mockStreamResumeReview).not.toHaveBeenCalled();
- });
-
- it("calls streamResumeReview with the resume id when generate is clicked", () => {
- const resume = makeResume(3);
- render(<AiResumeReviewSection resume={resume} />);
- fireEvent.click(getGenerateButton());
- expect(mockStreamResumeReview).toHaveBeenCalledWith(
- expect.objectContaining({ resumeId: resume.id }),
- );
- });
-});
-
-describe("AiResumeReviewSection – loading state", () => {
- beforeEach(() => {
- vi.clearAllMocks();
- });
-
- it("shows loading indicator while the review is streaming", async () => {
- // Pending stream keeps the component in the loading state.
- mockStreamResumeReview.mockReturnValue(new Promise(() => {}));
- render(<AiResumeReviewSection resume={makeResume(3)} />);
- fireEvent.click(getGenerateButton());
- await waitFor(() =>
- expect(screen.getByTestId("loading")).toBeInTheDocument(),
- );
- });
-
- it("shows review content when not loading", () => {
- mockStreamResumeReview.mockResolvedValue({
- scores: { overall: 85, impact: 80, clarity: 82, atsCompatibility: 78 },
- body: "## Summary\nGreat resume",
- });
- render(<AiResumeReviewSection resume={makeResume(3)} />);
- expect(screen.getByTestId("review-content")).toBeInTheDocument();
- expect(screen.queryByTestId("loading")).not.toBeInTheDocument();
- });
-});
-
-const completedReview: ResumeReviewResult = {
- scores: { overall: 85, impact: 80, clarity: 82, atsCompatibility: 78 },
- body: "## Summary\nGreat resume",
-};
-
-describe("AiResumeReviewSection – auto-save", () => {
- const onReviewSaved = vi.fn();
-
- beforeEach(() => {
- vi.clearAllMocks();
- onReviewSaved.mockClear();
- });
-
- it("saves review result when streaming completes with valid data", async () => {
- mockStreamResumeReview.mockResolvedValue(completedReview);
- mockSaveResumeReviewResult.mockResolvedValue({ success: true });
-
- const resume = makeResume(3);
- render(
- <AiResumeReviewSection resume={resume} onReviewSaved={onReviewSaved} />,
- );
- await openSheet();
- fireEvent.click(getGenerateButton());
-
- await waitFor(() => {
- expect(mockSaveResumeReviewResult).toHaveBeenCalledTimes(1);
- expect(mockSaveResumeReviewResult).toHaveBeenCalledWith(
- resume.id,
- expect.stringContaining('"overall":85'),
- );
- });
-
- const savedData = JSON.parse(mockSaveResumeReviewResult.mock.calls[0][1]);
- expect(savedData).toMatchObject({
- overall: 85,
- impact: 80,
- clarity: 82,
- atsCompatibility: 78,
- body: "## Summary\nGreat resume",
- provider: "openai",
- model: "gpt-4o",
- });
- expect(savedData.reviewedAt).toBeTruthy();
- });
-
- it("calls onReviewSaved callback after successful save", async () => {
- mockStreamResumeReview.mockResolvedValue(completedReview);
- mockSaveResumeReviewResult.mockResolvedValue({ success: true });
-
- render(
- <AiResumeReviewSection
- resume={makeResume(3)}
- onReviewSaved={onReviewSaved}
- />,
- );
- fireEvent.click(getGenerateButton());
-
- await waitFor(() => {
- expect(onReviewSaved).toHaveBeenCalledWith(
- expect.stringContaining('"overall":85'),
- );
- });
- });
-
- it("shows success toast after save", async () => {
- mockStreamResumeReview.mockResolvedValue(completedReview);
- mockSaveResumeReviewResult.mockResolvedValue({ success: true });
-
- render(<AiResumeReviewSection resume={makeResume(3)} />);
- fireEvent.click(getGenerateButton());
-
- await waitFor(() => {
- expect(mockToastSuccess).toHaveBeenCalledWith("Review saved");
- });
- });
-
- it("does not save when the user closes the sheet mid-stream", async () => {
- // streamResumeReview salvages partial data and resolves on abort, so the
- // component must skip saving a review the user cancelled.
- let resolveStream!: (value: ResumeReviewResult) => void;
- const streamCall = new Promise<ResumeReviewResult>((r) => {
- resolveStream = r;
- });
- mockStreamResumeReview.mockReturnValue(streamCall);
- mockSaveResumeReviewResult.mockResolvedValue({ success: true });
-
- render(
- <AiResumeReviewSection
- resume={makeResume(3)}
- onReviewSaved={onReviewSaved}
- />,
- );
- fireEvent.click(getGenerateButton());
-
- await waitFor(() =>
- expect(mockStreamResumeReview).toHaveBeenCalledTimes(1),
- );
-
- // User closes the sheet -> component aborts the in-flight controller.
- await act(async () => {
- mockSheetProps.onOpenChange?.(false);
- });
-
- // The stream then resolves with the salvaged partial result.
- await act(async () => {
- resolveStream({
- scores: { overall: 85, impact: 80, clarity: 82, atsCompatibility: 78 },
- body: "partial",
- });
- await streamCall;
- });
-
- expect(mockSaveResumeReviewResult).not.toHaveBeenCalled();
- expect(onReviewSaved).not.toHaveBeenCalled();
- });
-
- it("does not save when stream returns no scores", async () => {
- mockStreamResumeReview.mockResolvedValue({ body: "partial data" });
-
- render(
- <AiResumeReviewSection
- resume={makeResume(3)}
- onReviewSaved={onReviewSaved}
- />,
- );
- fireEvent.click(getGenerateButton());
-
- await new Promise((r) => setTimeout(r, 50));
-
- expect(mockSaveResumeReviewResult).not.toHaveBeenCalled();
- expect(onReviewSaved).not.toHaveBeenCalled();
- });
-
- it("shows error toast when save fails", async () => {
- mockStreamResumeReview.mockResolvedValue(completedReview);
- mockSaveResumeReviewResult.mockResolvedValue({
- success: false,
- message: "DB error",
- });
-
- render(
- <AiResumeReviewSection
- resume={makeResume(3)}
- onReviewSaved={onReviewSaved}
- />,
- );
- fireEvent.click(getGenerateButton());
-
- await waitFor(() => {
- expect(mockToastError).toHaveBeenCalledWith("DB error");
- });
-
- expect(onReviewSaved).not.toHaveBeenCalled();
- });
-});
diff --git a/__tests__/api-auth-contract.spec.ts b/__tests__/api-auth-contract.spec.ts
index 4b669a6..ed5c170 100644
--- a/__tests__/api-auth-contract.spec.ts
+++ b/__tests__/api-auth-contract.spec.ts
@@ -26,7 +26,6 @@ import {
GET as getResume,
POST as postResume,
} from "@/app/api/profile/resume/route";
-import { POST as reviewResume } from "@/app/api/ai/resume/review/route";
import { POST as generateCoverLetter } from "@/app/api/ai/cover-letter/route";
import { POST as agentChat } from "@/app/api/ai/chat/route";
@@ -72,11 +71,6 @@ describe("API auth contract: guarded routes reject anonymous requests", () => {
expect(res!.status).toBe(401);
});
- it("POST /api/ai/resume/review -> 401", async () => {
- const res = await reviewResume(req());
- expect(res.status).toBe(401);
- });
-
it("POST /api/ai/cover-letter -> 401", async () => {
const res = await generateCoverLetter(req());
expect(res.status).toBe(401);
diff --git a/src/app/api/ai/resume/review/route.ts b/src/app/api/ai/resume/review/route.ts
deleted file mode 100644
index c524898..0000000
--- a/src/app/api/ai/resume/review/route.ts
+++ /dev/null
@@ -1,131 +0,0 @@
-import "server-only";
-
-import { auth } from "@/auth";
-import { NextRequest, NextResponse } from "next/server";
-import { streamText } from "ai";
-import { getModel } from "@/lib/ai/providers";
-import { checkRateLimit } from "@/lib/ai/rate-limiter";
-import { TEMPERATURES } from "@/lib/ai/config";
-import {
- RESUME_REVIEW_SYSTEM_PROMPT,
- buildResumeReviewPrompt,
- AIUnavailableError,
- preprocessResume,
-} from "@/lib/ai";
-import { APP_CONSTANTS } from "@/lib/constants";
-import { getResumeById } from "@/actions/profile.actions";
-import { AiModel } from "@/models/ai.model";
-
-/**
- * Resume Review Endpoint
- * Single comprehensive LLM call for complete resume analysis
- */
-export const POST = async (req: NextRequest) => {
- const session = await auth();
- const userId = session?.user?.id;
-
- if (!session || !userId) {
- return NextResponse.json({ error: "Not Authenticated" }, { status: 401 });
- }
-
- // Rate limiting
- const rateLimit = checkRateLimit(userId);
- if (!rateLimit.allowed) {
- return NextResponse.json(
- {
- error: `Rate limit exceeded. Try again in ${Math.ceil(
- rateLimit.resetIn / 1000,
- )} seconds.`,
- },
- { status: 429 },
- );
- }
-
- const { selectedModel, resumeId } = (await req.json()) as {
- selectedModel: AiModel;
- resumeId: string;
- };
-
- if (!resumeId || !selectedModel) {
- return NextResponse.json(
- { error: "resumeId and model selection required" },
- { status: 400 },
- );
- }
-
- // Load the resume server-side, scoped to the caller (ownership check) — never
- // trust resume content sent by the client.
- const resumeResult = await getResumeById(resumeId);
- if (!resumeResult?.success || !resumeResult.data) {
- return NextResponse.json({ error: "Resume not found" }, { status: 404 });
- }
-
- try {
- const preprocessResult = await preprocessResume(resumeResult.data);
- if (!preprocessResult.success) {
- return NextResponse.json(
- {
- error: preprocessResult.error.message,
- code: preprocessResult.error.code,
- },
- { status: 400 },
- );
- }
- const { normalizedText } = preprocessResult.data;
-
- const model = await getModel(
- selectedModel.provider,
- selectedModel.model || "llama3.2",
- userId,
- );
-
- const controller = new AbortController();
- const timer = setTimeout(
- () => controller.abort(),
- APP_CONSTANTS.AI_RESUME_REVIEW_TIMEOUT_MS,
- );
-
- // Free-form markdown output (scores line + markdown body). Plain text means
- // toTextStreamResponse() is correct here — no structured-output parsing, so
- // none of the json/tool-call empty-textStream pitfalls apply.
- const result = streamText({
- model,
- system: RESUME_REVIEW_SYSTEM_PROMPT,
- prompt: buildResumeReviewPrompt(normalizedText),
- temperature: TEMPERATURES.FEEDBACK,
- abortSignal: controller.signal,
- providerOptions: {
- ollama: { options: { num_ctx: APP_CONSTANTS.AI_OLLAMA_NUM_CTX } },
- },
- onFinish: () => {
- clearTimeout(timer);
- },
- onError: ({ error }) => {
- clearTimeout(timer);
- console.error("Resume review stream error:", error);
- },
- });
-
- return result.toTextStreamResponse();
- } catch (error) {
- console.error("Resume review error:", error);
-
- if (error instanceof AIUnavailableError) {
- return NextResponse.json({ error: error.message }, { status: 503 });
- }
-
- const message =
- error instanceof Error ? error.message : "AI request failed";
-
- if (message.includes("fetch failed") || message.includes("ECONNREFUSED")) {
- return NextResponse.json(
- {
- error: `Cannot connect to ${selectedModel.provider} service. Please ensure the service is running.`,
- },
- { status: 503 },
- );
- }
-
- return NextResponse.json({ error: message }, { status: 500 });
- }
-};
diff --git a/src/components/agent/AgentChatPanel.tsx b/src/components/agent/AgentChatPanel.tsx
index 0013335..75f933c 100644
--- a/src/components/agent/AgentChatPanel.tsx
+++ b/src/components/agent/AgentChatPanel.tsx
@@ -22,7 +22,8 @@ export function AgentChatPanel() {
preflight,
} = useAgentChat();
- // Status icon for the terminal header bar — mirrors AiResumeReviewSection.
+ // Status icon for the terminal header bar — same shape the other AI
+ // surfaces use for their provider preflight.
const statusIcon = !preflight.checked ? (
<Loader2 className="h-3.5 w-3.5 shrink-0 animate-spin text-muted-foreground" />
) : preflight.provider === AiProvider.OLLAMA ? (
diff --git a/src/components/agent/AgentReviewScoreCard.tsx b/src/components/agent/AgentReviewScoreCard.tsx
index e554d6c..0b6af28 100644
--- a/src/components/agent/AgentReviewScoreCard.tsx
+++ b/src/components/agent/AgentReviewScoreCard.tsx
@@ -3,9 +3,9 @@
import { RadialChartComponent } from "@/components/RadialChartSvg";
import type { ResumeScores } from "@/models/ai.schemas";
-// Deliberately a copy of AiResumeReviewResponseContent's ScoresSection rather
-// than a shared extraction: the old surface stays byte-identical until it is
-// retired, and this is the thing that proves the new one works.
+// Started as a copy of the retired review sheet's ScoresSection, kept
+// separate so that surface could be deleted without touching this one.
+// AiJobMatchResponseContent still has its own near-identical version.
export function AgentReviewScoreCard({ scores }: { scores: ResumeScores }) {
const items = [
{ label: "Impact", value: scores.impact },
diff --git a/src/components/profile/AiResumeReviewResponseContent.tsx b/src/components/profile/AiResumeReviewResponseContent.tsx
deleted file mode 100644
index 02eba56..0000000
--- a/src/components/profile/AiResumeReviewResponseContent.tsx
+++ /dev/null
@@ -1,72 +0,0 @@
-"use client";
-
-import { useMemo } from "react";
-import MarkdownIt from "markdown-it";
-import { RadialChartComponent } from "../RadialChartSvg";
-import { TipTapContentViewer } from "../TipTapContentViewer";
-import { ResumeScores } from "@/models/ai.schemas";
-
-// html:false escapes any raw HTML in the model output; TipTapContentViewer
-// further strips unrecognized tags, so the rendered review is safe.
-const md = new MarkdownIt({ html: false, linkify: false, breaks: true });
-
-const ScoresSection = ({ scores }: { scores?: ResumeScores }) => {
- if (!scores) return null;
-
- const items = [
- { label: "Impact", value: scores.impact },
- { label: "Clarity", value: scores.clarity },
- { label: "ATS", value: scores.atsCompatibility },
- ];
-
- return (
- <div className="pt-4">
- {scores.overall !== undefined && (
- <div className="flex justify-center">
- <RadialChartComponent score={scores.overall} />
- </div>
- )}
- <div className="grid grid-cols-3 gap-2 mt-[-10px]">
- {items.map((item) => (
- <div key={item.label} className="text-center">
- <div className="text-xs text-muted-foreground">{item.label}</div>
- <div className="font-semibold">{item.value}</div>
- </div>
- ))}
- </div>
- </div>
- );
-};
-
-export const AiResumeReviewResponseContent = ({
- scores,
- body,
- isStreaming,
-}: {
- scores?: ResumeScores;
- body?: string;
- isStreaming?: boolean;
-}) => {
- const html = useMemo(() => (body ? md.render(body) : ""), [body]);
-
- if (!scores && !html) return null;
-
- return (
- <div className="space-y-2">
- <ScoresSection scores={scores} />
-
- {html && (
- <div className="mt-4 text-sm leading-relaxed [&_p]:mt-2 [&_ul]:mt-2 [&_ol]:mt-2 [&_h2]:mt-4 [&_h2]:font-semibold">
- <TipTapContentViewer content={html} />
- </div>
- )}
-
- {isStreaming && (
- <div className="flex items-center gap-2 text-muted-foreground text-sm mt-4 animate-pulse">
- <div className="h-2 w-2 bg-primary rounded-full"></div>
- <span>Analyzing resume...</span>
- </div>
- )}
- </div>
- );
-};
diff --git a/src/components/profile/AiResumeReviewSection.tsx b/src/components/profile/AiResumeReviewSection.tsx
deleted file mode 100644
index 7ea4549..0000000
--- a/src/components/profile/AiResumeReviewSection.tsx
+++ /dev/null
@@ -1,311 +0,0 @@
-"use client";
-
-import { Sparkles, CheckCircle, XCircle, Loader2, X } from "lucide-react";
-import { Button } from "../ui/button";
-import {
- Sheet,
- SheetClose,
- SheetContent,
- SheetPortal,
- SheetTitle,
- SheetTrigger,
-} from "../ui/sheet";
-import Loading from "../Loading";
-import { useState, useEffect, useCallback, useRef } from "react";
-import { useSheetAutoScroll } from "@/hooks/useSheetAutoScroll";
-import { useRightRailPanel } from "@/context/RightRailContext";
-import { useResizablePanel } from "@/hooks/useResizablePanel";
-import { APP_CONSTANTS } from "@/lib/constants";
-import { toastSuccess, toastError } from "@/lib/toast";
-import { Resume } from "@/models/profile.model";
-import { AiModel, AiProvider, defaultModel } from "@/models/ai.model";
-import { AiResumeReviewResponseContent } from "./AiResumeReviewResponseContent";
-import {
- streamResumeReview,
- type ResumeReviewResult,
-} from "@/utils/streamResumeReview.utils";
-import { checkOllamaConnection } from "@/utils/ai.utils";
-import { getUserSettings } from "@/actions/userSettings.actions";
-import { saveResumeReviewResult } from "@/actions/profile.actions";
-import { useSlowResponseWarning } from "@/hooks/useSlowResponseWarning";
-import { SlowResponseWarning } from "../common/SlowResponseWarning";
-import {
- hasMinResumeSections,
- warnInsufficientResumeSections,
-} from "@/utils/resumeSections.utils";
-
-interface AiSectionProps {
- resume: Resume;
- onReviewSaved?: (reviewData: string) => void;
-}
-
-const AiResumeReviewSection = ({ resume, onReviewSaved }: AiSectionProps) => {
- const [aISectionOpen, setAiSectionOpen] = useState(false);
- const [ollamaConnected, setOllamaConnected] = useState<boolean | null>(null);
- const [connectionError, setConnectionError] = useState<string>("");
- const [selectedModel, setSelectedModel] = useState<AiModel>(defaultModel);
- const [isLoadingSettings, setIsLoadingSettings] = useState(false);
- const { claim, release } = useRightRailPanel("resume-review");
-
- const checkConnectionStatus = useCallback(async (provider: AiProvider) => {
- setOllamaConnected(null);
- setConnectionError("");
- const result = await checkOllamaConnection(provider);
- if (result.isConnected) {
- setOllamaConnected(true);
- } else {
- setOllamaConnected(false);
- setConnectionError(result.error || "Ollama is not reachable.");
- }
- }, []);
-
- useEffect(() => {
- if (!aISectionOpen) return;
- const fetchSettings = async () => {
- try {
- const result = await getUserSettings();
- if (result.success && result.data?.settings?.ai) {
- const aiSettings = result.data.settings.ai;
- const model: AiModel = {
- provider: aiSettings.provider || defaultModel.provider,
- model: aiSettings.model,
- };
- setSelectedModel(model);
- // Only check Ollama connectivity once we know the actual provider
- if (model.provider === "ollama") {
- await checkConnectionStatus(model.provider);
- }
- }
- } catch (error) {
- console.error("Error fetching AI settings:", error);
- } finally {
- setIsLoadingSettings(false);
- }
- };
- fetchSettings();
- }, [aISectionOpen, checkConnectionStatus]);
-
- const [result, setResult] = useState<ResumeReviewResult | undefined>();
- const [isLoading, setIsLoading] = useState(false);
- const abortRef = useRef<AbortController | null>(null);
- const { scrollAnchorRef, handleSheetScroll, resetScroll } =
- useSheetAutoScroll(isLoading, result);
- const { width, handleMouseDown } = useResizablePanel("ai-panel-width");
-
- const stop = useCallback(() => {
- abortRef.current?.abort();
- abortRef.current = null;
- setIsLoading(false);
- }, []);
-
- const saveReview = useCallback(
- (reviewResult: ResumeReviewResult) => {
- const scores = reviewResult.scores;
- if (!scores) return;
-
- const reviewData = JSON.stringify({
- overall: scores.overall,
- impact: scores.impact,
- clarity: scores.clarity,
- atsCompatibility: scores.atsCompatibility,
- body: reviewResult.body,
- reviewedAt: new Date().toISOString(),
- provider: selectedModel.provider,
- model: selectedModel.model,
- });
-
- saveResumeReviewResult(resume.id!, reviewData).then((res) => {
- if (res?.success) {
- onReviewSaved?.(reviewData);
- toastSuccess("Review saved");
- } else {
- toastError(res?.message || "Failed to save review");
- }
- });
- },
- [resume.id, onReviewSaved, selectedModel.provider, selectedModel.model],
- );
-
- const getResumeReview = async () => {
- if (!resume || !hasMinResumeSections(resume.ResumeSections?.length)) {
- warnInsufficientResumeSections(
- "running a review",
- "e.g. Summary and Experience",
- );
- return;
- }
-
- const controller = new AbortController();
- abortRef.current = controller;
- resetScroll();
- setResult(undefined);
- setIsLoading(true);
-
- try {
- const reviewResult = await streamResumeReview({
- resumeId: resume.id!,
- selectedModel,
- signal: controller.signal,
- onUpdate: setResult,
- });
- if (controller.signal.aborted) return;
- saveReview(reviewResult);
- } catch (err) {
- // Aborting (e.g. closing the sheet) is expected — don't toast.
- if (controller.signal.aborted) return;
- toastError(
- err instanceof Error ? err.message : "Failed to get AI review",
- );
- } finally {
- if (abortRef.current === controller) abortRef.current = null;
- setIsLoading(false);
- }
- };
-
- const triggerSheetChange = (openState: boolean) => {
- setAiSectionOpen(openState);
- if (openState) claim();
- else release();
- if (!openState && isLoading) {
- stop();
- }
- };
-
- // Check if we have any content to show
- const hasContent = !!(result && (result.scores || result.body));
-
- const showSlowWarning = useSlowResponseWarning(isLoading, !!hasContent);
-
- // Status icon for the terminal header bar
- const statusIcon =
- selectedModel.provider === "ollama" ? (
- ollamaConnected === null ? (
- <Loader2 className="h-3.5 w-3.5 shrink-0 animate-spin text-muted-foreground" />
- ) : ollamaConnected === true ? (
- <CheckCircle className="h-3.5 w-3.5 shrink-0 text-green-500" />
- ) : (
- <XCircle className="h-3.5 w-3.5 shrink-0 text-destructive" />
- )
- ) : (
- <Sparkles className="h-3.5 w-3.5 shrink-0 text-muted-foreground" />
- );
-
- const providerLabel =
- selectedModel.provider.charAt(0).toUpperCase() +
- selectedModel.provider.slice(1);
-
- return (
- <Sheet open={aISectionOpen} onOpenChange={triggerSheetChange}>
- <div className="ml-2">
- <SheetTrigger asChild>
- <Button
- size="sm"
- variant="outline"
- className="h-8 gap-1 cursor-pointer"
- onClick={() => triggerSheetChange(true)}
- disabled={isLoading || isLoadingSettings}
- >
- <Sparkles className="h-3.5 w-3.5" />
- <span className="sr-only sm:not-sr-only sm:whitespace-nowrap">
- Review
- </span>
- </Button>
- </SheetTrigger>
- </div>
- <SheetPortal>
- <SheetContent
- className="flex flex-col p-0 overflow-hidden [&>button:last-child]:hidden"
- style={{
- width: `${width}px`,
- maxWidth: `${APP_CONSTANTS.RESIZABLE_PANEL_MAX_WIDTH_RATIO * 100}vw`,
- }}
- >
- {/* VS Code-style drag handle on left edge */}
- <div
- className="absolute left-0 top-0 h-full w-1 cursor-col-resize z-10 group"
- onMouseDown={handleMouseDown}
- >
- <div className="h-full w-px bg-transparent group-hover:bg-primary/50 transition-colors" />
- </div>
- {/* Terminal-style tab bar — always visible */}
- <div className="flex items-center gap-3 px-4 py-2.5 border-b bg-muted/20 shrink-0">
- <SheetTitle className="text-[11px] font-bold tracking-[0.15em] uppercase text-foreground leading-none shrink-0 m-0">
- AI REVIEW
- </SheetTitle>
- <span className="text-muted-foreground/30 text-xs select-none">
- ···
- </span>
- <div className="flex items-center gap-1.5 min-w-0">
- {statusIcon}
- <span className="text-xs text-muted-foreground font-mono truncate">
- {selectedModel.model
- ? `${providerLabel} / ${selectedModel.model}`
- : providerLabel}
- </span>
- </div>
- <SheetClose asChild>
- <Button
- variant="ghost"
- size="icon"
- className="h-6 w-6 ml-auto shrink-0 rounded-sm opacity-70 hover:opacity-100"
- >
- <X className="h-3.5 w-3.5" />
- </Button>
- </SheetClose>
- </div>
-
- <div
- className="flex-1 overflow-y-auto px-6 pt-4 pb-6"
- onScroll={handleSheetScroll}
- >
- {selectedModel.provider === "ollama" &&
- ollamaConnected === false &&
- connectionError && (
- <p className="text-xs text-red-600">{connectionError}</p>
- )}
-
- {!isLoading && (
- <div
- className={`flex justify-center items-center${!hasContent ? " min-h-[calc(100dvh-9rem)]" : " py-2"}`}
- >
- <Button
- size="sm"
- variant="outline"
- className="h-8 gap-1 cursor-pointer"
- onClick={getResumeReview}
- disabled={
- isLoading ||
- (selectedModel.provider === "ollama" &&
- ollamaConnected === false)
- }
- >
- <Sparkles className="h-3.5 w-3.5" />
- <span className="sr-only sm:not-sr-only sm:whitespace-nowrap">
- Generate AI Review
- </span>
- </Button>
- </div>
- )}
-
- {isLoading && !hasContent ? (
- <div className="flex items-center flex-col mt-4">
- <Loading />
- <div className="mt-2">Analyzing resume...</div>
- {showSlowWarning && <SlowResponseWarning />}
- </div>
- ) : (
- <AiResumeReviewResponseContent
- scores={result?.scores}
- body={result?.body}
- isStreaming={isLoading}
- />
- )}
- <div ref={scrollAnchorRef} />
- </div>
- </SheetContent>
- </SheetPortal>
- </Sheet>
- );
-};
-
-export default AiResumeReviewSection;
diff --git a/src/components/profile/ResumeContainer.tsx b/src/components/profile/ResumeContainer.tsx
index 1f14679..b989b8d 100644
--- a/src/components/profile/ResumeContainer.tsx
+++ b/src/components/profile/ResumeContainer.tsx
@@ -19,8 +19,8 @@ import ExperienceCard from "./ExperienceCard";
import EducationCard from "./EducationCard";
import CertificationCard from "./CertificationCard";
import SkillsSectionCard from "./SkillsSectionCard";
-import AiResumeReviewSection from "./AiResumeReviewSection";
import { ReviewDetails } from "./ReviewDetails";
+import { useAgentChat } from "@/components/agent/AgentChatProvider";
import { DownloadFileButton } from "./DownloadFileButton";
import type { ResumeReviewData } from "@/models/ai.schemas";
import {
@@ -361,20 +361,15 @@ function ResumeContainer({
const goBack = () => router.back();
const isDefault = !!resume?.id && resume.id === defaultResumeId;
const [setDefaultConfirmOpen, setSetDefaultConfirmOpen] = useState(false);
- const [currentReviewData, setCurrentReviewData] = useState(
- resume.reviewData,
- );
+ const { open: openChat, prefillComposer } = useAgentChat();
const parsedReviewData = useMemo(() => {
- if (!currentReviewData) return null;
+ if (!resume.reviewData) return null;
try {
- return JSON.parse(currentReviewData) as ResumeReviewData;
+ return JSON.parse(resume.reviewData) as ResumeReviewData;
} catch {
return null;
}
- }, [currentReviewData]);
- const handleReviewSaved = useCallback((reviewData: string) => {
- setCurrentReviewData(reviewData);
- }, []);
+ }, [resume.reviewData]);
const resumeSectionRef = useRef<AddResumeSectionRef>(null);
const [isExporting, setIsExporting] = useState(false);
const [pendingPdf, setPendingPdf] = useState<{
@@ -772,10 +767,20 @@ function ResumeContainer({
</CardDescription>
<div className="flex items-center gap-2 flex-wrap lg:justify-end">
<AddResumeSection resume={resume} ref={resumeSectionRef} />
- <AiResumeReviewSection
- resume={resume}
- onReviewSaved={handleReviewSaved}
- />
+ <Button
+ className="h-8 gap-1 cursor-pointer"
+ onClick={() => {
+ prefillComposer(`Review ${title}`);
+ openChat();
+ }}
+ size="sm"
+ variant="outline"
+ >
+ <Sparkles className="h-3.5 w-3.5" />
+ <span className="sr-only sm:not-sr-only sm:whitespace-nowrap">
+ Review
+ </span>
+ </Button>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button size="sm" variant="outline">
diff --git a/src/utils/streamResumeReview.utils.ts b/src/utils/streamResumeReview.utils.ts
deleted file mode 100644
index f00021a..0000000
--- a/src/utils/streamResumeReview.utils.ts
+++ /dev/null
@@ -1,69 +0,0 @@
-import { AiModel } from "@/models/ai.model";
-import {
- parseResumeReview,
- type ResumeReviewResult,
-} from "@/lib/ai/resumeReview/parse";
-
-export type { ResumeReviewResult } from "@/lib/ai/resumeReview/parse";
-
-type StreamResumeReviewArgs = {
- resumeId: string;
- selectedModel: AiModel;
- // Called on each chunk with the parsed-so-far result for progressive render.
- onUpdate?: (result: ResumeReviewResult) => void;
- signal?: AbortSignal;
-};
-
-// Consumes the plain-text stream from /api/ai/resume/review and returns the
-// parsed scores + markdown body. Salvages whatever arrived if the stream ends
-// abnormally.
-export async function streamResumeReview({
- resumeId,
- selectedModel,
- onUpdate,
- signal,
-}: StreamResumeReviewArgs): Promise<ResumeReviewResult> {
- const res = await fetch("/api/ai/resume/review", {
- method: "POST",
- headers: { "Content-Type": "application/json" },
- body: JSON.stringify({ selectedModel, resumeId }),
- signal,
- });
-
- // Pre-generation failures (auth, rate limit, preprocessing) still return JSON.
- if (!res.ok || !res.body) {
- let message = "Failed to get AI review.";
- try {
- const err = await res.json();
- if (err?.error) message = err.error;
- } catch {
- // Non-JSON error body — keep the default message.
- }
- throw new Error(message);
- }
-
- const reader = res.body.getReader();
- const decoder = new TextDecoder();
- let raw = "";
-
- try {
- while (true) {
- const { done, value } = await reader.read();
- if (done) break;
- raw += decoder.decode(value, { stream: true });
- onUpdate?.(parseResumeReview(raw));
- }
- } catch (err) {
- // Abnormal end (abort / incomplete chunked encoding): keep what we have.
- if (!raw) throw err;
- }
-
- const final = parseResumeReview(raw);
- if (!final.body && !final.scores) {
- throw new Error(
- "The AI service returned no data. Please ensure it is running and try again.",
- );
- }
- onUpdate?.(final);
- return final;
-}