Job application tracker and AI-powered job search assistant. Helps job seekers manage their search journey with AI resume review, job matching, task logging, and application analytics, all while keeping your data private.
TypeScript ai-agentai-resume-analyzerapplication-trackerapplication-tracking-systematscareerjob-applicationjob-automationjob-huntingjob-searchjob-seeker-toolsjob-trackerjob-trackingjobsearchjobseekersmcpollamaresumeresume-reviewself-hosted
feat: Enhance job-related tests and components to include total job counts and improve validation handling
Khuram Niazd82b0a1af050
diff --git a/__tests__/company.actions.spec.ts b/__tests__/company.actions.spec.tsindex 1b2e9e6..629a5d8 100644--- a/__tests__/company.actions.spec.ts+++ b/__tests__/company.actions.spec.ts@@ -115,7 +115,7 @@ describe("Company Actions", () => {const expectedData = mockData.map((c) => ({...c,- _count: { jobsRejected: 0 },+ _count: { jobsRejected: 0, jobsTotal: 0 },}));expect(result).toEqual({ data: expectedData, total: mockTotal });expect(prisma.company.findMany).toHaveBeenCalledWith({diff --git a/__tests__/jobLocation.actions.spec.ts b/__tests__/jobLocation.actions.spec.tsindex 34080cb..1b3267e 100644--- a/__tests__/jobLocation.actions.spec.ts+++ b/__tests__/jobLocation.actions.spec.ts@@ -23,6 +23,7 @@ vi.mock("@prisma/client", () => {},job: {count: vi.fn(),+ groupBy: vi.fn(),},};return { PrismaClient: vi.fn(function() { return mPrismaClient; }) };@@ -113,10 +114,15 @@ describe("Job Location Actions", () => {];(prisma.location.findMany as any).mockResolvedValue(mockData);(prisma.location.count as any).mockResolvedValue(1);+ (prisma.job.groupBy as any).mockResolvedValue([]);const result = await getJobLocationsList(1, 10, "applied");- expect(result).toEqual({ data: mockData, total: 1 });+ const expectedData = mockData.map((l) => ({+ ...l,+ _count: { jobsTotal: 0 },+ }));+ expect(result).toEqual({ data: expectedData, total: 1 });expect(prisma.location.findMany).toHaveBeenCalledWith({where: { createdBy: mockUser.id },skip: 0,diff --git a/__tests__/jobtitle.actions.spec.ts b/__tests__/jobtitle.actions.spec.tsindex 79e983f..63a8931 100644--- a/__tests__/jobtitle.actions.spec.ts+++ b/__tests__/jobtitle.actions.spec.ts@@ -22,6 +22,7 @@ vi.mock("@prisma/client", () => {},job: {count: vi.fn(),+ groupBy: vi.fn(),},};return { PrismaClient: vi.fn(function() { return mPrismaClient; }) };@@ -112,10 +113,15 @@ describe("Job Title Actions", () => {];(prisma.jobTitle.findMany as any).mockResolvedValue(mockData);(prisma.jobTitle.count as any).mockResolvedValue(1);+ (prisma.job.groupBy as any).mockResolvedValue([]);const result = await getJobTitleList(1, 10, "applied");- expect(result).toEqual({ data: mockData, total: 1 });+ const expectedData = mockData.map((t) => ({+ ...t,+ _count: { jobsTotal: 0 },+ }));+ expect(result).toEqual({ data: expectedData, total: 1 });expect(prisma.jobTitle.findMany).toHaveBeenCalledWith({where: { createdBy: mockUser.id },skip: 0,diff --git a/e2e/add-job.spec.ts b/e2e/add-job.spec.tsindex c14a05f..1e304c5 100644--- a/e2e/add-job.spec.ts+++ b/e2e/add-job.spec.ts@@ -38,9 +38,9 @@ test.describe("Add New Job", () => {.locator("div").fill("test description edited");await page.getByTestId("save-job-btn").click();- await expect(page.getByRole("status").first()).toContainText(- /Job has been updated/,- );+ // Dialog closes only on a successful save; assert that instead of the+ // toast, which auto-dismisses and can vanish before the poll under load.+ await expect(page.getByTestId("add-job-dialog-title")).not.toBeVisible();});test("should delete a job", async ({ page, cleanup }) => {@@ -58,9 +58,6 @@ test.describe("Add New Job", () => {await page.getByRole("menuitem", { name: "Delete" }).click();await page.getByRole("button", { name: "Delete" }).click();- await expect(page.getByRole("status").first()).toContainText(- /Job has been deleted/,- );await expect(page.getByRole("row", { name: jobText })).not.toBeVisible();});@@ -201,9 +198,161 @@ test.describe("Add New Job", () => {.fill("test note content");await noteContainer.getByRole("button", { name: "Save" }).click();- await expect(page.getByRole("status").first()).toContainText(- /Note added successfully/,- );await expect(page.getByText("test note content")).toBeVisible();});++ test("should show validation errors when required fields are missing", async ({+ page,+ }) => {+ // No cleanup needed: submission fails validation, so nothing is created.+ await page.getByRole("button", { name: "New Job" }).click();+ await expect(page.getByTestId("add-job-dialog-title")).toBeVisible();++ await page.getByTestId("save-job-btn").click();++ await expect(page.getByText("Job title is required.")).toBeVisible();+ await expect(page.getByText("Company name is required.")).toBeVisible();+ await expect(page.getByText("Location is required.")).toBeVisible();+ await expect(page.getByText("Source is required.")).toBeVisible();+ await expect(+ page.getByText("Job description is required."),+ ).toBeVisible();+ });++ test("should change job status from the jobs table actions menu", async ({+ page,+ cleanup,+ }) => {+ const jobText = uniqueName("developer test title status menu");+ await createNewJob(page, jobText, cleanup);+ await expect(page.getByRole("row", { name: jobText }).first()).toBeVisible();++ await page+ .getByRole("row", { name: jobText })+ .getByTestId("job-actions-menu-btn")+ .first()+ .click();+ // Radix submenus open on hover; clicking the subtrigger can toggle it+ // shut mid-open, so hover to open then wait for the item.+ await page.getByRole("menuitem", { name: "Change status" }).hover();+ const interviewItem = page.getByRole("menuitem", { name: "Interview" });+ await expect(interviewItem).toBeVisible();+ await interviewItem.click();++ // Assert on the persistent status cell rather than the toast, which+ // auto-dismisses after 5s and can vanish before the poll under load.+ await expect(+ page.getByRole("row", { name: jobText }).getByText("Interview"),+ ).toBeVisible();+ });++ test("should reuse an existing company when creating a second job", async ({+ page,+ cleanup,+ }) => {+ const firstJobText = uniqueName("developer test title reuse first");+ const secondJobText = uniqueName("developer test title reuse second");+ const sharedCompany = `company ${firstJobText.replace(/\s+/g, "-")}`;++ await createNewJob(page, firstJobText, cleanup);+ await expect(+ page.getByRole("row", { name: firstJobText }).first(),+ ).toBeVisible();++ await createNewJob(page, secondJobText, cleanup, {+ company: sharedCompany,+ });+ await expect(+ page.getByRole("row", { name: secondJobText }).first(),+ ).toBeVisible();++ await expect(+ page.getByRole("row", { name: firstJobText }).getByText(sharedCompany),+ ).toBeVisible();+ await expect(+ page.getByRole("row", { name: secondJobText }).getByText(sharedCompany),+ ).toBeVisible();+ });++ test("should find a job via the jobs search box", async ({+ page,+ cleanup,+ }) => {+ const jobText = uniqueName("developer test title searchable");+ await createNewJob(page, jobText, cleanup);+ await expect(page.getByRole("row", { name: jobText }).first()).toBeVisible();++ const searchInput = page.getByPlaceholder("Search jobs...");+ await searchInput.fill(jobText);+ await expect(page.getByRole("row", { name: jobText }).first()).toBeVisible();++ await searchInput.fill(uniqueName("no such job matches this"));+ await expect(page.getByRole("row", { name: jobText })).not.toBeVisible();+ });++ test("should filter the jobs list by status", async ({ page, cleanup }) => {+ const jobText = uniqueName("developer test title filter");+ await createNewJob(page, jobText, cleanup);+ await expect(page.getByRole("row", { name: jobText }).first()).toBeVisible();++ await page.getByTestId("job-filter-select").click();+ await page.getByRole("option", { name: "Rejected", exact: true }).click();+ await expect(page.getByRole("row", { name: jobText })).not.toBeVisible();++ await page.getByTestId("job-filter-select").click();+ await page.getByRole("option", { name: "Draft", exact: true }).click();+ await expect(page.getByRole("row", { name: jobText }).first()).toBeVisible();+ });++ test("should navigate to job details from the actions menu", async ({+ page,+ cleanup,+ }) => {+ const jobText = uniqueName("developer test title view details");+ const jobId = await createNewJob(page, jobText, cleanup);+ await expect(page.getByRole("row", { name: jobText }).first()).toBeVisible();++ await page+ .getByRole("row", { name: jobText })+ .getByTestId("job-actions-menu-btn")+ .first()+ .click();+ await page.getByRole("menuitem", { name: "View Details" }).click();++ await expect(page).toHaveURL(new RegExp(`/dashboard/myjobs/${jobId}$`));+ await expect(page.getByText(jobText).first()).toBeVisible();+ });++ test("should add and persist a skill tag on a job", async ({+ page,+ cleanup,+ }) => {+ const jobText = uniqueName("developer test title tag");+ const tagText = uniqueName("skill tag");+ cleanup.tag(tagText);++ await createNewJob(page, jobText, cleanup, {+ beforeSave: async (page) => {+ await page+ .getByRole("combobox", { name: "Search or add a skill..." })+ .click();+ await page.getByPlaceholder("Type a skill...").fill(tagText);+ await page.getByText(`Create "${tagText}"`).click();+ // Wait for the create server action to resolve and the field to+ // update (the badge only renders once the tag id lands in form+ // state) before letting createNewJob click Save.+ await expect(page.getByText(tagText, { exact: true })).toBeVisible();+ },+ });+ await expect(page.getByRole("row", { name: jobText }).first()).toBeVisible();++ await page+ .getByRole("row", { name: jobText })+ .getByTestId("job-actions-menu-btn")+ .first()+ .click();+ await page.getByRole("menuitem", { name: "Edit Job" }).click();+ await expect(page.getByTestId("add-job-dialog-title")).toBeVisible();+ await expect(page.getByText(tagText, { exact: true })).toBeVisible();+ });});diff --git a/e2e/fixtures.ts b/e2e/fixtures.tsindex 2a93925..0edda8c 100644--- a/e2e/fixtures.ts+++ b/e2e/fixtures.ts@@ -52,11 +52,13 @@ export async function createNewJob(options?: {skipUrl?: boolean;beforeSave?: (page: Page) => Promise<void>;+ company?: string;+ location?: string;},): Promise<string> {const suffix = jobText.replace(/\s+/g, "-");- const companyText = `company ${suffix}`;- const locationText = `location ${suffix}`;+ const companyText = options?.company ?? `company ${suffix}`;+ const locationText = options?.location ?? `location ${suffix}`;await page.getByRole("button", { name: "New Job" }).click();await expect(page).toHaveURL(/\/dashboard\/myjobs/);@@ -120,6 +122,7 @@ export type CleanupRegistry = {company: (name: string) => void;location: (name: string) => void;activityType: (name: string) => void;+ tag: (name: string) => void;};type Fixtures = {@@ -142,6 +145,7 @@ export const test = base.extend<Fixtures>({const companies: string[] = [];const locations: string[] = [];const activityTypes: string[] = [];+ const tags: string[] = [];await use({job: (id) => jobIds.push(id),resume: (title) => resumes.push(title),@@ -150,6 +154,7 @@ export const test = base.extend<Fixtures>({company: (name) => companies.push(name),location: (name) => locations.push(name),activityType: (name) => activityTypes.push(name),+ tag: (name) => tags.push(name),});// page.request carries the session cookie; page is still alive here// because cleanup tears down before the page fixture.@@ -162,6 +167,7 @@ export const test = base.extend<Fixtures>({companies,locations,activityTypes,+ tags,},});if (!res.ok()) {diff --git a/e2e/profile.spec.ts b/e2e/profile.spec.tsindex dc6bdf1..6c43724 100644--- a/e2e/profile.spec.ts+++ b/e2e/profile.spec.ts@@ -24,14 +24,11 @@ test.describe("Profile page", () => {const resumeTitle = uniqueName("Test Resume");await page.getByRole("link", { name: "Profile" }).click();await createResume(page, resumeTitle, cleanup);- await expect(page.getByRole("status").first()).toContainText(- /Resume title has been created/,- );await expect(page.locator("tbody")).toContainText(resumeTitle);await deleteResume(page, resumeTitle);- await expect(page.getByRole("status").first()).toContainText(- /Resume has been deleted successfully/,- );+ // Assert on the persistent outcome (row removed) rather than the toast,+ // which auto-dismisses after 5s and can vanish before the poll under load.+ await expect(page.locator("tbody")).not.toContainText(resumeTitle);});test("should edit the resume title", async ({ page, baseURL, cleanup }) => {@@ -53,9 +50,6 @@ test.describe("Profile page", () => {await page.getByRole("menuitem", { name: /Edit Resume Title/ }).click();await page.getByPlaceholder("Ex: Full Stack Developer").fill(editedTitle);await page.getByRole("dialog").getByRole("button", { name: "Save" }).click();- await expect(page.getByRole("status").first()).toContainText(- /Resume title has been updated/,- );await expect(page.locator("tbody")).toContainText(editedTitle);});@@ -87,9 +81,6 @@ test.describe("Profile page", () => {await page.getByLabel("Address").click();await page.getByLabel("Address").fill("Calgary");await page.getByRole("button", { name: "Save" }).click();- await expect(page.getByRole("status").first()).toContainText(- /Contact Info has been created/,- );await expect(page.getByRole("heading", { name: "John Doe" })).toBeVisible();});@@ -112,9 +103,6 @@ test.describe("Profile page", () => {await page.getByRole("button", { name: "Save" }).click();await expect(page.getByRole("heading", { name: "Summary" })).toBeVisible();await expect(page.getByText("this is test summary")).toBeVisible();- await expect(page.getByRole("status").first()).toContainText(- /Summary has been created/,- );});test("should add resume work experience section", async ({@@ -126,9 +114,6 @@ test.describe("Profile page", () => {await page.getByRole("link", { name: "Profile" }).click();await createResume(page, resumeTitle, cleanup);await addExperience(page, resumeTitle, jobText, cleanup);- await expect(page.getByRole("status").first()).toContainText(- /Experience has been added/,- );await expect(page.getByRole("heading", { name: jobText }).first(),).toBeVisible();@@ -143,9 +128,6 @@ test.describe("Profile page", () => {await page.getByRole("link", { name: "Profile" }).click();await createResume(page, resumeTitle, cleanup);await addExperience(page, resumeTitle, jobText, cleanup);- await expect(page.getByRole("status").first()).toContainText(- /Experience has been added/,- );await expect(page.getByRole("heading", { name: jobText }).first(),).toBeVisible();@@ -216,9 +198,6 @@ test.describe("Profile page", () => {await page.locator("div:nth-child(2) > .tiptap").click();await page.locator("div:nth-child(2) > .tiptap").fill("test description");await page.getByRole("button", { name: "Save" }).click();- await expect(page.getByRole("status").first()).toContainText(- /Education has been added/,- );await expect(page.getByRole("heading", { name: "test school" }).first(),).toBeVisible();diff --git a/e2e/tasks.spec.ts b/e2e/tasks.spec.tsindex c2f4ed8..c101e5d 100644--- a/e2e/tasks.spec.ts+++ b/e2e/tasks.spec.ts@@ -129,9 +129,9 @@ test.describe("Tasks Management", () => {await deleteTask(page, deleteTaskTitle);- await expect(page.getByRole("status").first()).toContainText(- /Task has been deleted/,- );+ await expect(+ page.getByRole("row", { name: new RegExp(deleteTaskTitle, "i") }),+ ).not.toBeVisible();});test("should change task status via dropdown", async ({ page, cleanup }) => {@@ -147,16 +147,22 @@ test.describe("Tasks Management", () => {.getByTestId("task-actions-menu-btn").first().click({ force: true });- await page- .getByRole("menuitem", { name: "Change Status" })- .click({ force: true });- await page- .getByRole("menuitem", { name: "Needs Attention" })- .click({ force: true });+ // Radix submenus open on hover; clicking the subtrigger can toggle it+ // shut mid-open, so hover to open then wait for the item.+ await page.getByRole("menuitem", { name: "Change Status" }).hover();+ const needsAttentionItem = page.getByRole("menuitem", {+ name: "Needs Attention",+ });+ await expect(needsAttentionItem).toBeVisible();+ await needsAttentionItem.click();- await expect(page.getByRole("status").first()).toContainText(- /Task status updated/,- );+ // Assert on the persistent status badge rather than the toast, which+ // auto-dismisses after 5s and can vanish before the poll under load.+ await expect(+ page+ .getByRole("row", { name: new RegExp(statusTaskTitle, "i") })+ .getByText("Needs Attention"),+ ).toBeVisible();});test("should filter tasks by status", async ({ page }) => {@@ -205,9 +211,11 @@ test.describe("Tasks Management", () => {});await completeBtn.click({ force: true });- await expect(page.getByRole("status").first()).toContainText(- /Task status updated/,- );+ // The button's label flips on success; assert that instead of the toast,+ // which auto-dismisses after 5s and can vanish before the poll under load.+ await expect(+ taskRow.getByRole("button", { name: "Mark as in progress" }),+ ).toBeVisible();});test.describe.serial("Task Activity Integration", () => {@@ -255,9 +263,6 @@ test.describe("Tasks Management", () => {.getByTestId("task-start-activity-btn").click({ force: true });- await expect(page.getByRole("status").first()).toContainText(- /Activity started from task/,- );await expect(page).toHaveURL(/\/dashboard\/activities/);// Stop the running activity (the linked activity row is removed by the@@ -288,9 +293,6 @@ test.describe("Tasks Management", () => {await taskRow.getByTestId("task-start-activity-btn").click({ force: true });- await expect(page.getByRole("status").first()).toContainText(- /Activity started from task/,- );await expect(page).toHaveURL(/\/dashboard\/activities/);// Stop the activity so we can test the linked state@@ -341,9 +343,11 @@ test.describe("Tasks Management", () => {await taskRow.getByRole("button", { name: "Mark as complete" }).click({ force: true });- await expect(page.getByRole("status").first()).toContainText(- /Task status updated/,- );+ // Button label flips on success; assert that rather than the transient+ // toast so the following steps run against a committed status.+ await expect(+ taskRow.getByRole("button", { name: "Mark as in progress" }),+ ).toBeVisible();// Add Complete status to filter to see completed tasksawait pagediff --git a/src/app/api/test/cleanup/route.ts b/src/app/api/test/cleanup/route.tsindex c6e48e5..79c61e3 100644--- a/src/app/api/test/cleanup/route.ts+++ b/src/app/api/test/cleanup/route.ts@@ -26,6 +26,7 @@ export async function POST(req: NextRequest) {companies = [],locations = [],activityTypes = [],+ tags = [],}: {jobIds?: string[];resumes?: string[];@@ -34,6 +35,7 @@ export async function POST(req: NextRequest) {companies?: string[];locations?: string[];activityTypes?: string[];+ tags?: string[];} = await req.json();// Delete jobs, resumes and tasks first (they/their sections reference the@@ -70,10 +72,31 @@ export async function POST(req: NextRequest) {await deleteLibraryByName("company", companies, userId);await deleteLibraryByName("location", locations, userId);await deleteLibraryByName("activityType", activityTypes, userId);+ await deleteTagsByName(tags, userId);return NextResponse.json({ success: true });}+// Tags are shared across jobs/questions/skills (not a single ref model like+// the Library types above), so they get their own reference count + delete.+async function deleteTagsByName(names: string[], userId: string) {+ for (const name of names) {+ const value = name.trim().toLowerCase();+ if (!value) continue;+ const tag = await prisma.tag.findFirst({+ where: { value, createdBy: userId },+ select: {+ id: true,+ _count: { select: { jobs: true, questions: true, skills: true } },+ },+ });+ if (!tag) continue;+ const { jobs, questions, skills } = tag._count;+ if (jobs + questions + skills > 0) continue;+ await prisma.tag.delete({ where: { id: tag.id } });+ }+}+type RefModel = "jobTitle" | "company" | "location" | "activityType";// Count every place a Library row can still be referenced from, so we neverdiff --git a/src/components/myjobs/JobsContainer.tsx b/src/components/myjobs/JobsContainer.tsxindex 1e426d7..4d878a1 100644--- a/src/components/myjobs/JobsContainer.tsx+++ b/src/components/myjobs/JobsContainer.tsx@@ -405,7 +405,10 @@ function JobsContainer({placeholder="Search jobs..."/><Select value={filterKey} onValueChange={onFilterChange}>- <SelectTrigger className="w-[120px] h-8">+ <SelectTrigger+ className="w-[120px] h-8"+ data-testid="job-filter-select"+ ><ListFilter className="h-3.5 w-3.5" /><SelectValue placeholder="Filter" /></SelectTrigger>diff --git a/src/components/myjobs/TagInput.tsx b/src/components/myjobs/TagInput.tsxindex e92129c..a477a32 100644--- a/src/components/myjobs/TagInput.tsx+++ b/src/components/myjobs/TagInput.tsx@@ -123,6 +123,7 @@ export function TagInput({<Buttonvariant="outline"role="combobox"+ aria-label={placeholder}aria-expanded={open}className={cn("w-full justify-between font-normal",