Skip to content

Job application tracker and AI-powered job search assistant. Helps job seekers manage their search journey with AI resume review, job matching, task logging, and application analytics, all while keeping your data private.

refactor: dedupe no-resumes/pick-a-resume JSX in AgentResultCard renderers

Khuram Niaze46c20ca8a0e
diff --git a/src/components/agent/AgentResultCard/CoverLetterResult.tsx b/src/components/agent/AgentResultCard/CoverLetterResult.tsx
index 54fba86..7ccae75 100644
--- a/src/components/agent/AgentResultCard/CoverLetterResult.tsx
+++ b/src/components/agent/AgentResultCard/CoverLetterResult.tsx
@@ -2,7 +2,8 @@
import Link from "next/link";
import { AgentMarkdown } from "@/components/agent/AgentMarkdown";
-import { AgentResumePicker } from "@/components/agent/AgentResumePicker";
+import { NoResumesNotice } from "@/components/agent/AgentResultCard/NoResumesNotice";
+import { ResumeSelectionPrompt } from "@/components/agent/AgentResultCard/ResumeSelectionPrompt";
import type { AgentCoverLetterResult } from "@/models/agent.model";
// The letter comes from the tool output, not from the streamed text: the
@@ -27,24 +28,18 @@ export function CoverLetterResult({ output }: { output: AgentCoverLetterResult }
}
if (output.status === "no_resumes") {
- return (
- <p className="text-sm">
- You don&apos;t have any resumes yet — create one on the Profile page.
- </p>
- );
+ return <NoResumesNotice />;
}
if (output.status === "needs_selection") {
return (
- <div className="text-sm">
- <p>Which resume should the letter draw on?</p>
- <AgentResumePicker
- resumes={output.resumes}
- messageFor={(title) =>
- `Write a cover letter for this job using my resume "${title}"`
- }
- />
- </div>
+ <ResumeSelectionPrompt
+ prompt="Which resume should the letter draw on?"
+ resumes={output.resumes}
+ messageFor={(title) =>
+ `Write a cover letter for this job using my resume "${title}"`
+ }
+ />
);
}
diff --git a/src/components/agent/AgentResultCard/GetResumeResult.tsx b/src/components/agent/AgentResultCard/GetResumeResult.tsx
index 63ba828..5496179 100644
--- a/src/components/agent/AgentResultCard/GetResumeResult.tsx
+++ b/src/components/agent/AgentResultCard/GetResumeResult.tsx
@@ -1,17 +1,14 @@
"use client";
-import { AgentResumePicker } from "@/components/agent/AgentResumePicker";
+import { NoResumesNotice } from "@/components/agent/AgentResultCard/NoResumesNotice";
+import { ResumeSelectionPrompt } from "@/components/agent/AgentResultCard/ResumeSelectionPrompt";
import type { AgentGetResumeResult } from "@/models/agent.model";
// The resume text itself is never rendered: the user is about to read the
// review, not the serialization, and the card would be a wall of text.
export function GetResumeResult({ output }: { output: AgentGetResumeResult }) {
if (output.status === "no_resumes") {
- return (
- <p className="text-sm">
- You don&apos;t have any resumes yet — create one on the Profile page.
- </p>
- );
+ return <NoResumesNotice />;
}
if (output.status === "unreadable") {
@@ -23,12 +20,7 @@ export function GetResumeResult({ output }: { output: AgentGetResumeResult }) {
}
if (output.status === "needs_selection") {
- return (
- <div className="text-sm">
- <p>Which resume?</p>
- <AgentResumePicker resumes={output.resumes} />
- </div>
- );
+ return <ResumeSelectionPrompt prompt="Which resume?" resumes={output.resumes} />;
}
const sourceNote =
diff --git a/src/components/agent/AgentResultCard/MatchJobResult.tsx b/src/components/agent/AgentResultCard/MatchJobResult.tsx
index 9833c93..237360c 100644
--- a/src/components/agent/AgentResultCard/MatchJobResult.tsx
+++ b/src/components/agent/AgentResultCard/MatchJobResult.tsx
@@ -1,7 +1,8 @@
"use client";
-import { AgentResumePicker } from "@/components/agent/AgentResumePicker";
import { AgentMatchContent } from "@/components/agent/AgentMatchContent";
+import { NoResumesNotice } from "@/components/agent/AgentResultCard/NoResumesNotice";
+import { ResumeSelectionPrompt } from "@/components/agent/AgentResultCard/ResumeSelectionPrompt";
import type { AgentMatchJobResult } from "@/models/agent.model";
// The score and body come from the tool output, not from parsed prose — the
@@ -18,22 +19,16 @@ export function MatchJobResult({ output }: { output: AgentMatchJobResult }) {
}
if (output.status === "no_resumes") {
- return (
- <p className="text-sm">
- You don&apos;t have any resumes yet — create one on the Profile page.
- </p>
- );
+ return <NoResumesNotice />;
}
if (output.status === "needs_selection") {
return (
- <div className="text-sm">
- <p>Which resume should I match against?</p>
- <AgentResumePicker
- resumes={output.resumes}
- messageFor={(title) => `Match this job against my resume "${title}"`}
- />
- </div>
+ <ResumeSelectionPrompt
+ prompt="Which resume should I match against?"
+ resumes={output.resumes}
+ messageFor={(title) => `Match this job against my resume "${title}"`}
+ />
);
}
diff --git a/src/components/agent/AgentResultCard/NoResumesNotice.tsx b/src/components/agent/AgentResultCard/NoResumesNotice.tsx
new file mode 100644
index 0000000..49bd2e8
--- /dev/null
+++ b/src/components/agent/AgentResultCard/NoResumesNotice.tsx
@@ -0,0 +1,9 @@
+"use client";
+
+export function NoResumesNotice() {
+ return (
+ <p className="text-sm">
+ You don&apos;t have any resumes yet — create one on the Profile page.
+ </p>
+ );
+}
diff --git a/src/components/agent/AgentResultCard/ResumeSelectionPrompt.tsx b/src/components/agent/AgentResultCard/ResumeSelectionPrompt.tsx
new file mode 100644
index 0000000..abb425e
--- /dev/null
+++ b/src/components/agent/AgentResultCard/ResumeSelectionPrompt.tsx
@@ -0,0 +1,20 @@
+"use client";
+
+import { AgentResumePicker } from "@/components/agent/AgentResumePicker";
+
+export function ResumeSelectionPrompt({
+ prompt,
+ resumes,
+ messageFor,
+}: {
+ prompt: string;
+ resumes: { id: string; title: string }[];
+ messageFor?: (title: string) => string;
+}) {
+ return (
+ <div className="text-sm">
+ <p>{prompt}</p>
+ <AgentResumePicker resumes={resumes} messageFor={messageFor} />
+ </div>
+ );
+}
diff --git a/src/components/agent/AgentResultCard/ReviewResumeResult.tsx b/src/components/agent/AgentResultCard/ReviewResumeResult.tsx
index 8a445c6..04c79d8 100644
--- a/src/components/agent/AgentResultCard/ReviewResumeResult.tsx
+++ b/src/components/agent/AgentResultCard/ReviewResumeResult.tsx
@@ -1,7 +1,8 @@
"use client";
-import { AgentResumePicker } from "@/components/agent/AgentResumePicker";
import { AgentReviewContent } from "@/components/agent/AgentReviewContent";
+import { NoResumesNotice } from "@/components/agent/AgentResultCard/NoResumesNotice";
+import { ResumeSelectionPrompt } from "@/components/agent/AgentResultCard/ResumeSelectionPrompt";
import type { AgentReviewResumeResult } from "@/models/agent.model";
// The scores and body come from the tool output, not from parsed prose — the
@@ -9,20 +10,11 @@ import type { AgentReviewResumeResult } from "@/models/agent.model";
// what was saved.
export function ReviewResumeResult({ output }: { output: AgentReviewResumeResult }) {
if (output.status === "no_resumes") {
- return (
- <p className="text-sm">
- You don&apos;t have any resumes yet — create one on the Profile page.
- </p>
- );
+ return <NoResumesNotice />;
}
if (output.status === "needs_selection") {
- return (
- <div className="text-sm">
- <p>Which resume?</p>
- <AgentResumePicker resumes={output.resumes} />
- </div>
- );
+ return <ResumeSelectionPrompt prompt="Which resume?" resumes={output.resumes} />;
}
if (output.status === "unreadable" || output.status === "generation_failed") {