Skip to content

✨ Innovative and open-source visualization application that transforms various data formats, such as JSON, YAML, XML and CSV into interactive graphs.

fix: remove use-long-press dependency from www package and add it to jsoncrack-react package

AykutSarac455fb94196fc
diff --git a/apps/www/package.json b/apps/www/package.json
index 5ab84f4f..9009844d 100644
--- a/apps/www/package.json
+++ b/apps/www/package.json
@@ -45,7 +45,6 @@
"reaflow": "5.4.1",
"shiki": "^4.0.2",
"styled-components": "^6.3.11",
- "use-long-press": "^3.3.0",
"zustand": "^5.0.12"
},
"devDependencies": {
diff --git a/apps/www/src/features/editor/views/GraphView/index.tsx b/apps/www/src/features/editor/views/GraphView/index.tsx
index 87768994..f0a636f9 100644
--- a/apps/www/src/features/editor/views/GraphView/index.tsx
+++ b/apps/www/src/features/editor/views/GraphView/index.tsx
@@ -3,7 +3,6 @@ import { Box } from "@mantine/core";
import styled from "styled-components";
import { JSONCrack } from "jsoncrack-react";
import type { NodeData } from "jsoncrack-react";
-import { useLongPress } from "use-long-press";
import { SUPPORTED_LIMIT } from "../../../../constants/graph";
import useConfig from "../../../../store/useConfig";
import useJson from "../../../../store/useJson";
@@ -18,10 +17,13 @@ const StyledEditorWrapper = styled.div<{ $widget: boolean }>`
width: 100%;
height: 100%;
- .jsoncrack-space,
- .jsoncrack-space:active {
+ .jsoncrack-space {
cursor: url("/assets/cursor.svg"), auto;
}
+
+ .jsoncrack-space:active {
+ cursor: grabbing;
+ }
`;
interface GraphProps {
@@ -38,19 +40,6 @@ export const GraphView = ({ isWidget = false }: GraphProps) => {
const json = useJson(state => state.json);
const setVisible = useModal(state => state.setVisible);
- const callback = React.useCallback(() => {
- const canvas = document.querySelector(".jsoncrack-canvas") as HTMLDivElement | null;
- canvas?.classList.add("dragging");
- }, []);
-
- const bindLongPress = useLongPress(callback, {
- threshold: 150,
- onFinish: () => {
- const canvas = document.querySelector(".jsoncrack-canvas") as HTMLDivElement | null;
- canvas?.classList.remove("dragging");
- },
- });
-
const blurOnClick = React.useCallback(() => {
if ("activeElement" in document) {
(document.activeElement as HTMLElement | null)?.blur();
@@ -76,7 +65,6 @@ export const GraphView = ({ isWidget = false }: GraphProps) => {
$widget={isWidget}
onContextMenu={event => event.preventDefault()}
onClick={blurOnClick}
- {...bindLongPress()}
>
<JSONCrack
key={[direction, gesturesEnabled, rulersEnabled].join("-")}
diff --git a/packages/jsoncrack-react/package.json b/packages/jsoncrack-react/package.json
index 84abb0a3..b98aeff0 100644
--- a/packages/jsoncrack-react/package.json
+++ b/packages/jsoncrack-react/package.json
@@ -47,7 +47,8 @@
"dependencies": {
"jsonc-parser": "^3.3.1",
"react-zoomable-ui": "^0.11.0",
- "reaflow": "5.4.1"
+ "reaflow": "5.4.1",
+ "use-long-press": "^3.3.0"
},
"devDependencies": {
"@eslint/js": "^10.0.1",
diff --git a/packages/jsoncrack-react/src/JSONCrackComponent.tsx b/packages/jsoncrack-react/src/JSONCrackComponent.tsx
index 6c6a2931..8f26c734 100644
--- a/packages/jsoncrack-react/src/JSONCrackComponent.tsx
+++ b/packages/jsoncrack-react/src/JSONCrackComponent.tsx
@@ -5,6 +5,7 @@ import type { ViewPort } from "react-zoomable-ui";
import { Space } from "react-zoomable-ui";
import { Canvas } from "reaflow";
import type { ElkRoot } from "reaflow";
+import { useLongPress } from "use-long-press";
import styles from "./JSONCrackStyles.module.css";
import { Controls } from "./components/Controls";
import { CustomEdge } from "./components/CustomEdge";
@@ -272,6 +273,21 @@ export const JSONCrack = React.forwardRef<JSONCrackRef, JSONCrackProps>(
[centerView, centerOnLayout]
);
+ const onLongPress = React.useCallback(() => {
+ const canvas = containerRef.current?.querySelector(".jsoncrack-canvas") as HTMLElement | null;
+ canvas?.classList.add("dragging");
+ }, []);
+
+ const bindLongPress = useLongPress(onLongPress, {
+ threshold: 150,
+ onFinish: () => {
+ const canvas = containerRef.current?.querySelector(
+ ".jsoncrack-canvas"
+ ) as HTMLElement | null;
+ canvas?.classList.remove("dragging");
+ },
+ });
+
const tooLargeContent = renderNodeLimitExceeded?.(totalNodes, maxRenderableNodes);
const canvasClassName = [styles.canvasWrapper, showGrid ? styles.showGrid : "", className]
.filter(Boolean)
@@ -308,6 +324,7 @@ export const JSONCrack = React.forwardRef<JSONCrackRef, JSONCrackProps>(
className={canvasClassName}
style={canvasStyle}
onContextMenu={event => event.preventDefault()}
+ {...bindLongPress()}
>
{showControls && (
<Controls
diff --git a/packages/jsoncrack-react/src/JSONCrackStyles.module.css b/packages/jsoncrack-react/src/JSONCrackStyles.module.css
index 40329611..ef3354b3 100644
--- a/packages/jsoncrack-react/src/JSONCrackStyles.module.css
+++ b/packages/jsoncrack-react/src/JSONCrackStyles.module.css
@@ -32,8 +32,8 @@
}
.canvasWrapper :global(.dragging),
-.canvasWrapper :global(.dragging button) {
- pointer-events: none;
+.canvasWrapper :global(.dragging *) {
+ pointer-events: none !important;
}
.canvasWrapper :global(text) {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 5e6297d7..89d98c53 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -192,9 +192,6 @@ importers:
styled-components:
specifier: ^6.3.11
- use-long-press:
- specifier: ^3.3.0
- version: 3.3.0([email protected])
zustand:
specifier: ^5.0.12
@@ -265,6 +262,9 @@ importers:
reaflow:
specifier: 5.4.1
+ use-long-press:
+ specifier: ^3.3.0
+ version: 3.3.0([email protected])
devDependencies:
'@eslint/js':
specifier: ^10.0.1