Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix(admin): verify resolved password reset email subjects

Tin0323c8afccd8
diff --git a/packages/email/src/send-email-brand.test.ts b/packages/email/src/send-email-brand.test.ts
index 7ee50eb81..5e3cb0b7f 100644
--- a/packages/email/src/send-email-brand.test.ts
+++ b/packages/email/src/send-email-brand.test.ts
@@ -9,7 +9,11 @@ import {
vi,
} from "vite-plus/test";
import { setBrandNameResolver } from "./brand";
-import { sendMagicLinkEmail, sendNotificationEmail } from "./send-email";
+import {
+ sendMagicLinkEmail,
+ sendNotificationEmail,
+ sendPasswordResetEmail,
+} from "./send-email";
const smtp = vi.hoisted(() => ({ sendMail: vi.fn().mockResolvedValue({}) }));
vi.mock("nodemailer", () => ({ createTransport: () => smtp }));
@@ -59,6 +63,31 @@ describe("email instance name", () => {
);
});
+ it("resolves the password reset subject to a string using one name per send", async () => {
+ const resolveName = vi
+ .fn()
+ .mockResolvedValueOnce("Acme $&")
+ .mockResolvedValueOnce("Other");
+ setBrandNameResolver(resolveName);
+ await sendPasswordResetEmail(
+ (name) => `${name}-Passwort zurücksetzen`,
+ {
+ resetLink: "https://example.test/reset",
+ userName: "Upgrade Kaneo",
+ locale: "de-DE",
+ },
+ );
+ expect(resolveName).toHaveBeenCalledTimes(1);
+ expect(smtp.sendMail).toHaveBeenCalledWith(
+ expect.objectContaining({
+ subject: "Acme $&-Passwort zurücksetzen",
+ html: expect.stringContaining("Acme $&"),
+ }),
+ );
+ expect(smtp.sendMail.mock.calls[0]?.[0].html).toContain("Upgrade Kaneo");
+ });
+
it("uses the same name in the body and subject across concurrent sends", async () => {
let releaseFirst!: () => void;
let firstRendered!: () => void;
diff --git a/tests/api-integration/password-reset.test.ts b/tests/api-integration/password-reset.test.ts
index 3df7dbe40..a6020e990 100644
--- a/tests/api-integration/password-reset.test.ts
+++ b/tests/api-integration/password-reset.test.ts
@@ -75,9 +75,14 @@ async function requestReset() {
const link = new URL((props as { resetLink: string }).resetLink);
expect(link.origin).toBe("http://localhost:1337");
expect(link.searchParams.get("callbackURL")).toBe(redirectTo);
- expect(vi.mocked(email.sendPasswordResetEmail).mock.calls.at(-1)?.[1]).toBe(
- "Kaneo-Passwort zurücksetzen",
- );
+ const subject = vi
+ .mocked(email.sendPasswordResetEmail)
+ .mock.calls.at(-1)?.[1];
+ expect(typeof subject).toBe("function");
+ if (typeof subject !== "function")
+ throw new Error("Missing subject resolver");
+ expect(subject("Kaneo")).toBe("Kaneo-Passwort zurücksetzen");
+ expect(subject("Acme $&")).toBe("Acme $&-Passwort zurücksetzen");
return { link, token: link.pathname.split("/").at(-1) };
}