⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix(gitea): reject saved tokens for changed servers
Tin0b769f82cea2
diff --git a/apps/api/src/gitea-integration/controllers/create-gitea-integration.ts b/apps/api/src/gitea-integration/controllers/create-gitea-integration.tsindex 389116c37..314da32d9 100644--- a/apps/api/src/gitea-integration/controllers/create-gitea-integration.ts+++ b/apps/api/src/gitea-integration/controllers/create-gitea-integration.ts@@ -16,6 +16,8 @@ import {verifyGiteaToken,} from "../../plugins/gitea/utils/gitea-api";+import { resolveVerificationToken } from "./resolve-verification-token";+async function createGiteaIntegration({projectId,baseUrl,@@ -46,24 +48,11 @@ async function createGiteaIntegration({),});- let resolvedToken = accessToken?.trim() ?? "";- if (!resolvedToken && existingIntegration) {- try {- const prev = JSON.parse(existingIntegration.config) as GiteaConfig;- resolvedToken = prev.accessToken;- } catch (error) {- console.warn("Failed to parse existing Gitea integration config", {- integrationId: existingIntegration.id,- error,- });- }- }-- if (!resolvedToken) {- throw new HTTPException(400, {- message: "Personal access token is required",- });- }+ const resolvedToken = await resolveVerificationToken({+ projectId,+ baseUrl: normalizedBase,+ accessToken,+ });try {await verifyGiteaToken(normalizedBase, resolvedToken);diff --git a/tests/api/gitea-integration/create-gitea-integration.test.ts b/tests/api/gitea-integration/create-gitea-integration.test.tsnew file mode 100644index 000000000..a328e1278--- /dev/null+++ b/tests/api/gitea-integration/create-gitea-integration.test.ts@@ -0,0 +1,82 @@+import { beforeEach, describe, expect, it, vi } from "vite-plus/test";++const m = vi.hoisted(() => ({+ config: vi.fn(),+ verify: vi.fn(),+ getRepo: vi.fn(),+ save: vi.fn(),+}));+vi.mock("../../../apps/api/src/database", () => ({+ default: {+ query: {+ projectTable: { findFirst: async () => ({ id: "project" }) },+ integrationTable: { findFirst: m.config, findMany: async () => [] },+ },+ update: () => ({+ set: m.save.mockReturnValue({+ where: () => ({+ returning: async () => [+ { id: "integration", projectId: "project", isActive: true },+ ],+ }),+ }),+ }),+ },+}));+vi.mock("../../../apps/api/src/plugins/gitea/utils/gitea-api", () => ({+ GiteaApiError: class extends Error {},+ verifyGiteaToken: m.verify,+ createGiteaClient: () => ({ getRepo: m.getRepo }),+}));+const { default: reconnect } =+ await import("../../../apps/api/src/gitea-integration/controllers/create-gitea-integration");+const input = {+ projectId: "project",+ baseUrl: "https://gitea.example",+ accessToken: undefined,+ repositoryOwner: "owner",+ repositoryName: "repo",+};+beforeEach(() => {+ vi.clearAllMocks();+ m.config.mockResolvedValue({+ id: "integration",+ config: JSON.stringify({+ baseUrl: "https://gitea.example/",+ accessToken: "saved-token",+ }),+ });+});+describe("gitea reconnect credentials", () => {+ it("rejects a changed destination before sending the saved token", async () => {+ await expect(+ reconnect({ ...input, baseUrl: "https://attacker.example" }),+ ).rejects.toMatchObject({ status: 400 });+ expect(m.verify).not.toHaveBeenCalled();+ expect(m.getRepo).not.toHaveBeenCalled();+ expect(m.save).not.toHaveBeenCalled();+ });+ it("reuses credentials only for the same normalized destination", async () => {+ await reconnect(input);+ expect(m.verify).toHaveBeenCalledWith(+ "https://gitea.example",+ "saved-token",+ );+ });+ it("allows a changed destination with an explicitly supplied token", async () => {+ await reconnect({+ ...input,+ baseUrl: "https://new-gitea.example",+ accessToken: " new-token ",+ });+ expect(m.verify).toHaveBeenCalledWith(+ "https://new-gitea.example",+ "new-token",+ );+ });+ it("rejects invalid saved configuration without contacting a provider", async () => {+ m.config.mockResolvedValue({ id: "integration", config: "{" });+ await expect(reconnect(input)).rejects.toMatchObject({ status: 400 });+ expect(m.verify).not.toHaveBeenCalled();+ });+});