Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix(rbac): address PR review feedback (build, tests, label permissions)

Andrej21c0f754ecbc
diff --git a/Dockerfile.kaneo b/Dockerfile.kaneo
index c58e6fcb1..e329a2124 100644
--- a/Dockerfile.kaneo
+++ b/Dockerfile.kaneo
@@ -10,6 +10,7 @@ COPY pnpm-workspace.yaml package.json pnpm-lock.yaml ./
COPY packages/typescript-config/package.json ./packages/typescript-config/
COPY packages/email/package.json ./packages/email/
COPY packages/libs/package.json ./packages/libs/
+COPY packages/permissions/package.json ./packages/permissions/
COPY apps/api/package.json ./apps/api/
RUN pnpm install --frozen-lockfile
@@ -17,6 +18,7 @@ RUN pnpm install --frozen-lockfile
COPY packages/typescript-config ./packages/typescript-config
COPY packages/email ./packages/email
COPY packages/libs ./packages/libs
+COPY packages/permissions ./packages/permissions
COPY apps/api ./apps/api
WORKDIR /app/packages/email
@@ -34,6 +36,7 @@ COPY --from=api-builder /app/apps/api/package.json ./apps/api/
COPY --from=api-builder /app/packages/typescript-config/package.json ./packages/typescript-config/
COPY --from=api-builder /app/packages/libs/package.json ./packages/libs/
COPY --from=api-builder /app/packages/email/package.json ./packages/email/
+COPY --from=api-builder /app/packages/permissions/package.json ./packages/permissions/
RUN sed -i 's/"prepare": "husky"/"prepare": ""/g' package.json && \
corepack enable && \
@@ -43,6 +46,7 @@ RUN sed -i 's/"prepare": "husky"/"prepare": ""/g' package.json && \
COPY --from=api-builder /app/apps/api/dist ./apps/api/dist
COPY --from=api-builder /app/apps/api/drizzle ./apps/api/drizzle
COPY --from=api-builder /app/packages/email ./packages/email
+COPY --from=api-builder /app/packages/permissions ./packages/permissions
FROM --platform=$BUILDPLATFORM node:20.20.2-alpine AS web-builder
@@ -56,11 +60,13 @@ COPY pnpm-workspace.yaml pnpm-lock.yaml package.json ./
COPY apps/web/package.json ./apps/web/
COPY packages/typescript-config/package.json ./packages/typescript-config/
COPY packages/libs/package.json ./packages/libs/
+COPY packages/permissions/package.json ./packages/permissions/
RUN pnpm install --frozen-lockfile
COPY packages/typescript-config ./packages/typescript-config
COPY packages/libs ./packages/libs
+COPY packages/permissions ./packages/permissions
COPY i18n ./i18n
COPY apps/web ./apps/web
diff --git a/apps/api/Dockerfile b/apps/api/Dockerfile
index b808a3fd4..603989a6d 100644
--- a/apps/api/Dockerfile
+++ b/apps/api/Dockerfile
@@ -13,6 +13,7 @@ COPY pnpm-workspace.yaml package.json pnpm-lock.yaml ./
COPY packages/typescript-config/package.json ./packages/typescript-config/
COPY packages/email/package.json ./packages/email/
COPY packages/libs/package.json ./packages/libs/
+COPY packages/permissions/package.json ./packages/permissions/
COPY apps/api/package.json ./apps/api/
# Install dependencies
@@ -22,6 +23,7 @@ RUN pnpm install --frozen-lockfile
COPY packages/typescript-config ./packages/typescript-config
COPY packages/email ./packages/email
COPY packages/libs ./packages/libs
+COPY packages/permissions ./packages/permissions
COPY apps/api ./apps/api
# Build email package first
@@ -50,6 +52,7 @@ COPY --from=builder /app/apps/api/package.json ./apps/api/
COPY --from=builder /app/packages/typescript-config/package.json ./packages/typescript-config/
COPY --from=builder /app/packages/libs/package.json ./packages/libs/
COPY --from=builder /app/packages/email/package.json ./packages/email/
+COPY --from=builder /app/packages/permissions/package.json ./packages/permissions/
# Install production dependencies only
RUN sed -i 's/"prepare": "husky"/"prepare": ""/g' package.json && \
@@ -61,6 +64,7 @@ RUN sed -i 's/"prepare": "husky"/"prepare": ""/g' package.json && \
COPY --from=builder /app/apps/api/dist ./apps/api/dist
COPY --from=builder /app/apps/api/drizzle ./apps/api/drizzle
COPY --from=builder /app/packages/email ./packages/email
+COPY --from=builder /app/packages/permissions ./packages/permissions
# Set environment variables
ENV NODE_ENV=production
diff --git a/apps/api/src/label/index.ts b/apps/api/src/label/index.ts
index 68aa8ebb1..331d6e974 100644
--- a/apps/api/src/label/index.ts
+++ b/apps/api/src/label/index.ts
@@ -89,7 +89,7 @@ const label = new Hono<{
}),
),
workspaceAccess.fromBody(),
- requireWorkspacePermission({ project: ["update"] }),
+ requireWorkspacePermission({ label: ["create"] }),
async (c) => {
const { name, color, workspaceId, taskId } = c.req.valid("json");
const userId = c.get("userId");
@@ -138,7 +138,7 @@ const label = new Hono<{
validator("param", v.object({ id: v.string() })),
validator("json", v.object({ taskId: v.string() })),
workspaceAccess.fromLabel(),
- requireWorkspacePermission({ task: ["update"] }),
+ requireWorkspacePermission({ label: ["update"] }),
async (c) => {
const { id } = c.req.valid("param");
const { taskId } = c.req.valid("json");
@@ -164,7 +164,7 @@ const label = new Hono<{
}),
validator("param", v.object({ id: v.string() })),
workspaceAccess.fromLabel(),
- requireWorkspacePermission({ task: ["update"] }),
+ requireWorkspacePermission({ label: ["update"] }),
async (c) => {
const { id } = c.req.valid("param");
const userId = c.get("userId");
@@ -196,7 +196,7 @@ const label = new Hono<{
}),
),
workspaceAccess.fromLabel(),
- requireWorkspacePermission({ project: ["update"] }),
+ requireWorkspacePermission({ label: ["update"] }),
async (c) => {
const { id } = c.req.valid("param");
const { name, color } = c.req.valid("json");
@@ -221,7 +221,7 @@ const label = new Hono<{
}),
validator("param", v.object({ id: v.string() })),
workspaceAccess.fromLabel(),
- requireWorkspacePermission({ project: ["update"] }),
+ requireWorkspacePermission({ label: ["delete"] }),
async (c) => {
const { id } = c.req.valid("param");
const userId = c.get("userId");
diff --git a/apps/api/src/utils/require-workspace-permission.ts b/apps/api/src/utils/require-workspace-permission.ts
index 8adfb01ac..ff1b47846 100644
--- a/apps/api/src/utils/require-workspace-permission.ts
+++ b/apps/api/src/utils/require-workspace-permission.ts
@@ -1,10 +1,63 @@
+import { type BuiltInRoleName, builtInRoles } from "@kaneo/permissions";
+import { and, eq } from "drizzle-orm";
import type { Context, Next } from "hono";
import { HTTPException } from "hono/http-exception";
-import { auth } from "../auth";
+import db, { schema } from "../database";
import { isInstanceAdmin } from "./is-instance-admin";
type PermissionMap = Record<string, string[]>;
+function builtInRoleStatements(
+ role: string,
+): Record<string, readonly string[]> | null {
+ if (role in builtInRoles) {
+ return builtInRoles[role as BuiltInRoleName].statements as Record<
+ string,
+ readonly string[]
+ >;
+ }
+ return null;
+}
+
+async function customRoleStatements(
+ workspaceId: string,
+ role: string,
+): Promise<Record<string, readonly string[]> | null> {
+ const [row] = await db
+ .select({ permission: schema.workspaceRoleTable.permission })
+ .from(schema.workspaceRoleTable)
+ .where(
+ and(
+ eq(schema.workspaceRoleTable.workspaceId, workspaceId),
+ eq(schema.workspaceRoleTable.role, role),
+ ),
+ )
+ .limit(1);
+
+ if (!row?.permission) return null;
+
+ try {
+ const parsed = JSON.parse(row.permission) as Record<string, string[]>;
+ return parsed;
+ } catch {
+ return null;
+ }
+}
+
+function satisfies(
+ statements: Record<string, readonly string[]>,
+ required: PermissionMap,
+): boolean {
+ for (const [resource, actions] of Object.entries(required)) {
+ const granted = statements[resource];
+ if (!granted) return false;
+ for (const action of actions) {
+ if (!granted.includes(action)) return false;
+ }
+ }
+ return true;
+}
+
export function requireWorkspacePermission(permissions: PermissionMap) {
return async (c: Context, next: Next) => {
const workspaceId = c.get("workspaceId");
@@ -18,21 +71,31 @@ export function requireWorkspacePermission(permissions: PermissionMap) {
return next();
}
- let allowed = false;
- try {
- const result = await auth.api.hasPermission({
- headers: c.req.raw.headers,
- body: {
- organizationId: workspaceId,
- permissions,
- },
- });
- allowed = result?.success === true;
- } catch {
- allowed = false;
+ const userId = c.get("userId");
+ if (!userId) {
+ throw new HTTPException(401, { message: "Unauthorized" });
}
- if (!allowed) {
+ const [member] = await db
+ .select({ role: schema.workspaceUserTable.role })
+ .from(schema.workspaceUserTable)
+ .where(
+ and(
+ eq(schema.workspaceUserTable.workspaceId, workspaceId),
+ eq(schema.workspaceUserTable.userId, userId),
+ ),
+ )
+ .limit(1);
+
+ if (!member?.role) {
+ throw new HTTPException(403, { message: "Insufficient permissions" });
+ }
+
+ const statements =
+ builtInRoleStatements(member.role) ??
+ (await customRoleStatements(workspaceId, member.role));
+
+ if (!statements || !satisfies(statements, permissions)) {
throw new HTTPException(403, { message: "Insufficient permissions" });
}
diff --git a/apps/web/Dockerfile b/apps/web/Dockerfile
index ae8bcce39..880038887 100644
--- a/apps/web/Dockerfile
+++ b/apps/web/Dockerfile
@@ -13,6 +13,7 @@ COPY pnpm-workspace.yaml pnpm-lock.yaml package.json ./
COPY apps/web/package.json ./apps/web/
COPY packages/typescript-config/package.json ./packages/typescript-config/
COPY packages/libs/package.json ./packages/libs/
+COPY packages/permissions/package.json ./packages/permissions/
# Install dependencies
RUN pnpm install --frozen-lockfile
@@ -20,6 +21,7 @@ RUN pnpm install --frozen-lockfile
# Copy only necessary source code
COPY packages/typescript-config ./packages/typescript-config
COPY packages/libs ./packages/libs
+COPY packages/permissions ./packages/permissions
COPY i18n ./i18n
COPY apps/web ./apps/web
diff --git a/packages/permissions/src/index.ts b/packages/permissions/src/index.ts
index 3fe90e3d5..d18654f26 100644
--- a/packages/permissions/src/index.ts
+++ b/packages/permissions/src/index.ts
@@ -10,6 +10,7 @@ export const statement = {
...defaultStatements,
project: ["create", "read", "update", "delete", "share"],
task: ["create", "read", "update", "delete", "assign"],
+ label: ["create", "read", "update", "delete"],
workspace: ["read", "update", "delete", "manage_settings"],
} as const;
@@ -19,6 +20,7 @@ export const viewer = ac.newRole({
...memberAc.statements,
project: ["read"],
task: ["read"],
+ label: ["read"],
workspace: ["read"],
});
@@ -26,6 +28,7 @@ export const member = ac.newRole({
...memberAc.statements,
project: ["create", "read"],
task: ["create", "read", "update"],
+ label: ["create", "read", "update", "delete"],
workspace: ["read"],
});
@@ -33,6 +36,7 @@ export const admin = ac.newRole({
...adminAc.statements,
project: ["create", "read", "update", "delete", "share"],
task: ["create", "read", "update", "delete", "assign"],
+ label: ["create", "read", "update", "delete"],
workspace: ["read", "update", "manage_settings"],
});
@@ -40,6 +44,7 @@ export const owner = ac.newRole({
...ownerAc.statements,
project: ["create", "read", "update", "delete", "share"],
task: ["create", "read", "update", "delete", "assign"],
+ label: ["create", "read", "update", "delete"],
workspace: ["read", "update", "delete", "manage_settings"],
});