Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix(review): qodo/coderabbit suggestions

justin270bc0476157
diff --git a/apps/web/src/lib/error-handler.test.ts b/apps/web/src/lib/error-handler.test.ts
new file mode 100644
index 000000000..5a959b73b
--- /dev/null
+++ b/apps/web/src/lib/error-handler.test.ts
@@ -0,0 +1,28 @@
+import { describe, expect, it } from "vitest";
+import { parseApiError } from "./error-handler";
+
+describe("parseApiError", () => {
+ it("returns a generic message for unknown Error instances instead of leaking error.message", () => {
+ const internalMessage =
+ "Cannot read properties of undefined (reading 'id') at TaskList";
+ const result = parseApiError(new Error(internalMessage));
+
+ expect(result.type).toBe("unknown");
+ expect(result.message).toBe("An unexpected error occurred.");
+ expect(result.message).not.toContain(internalMessage);
+ // originalError is preserved so Sentry still sees the real cause.
+ expect(result.originalError?.message).toBe(internalMessage);
+ });
+
+ it("returns a generic message for non-Error values", () => {
+ const result = parseApiError("something bad happened");
+ expect(result.type).toBe("unknown");
+ expect(result.message).toBe("An unexpected error occurred.");
+ });
+
+ it("still returns a CORS-specific message for matching errors", () => {
+ const result = parseApiError(new Error("Failed to fetch: CORS blocked"));
+ expect(result.type).toBe("cors");
+ expect(result.message).toContain("CORS");
+ });
+});
diff --git a/apps/web/src/lib/error-handler.ts b/apps/web/src/lib/error-handler.ts
index b31d5d762..9db58617e 100644
--- a/apps/web/src/lib/error-handler.ts
+++ b/apps/web/src/lib/error-handler.ts
@@ -60,8 +60,13 @@ export function parseApiError(error: unknown): ApiError {
};
}
+ // Don't surface `error.message` here: this branch covers both genuine
+ // API unknowns and any non-API error passed in (e.g. a React render
+ // error bubbled up to ErrorBoundary), and a raw `error.message` from
+ // the latter can leak internal implementation details to end users.
+ // The original error is preserved on `originalError` for Sentry.
return {
- message: error.message || "An unexpected error occurred.",
+ message: "An unexpected error occurred.",
type: "unknown",
originalError: error,
};