⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix(ci): validate complete security dependency inventories
Tin Sever2b3d90ee97f2
diff --git a/apps/api/src/auth.ts b/apps/api/src/auth.tsindex 1c9ae028e..3a373824d 100644--- a/apps/api/src/auth.ts+++ b/apps/api/src/auth.ts@@ -624,7 +624,8 @@ export const auth = betterAuth({});},beforeCreateInvitation: async ({ invitation }) => {- const role = normalizeInvitationRole(invitation.role) ?? invitation.role;+ const role =+ normalizeInvitationRole(invitation.role) ?? invitation.role;await assertInvitationOwnerAllowed({ ...invitation, role });const access = await resolveInvitationProjectAccess({...invitation,diff --git a/apps/api/src/workspace-members/assert-stored-owner-role-safe.test.ts b/apps/api/src/workspace-members/assert-stored-owner-role-safe.test.tsindex f2527298c..4124d4c02 100644--- a/apps/api/src/workspace-members/assert-stored-owner-role-safe.test.ts+++ b/apps/api/src/workspace-members/assert-stored-owner-role-safe.test.ts@@ -10,11 +10,14 @@ describe("stored ownership review", () => {);it.each([- null, undefined, "member", "member, recruiter", "owner", "member,owner", "owner, owner",- ])(- "preserves roles with no ambiguous ownership grant (%j)",- (role) => {- expect(() => assertStoredOwnerRoleSafe(role)).not.toThrow();- },- );+ null,+ undefined,+ "member",+ "member, recruiter",+ "owner",+ "member,owner",+ "owner, owner",+ ])("preserves roles with no ambiguous ownership grant (%j)", (role) => {+ expect(() => assertStoredOwnerRoleSafe(role)).not.toThrow();+ });});diff --git a/package.json b/package.jsonindex 742fafefa..96418405c 100644--- a/package.json+++ b/package.json@@ -37,7 +37,8 @@"tar-fs": ">=3.1.3","typescript": "7.0.2","vite": "catalog:",- "vite-plus": "catalog:"+ "vite-plus": "catalog:",+ "yaml": "^2.9.0"},"engines": {"node": "^24.15.0 || >=26.0.0"diff --git a/pnpm-lock.yaml b/pnpm-lock.yamlindex 32881a3be..d8f0e906a 100644--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -278,6 +278,9 @@ importers:vite-plus:specifier: 'catalog:'version: 1.4.0(@opentelemetry/[email protected])(@types/[email protected])(@vitest/[email protected])(@vitest/[email protected])([email protected])([email protected])([email protected](@noble/[email protected]))([email protected](@types/[email protected])([email protected]))([email protected])([email protected])([email protected])([email protected])+ yaml:+ specifier: '>=2.8.3'+ version: 2.9.0apps/api:dependencies:diff --git a/scripts/ci/dependency-graph-identity.mjs b/scripts/ci/dependency-graph-identity.mjsindex ab08f0027..528c7b8ac 100644--- a/scripts/ci/dependency-graph-identity.mjs+++ b/scripts/ci/dependency-graph-identity.mjs@@ -10,11 +10,17 @@ export function packageIdentity(key) {if (depth < 0) throw new Error(`Invalid pnpm suffix: ${key}`);}if (depth !== 0) throw new Error(`Invalid pnpm suffix: ${key}`);- const match = /^(?<name>(?:@[^/@\s]+\/)?[^/@\s]+)@(?<version>\d+\.\d+\.\d+(?:-[\da-zA-Z.-]+)?(?:\+[\da-zA-Z.-]+)?)$/.exec(base);+ const match =+ /^(?<name>(?:@[^/@\s]+\/)?[^/@\s]+)@(?<version>\d+\.\d+\.\d+(?:-[\da-zA-Z.-]+)?(?:\+[\da-zA-Z.-]+)?)$/.exec(+ base,+ );if (!match) throw new Error(`Unsupported npm package identity: ${key}`);const { name, version } = match.groups;const encodedName = name.split("/").map(encodeURIComponent).join("/");- return { base, purl: `pkg:npm/${encodedName}@${encodeURIComponent(version)}` };+ return {+ base,+ purl: `pkg:npm/${encodedName}@${encodeURIComponent(version)}`,+ };}export function dependencyKey(name, reference) {diff --git a/scripts/ci/dependency-graph-lock.mjs b/scripts/ci/dependency-graph-lock.mjsindex 4e0c9839d..55ab5575d 100644--- a/scripts/ci/dependency-graph-lock.mjs+++ b/scripts/ci/dependency-graph-lock.mjs@@ -1,6 +1,9 @@import { posix } from "node:path";import { parseAllDocuments } from "yaml";-import { dependencyKey, packageIdentity } from "./dependency-graph-identity.mjs";+import {+ dependencyKey,+ packageIdentity,+} from "./dependency-graph-identity.mjs";const groups = ["dependencies", "optionalDependencies", "devDependencies"];@@ -20,8 +23,12 @@ function mainDocument(source) {const candidates = [];for (const document of documents) {if (document.errors.length) throw new Error(document.errors[0].message);- const lock = mapping(document.toJS({ maxAliasCount: 100 }), "lock document");- if (lock.lockfileVersion !== "9.0") throw new Error("Expected pnpm lockfile version 9.0");+ const lock = mapping(+ document.toJS({ maxAliasCount: 100 }),+ "lock document",+ );+ if (lock.lockfileVersion !== "9.0")+ throw new Error("Expected pnpm lockfile version 9.0");const importers = Object.values(mapping(lock.importers, "importers"));if (!importers.length) throw new Error("Empty importers");for (const importer of importers) mapping(importer, "importer");@@ -34,9 +41,11 @@ function mainDocument(source) {"packageManagerDependencies" in importer,);if (application && !environment) candidates.push(lock);- else if (!environment || application) throw new Error("Unrecognized or mixed lock document");+ else if (!environment || application)+ throw new Error("Unrecognized or mixed lock document");}- if (candidates.length !== 1) throw new Error("Expected exactly one application lock document");+ if (candidates.length !== 1)+ throw new Error("Expected exactly one application lock document");return candidates[0];}@@ -62,12 +71,14 @@ export function buildManifest(source, path) {for (const [key, value] of Object.entries(snapshots)) {mapping(value, key);const { base, purl } = packageIdentity(key);- if (!packageBases.has(base)) throw new Error(`Snapshot missing package: ${key}`);+ if (!packageBases.has(base))+ throw new Error(`Snapshot missing package: ${key}`);covered.add(base);identities.set(key, purl);}for (const base of packageBases) {- if (!covered.has(base)) throw new Error(`Package missing snapshot: ${base}`);+ if (!covered.has(base))+ throw new Error(`Package missing snapshot: ${base}`);}function resolve(name, reference) {@@ -88,7 +99,9 @@ export function buildManifest(source, path) {for (const [name, reference] of Object.entries(references)) {const child = resolve(name, reference);children.add(child);- resolved.get(identities.get(key)).dependencies.add(identities.get(child));+ resolved+ .get(identities.get(key))+ .dependencies.add(identities.get(child));}}edges.set(key, children);@@ -99,10 +112,14 @@ export function buildManifest(source, path) {const developmentRoots = [];for (const [importerPath, importer] of Object.entries(lock.importers)) {for (const group of groups) {- for (const [name, value] of Object.entries(dependencyGroup(importer, group))) {+ for (const [name, value] of Object.entries(+ dependencyGroup(importer, group),+ )) {const { version } = mapping(value, name);if (typeof version === "string" && version.startsWith("link:")) {- const target = posix.normalize(posix.join(importerPath, version.slice(5)));+ const target = posix.normalize(+ posix.join(importerPath, version.slice(5)),+ );if (!Object.hasOwn(lock.importers, target)) {throw new Error(`Missing workspace importer: ${target}`);}@@ -111,7 +128,9 @@ export function buildManifest(source, path) {}const key = resolve(name, version);direct.add(identities.get(key));- (group === "devDependencies" ? developmentRoots : runtimeRoots).push(key);+ (group === "devDependencies" ? developmentRoots : runtimeRoots).push(+ key,+ );}}}diff --git a/scripts/ci/dependency-graph-snapshot.mjs b/scripts/ci/dependency-graph-snapshot.mjsindex eea04a1e1..2801f7afe 100644--- a/scripts/ci/dependency-graph-snapshot.mjs+++ b/scripts/ci/dependency-graph-snapshot.mjs@@ -7,7 +7,8 @@ export function buildSnapshot(sources, { sha, ref, runId, scanned }) {if (!/^(?:[a-f\d]{40}|[a-f\d]{64})$/i.test(sha ?? "")) {throw new Error("Invalid commit SHA");}- if (ref !== "refs/heads/main") throw new Error("Dependency snapshots require main");+ if (ref !== "refs/heads/main")+ throw new Error("Dependency snapshots require main");if (typeof runId !== "string" || !runId) throw new Error("Missing run ID");if (typeof scanned !== "string" || !Number.isFinite(Date.parse(scanned))) {throw new Error("Invalid scan time");diff --git a/scripts/ci/dependency-graph.mjs b/scripts/ci/dependency-graph.mjsindex 1ddb62a24..8f2c68898 100644--- a/scripts/ci/dependency-graph.mjs+++ b/scripts/ci/dependency-graph.mjs@@ -4,7 +4,9 @@ import { buildSnapshot, lockPaths } from "./dependency-graph-snapshot.mjs";export async function main(args = process.argv.slice(2), env = process.env) {if (args.length !== 1 || !["--dry-run", "--submit"].includes(args[0])) {- throw new Error("Usage: node scripts/ci/dependency-graph.mjs --dry-run|--submit");+ throw new Error(+ "Usage: node scripts/ci/dependency-graph.mjs --dry-run|--submit",+ );}const sources = Object.fromEntries(await Promise.all(@@ -52,14 +54,18 @@ export async function main(args = process.argv.slice(2), env = process.env) {throw new Error(`Dependency submission failed: HTTP ${response.status}`);}const result = await response.json();- if (result.result !== "SUCCESS") throw new Error("Dependency submission did not report SUCCESS");+ if (result.result !== "SUCCESS")+ throw new Error("Dependency submission did not report SUCCESS");for (const [path, manifest] of Object.entries(snapshot.manifests)) {const count = Object.keys(manifest.resolved).length;console.log(`${path}: submitted ${count} npm packages`);}}-if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {+if (+ process.argv[1] &&+ import.meta.url === pathToFileURL(process.argv[1]).href+) {main().catch((error) => {console.error(error.message);process.exitCode = 1;diff --git a/scripts/ci/dependency-graph.test.mjs b/scripts/ci/dependency-graph.test.mjsindex 35b222a0b..92ed5ebb5 100644--- a/scripts/ci/dependency-graph.test.mjs+++ b/scripts/ci/dependency-graph.test.mjs@@ -1,8 +1,12 @@+import { execFileSync } from "node:child_process";import assert from "node:assert/strict";import { readFile } from "node:fs/promises";import test from "node:test";import { parseAllDocuments, stringify } from "yaml";-import { dependencyKey, packageIdentity } from "./dependency-graph-identity.mjs";+import {+ dependencyKey,+ packageIdentity,+} from "./dependency-graph-identity.mjs";import { buildManifest } from "./dependency-graph-lock.mjs";import { buildSnapshot, lockPaths } from "./dependency-graph-snapshot.mjs";import { main } from "./dependency-graph.mjs";@@ -79,14 +83,24 @@ function changedApplication(change) {// No network or file writes are needed to validate a constructed payload.function assertPayload(snapshot) {assert.deepEqual(Object.keys(snapshot).sort(), [- "detector", "job", "manifests", "ref", "scanned", "sha", "version",+ "detector",+ "job",+ "manifests",+ "ref",+ "scanned",+ "sha",+ "version",]);assert.equal(snapshot.version, 0);assert.match(snapshot.sha, /^(?:[a-f\d]{40}|[a-f\d]{64})$/i);assert.match(snapshot.ref, /^refs\//);assert.ok(Number.isFinite(Date.parse(snapshot.scanned)));assert.deepEqual(Object.keys(snapshot.job).sort(), ["correlator", "id"]);- assert.deepEqual(Object.keys(snapshot.detector).sort(), ["name", "url", "version"]);+ assert.deepEqual(Object.keys(snapshot.detector).sort(), [+ "name",+ "url",+ "version",+ ]);const descriptions = [...Object.values(snapshot.job),...Object.values(snapshot.detector),@@ -97,7 +111,11 @@ function assertPayload(snapshot) {}assert.deepEqual(Object.keys(snapshot.manifests), lockPaths);for (const [path, manifest] of Object.entries(snapshot.manifests)) {- assert.deepEqual(Object.keys(manifest).sort(), ["file", "name", "resolved"]);+ assert.deepEqual(Object.keys(manifest).sort(), [+ "file",+ "name",+ "resolved",+ ]);assert.equal(manifest.name, path);assert.deepEqual(manifest.file, { source_location: path });assert.ok(Object.keys(manifest.resolved).length);@@ -276,9 +294,14 @@ test("actual root and e2e locks cover every main-document package with valid payconst lock = documents.find((document) => document.settings);assert.ok(lock);const expected = [- ...new Set(Object.keys(lock.packages).map((key) => packageIdentity(key).purl)),+ ...new Set(+ Object.keys(lock.packages).map((key) => packageIdentity(key).purl),+ ),].sort();- assert.deepEqual(Object.keys(snapshot.manifests[path].resolved).sort(), expected);+ assert.deepEqual(+ Object.keys(snapshot.manifests[path].resolved).sort(),+ expected,+ );}for (const name of ["qs", "node-forge", "deepmerge"]) {assert.ok(@@ -295,16 +318,28 @@ test("actual root and e2e locks cover every main-document package with valid pay});test("CLI dry-run builds the real payload without networking or file writes", async (t) => {- let output = "";- t.mock.method(process.stdout, "write", (chunk) => {- output += chunk;- return true;- });+ // Node's test runner also uses stdout for its binary protocol. Capture a+ // separate CLI process instead of intercepting that protocol in this worker.+ const code = `+ globalThis.fetch = () => { throw new Error("Unexpected network access"); };+ const { main } = await import("./scripts/ci/dependency-graph.mjs");+ await main(["--dry-run"], ${JSON.stringify({ GITHUB_SHA: context.sha, GITHUB_REF: context.ref })});+ `;+ const env = { ...process.env };+ delete env.NODE_TEST_CONTEXT;+ const output = execFileSync(+ process.execPath,+ ["--input-type=module", "--eval", code],+ {+ env,+ encoding: "utf8",+ maxBuffer: 16 * 1024 * 1024,+ },+ );+ assertPayload(JSON.parse(output));const network = t.mock.method(globalThis, "fetch", () => {throw new Error("Unexpected network access");});- await main(["--dry-run"], { GITHUB_SHA: context.sha, GITHUB_REF: context.ref });- assertPayload(JSON.parse(output));assert.equal(network.mock.callCount(), 0);await assert.rejects(main(["--submit"], {@@ -336,7 +371,10 @@ test("trusted submission sends one complete snapshot to GitHub and rejects unsucGITHUB_TOKEN: "synthetic-test-token",};const network = t.mock.method(globalThis, "fetch", async (url, options) => {- assert.equal(url, "https://api.github.com/repos/usekaneo/kaneo/dependency-graph/snapshots");+ assert.equal(+ url,+ "https://api.github.com/repos/usekaneo/kaneo/dependency-graph/snapshots",+ );assert.equal(options.method, "POST");assert.equal(options.redirect, "error");assert.equal(options.headers.Authorization, "Bearer synthetic-test-token");@@ -348,8 +386,12 @@ test("trusted submission sends one complete snapshot to GitHub and rejects unsuc});await main(["--submit"], env);assert.equal(network.mock.callCount(), 1);- network.mock.mockImplementation(async () => Response.json({ result: "ERROR" }, { status: 201 }));+ network.mock.mockImplementation(async () =>+ Response.json({ result: "ERROR" }, { status: 201 }),+ );await assert.rejects(main(["--submit"], env), /did not report SUCCESS/);- network.mock.mockImplementation(async () => new Response(null, { status: 403 }));+ network.mock.mockImplementation(+ async () => new Response(null, { status: 403 }),+ );await assert.rejects(main(["--submit"], env), /HTTP 403/);});diff --git a/tests/api-integration/invitation-legacy-owner-role.test.ts b/tests/api-integration/invitation-legacy-owner-role.test.tsindex cb89ee752..23518de8f 100644--- a/tests/api-integration/invitation-legacy-owner-role.test.ts+++ b/tests/api-integration/invitation-legacy-owner-role.test.ts@@ -3,7 +3,10 @@ import { eq } from "drizzle-orm";import { beforeEach, describe, expect, it, vi } from "vite-plus/test";import db, { schema } from "../../apps/api/src/database";import { resetTestDatabase } from "./helpers/database";-import { invitationSecurityFixture, organizationRequest } from "./helpers/invitation-security";+import {+ invitationSecurityFixture,+ organizationRequest,+} from "./helpers/invitation-security";import { readMemberAccessRows } from "./helpers/project-access/read-member-access-rows";beforeEach(resetTestDatabase);@@ -17,14 +20,22 @@ describe("legacy invitation ownership", () => {const send = vi.spyOn(email, "sendWorkspaceInvitationEmail");const { response, invitee } = await ctx.accept(invitation.id);expect(response.status).toBe(403);- expect(await response.json()).toMatchObject({ code: "OWNER_ROLE_REVIEW_REQUIRED" });- expect(await db.query.invitationTable.findFirst({- where: eq(schema.invitationTable.id, invitation.id),- })).toEqual(invitation);- expect(await db.query.workspaceUserTable.findFirst({- where: eq(schema.workspaceUserTable.userId, invitee.userId),- })).toBeUndefined();- expect(await readMemberAccessRows(ctx.workspace.id, invitee.userId)).toEqual({ rules: [], grants: [] });+ expect(await response.json()).toMatchObject({+ code: "OWNER_ROLE_REVIEW_REQUIRED",+ });+ expect(+ await db.query.invitationTable.findFirst({+ where: eq(schema.invitationTable.id, invitation.id),+ }),+ ).toEqual(invitation);+ expect(+ await db.query.workspaceUserTable.findFirst({+ where: eq(schema.workspaceUserTable.userId, invitee.userId),+ }),+ ).toBeUndefined();+ expect(+ await readMemberAccessRows(ctx.workspace.id, invitee.userId),+ ).toEqual({ rules: [], grants: [] });expect(send).not.toHaveBeenCalled();},);@@ -37,7 +48,9 @@ describe("legacy invitation ownership", () => {const { response, invitee } = await ctx.accept(invitation.id);expect(response.status).toBe(200);expect(await response.json()).toMatchObject({ member: { role } });- expect(await readMemberAccessRows(ctx.workspace.id, invitee.userId)).toEqual({ rules: [], grants: [] });+ expect(+ await readMemberAccessRows(ctx.workspace.id, invitee.userId),+ ).toEqual({ rules: [], grants: [] });},);@@ -49,9 +62,11 @@ describe("legacy invitation ownership", () => {const response = await ctx.invite(cookies, "member", { resend: true });expect(response.status).toBe(403);expect(await response.text()).not.toContain(invitation.id);- expect(await db.query.invitationTable.findFirst({- where: eq(schema.invitationTable.id, invitation.id),- })).toEqual(invitation);+ expect(+ await db.query.invitationTable.findFirst({+ where: eq(schema.invitationTable.id, invitation.id),+ }),+ ).toEqual(invitation);}const listed = await ctx.app.request(`/api/auth/organization/list-invitations?organizationId=${ctx.workspace.id}`,@@ -62,30 +77,40 @@ describe("legacy invitation ownership", () => {expect(send).not.toHaveBeenCalled();});- it.each(["member", "owner"])("lets an owner replace an expired ambiguous invitation with %s", async (role) => {- const ctx = await invitationSecurityFixture();- const expired = await ctx.pending("member, owner");- await db.update(schema.invitationTable)- .set({ expiresAt: new Date(Date.now() - 60_000) })- .where(eq(schema.invitationTable.id, expired.id));- const send = vi.spyOn(email, "sendWorkspaceInvitationEmail");- const response = await ctx.invite(ctx.owner.cookies, role, { resend: true });- expect(response.status).toBe(200);- const created = await response.json() as { id: string; role: string };- expect(created.id).not.toBe(expired.id);- expect(created.role).toBe(role);- expect(send).toHaveBeenCalledOnce();- });+ it.each(["member", "owner"])(+ "lets an owner replace an expired ambiguous invitation with %s",+ async (role) => {+ const ctx = await invitationSecurityFixture();+ const expired = await ctx.pending("member, owner");+ await db+ .update(schema.invitationTable)+ .set({ expiresAt: new Date(Date.now() - 60_000) })+ .where(eq(schema.invitationTable.id, expired.id));+ const send = vi.spyOn(email, "sendWorkspaceInvitationEmail");+ const response = await ctx.invite(ctx.owner.cookies, role, {+ resend: true,+ });+ expect(response.status).toBe(200);+ const created = (await response.json()) as { id: string; role: string };+ expect(created.id).not.toBe(expired.id);+ expect(created.role).toBe(role);+ expect(send).toHaveBeenCalledOnce();+ },+ );it("rejects owner requests even when a resend would retain an ordinary stored role", async () => {const ctx = await invitationSecurityFixture();const invitation = await ctx.pending("member");const send = vi.spyOn(email, "sendWorkspaceInvitationEmail");- const response = await ctx.invite(ctx.actor.cookies, ["member", " owner"], { resend: true });+ const response = await ctx.invite(ctx.actor.cookies, ["member", " owner"], {+ resend: true,+ });expect(response.status).toBe(403);- expect(await db.query.invitationTable.findFirst({- where: eq(schema.invitationTable.id, invitation.id),- })).toEqual(invitation);+ expect(+ await db.query.invitationTable.findFirst({+ where: eq(schema.invitationTable.id, invitation.id),+ }),+ ).toEqual(invitation);expect(send).not.toHaveBeenCalled();});@@ -93,11 +118,15 @@ describe("legacy invitation ownership", () => {const ctx = await invitationSecurityFixture();const invitation = await ctx.pending("member,recruiter");const send = vi.spyOn(email, "sendWorkspaceInvitationEmail");- const response = await ctx.invite(ctx.actor.cookies, "member", { resend: true });+ const response = await ctx.invite(ctx.actor.cookies, "member", {+ resend: true,+ });expect(response.status).toBe(200);expect(await response.json()).toMatchObject({- id: invitation.id, role: "member,recruiter",- projectAccess: "selected", projectIds: [ctx.project.id],+ id: invitation.id,+ role: "member,recruiter",+ projectAccess: "selected",+ projectIds: [ctx.project.id],});expect(send).toHaveBeenCalledOnce();});@@ -108,9 +137,12 @@ describe("previously accepted ambiguous ownership", () => {"removes only the accidental ownership of %j without rewriting membership",async (role) => {const ctx = await invitationSecurityFixture(role);- const capabilities = await ctx.app.request(`/api/workspace/${ctx.workspace.id}/capabilities`, {- headers: { cookie: ctx.actor.cookies },- });+ const capabilities = await ctx.app.request(+ `/api/workspace/${ctx.workspace.id}/capabilities`,+ {+ headers: { cookie: ctx.actor.cookies },+ },+ );expect(capabilities.status).toBe(200);expect(await capabilities.json()).toMatchObject({deleteWorkspace: false,@@ -120,33 +152,67 @@ describe("previously accepted ambiguous ownership", () => {const send = vi.spyOn(email, "sendWorkspaceInvitationEmail");const invited = await ctx.invite(ctx.actor.cookies, "owner");expect(invited.status).toBe(403);- expect(await invited.json()).toMatchObject({ code: "OWNER_ROLE_REVIEW_REQUIRED" });- const promoted = await organizationRequest(ctx.app, { cookie: ctx.actor.cookies }, "update-member-role", {- organizationId: ctx.workspace.id, memberId: ctx.membership.id, role: ["member", " owner"],+ expect(await invited.json()).toMatchObject({+ code: "OWNER_ROLE_REVIEW_REQUIRED",});+ const promoted = await organizationRequest(+ ctx.app,+ { cookie: ctx.actor.cookies },+ "update-member-role",+ {+ organizationId: ctx.workspace.id,+ memberId: ctx.membership.id,+ role: ["member", " owner"],+ },+ );expect(promoted.status).toBe(403);// A second canonical owner makes the provider's last-owner check pass;// the malformed actor must still never acquire the right to remove one.const secondOwner = await ctx.accept((await ctx.pending("owner")).id);expect(secondOwner.response.status).toBe(200);- const removed = await organizationRequest(ctx.app, { cookie: ctx.actor.cookies }, "remove-member", {- organizationId: ctx.workspace.id, memberIdOrEmail: "[email protected]",- });+ const removed = await organizationRequest(+ ctx.app,+ { cookie: ctx.actor.cookies },+ "remove-member",+ {+ organizationId: ctx.workspace.id,+ memberIdOrEmail: "[email protected]",+ },+ );expect(removed.status).toBe(403);- expect(await removed.json()).toMatchObject({ code: "OWNER_ROLE_REVIEW_REQUIRED" });- expect(await db.query.workspaceUserTable.findFirst({- where: eq(schema.workspaceUserTable.id, ctx.membership.id),- })).toEqual(ctx.membership);- expect(await db.query.workspaceUserTable.findFirst({- where: eq(schema.workspaceUserTable.userId, ctx.owner.userId),- })).toBeDefined();+ expect(await removed.json()).toMatchObject({+ code: "OWNER_ROLE_REVIEW_REQUIRED",+ });+ expect(+ await db.query.workspaceUserTable.findFirst({+ where: eq(schema.workspaceUserTable.id, ctx.membership.id),+ }),+ ).toEqual(ctx.membership);+ expect(+ await db.query.workspaceUserTable.findFirst({+ where: eq(schema.workspaceUserTable.userId, ctx.owner.userId),+ }),+ ).toBeDefined();expect(send).not.toHaveBeenCalled();// Only an explicit decision by a true owner can restore ownership.- const reviewed = await organizationRequest(ctx.app, { cookie: ctx.owner.cookies }, "update-member-role", {- organizationId: ctx.workspace.id, memberId: ctx.membership.id, role: "member,owner",- });+ const reviewed = await organizationRequest(+ ctx.app,+ { cookie: ctx.owner.cookies },+ "update-member-role",+ {+ organizationId: ctx.workspace.id,+ memberId: ctx.membership.id,+ role: "member,owner",+ },+ );expect(reviewed.status).toBe(200);- expect((await ctx.invite(ctx.actor.cookies, "owner", { email: "[email protected]" })).status).toBe(200);+ expect(+ (+ await ctx.invite(ctx.actor.cookies, "owner", {+ email: "[email protected]",+ })+ ).status,+ ).toBe(200);},);});