Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix(chart): require explicit auth secret

Tin331794873882
diff --git a/charts/kaneo/README.md b/charts/kaneo/README.md
index fddbb92ef..9da6d28e3 100644
--- a/charts/kaneo/README.md
+++ b/charts/kaneo/README.md
@@ -99,7 +99,7 @@ When CPU autoscaling is enabled, set `kaneo.resources.requests.cpu`; Kubernetes
| `kaneo.env` | Environment variables for the Kaneo container | See `values.yaml` |
| `kaneo.env.clientUrl` | Public URL of the Kaneo instance. **Required for any non-localhost deployment** — sets `KANEO_CLIENT_URL`. Omitting this causes "invalid origin" errors on login. Note: this key is case-sensitive (`clientUrl`, not `clientURL`). | `""` |
| `kaneo.env.corsOrigins` | Allowed CORS origins as a comma-separated string or YAML list | `[]` |
-| `kaneo.env.authSecret` | Better Auth secret; generated per release when empty, ignored if existingSecret is enabled | `""` |
+| `kaneo.env.authSecret` | Required Better Auth secret (minimum 32 characters), ignored if existingSecret is enabled | `""` |
| `kaneo.env.existingSecret.enabled` | Whether to use an existing secret for `AUTH_SECRET` | `false` |
| `kaneo.env.existingSecret.name` | Name of the existing secret containing `AUTH_SECRET` | `""` |
| `kaneo.env.existingSecret.key` | Key in the existing secret that contains `AUTH_SECRET` | `auth-secret` |
diff --git a/charts/kaneo/templates/auth-secret.yaml b/charts/kaneo/templates/auth-secret.yaml
deleted file mode 100644
index 2bdec52b1..000000000
--- a/charts/kaneo/templates/auth-secret.yaml
+++ /dev/null
@@ -1,21 +0,0 @@
-{{- if not .Values.kaneo.env.existingSecret.enabled }}
-{{- $secretName := printf "%s-auth" (include "kaneo.fullname" .) }}
-{{- $secretValue := .Values.kaneo.env.authSecret | toString }}
-{{- if not $secretValue }}
- {{- $existing := lookup "v1" "Secret" .Release.Namespace $secretName }}
- {{- if and $existing $existing.data (hasKey $existing.data "auth-secret") }}
- {{- $secretValue = (index $existing.data "auth-secret" | b64dec) }}
- {{- else }}
- {{- $secretValue = randAlphaNum 64 }}
- {{- end }}
-{{- end }}
-apiVersion: v1
-kind: Secret
-metadata:
- name: {{ $secretName }}
- labels:
- {{- include "kaneo.labels" . | nindent 4 }}
-type: Opaque
-stringData:
- auth-secret: {{ $secretValue | quote }}
-{{- end }}
diff --git a/charts/kaneo/templates/deployment.yaml b/charts/kaneo/templates/deployment.yaml
index 79d632fb7..0d20c7011 100644
--- a/charts/kaneo/templates/deployment.yaml
+++ b/charts/kaneo/templates/deployment.yaml
@@ -55,10 +55,7 @@ spec:
name: {{ .Values.kaneo.env.existingSecret.name }}
key: {{ .Values.kaneo.env.existingSecret.key }}
{{- else }}
- valueFrom:
- secretKeyRef:
- name: {{ printf "%s-auth" (include "kaneo.fullname" .) }}
- key: auth-secret
+ value: {{ .Values.kaneo.env.authSecret | quote }}
{{- end }}
{{- if and (not .Values.kaneo.env.database.external.enabled) .Values.postgresql.auth.existingSecret }}
- name: KANEO_POSTGRES_PASSWORD
diff --git a/charts/kaneo/templates/validations.yaml b/charts/kaneo/templates/validations.yaml
index f81fd823f..0b6249de6 100644
--- a/charts/kaneo/templates/validations.yaml
+++ b/charts/kaneo/templates/validations.yaml
@@ -1,6 +1,6 @@
{{- $publicExposureEnabled := or .Values.ingress.enabled .Values.gateway.enabled -}}
-{{- if and (not .Values.kaneo.env.existingSecret.enabled) .Values.kaneo.env.authSecret (lt (len (.Values.kaneo.env.authSecret | toString)) 32) -}}
-{{- fail "kaneo.env.authSecret must be at least 32 characters; leave it empty to generate a per-release secret" -}}
+{{- if and (not .Values.kaneo.env.existingSecret.enabled) (or (not .Values.kaneo.env.authSecret) (lt (len (.Values.kaneo.env.authSecret | toString)) 32)) -}}
+{{- fail "kaneo.env.authSecret must be explicitly set to at least 32 characters or provided via kaneo.env.existingSecret" -}}
{{- end -}}
{{- if and $publicExposureEnabled .Values.postgresql.enabled (not .Values.postgresql.auth.existingSecret) (eq .Values.postgresql.auth.password "kaneo_password") -}}
{{- fail "postgresql.auth.password must be changed or provided via postgresql.auth.existingSecret before enabling ingress or gateway" -}}
diff --git a/charts/kaneo/values.yaml b/charts/kaneo/values.yaml
index 3586689e8..99600acb7 100644
--- a/charts/kaneo/values.yaml
+++ b/charts/kaneo/values.yaml
@@ -86,8 +86,8 @@ kaneo:
# Allowed CORS origins. Accepts a comma-separated string or YAML list.
# Defaults to clientUrl when left empty.
corsOrigins: []
- # Optional explicit Better Auth secret (minimum 32 characters).
- # When empty, the chart generates and preserves a per-release secret.
+ # Required Better Auth secret (minimum 32 characters), unless existingSecret is enabled.
+ # Generate with: openssl rand -hex 32
authSecret: ""
existingSecret:
enabled: false