⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix: wait for subtask status columns
Bryan Nathan3a6170546bb6
diff --git a/apps/web/src/components/task/task-subtasks.test.tsx b/apps/web/src/components/task/task-subtasks.test.tsxindex 78ae5659a..10a8c2979 100644--- a/apps/web/src/components/task/task-subtasks.test.tsx+++ b/apps/web/src/components/task/task-subtasks.test.tsx@@ -5,12 +5,13 @@ import {screen,waitFor,} from "@testing-library/react";-import { afterEach, describe, expect, it, vi } from "vitest";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";import TaskSubtasks from "./task-subtasks";const mocks = vi.hoisted(() => ({createTask: vi.fn(),createRelation: vi.fn(),+ getColumns: vi.fn(),}));vi.mock("@tanstack/react-router", () => ({ useNavigate: () => vi.fn() }));@@ -33,12 +34,7 @@ vi.mock("@/hooks/mutations/task/use-update-task-status", () => ({useUpdateTaskStatus: () => ({ mutateAsync: vi.fn() }),}));vi.mock("@/hooks/queries/column/use-get-columns", () => ({- useGetColumns: () => ({- data: [- { id: "todo", slug: "to-do", name: "To Do", isFinal: false },- { id: "done", slug: "done", name: "Done", isFinal: true },- ],- }),+ useGetColumns: () => mocks.getColumns(),}));vi.mock("@/hooks/queries/task-relation/use-get-task-relations", () => ({default: () => ({ data: [] }),@@ -57,6 +53,16 @@ vi.mock("@/hooks/use-workspace-permission", () => ({}));vi.mock("@/lib/toast", () => ({ toast: { error: vi.fn(), success: vi.fn() } }));+beforeEach(() => {+ mocks.getColumns.mockReturnValue({+ data: [+ { id: "todo", slug: "to-do", name: "To Do", isFinal: false },+ { id: "done", slug: "done", name: "Done", isFinal: true },+ ],+ isLoading: false,+ });+});+afterEach(() => {cleanup();vi.clearAllMocks();@@ -76,7 +82,11 @@ describe("TaskSubtasks", () => {/>,);- fireEvent.click(screen.getAllByRole("button")[1]);+ fireEvent.click(+ screen.getByRole("button", {+ name: "tasks:subtasks.addAction tasks:subtasks.title",+ }),+ );fireEvent.change(screen.getByPlaceholderText("tasks:subtasks.inputPlaceholder"),{ target: { value: "Design login form" } },@@ -104,7 +114,11 @@ describe("TaskSubtasks", () => {/>,);- fireEvent.click(screen.getAllByRole("button")[1]);+ fireEvent.click(+ screen.getByRole("button", {+ name: "tasks:subtasks.addAction tasks:subtasks.title",+ }),+ );fireEvent.change(screen.getByPlaceholderText("tasks:subtasks.inputPlaceholder"),{ target: { value: "Implement login form" } },@@ -118,4 +132,23 @@ describe("TaskSubtasks", () => {expect.objectContaining({ status: "to-do" }),);});++ it("blocks active-parent creation until project columns are available", () => {+ mocks.getColumns.mockReturnValue({ data: [], isLoading: true });++ render(+ <TaskSubtasks+ taskId="parent-3"+ projectId="project-1"+ workspaceId="workspace-1"+ parentStatus="in-progress"+ />,+ );++ expect(+ screen.getByRole("button", {+ name: "tasks:subtasks.addAction tasks:subtasks.title",+ }),+ ).toBeDisabled();+ });});diff --git a/apps/web/src/components/task/task-subtasks.tsx b/apps/web/src/components/task/task-subtasks.tsxindex 46fa8998c..d66f55e41 100644--- a/apps/web/src/components/task/task-subtasks.tsx+++ b/apps/web/src/components/task/task-subtasks.tsx@@ -66,7 +66,8 @@ export default function TaskSubtasks({const createRelation = useCreateTaskRelation();const { mutateAsync: deleteTask } = useDeleteTask();const { mutateAsync: updateTaskStatus } = useUpdateTaskStatus();- const { data: columns = [] } = useGetColumns(projectId);+ const { data: columns = [], isLoading: isLoadingColumns } =+ useGetColumns(projectId);const { canManageTasks } = useWorkspacePermission();const canEdit = canManageTasks();@@ -74,7 +75,9 @@ export default function TaskSubtasks({// validates status against columns). A subtask counts as completed when its// status is a final column.const doneSlug = columns.find((c) => c.isFinal)?.slug ?? "done";- const todoSlug = columns.find((c) => !c.isFinal)?.slug ?? "to-do";+ const todoSlug = columns.find((c) => !c.isFinal)?.slug;+ const canCreateSubtask =+ parentStatus === "planned" || (!isLoadingColumns && Boolean(todoSlug));const isCompleted = (status: string) =>columns.length > 0? (columns.find((c) => c.slug === status)?.isFinal ?? false)@@ -256,13 +259,15 @@ export default function TaskSubtasks({const handleAddSubtask = async () => {if (!newTitle.trim()) return;+ const initialStatus = parentStatus === "planned" ? "planned" : todoSlug;+ if (!initialStatus) return;try {const newTask = await createTask.mutateAsync({title: newTitle.trim(),description: "",projectId,- status: parentStatus === "planned" ? "planned" : todoSlug,+ status: initialStatus,priority: "no-priority",});@@ -337,7 +342,9 @@ export default function TaskSubtasks({variant="ghost"size="xs"className="text-muted-foreground"+ aria-label={`${t("tasks:subtasks.addAction")} ${t("tasks:subtasks.title")}`}onClick={() => setIsAdding(true)}+ disabled={!canCreateSubtask}><Plus className="size-3.5" /></Button>@@ -412,7 +419,9 @@ export default function TaskSubtasks({<Buttonsize="xs"onClick={handleAddSubtask}- disabled={!newTitle.trim() || createTask.isPending}+ disabled={+ !newTitle.trim() || createTask.isPending || !canCreateSubtask+ }>{t("tasks:subtasks.addAction")}</Button>