⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix(web): drop deleted tasks from cached subtask lists
irfanfaraaz4487089ebea4
diff --git a/apps/web/src/hooks/mutations/task/remove-task-from-relations.test.ts b/apps/web/src/hooks/mutations/task/remove-task-from-relations.test.tsnew file mode 100644index 000000000..bb3872f88--- /dev/null+++ b/apps/web/src/hooks/mutations/task/remove-task-from-relations.test.ts@@ -0,0 +1,37 @@+import { QueryClient } from "@tanstack/react-query";+import { describe, expect, it } from "vite-plus/test";+import { removeTasksFromRelations } from "./remove-task-from-relations";++const relation = (id: string, sourceTaskId: string, targetTaskId: string) => ({+ id,+ sourceTaskId,+ targetTaskId,+ relationType: "subtask",+});++describe("removeTasksFromRelations", () => {+ it("drops deleted tasks from every cached relation list", () => {+ const queryClient = new QueryClient();+ queryClient.setQueryData(+ ["task-relations", "parent"],+ [+ relation("r1", "parent", "sub-a"),+ relation("r2", "parent", "sub-b"),+ relation("r3", "parent", "sub-c"),+ ],+ );+ queryClient.setQueryData(+ ["task-relations", "sub-a"],+ [relation("r1", "parent", "sub-a")],+ );++ removeTasksFromRelations(queryClient, ["sub-a", "sub-c"]);++ expect(queryClient.getQueryData(["task-relations", "parent"])).toEqual([+ relation("r2", "parent", "sub-b"),+ ]);+ expect(+ queryClient.getQueryData(["task-relations", "sub-a"]),+ ).toBeUndefined();+ });+});diff --git a/apps/web/src/hooks/mutations/task/remove-task-from-relations.ts b/apps/web/src/hooks/mutations/task/remove-task-from-relations.tsnew file mode 100644index 000000000..630d2c0b5--- /dev/null+++ b/apps/web/src/hooks/mutations/task/remove-task-from-relations.ts@@ -0,0 +1,29 @@+import type { QueryClient } from "@tanstack/react-query";++type Relation = { sourceTaskId: string; targetTaskId: string };++// Cached relation lists are not refetched on mount, so drop deleted tasks here+// or a parent keeps showing a subtask that no longer exists.+export function removeTasksFromRelations(+ queryClient: QueryClient,+ taskIds: string[],+) {+ const deleted = new Set(taskIds);++ for (const taskId of taskIds) {+ queryClient.removeQueries({+ queryKey: ["task-relations", taskId],+ exact: true,+ });+ }++ queryClient.setQueriesData<Relation[]>(+ { queryKey: ["task-relations"] },+ (relations) =>+ relations?.filter(+ (relation) =>+ !deleted.has(relation.sourceTaskId) &&+ !deleted.has(relation.targetTaskId),+ ),+ );+}diff --git a/apps/web/src/hooks/mutations/task/use-bulk-operations.ts b/apps/web/src/hooks/mutations/task/use-bulk-operations.tsindex 8de7785e0..b7d1081bf 100644--- a/apps/web/src/hooks/mutations/task/use-bulk-operations.ts+++ b/apps/web/src/hooks/mutations/task/use-bulk-operations.ts@@ -2,6 +2,7 @@ import { useMutation, useQueryClient } from "@tanstack/react-query";import { invalidateMyWork } from "@/lib/invalidate-my-work";import bulkOperation from "@/fetchers/task/bulk-operation";import deleteTask from "@/fetchers/task/delete-task";+import { removeTasksFromRelations } from "./remove-task-from-relations";export function useBulkOperations() {const queryClientRef = useQueryClient();@@ -16,7 +17,10 @@ export function useBulkOperations() {mutationFn: async (taskIds: string[]) => {await Promise.all(taskIds.map((id) => deleteTask(id)));},- onSuccess: invalidateCommon,+ onSuccess: (_, taskIds) => {+ removeTasksFromRelations(queryClientRef, taskIds);+ invalidateCommon();+ },});const bulkArchive = useMutation({diff --git a/apps/web/src/hooks/mutations/task/use-delete-task.ts b/apps/web/src/hooks/mutations/task/use-delete-task.tsindex 7941aa04c..ac358c6de 100644--- a/apps/web/src/hooks/mutations/task/use-delete-task.ts+++ b/apps/web/src/hooks/mutations/task/use-delete-task.ts@@ -4,6 +4,7 @@ import deleteTask from "@/fetchers/task/delete-task";import useProjectStore from "@/store/project";import type { ProjectWithTasks } from "@/types/project";import { removeTaskFromProject } from "./remove-task-from-project";+import { removeTasksFromRelations } from "./remove-task-from-relations";export function useDeleteTask() {const queryClient = useQueryClient();@@ -22,6 +23,7 @@ export function useDeleteTask() {queryKey: ["task", deletedTask.id],exact: true,});+ removeTasksFromRelations(queryClient, [deletedTask.id]);void queryClient.invalidateQueries({queryKey: ["tasks", deletedTask.projectId],});