Skip to content

armgit / kaneo

Public Imported from GitHub
0

⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.

fix(migration): validate only recognized legacy transitions

Tin72549e3a46df
diff --git a/apps/api/src/migrations/column-migration.ts b/apps/api/src/migrations/column-migration.ts
index f11673f4c..299f3e1e0 100644
--- a/apps/api/src/migrations/column-migration.ts
+++ b/apps/api/src/migrations/column-migration.ts
@@ -103,9 +103,10 @@ async function migrateProject(projectId: string, pending: Set<string>) {
(!transitions ||
typeof transitions !== "object" ||
Array.isArray(transitions) ||
- Object.values(transitions).some(
- (value) => typeof value !== "string",
- ))
+ Object.keys(EVENT_MAPPING)
+ .map((key) => transitions[key])
+ .filter((value) => value !== undefined)
+ .some((value) => typeof value !== "string"))
)
throw new Error("Invalid legacy status transitions");
} catch {
diff --git a/tests/api-integration/column-migration-once.test.ts b/tests/api-integration/column-migration-once.test.ts
index bdfd648b7..cacf581ec 100644
--- a/tests/api-integration/column-migration-once.test.ts
+++ b/tests/api-integration/column-migration-once.test.ts
@@ -175,3 +175,23 @@ it.each(["invalid", null, [], { onPROpen: 1 }])(
]);
},
);
+
+it("migrates recognized transitions while ignoring unrelated legacy flags", async () => {
+ const { workspace } = await createWorkspaceMember();
+ const { project } = await createProjectFixture({ workspaceId: workspace.id });
+ await db
+ .delete(schema.columnTable)
+ .where(eq(schema.columnTable.projectId, project.id));
+ await db.insert(schema.integrationTable).values({
+ projectId: project.id,
+ type: "gitea",
+ config: JSON.stringify({
+ statusTransitions: { onPROpen: "in-review", legacyFlag: false },
+ }),
+ });
+ await migrateColumns();
+ expect(await db.select().from(schema.workflowRuleTable)).toHaveLength(3);
+ expect(await db.select().from(schema.dataMigrationTable)).toEqual([
+ expect.objectContaining({ id: "column-workflow-v1" }),
+ ]);
+});