⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix: publish label deletion events and sync to GitHub/Gitea when labels are cascaded from workspace
Glen Eder94559e72f374
diff --git a/apps/api/src/label/controllers/delete-label.ts b/apps/api/src/label/controllers/delete-label.tsindex d1f0b2566..56d7ae885 100644--- a/apps/api/src/label/controllers/delete-label.ts+++ b/apps/api/src/label/controllers/delete-label.ts@@ -3,6 +3,7 @@ import { HTTPException } from "hono/http-exception";import db from "../../database";import { labelTable, projectTable, taskTable } from "../../database/schema";import { publishEvent } from "../../events";+import { removeLabelFromGitea } from "../../plugins/gitea/utils/sync-label-to-gitea";import { removeLabelFromGitHub } from "../../plugins/github/utils/sync-label-to-github";async function deleteLabel(id: string, userId: string) {@@ -78,6 +79,26 @@ async function deleteLabel(id: string, userId: string) {});}+ // Capture affected task-level labels before cascading so we have data+ // for events and provider sync+ const affectedLabels = await db+ .select({+ label: labelTable,+ taskId: taskTable.id,+ projectId: projectTable.id,+ workspaceId: projectTable.workspaceId,+ })+ .from(labelTable)+ .innerJoin(taskTable, eq(labelTable.taskId, taskTable.id))+ .innerJoin(projectTable, eq(taskTable.projectId, projectTable.id))+ .where(+ and(+ eq(labelTable.workspaceId, label.workspaceId),+ eq(labelTable.name, label.name),+ isNotNull(labelTable.taskId),+ ),+ );+// Cascade: delete all task-level copies of this label so existing tasks lose itawait db.delete(labelTable)@@ -89,6 +110,27 @@ async function deleteLabel(id: string, userId: string) {),);+ // Emit events and sync providers for each affected task+ for (const { label: l, taskId, projectId } of affectedLabels) {+ if (l.taskId) {+ removeLabelFromGitHub(l.taskId, l.name).catch((error) => {+ console.error("Failed to remove label from GitHub:", error);+ });+ removeLabelFromGitea(l.taskId, l.name).catch((error) => {+ console.error("Failed to remove label from Gitea:", error);+ });+ }++ await publishEvent("task.label_deleted", {+ label: l,+ task: { id: taskId, projectId },+ projectId,+ taskId,+ userId,+ type: "label_deleted",+ });+ }+return deletedLabel;}diff --git a/tests/api-integration/label.test.ts b/tests/api-integration/label.test.tsindex 31707a335..ecb557a44 100644--- a/tests/api-integration/label.test.ts+++ b/tests/api-integration/label.test.ts@@ -162,7 +162,7 @@ describe("API integration: labels", () => {.returning();// Create task-level copies (simulating assigning the label to tasks)- const [taskLabelA] = await db+ const [_taskLabelA] = await db.insert(schema.labelTable).values({name: "Bug",diff --git a/tests/api/label/delete-label.test.ts b/tests/api/label/delete-label.test.tsnew file mode 100644index 000000000..8d9fdbdc9--- /dev/null+++ b/tests/api/label/delete-label.test.ts@@ -0,0 +1,210 @@+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";++const mockFindFirst = vi.fn();+const mockSelect = vi.fn();+const mockDelete = vi.fn();+const mockPublishEvent = vi.fn();+const mockRemoveLabelFromGitHub = vi.fn();+const mockRemoveLabelFromGitea = vi.fn();++vi.mock("../../../apps/api/src/database", () => ({+ default: {+ query: {+ labelTable: {+ findFirst: (...args: unknown[]) => mockFindFirst(...args),+ },+ },+ select: (...args: unknown[]) => mockSelect(...args),+ delete: (...args: unknown[]) => mockDelete(...args),+ },+}));++vi.mock("../../../apps/api/src/events", () => ({+ publishEvent: (...args: unknown[]) => mockPublishEvent(...args),+}));++vi.mock(+ "../../../apps/api/src/plugins/github/utils/sync-label-to-github",+ () => ({+ removeLabelFromGitHub: (...args: unknown[]) =>+ mockRemoveLabelFromGitHub(...args),+ }),+);++vi.mock(+ "../../../apps/api/src/plugins/gitea/utils/sync-label-to-gitea",+ () => ({+ removeLabelFromGitea: (...args: unknown[]) =>+ mockRemoveLabelFromGitea(...args),+ }),+);++import deleteLabel from "../../../apps/api/src/label/controllers/delete-label";++const WORKSPACE_LABEL = {+ id: "label-ws-1",+ name: "bug",+ color: "EF4444",+ createdAt: new Date(),+ updatedAt: new Date(),+ taskId: null,+ workspaceId: "ws-1",+};++const DELETED_WORKSPACE_LABEL = { ...WORKSPACE_LABEL };++const TASK_LABEL_1 = {+ id: "label-task-1",+ name: "bug",+ color: "EF4444",+ createdAt: new Date(),+ updatedAt: new Date(),+ taskId: "task-1",+ workspaceId: "ws-1",+};++const TASK_LABEL_2 = {+ id: "label-task-2",+ name: "bug",+ color: "EF4444",+ createdAt: new Date(),+ updatedAt: new Date(),+ taskId: "task-2",+ workspaceId: "ws-1",+};++/**+ * Build a mock chain for `db.select().from().innerJoin().innerJoin().where()`.+ * The terminal `.where()` returns a Promise resolved to `rows`.+ */+function makeSelectMock(rows: unknown[]) {+ const chain: Record<string, vi.Mock> = {+ from: vi.fn(() => chain),+ innerJoin: vi.fn(() => chain),+ where: vi.fn(() => Promise.resolve(rows)),+ };+ return chain;+}++/**+ * Build a mock chain for `db.delete().where().returning()` and+ * `db.delete().where()` (no returning).+ *+ * - `.where()` returns a sub-chain that supports `.returning()` and is thenable.+ */+function makeDeleteMock(deletedRow: unknown) {+ const chain: Record<string, vi.Mock> = {};++ // Sub-chain returned by .where():+ // - Native Promise.then so `await db.delete().where(...)` works+ // - .returning() attached for the returning-delete path+ const whereResult = Object.assign(Promise.resolve(undefined), {+ returning: vi.fn(() => Promise.resolve([deletedRow])),+ });++ chain.where = vi.fn(() => whereResult);++ return chain;+}++describe("deleteLabel", () => {+ beforeEach(() => {+ vi.clearAllMocks();+ });++ afterEach(() => {+ vi.restoreAllMocks();+ });++ describe("workspace-level label deletion (taskId is null)", () => {+ it("emits task.label_deleted events for each affected task-level label", async () => {+ mockRemoveLabelFromGitHub.mockResolvedValue(undefined);+ mockRemoveLabelFromGitea.mockResolvedValue(undefined);+ mockFindFirst.mockResolvedValue(WORKSPACE_LABEL);+ mockSelect.mockReturnValue(+ makeSelectMock([+ {+ label: TASK_LABEL_1,+ taskId: "task-1",+ projectId: "proj-1",+ workspaceId: "ws-1",+ },+ {+ label: TASK_LABEL_2,+ taskId: "task-2",+ projectId: "proj-2",+ workspaceId: "ws-1",+ },+ ]),+ );+ mockDelete.mockReturnValue(makeDeleteMock(DELETED_WORKSPACE_LABEL));++ await deleteLabel("label-ws-1", "user-1");++ expect(mockPublishEvent).toHaveBeenCalledTimes(2);+ expect(mockPublishEvent).toHaveBeenCalledWith("task.label_deleted", {+ label: TASK_LABEL_1,+ task: { id: "task-1", projectId: "proj-1" },+ projectId: "proj-1",+ taskId: "task-1",+ userId: "user-1",+ type: "label_deleted",+ });+ expect(mockPublishEvent).toHaveBeenCalledWith("task.label_deleted", {+ label: TASK_LABEL_2,+ task: { id: "task-2", projectId: "proj-2" },+ projectId: "proj-2",+ taskId: "task-2",+ userId: "user-1",+ type: "label_deleted",+ });+ });++ it("calls removeLabelFromGitHub and removeLabelFromGitea for each affected task", async () => {+ mockRemoveLabelFromGitHub.mockResolvedValue(undefined);+ mockRemoveLabelFromGitea.mockResolvedValue(undefined);+ mockFindFirst.mockResolvedValue(WORKSPACE_LABEL);+ mockSelect.mockReturnValue(+ makeSelectMock([+ {+ label: TASK_LABEL_1,+ taskId: "task-1",+ projectId: "proj-1",+ workspaceId: "ws-1",+ },+ {+ label: TASK_LABEL_2,+ taskId: "task-2",+ projectId: "proj-2",+ workspaceId: "ws-1",+ },+ ]),+ );+ mockDelete.mockReturnValue(makeDeleteMock(DELETED_WORKSPACE_LABEL));++ await deleteLabel("label-ws-1", "user-1");++ expect(mockRemoveLabelFromGitHub).toHaveBeenCalledTimes(2);+ expect(mockRemoveLabelFromGitHub).toHaveBeenCalledWith("task-1", "bug");+ expect(mockRemoveLabelFromGitHub).toHaveBeenCalledWith("task-2", "bug");++ expect(mockRemoveLabelFromGitea).toHaveBeenCalledTimes(2);+ expect(mockRemoveLabelFromGitea).toHaveBeenCalledWith("task-1", "bug");+ expect(mockRemoveLabelFromGitea).toHaveBeenCalledWith("task-2", "bug");+ });++ it("fires no events when no task-level labels are affected", async () => {+ mockRemoveLabelFromGitHub.mockResolvedValue(undefined);+ mockRemoveLabelFromGitea.mockResolvedValue(undefined);+ mockFindFirst.mockResolvedValue(WORKSPACE_LABEL);+ mockSelect.mockReturnValue(makeSelectMock([]));+ mockDelete.mockReturnValue(makeDeleteMock(DELETED_WORKSPACE_LABEL));++ await deleteLabel("label-ws-1", "user-1");++ expect(mockPublishEvent).not.toHaveBeenCalled();+ expect(mockRemoveLabelFromGitHub).not.toHaveBeenCalled();+ expect(mockRemoveLabelFromGitea).not.toHaveBeenCalled();+ });+ });+});