⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
feat: add access control to API endpoints
Alessandro Zanatta977d49e7ce7c
diff --git a/apps/api/src/activity/index.ts b/apps/api/src/activity/index.tsindex 26a4d1af3..5145ba147 100644--- a/apps/api/src/activity/index.ts+++ b/apps/api/src/activity/index.ts@@ -3,6 +3,7 @@ import { describeRoute, resolver, validator } from "hono-openapi";import * as v from "valibot";import { subscribeToEvent } from "../events";import { activitySchema } from "../schemas";+import { workspaceAccess } from "../utils/workspace-access-middleware";import createActivity from "./controllers/create-activity";import createComment from "./controllers/create-comment";import deleteComment from "./controllers/delete-comment";@@ -30,6 +31,7 @@ const activity = new Hono<{},}),validator("param", v.object({ taskId: v.string() })),+ workspaceAccess.fromTaskId(),async (c) => {const { taskId } = c.req.valid("param");const activities = await getActivities(taskId);@@ -60,6 +62,7 @@ const activity = new Hono<{type: v.string(),}),),+ workspaceAccess.fromTaskId(),async (c) => {const { taskId, userId, message, type } = c.req.valid("json");const activity = await createActivity(taskId, type, userId, message);@@ -88,6 +91,7 @@ const activity = new Hono<{comment: v.string(),}),),+ workspaceAccess.fromTaskId(),async (c) => {const { taskId, comment } = c.req.valid("json");const userId = c.get("userId");@@ -117,6 +121,7 @@ const activity = new Hono<{comment: v.string(),}),),+ workspaceAccess.fromActivity("activityId"),async (c) => {const { activityId, comment } = c.req.valid("json");const userId = c.get("userId");@@ -145,6 +150,7 @@ const activity = new Hono<{activityId: v.string(),}),),+ workspaceAccess.fromActivity("activityId"),async (c) => {const { activityId } = c.req.valid("json");const userId = c.get("userId");diff --git a/apps/api/src/label/index.ts b/apps/api/src/label/index.tsindex efacfa63b..a39042214 100644--- a/apps/api/src/label/index.ts+++ b/apps/api/src/label/index.ts@@ -2,6 +2,7 @@ import { Hono } from "hono";import { describeRoute, resolver, validator } from "hono-openapi";import * as v from "valibot";import { labelSchema } from "../schemas";+import { workspaceAccess } from "../utils/workspace-access-middleware";import createLabel from "./controllers/create-label";import deleteLabel from "./controllers/delete-label";import getLabel from "./controllers/get-label";@@ -26,6 +27,7 @@ const label = new Hono()},}),validator("param", v.object({ taskId: v.string() })),+ workspaceAccess.fromTaskId(),async (c) => {const { taskId } = c.req.valid("param");const labels = await getLabelsByTaskId(taskId);@@ -48,6 +50,7 @@ const label = new Hono()},}),validator("param", v.object({ workspaceId: v.string() })),+ workspaceAccess.fromParam(),async (c) => {const { workspaceId } = c.req.valid("param");const labels = await getLabelsByWorkspaceId(workspaceId);@@ -78,6 +81,7 @@ const label = new Hono()taskId: v.optional(v.string()),}),),+ workspaceAccess.fromBody(),async (c) => {const { name, color, workspaceId, taskId } = c.req.valid("json");const label = await createLabel(name, color, taskId, workspaceId);@@ -100,6 +104,7 @@ const label = new Hono()},}),validator("param", v.object({ id: v.string() })),+ workspaceAccess.fromLabel(),async (c) => {const { id } = c.req.valid("param");const label = await getLabel(id);@@ -129,6 +134,7 @@ const label = new Hono()color: v.string(),}),),+ workspaceAccess.fromLabel(),async (c) => {const { id } = c.req.valid("param");const { name, color } = c.req.valid("json");@@ -152,6 +158,7 @@ const label = new Hono()},}),validator("param", v.object({ id: v.string() })),+ workspaceAccess.fromLabel(),async (c) => {const { id } = c.req.valid("param");const label = await deleteLabel(id);diff --git a/apps/api/src/search/index.ts b/apps/api/src/search/index.tsindex 4e6ddd931..58f70025d 100644--- a/apps/api/src/search/index.ts+++ b/apps/api/src/search/index.ts@@ -2,6 +2,7 @@ import { Hono } from "hono";import { describeRoute, resolver, validator } from "hono-openapi";import * as v from "valibot";import { activitySchema, projectSchema, taskSchema } from "../schemas";+import { workspaceAccess } from "../utils/workspace-access-middleware";import globalSearch from "./controllers/global-search";const workspaceSchema = v.object({@@ -74,6 +75,7 @@ const search = new Hono<{userEmail: v.optional(v.pipe(v.string(), v.email())),}),),+ workspaceAccess.fromQuery(),async (c) => {const { q, type, workspaceId, projectId, limit, userEmail } =c.req.valid("query");diff --git a/apps/api/src/task/index.ts b/apps/api/src/task/index.tsindex 3790304f1..51e9bb9a3 100644--- a/apps/api/src/task/index.ts+++ b/apps/api/src/task/index.ts@@ -4,6 +4,7 @@ import * as v from "valibot";import { auth } from "../auth";import { publishEvent } from "../events";import { taskSchema } from "../schemas";+import { workspaceAccess } from "../utils/workspace-access-middleware";import createTask from "./controllers/create-task";import deleteTask from "./controllers/delete-task";import exportTasks from "./controllers/export-tasks";@@ -39,6 +40,7 @@ const task = new Hono<{},}),validator("param", v.object({ projectId: v.string() })),+ workspaceAccess.fromProject("projectId"),async (c) => {const { projectId } = c.req.valid("param");@@ -73,6 +75,7 @@ const task = new Hono<{userId: v.optional(v.string()),}),),+ workspaceAccess.fromProject("projectId"),async (c) => {const { projectId } = c.req.param();const { title, description, dueDate, priority, status, userId } =@@ -107,6 +110,7 @@ const task = new Hono<{},}),validator("param", v.object({ id: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");@@ -144,6 +148,7 @@ const task = new Hono<{userId: v.optional(v.string()),}),),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");const {@@ -201,6 +206,7 @@ const task = new Hono<{},}),validator("param", v.object({ projectId: v.string() })),+ workspaceAccess.fromProject("projectId"),async (c) => {const { projectId } = c.req.valid("param");@@ -240,6 +246,7 @@ const task = new Hono<{),}),),+ workspaceAccess.fromProject("projectId"),async (c) => {const { projectId } = c.req.valid("param");const { tasks } = c.req.valid("json");@@ -265,6 +272,7 @@ const task = new Hono<{},}),validator("param", v.object({ id: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");@@ -290,6 +298,7 @@ const task = new Hono<{}),validator("param", v.object({ id: v.string() })),validator("json", v.object({ status: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");const { status } = c.req.valid("json");@@ -327,6 +336,7 @@ const task = new Hono<{}),validator("param", v.object({ id: v.string() })),validator("json", v.object({ priority: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");const { priority } = c.req.valid("json");@@ -363,6 +373,7 @@ const task = new Hono<{}),validator("param", v.object({ id: v.string() })),validator("json", v.object({ userId: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");const { userId } = c.req.valid("json");@@ -418,6 +429,7 @@ const task = new Hono<{}),validator("param", v.object({ id: v.string() })),validator("json", v.object({ dueDate: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");const { dueDate } = c.req.valid("json");@@ -455,6 +467,7 @@ const task = new Hono<{}),validator("param", v.object({ id: v.string() })),validator("json", v.object({ title: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");const { title } = c.req.valid("json");@@ -492,6 +505,7 @@ const task = new Hono<{}),validator("param", v.object({ id: v.string() })),validator("json", v.object({ description: v.string() })),+ workspaceAccess.fromTask(),async (c) => {const { id } = c.req.valid("param");const { description } = c.req.valid("json");diff --git a/apps/api/src/time-entry/index.ts b/apps/api/src/time-entry/index.tsindex 5f9fef549..4a6a11160 100644--- a/apps/api/src/time-entry/index.ts+++ b/apps/api/src/time-entry/index.ts@@ -2,6 +2,7 @@ import { Hono } from "hono";import { describeRoute, resolver, validator } from "hono-openapi";import * as v from "valibot";import { timeEntrySchema } from "../schemas";+import { workspaceAccess } from "../utils/workspace-access-middleware";import createTimeEntry from "./controllers/create-time-entry";import getTimeEntriesByTaskId from "./controllers/get-time-entries";import getTimeEntry from "./controllers/get-time-entry";@@ -28,6 +29,7 @@ const timeEntry = new Hono<{},}),validator("param", v.object({ taskId: v.string() })),+ workspaceAccess.fromTaskId(),async (c) => {const { taskId } = c.req.valid("param");const timeEntries = await getTimeEntriesByTaskId(taskId);@@ -50,6 +52,7 @@ const timeEntry = new Hono<{},}),validator("param", v.object({ id: v.string() })),+ workspaceAccess.fromTimeEntry(),async (c) => {const { id } = c.req.valid("param");const timeEntry = await getTimeEntry(id);@@ -80,6 +83,7 @@ const timeEntry = new Hono<{description: v.optional(v.string()),}),),+ workspaceAccess.fromTaskId(),async (c) => {const { taskId, startTime, endTime, description } = c.req.valid("json");const userId = c.get("userId");@@ -117,6 +121,7 @@ const timeEntry = new Hono<{description: v.optional(v.string()),}),),+ workspaceAccess.fromTimeEntry(),async (c) => {const { id } = c.req.valid("param");const { startTime, endTime, description } = c.req.valid("json");diff --git a/apps/api/src/utils/workspace-access-middleware.ts b/apps/api/src/utils/workspace-access-middleware.tsindex 786a6652d..d31820e3a 100644--- a/apps/api/src/utils/workspace-access-middleware.ts+++ b/apps/api/src/utils/workspace-access-middleware.ts@@ -24,6 +24,7 @@ export function workspaceAccessMiddleware(return async (c: Context, next: Next) => {const userId = c.get("userId");+ console.log({ userId });if (!userId) {throw new HTTPException(401, { message: "Unauthorized" });}@@ -39,7 +40,12 @@ export function workspaceAccessMiddleware(} else if (source.type === "param") {workspaceId = c.req.param(source.key) || null;} else if (source.type === "lookup") {- const id = c.req.param(source.idKey) || c.req.query(source.idKey);+ const body = await c.req.json().catch(() => ({}));+ const id =+ c.req.param(source.idKey) ||+ c.req.query(source.idKey) ||+ body[source.idKey];+ console.log(source.idKey, source.type, id, source.resource);if (id) {workspaceId = await lookupWorkspaceId(source.resource, id);}@@ -177,6 +183,11 @@ export const workspaceAccess = {sources: [{ type: "lookup", resource: "task", idKey }],}),+ fromTaskId: (idKey = "taskId") =>+ workspaceAccessMiddleware({+ sources: [{ type: "lookup", resource: "task", idKey }],+ }),+fromLabel: (idKey = "id") =>workspaceAccessMiddleware({sources: [{ type: "lookup", resource: "label", idKey }],