⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix(web): address discard review feedback
Tina4ded329afda
diff --git a/apps/web/src/components/shared/modals/create-task-modal.test.tsx b/apps/web/src/components/shared/modals/create-task-modal.test.tsxindex 79a98d5f8..2485e52e6 100644--- a/apps/web/src/components/shared/modals/create-task-modal.test.tsx+++ b/apps/web/src/components/shared/modals/create-task-modal.test.tsx@@ -86,7 +86,7 @@ vi.mock("react-i18next", () => ({}));describe("CreateTaskModal", () => {- it("keeps unsaved input until the user confirms discarding it", async () => {+ it("keeps unsaved input while discard confirmation is open", async () => {useLocation.mockReturnValue({pathname: "/dashboard/workspace/workspace-1/project/project-1/board",});@@ -111,11 +111,57 @@ describe("CreateTaskModal", () => {).toBeTruthy();expect(titleInput).toHaveValue("Unsaved task");+ fireEvent.keyDown(document, { key: "Enter", ctrlKey: true });++ expect(createTask).not.toHaveBeenCalled();+ expect(onClose).not.toHaveBeenCalled();+ });++ it("closes after the user confirms discarding unsaved input", async () => {+ useLocation.mockReturnValue({+ pathname: "/dashboard/workspace/workspace-1/project/project-1/board",+ });+ const onClose = vi.fn();++ render(<CreateTaskModal open onClose={onClose} />);++ fireEvent.change(+ screen.getByPlaceholderText(+ "common:modals.createTask.taskTitlePlaceholder",+ ),+ { target: { value: "Unsaved task" } },+ );+ const backdrop = document.querySelector('[data-slot="dialog-backdrop"]');+ fireEvent.pointerDown(backdrop as Element);+ fireEvent.pointerUp(backdrop as Element);+ fireEvent.click(backdrop as Element);++ await screen.findByText("common:modals.createTask.discardTitle");+fireEvent.click(screen.getByText("common:modals.createTask.discardButton"));expect(onClose).toHaveBeenCalledTimes(1);});+ it("treats a selected project as unsaved input", async () => {+ useLocation.mockReturnValue({+ pathname: "/dashboard/workspace/workspace-1",+ });++ render(<CreateTaskModal open onClose={vi.fn()} />);++ fireEvent.click(screen.getByText("common:modals.createTask.selectProject"));+ fireEvent.click(await screen.findByText("Beta"));+ const backdrop = document.querySelector('[data-slot="dialog-backdrop"]');+ fireEvent.pointerDown(backdrop as Element);+ fireEvent.pointerUp(backdrop as Element);+ fireEvent.click(backdrop as Element);++ expect(+ await screen.findByText("common:modals.createTask.discardTitle"),+ ).toBeTruthy();+ });+it("shows a project picker and creates the task in the chosen project", async () => {useLocation.mockReturnValue({pathname: "/dashboard/workspace/workspace-1",diff --git a/apps/web/src/components/shared/modals/create-task-modal.tsx b/apps/web/src/components/shared/modals/create-task-modal.tsxindex 9d9df3dd9..c5b738968 100644--- a/apps/web/src/components/shared/modals/create-task-modal.tsx+++ b/apps/web/src/components/shared/modals/create-task-modal.tsx@@ -258,6 +258,7 @@ function CreateTaskModal({assigneeId ||startDate ||dueDate ||+ selectedProjectId ||labels.length > 0 ||draftTask,);@@ -272,6 +273,7 @@ function CreateTaskModal({setAssigneeId("");setStartDate(undefined);setDueDate(undefined);+ setSelectedProjectId("");setCreateMore(false);setLabels([]);setLabelsStep("select");@@ -527,7 +529,7 @@ function CreateTaskModal({const handleKeyDown = useCallback((e: KeyboardEvent) => {- if (!open) return;+ if (!open || discardConfirmationOpen) return;if ((e.metaKey || e.ctrlKey) && e.key === "Enter") {e.preventDefault();@@ -541,7 +543,7 @@ function CreateTaskModal({}}},- [open, title, resolvedProjectId, workspace?.id],+ [open, discardConfirmationOpen, title, resolvedProjectId, workspace?.id],);useEffect(() => {diff --git a/i18n/ko-KR.json b/i18n/ko-KR.jsonindex 65dfd214c..aabd2c270 100644--- a/i18n/ko-KR.json+++ b/i18n/ko-KR.json@@ -139,9 +139,9 @@"labelCreateError": "라벨 생성에 실패했습니다","createMore": "계속 만들기","createButton": "작업 만들기",- "discardTitle": "작업을 취소할까요?",+ "discardTitle": "작성 중인 작업을 버릴까요?","discardDescription": "저장하지 않은 작업 세부 정보가 손실됩니다.",- "discardButton": "작업 취소",+ "discardButton": "작업 버리기","untitledTask": "제목 없는 작업","labelColors": {"stone": "스톤",diff --git a/i18n/tr-TR.json b/i18n/tr-TR.jsonindex f48e97f50..3235b9f10 100644--- a/i18n/tr-TR.json+++ b/i18n/tr-TR.json@@ -139,9 +139,9 @@"labelCreateError": "Etiket oluşturulamadı","createMore": "Daha fazla oluştur","createButton": "Talep Oluştur",- "discardTitle": "Görev iptal edilsin mi?",- "discardDescription": "Kaydedilmemiş görev ayrıntıları kaybolacak.",- "discardButton": "Görevi iptal et",+ "discardTitle": "Kaydedilmemiş talep taslağı silinsin mi?",+ "discardDescription": "Kaydedilmemiş talep ayrıntıları kaybolacak.",+ "discardButton": "Talep taslağını sil","untitledTask": "Başlıksız talep","labelColors": {"stone": "Taş",