⚡ Project management that doesn't become the project. Boards, Gantt charts, and GitHub integration. Self-host it or use Kaneo Cloud.
TypeScript honoissue-managementissue-trackerjira-alternativekanbanlinear-alternativemcpproject-managementreactself-hostedtypescript
fix(web): preserve MIME metadata for unknown files
Bryan Nathanb34474cd893c
diff --git a/apps/web/src/lib/upload-task-image.test.ts b/apps/web/src/lib/upload-task-image.test.tsnew file mode 100644index 000000000..070696e3b--- /dev/null+++ b/apps/web/src/lib/upload-task-image.test.ts@@ -0,0 +1,70 @@+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import { uploadTaskImage } from "./upload-task-image";++const mocks = vi.hoisted(() => ({+ createImageUpload: vi.fn(),+ finalizeImageUpload: vi.fn(),+}));++vi.mock("@/fetchers/task/create-image-upload", () => ({+ default: mocks.createImageUpload,+ finalizeImageUpload: mocks.finalizeImageUpload,+}));++describe("uploadTaskImage", () => {+ beforeEach(() => {+ mocks.createImageUpload.mockResolvedValue({+ key: "task/file.conf",+ uploadUrl: "https://storage.example/upload",+ headers: {},+ });+ mocks.finalizeImageUpload.mockResolvedValue({+ url: "https://storage.example/file.conf",+ });+ vi.stubGlobal("fetch", vi.fn().mockResolvedValue({ ok: true }));+ });++ afterEach(() => {+ vi.unstubAllGlobals();+ vi.clearAllMocks();+ });++ it("uses a generic content type when the browser cannot detect one", async () => {+ const file = new File(["server config"], "server.conf");++ const asset = await uploadTaskImage({+ taskId: "task-1",+ surface: "comment",+ file,+ });++ expect(file.type).toBe("");+ expect(mocks.createImageUpload).toHaveBeenCalledWith(+ expect.objectContaining({ contentType: "application/octet-stream" }),+ );+ expect(mocks.finalizeImageUpload).toHaveBeenCalledWith(+ expect.objectContaining({ contentType: "application/octet-stream" }),+ );+ expect(asset.mimeType).toBe("application/octet-stream");+ expect(asset.kind).toBe("attachment");+ });++ it("preserves a browser-provided content type", async () => {+ const file = new File(["image"], "image.png", { type: "image/png" });++ const asset = await uploadTaskImage({+ taskId: "task-1",+ surface: "description",+ file,+ });++ expect(mocks.createImageUpload).toHaveBeenCalledWith(+ expect.objectContaining({ contentType: "image/png" }),+ );+ expect(mocks.finalizeImageUpload).toHaveBeenCalledWith(+ expect.objectContaining({ contentType: "image/png" }),+ );+ expect(asset.mimeType).toBe("image/png");+ expect(asset.kind).toBe("image");+ });+});diff --git a/apps/web/src/lib/upload-task-image.ts b/apps/web/src/lib/upload-task-image.tsindex 792c9b6a3..09b9dad52 100644--- a/apps/web/src/lib/upload-task-image.ts+++ b/apps/web/src/lib/upload-task-image.ts@@ -46,10 +46,12 @@ export async function uploadTaskImage({}}+ const contentType = file.type || "application/octet-stream";+const upload = await createImageUpload({taskId,filename: file.name || "image",- contentType: file.type,+ contentType,size: file.size,surface,});@@ -68,7 +70,7 @@ export async function uploadTaskImage({taskId,key: upload.key,filename: file.name || "image",- contentType: file.type,+ contentType,size: file.size,surface,});@@ -78,7 +80,7 @@ export async function uploadTaskImage({alt: getImageAltText(file.name || "image"),filename: file.name || "file",kind: isSupportedImageFile(file) ? "image" : "attachment",- mimeType: file.type,+ mimeType: contentType,size: file.size,};}